From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Cc: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
"Pandya, Puja" <puja.pandya@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>,
"Bjorge, Erik C" <erik.c.bjorge@intel.com>
Subject: Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 0/2] EdkRepo: Add support for SUBST drives
Date: Fri, 9 Oct 2020 20:33:56 +0000 [thread overview]
Message-ID: <MWHPR1101MB21605D7506E45B4DE13C94F1CD080@MWHPR1101MB2160.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1638312BEE642570.1366@groups.io>
Series pushed: 0e3fb4b~..04b701e
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Friday, September 25, 2020 6:28 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>;
> Agyeman, Prince <prince.agyeman@intel.com>; Bjorge, Erik C
> <erik.c.bjorge@intel.com>
> Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 0/2] EdkRepo: Add
> support for SUBST drives
>
> Changes in V3:
> - Changed loop for finding subst drive to single if statement
>
> Changes in V2:
> - Changed get_subst_drive_list() to get_subst_drive_dict()
>
> EdkRepo currently does not handle virtual drives created using the SUBST
> command.
> Specifically, when cloning or syncing a project to a subst drive the includeIf
> statements that redirect submodule fetches to mirror servers will be
> generated with the subst drive information. This causes git to not activate
> the includeif since it specifies the subst path and not the actual path.
>
> To resolve this, EdkRepo will now enumerate the virtual drives created by
> SUBST and if the current workspace is on a SUBST virtual drive EdkRepo will
> convert the workspace path to the path on the real volume.
>
> Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> Nate DeSimone (2):
> EdkRepo: Add function to enumerate subst drives
> EdkRepo: Add support for subst drives
>
> edkrepo/commands/clone_command.py | 8 +++++
> edkrepo/common/pathfix.py | 50
> ++++++++++++++++++++++++++++++-
> edkrepo/config/config_factory.py | 10 ++++++-
> 3 files changed, 66 insertions(+), 2 deletions(-)
>
> --
> 2.27.0.windows.1
>
>
>
>
>
parent reply other threads:[~2020-10-09 20:33 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1638312BEE642570.1366@groups.io>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1101MB21605D7506E45B4DE13C94F1CD080@MWHPR1101MB2160.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox