From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.3961.1607505160325179317 for ; Wed, 09 Dec 2020 01:12:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LObAu5g7; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: 6dr32lF6eOgT3UR4doUI6MKhUErPco5oDuznLgMu4t0daV5FDvBMscF3zK53+jHZ/jrpsY5EIv 7OKr5IfLrFEA== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="171473411" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="171473411" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 01:12:39 -0800 IronPort-SDR: Cewnpa7NJcgHe/Uacgr+2uIfrYjrVj+WxmVgxs3bfbGzGyEv7V+YgvmF8B+CqcqTZ9N0gxM/It en2pt3of5D2A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="348253075" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 09 Dec 2020 01:12:38 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 01:12:38 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Dec 2020 01:12:38 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.52) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Dec 2020 01:12:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y20MHBlgQRt5dwsyShAt847H/QLDQzbu2gVHp1QEs0ChCy0QYH4qUbaw1t1UB+6Y5uNpDvELDI66GLKTO5jgJAntO/PbjRazLCQcRx7kNe59E12CYlU7bEDRIiec5YzUowqBb1mupshRX+WhVr9jxd367tPoaIpjuxYgJkiGsUKPt4TmKZF0QRfann09PVePtB1Xnvi5sykgurEkRv+f6gR6Acr2gx9rwahyLfd/ifpJLDMNoJ6kR9sl5+h+7wUdTlfOeHo8Lbz5Ih5xLa/3b1pd44kq567OpZP1EV9cqyZ5vPccAsZ/gpb0WKkZgrcQ4ju/PuWL8JlyesTDkSHBFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fbq0PZBIVt3/B0EMKxzWl5ffPwz2GOYZPiknvCr1S9E=; b=fYyj8xNrRloPC30nfM8Wcv6dmhxMSYr+5MLSdBujYvWIJxiiTw8AXk64D7rK1smbOGySiiSsM6gnA03j9YsAQ0u4OcQYg8gBHZW/bXBBCxJsjW86T76AkI24v6nyvHaDyRrfVY8f3wHiYhfW2aXMT77DmOB1VqaMbx9FxlG/yJ6bcCdg7Juyi6J3uQV82UnHA/fcopohTc5p2bMNuXDCs+0erUtJNej+sf00U81Yuk3D0eXgrsQ+wCL4Hv1H0+s4PefryeHxFBvvnFOw7p8rWxldYGrRkBJw0ukWsoWl00ULozSgMedaTEfHTIfJ4tsClEWErljdzdSCpqaFZB2T4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fbq0PZBIVt3/B0EMKxzWl5ffPwz2GOYZPiknvCr1S9E=; b=LObAu5g7TpweMH6I+OOxXflkdrf2XQ2ZCQz2Zq4x+EiX47Mg7dUPJnWV7d8Bc2YY9rcdqVeXySY0PIEpO2tSsy+mEJOvIHr8U82SDVUWrD9rkETfeWgiRerZDVP6pvm65FmAI51GEf67+XSIjkU7O/XzKwIJutdZFbZogMSrBbk= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1760.namprd11.prod.outlook.com (2603:10b6:300:10e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Wed, 9 Dec 2020 09:12:36 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710%8]) with mapi id 15.20.3654.012; Wed, 9 Dec 2020 09:12:36 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Chiu, Chasel" , Liming Gao Subject: Re: [Patch V7 1/3] MinPlatformPkg: Add PCDs for Serial Terminal feature Thread-Topic: [Patch V7 1/3] MinPlatformPkg: Add PCDs for Serial Terminal feature Thread-Index: AQHWu7g6zUwajs/Y7EG8Ve4t71gO4qnun0cQ Date: Wed, 9 Dec 2020 09:12:36 +0000 Message-ID: References: <20201116013124.1983-1-heng.luo@intel.com> In-Reply-To: <20201116013124.1983-1-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f82bbe89-a9fe-438d-a1a2-08d89c2291d7 x-ms-traffictypediagnostic: MWHPR11MB1760: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:302; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r1vvRjp6niiCtVfhFwcwFgSWMekHq9QsZoOEVy4aRYXytfbUHf46tB837qy6WMfF2gc/2qXI0+WkAv0yJipTXQF3gSL5d6A1BsN+OlH/VEYbWG7LcEHtpXfga7mzxF5XaJZfFjozoaHQ7KjGBxxAfEfSzCY6U6F2gQyebJtQFfQTX1h9cmF3763xf0Oq0o1/CS5nL/yfpvy5y31PEoAGg5oWUDaL5x2LJkjXn1iaFOVNfd/4z3cLsADg05vNgUXgRR2GuYxqJbhSTpK/yRf1izGgX40u7zQCbXg9rW2V/1uuwVS71ymjRXUrLQ4QJ0lT2VjfUZzjEoP5C+ZwJz1UoEUq6UNMR5FGR7n61B5E4WwlV/HSD6M3jSUIS47hUgax/3tYkbRHO8xYVwroel6zwA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(346002)(376002)(54906003)(2906002)(33656002)(966005)(86362001)(71200400001)(55016002)(186003)(66556008)(110136005)(4326008)(53546011)(508600001)(83380400001)(66446008)(66476007)(52536014)(76116006)(64756008)(26005)(8936002)(8676002)(6506007)(19627235002)(9686003)(66946007)(7696005)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ehxa0hgprsRYGIqkWhw13F7xELB3kktUf8anS9snS3s3V2VFC/WDO0kH/s0j?= =?us-ascii?Q?qw7CnfiinLZXUyHN2upYm+msPAvepB+d3LgyUXgE5cjwEqMW4Li6G2e4vRJe?= =?us-ascii?Q?gHY73iRS/L+lPgFhAcwUAz5xSHgUlaOvQaztRNBmqSG1K63hCI6CPAIeNyWz?= =?us-ascii?Q?uzD5szVw3eQVz5HGk+t6APK7P3J/3gmQscu8dHKu7sbjxnuIMfIXxp1vQsJR?= =?us-ascii?Q?37R/stWfdt3tmt8Av7tXQ6Gl7j7bxMhr6fhKI3XQB/jdY5sWsX2qkVOxklrd?= =?us-ascii?Q?wDtQWY64gTWqKZc0k9ki/NYRkmHaXUPC7FNcqELlvz0QbQWN7s0bjKA8b1eN?= =?us-ascii?Q?KWB/f/vSwbU8JeR6I9UHWB2KKWVjcIPVZHev+hpc7WLop4JiQYNeeL9+S3Ns?= =?us-ascii?Q?+AC2YWAbayXFegHmJHTznFqKdU0gZB01D6XWgGgwoN9X5xW77QkRN91UdciW?= =?us-ascii?Q?yo/485UwBTWkFV+jwwzJdILC8uldVcC6Ag8ciZYfaT3ieSH1Fhlc+Q4QWZ40?= =?us-ascii?Q?dZdYWFr5VZnpZ4FygfWub6SE7FxK3x9SyvFVbXA5w5VjsdB3FmsJFvnNSup3?= =?us-ascii?Q?zGsgJAK6S4lQ/e3ZBt/Lyi++rxfsUSD2XtQ13NvbipoZ9vTfYpgh6nZgyGfc?= =?us-ascii?Q?roFDilRQW4n7stlgh7C6ZcMkoXE1IlkA/nfFQnz1eeRlG359dbYfj2d6SU9z?= =?us-ascii?Q?4yMrOOb/lZ5NRpwjVGe4kAhMW1AnmFIu5+kUl9qbV4La//WIEm9D4Ojq/X3x?= =?us-ascii?Q?Isn2eQggPNGyLxMvYQEXGd13vUejvElBoMmhoCcervRdJlQsDUXBHQsLK9r7?= =?us-ascii?Q?On2rTxhuD1FVckDOzk7RAQzLsE5HCsvwrbxqIUEt8djanVpHogPyTpSPpWHQ?= =?us-ascii?Q?WhvymWiwlT/lPw8S0q2dUnQTIPsXbcyBvN48dgcYAlL4V83npr6hRm2WiXWt?= =?us-ascii?Q?9FVCimQ14+Sa5UiX3h7DjMXJh3kaPJ5OUw6Aa15qNco=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f82bbe89-a9fe-438d-a1a2-08d89c2291d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 09:12:36.2074 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nLwVVuJZbzhxxFOhjpTcTUQr6ckX+s81gYTIhY+qp0yFpqT1EpC6MkwZppyf9yNX5HGfZhH8a6F0w45cSs7thFZO2+4CNa5wcqDt7z4pfmw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1760 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/79f4d39 > -----Original Message----- > From: Luo, Heng > Sent: Sunday, November 15, 2020 5:31 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Chiu, Chasel ; > Desimone, Nathaniel L ; Liming Gao > > Subject: [Patch V7 1/3] MinPlatformPkg: Add PCDs for Serial Terminal feat= ure >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3014 >=20 > Add PcdSerialTerminalEnable to enable/disable Serial Terminal feature, th= is > feature supports console redirect after the shell is loaded. >=20 > Cc: Eric Dong > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Heng Luo > --- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 + > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index 7ef189dac8..2a831f2669 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -318,3 +318,4 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable > |FALSE|BOOLEAN|0xF00000A5 > gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE|BOOL > EAN|0xF00000A6 gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable > |FALSE|BOOLEAN|0xF00000A7+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable > |FALSE|BOOLEAN|0xF00000B0diff --git > a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index 112ddff7d9..d0b5593817 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -1,7 +1,7 @@ > ## @file # Platform description. #-# Copyright (c) 2017 - 2019, Intel > Corporation. All rights reserved.
+# Copyright (c) 2017 - 2020, Intel > Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2- > Clause-Patent #@@ -44,6 +44,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE > ########################################################## > ###################### #-- > 2.24.0.windows.2