From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.3478.1634259195512042121 for ; Thu, 14 Oct 2021 17:53:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=DHq+YdXh; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="227777319" X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="227777319" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 17:53:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="548937789" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 14 Oct 2021 17:53:14 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 17:53:13 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 17:53:13 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 17:53:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MPloRp2ET85vVlUWvAmlz3dJZvEYfOH14uk9rsAjula40ojEIWqHLTf0bGpy48CJXTtBCucxsD5ktRMjwN+0kqsqm4etQGhPbh2X+4cS+H2MiVJkhRPKmw9JCxPq/ubwDr0VqUBgOE/GRG/5ShN4mO54ATHlzPp93O5qy5h73hvHhehxRBuGUjba70RRjjmMzfrucCEg6/DX6QIoymuoaEEbZ5gJ5vB7NlW3w0Q1Qoc+N9zkN+QFSMUt5eIey8ucl1fo5guyILsrnh+VAcIJgRfW/9DM4R2mWfa1Z+649ilPY4QGAI3W6SYYqbggB4ogdmQ7L8MESEwSWFkXu5lcBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RUADeCHSy3zXiOl9fZ16FaRl2d5Ktv5Q9k4z+KDGOGo=; b=gw/QWIiAahFBDWLls/P64Wg1WH9Wvr89KMdaVp0+NujTHZmjJTnIcycJ2MnyTVxdAcgZVvJ/8rLEWL3lq1JLo75nnVactN/3A0wPeiBzXCTGfMyl3/1Ksu2FJjVu3Rs6wUnT3q2QoHVN8ZGkhX09BvZkVHUBuWqVn/mcTeuTFrVrgn500e5JBU2XluIcirIOw2jx4Cce0brZNZLisUmVk5xWUevWbQlwESiZGnkFP6Z0+w5yeYYeRDkV6PzclR9WiW62Gk543x3IRx9nuGS+akjfrQ6G2CUu0K5ipXimcJYEmE3+xyqr8VvMU9myVAncPn7HMjJ0VIskcOWjaV1HHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RUADeCHSy3zXiOl9fZ16FaRl2d5Ktv5Q9k4z+KDGOGo=; b=DHq+YdXhPaF3jNj2YDNHD4QCEvR02Q9m1rcX9Hzlfj194l58ZiODq5wG6xgr0Jo7Am5f3PP/C5jr3NgW9+FqZEUo0jmDDlwM35EeRSW7eU8witlZ/BDQnT6cU+z1MDYL601osf7vKyevFGTeWQwGlv5YRV6uSapTamuXaTU2i0Y= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1760.namprd11.prod.outlook.com (2603:10b6:300:10e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 15 Oct 2021 00:53:12 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed%11]) with mapi id 15.20.4587.030; Fri, 15 Oct 2021 00:53:11 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" CC: "Oram, Isaac W" , "Felixp@ami.com" , "DOPPALAPUDI, HARIKRISHNA" , "Jha, Manish" , "Bobroff, Zachary" Subject: Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro Thread-Topic: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro Thread-Index: AQHXwUsLUHvwBcPWyU+4enaG0or3S6vTOnwQ Date: Fri, 15 Oct 2021 00:53:11 +0000 Message-ID: References: <20211014222952.1651-1-manickavasakamk@ami.com> In-Reply-To: <20211014222952.1651-1-manickavasakamk@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a9b9825-b596-43eb-2899-08d98f7629a2 x-ms-traffictypediagnostic: MWHPR11MB1760: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QmvSz3KOCXIyoYeg0hcsJ4SGJsTdeR2y0wSF5UkjRH3rziRyCRqZIdMc6SLADKdwC6gDgx03GMr7geSFKMe1op4JTe/zunAtoJDSHxRXpl4EF5ZdgD5n7eRpRwcQcLwZO0A6KWFUYV+ZF+Z6jWcl5cjdooDPL/Vm2Cp2Gkc1XUdTroJQj1jIFSalkgseleOV2MsVb8TafOFy1+lMxHLRgiaF4VN1Aykp7Tuz4h3JngVPfcy/EzJwv26FWrzPz9+gfXFqe5u3iaxKY5NttYbjqupMsVakoueYlcGCy2dBCCsOxwJceBidzMzZbr6umfoIgeJ3hYjqmuxo2SQaJwVq9Y7nkEShFf1LXTGaxeQSXZAIanDs+97u8INDX7UEMiPk3q79GYCVFIaKO0sKl1AvZlWx3zMHaIaLe73Z4umqpvlWjFdsKVPaJcUR5OMN1f8o2IuJv5f9Wp8mfEv8gMP5L2LqidcuUepPDGyXrL3EVYQ81C8TjS0nKhTl0UJAXzHOMzpaHimgWslLoERsKbJw31aeKH9HJ9Ai10Z2s2dqETWa5whc9athJoB2Kb7P66gZfMDmhEkG5K3crRAyZakzTG7ezX25eJqLH0hyNQfqfOeIe4Rc7zq2qoNsstjM1Do253Uz8Pm7vswgepXLrx1/e/L3qIZun6RJaAYoglHOEp9r1u6zuAE2N1qfoIfmeG20HVC3Oe+455Bgw5oeiQCa+9zhywoddDzAg+A9Bccdm+NjftR1GWonzA4wNJw5aPBSYgAEKzHz7AyqWcFKUCrnO6+rMQ+gje0+V6s4p2VP0JdLteuS8ZCaCdrBp15kA4QBF//thuHDKBc1nNiOQoFT6w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(40140700001)(38100700002)(33656002)(38070700005)(86362001)(82960400001)(52536014)(110136005)(64756008)(4326008)(55016002)(2906002)(54906003)(9686003)(7696005)(53546011)(66556008)(66476007)(5660300002)(26005)(316002)(66446008)(508600001)(71200400001)(966005)(8676002)(6506007)(186003)(83380400001)(76116006)(66946007)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wTeO0dbOr3n775BzKVeh6DR2tupB/WDR4wG0NdEGRLbWytmr8cuekhs1/Jce?= =?us-ascii?Q?QEYgUQwwmQs7XQWmLLX3QTsUNFNfCXwA0rii1y1ewzkXvk+Nh7ZAJ6/Ry0ml?= =?us-ascii?Q?FMbnvG3rXTg3tIFVJo4+1OrjVywDqHYZM6hVRJ0iiy21va+gP5bQjM8OUvhv?= =?us-ascii?Q?ucgkeaCRFxBmrvtxRAw3RW92qra2Tfx99+W2Iu8n6BeQRp9roGpwZulhXv3o?= =?us-ascii?Q?wH/quaB9Q/V2g3nIL+KnpdwJeTNHamwfr5y8COtkNs/NXdEl+sc4yWiPNMOI?= =?us-ascii?Q?tFSrO96GJ8EL/QlDvJw1TO8gY5jraG8Ag/vjZrAgaLm+bVZYInJIbceYm3E1?= =?us-ascii?Q?ElIPSwPT8X5iFbxIfC+G8DRJ36EGVM8kGbKriFQkAsvqcLjp5pHT1esO0i4I?= =?us-ascii?Q?UIJ5QSYGE76sHZDaPQIT2DhFo1S3kFhrvQDiQCp6GjP3BmkXEhQy6wBCtPU/?= =?us-ascii?Q?CV5rTki/l18L4Cu7y92ny4erXfVzfWzYhAMe5r+g1yblkqfN/cfbFqLC4OU4?= =?us-ascii?Q?BckH3i0jSQCiHowo6mKVU7KfBwtePpaDzzU8wvrotIjikb8axtALppSQsF6H?= =?us-ascii?Q?AXa1RsI7ZXrJj+o47o/lo2A72SCR0v+ai0I5z7xvj8z9NsD5Atotp4qZI6r3?= =?us-ascii?Q?WNUvzEoqil8LiZBz+M651XidcvgiG33QBZv/Zq+OlKS/Yfl4c24KZ1U1N+aw?= =?us-ascii?Q?K/0xZDCPkX5PR8JwOsV0zi9EZvuh1UhLR8yIuE9sJuWdwYu879/dLJ8DgUE4?= =?us-ascii?Q?p79fxIgRlnV8JYNXiv9iKYPGo1AzegQt60TT6AHSuJYbiDnT4IV4zpAbD4H/?= =?us-ascii?Q?sUeWU/BWidEYmJui3v8hBBLKDCbO5IJEYhUgmbVrZ0NGBGFMCuwjXJRDIfNB?= =?us-ascii?Q?P+q9PQnopOOrBfScMW5toPO4ar34n3ufSLqzoL0xXHzPPMX9oc2ZJi0p84kD?= =?us-ascii?Q?hBO177mxRtz4I3HV9lQGG+MLGbjkBxWDeP0K5ktbLRKKxx/6BJXOrLjaw/uc?= =?us-ascii?Q?fR9a19X0GHMUh03zwZo3+Sc8h1VY3zOMP1ESFcE695/9t7Jvr0t867OTzJLi?= =?us-ascii?Q?aQajnh78sLIvK/zzndrPYtieOgL1n4LapBZFmHHAVciS5g6kGWdIkT/ER83K?= =?us-ascii?Q?jEB3XExfmKZkZ1NbII9znfeFfTaoWpb8VMLE5oQKJC2jNOR5LDpIsR2ouCbR?= =?us-ascii?Q?Y3PMZuwXzbecrZVkA76WRKq9Ez5bNprPoUoK6uq8QWeUy3bKJmB3r4GN4/FS?= =?us-ascii?Q?fGi4sT+COOHnzdpvT8L7vKGu4752FJwRLPfu0O2dXD/IfN2JFyp0UZzGNNQU?= =?us-ascii?Q?vcvoCrAdcMpoftSj0tJ8IUGj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a9b9825-b596-43eb-2899-08d98f7629a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 00:53:11.5182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fya3IabAPiJnwfyxreonLEyIzGav4kfBlr3/yzkjRQYB77ImeyGBtFlhU00u2s88O/LXe1ctnJAUyCgQozkMyugSlG1vVDxRlvBLiQz9/8U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1760 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > manickavasakam karpagavinayagam via groups.io > Sent: Thursday, October 14, 2021 3:30 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Felixp@ami.com; DOPPALAPUDI, > HARIKRISHNA ; Jha, Manish ; > Bobroff, Zachary ; KARPAGAVINAYAGAM, > MANICKAVASAKAM > Subject: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for > WilsonCitySMT OS boot issue & using proper ASSERT macro >=20 > Fix to resolve the OS boot issue when booting on WilsonCitySMT board. > ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status > code and not with TRUE or FALSE. > Replaced ASSERT_EFI_ERROR with ASSERT. >=20 > Signed-off-by: Manickavasakam Karpagavinayagam > > --- > Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c | > 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > index d8274fa7ad..212103f483 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > @@ -68,6 +68,16 @@ BoardInitDxeDriverEntry ( > ASSERT_EFI_ERROR (Status); >=20 > break; >=20 >=20 >=20 > + case TypeWilsonCitySMT: >=20 > + Status =3D gBS->InstallProtocolInterface( >=20 > + &Handle, >=20 > + &gEfiPlatformTypeWilsonCitySMTProtocolGuid, >=20 > + EFI_NATIVE_INTERFACE, >=20 > + NULL >=20 > + ); >=20 > + ASSERT_EFI_ERROR(Status); >=20 > + break; >=20 > + >=20 > case TypeCooperCityRP: >=20 > Status =3D gBS->InstallProtocolInterface ( >=20 > &Handle, >=20 > @@ -80,7 +90,7 @@ BoardInitDxeDriverEntry ( >=20 >=20 > default: >=20 > // CAN'T GO TO HERE. >=20 > - ASSERT_EFI_ERROR (FALSE); >=20 > + ASSERT (FALSE); >=20 > } >=20 >=20 >=20 > return Status; >=20 > -- > 2.25.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. >=20 >=20 >=20 >=20