From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.2836.1608340685791998435 for ; Fri, 18 Dec 2020 17:18:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=M+lSwPY9; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: R1jCEdNQcTwN/WMyG6t2syUGLzdbrGBgeqF8xFUHGcRbHeuo20/+rOcNt7sMerMZf+ZTGCEleh VEdZaeGub5DQ== X-IronPort-AV: E=McAfee;i="6000,8403,9839"; a="172031625" X-IronPort-AV: E=Sophos;i="5.78,432,1599548400"; d="scan'208";a="172031625" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2020 17:18:04 -0800 IronPort-SDR: VLRLX+dfme7WhcNEy8LF3uUmTGutxMew3zkb2ULBLABLAEc8mCTtNaoUJAM01uxDw6gkwku/s/ WxQLrRAHmjzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,432,1599548400"; d="scan'208";a="561661726" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 18 Dec 2020 17:18:04 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 18 Dec 2020 17:18:04 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 18 Dec 2020 17:18:04 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 18 Dec 2020 17:18:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5cwNvMBAWGIimi9jx667E2//iyl/U/Jikku1qoZjz8Gb6245RJiqqg4DQhClEnGvFd9yqihiYZlyvM54NqpPp9vn468v8dnQk6vbsyTHVRxAPd98g/mcrfVeExfiGNei5nJfRS67QreKellcBpPMFVHFhc/B3lQV13uYGEk8IsAqTxXVxsnS9DTduiHeC2KoVRydA24WgOE/5hWNxb9PX2Yrcx4YBlkqf5tvl2AsISEIyJLLb99otkJ/VayxmMykFO0Y0WuUBpi+4BbA+hlVHes5LsCwznMcjgm93gTsS8ctar/qsdq64rQDSVY/gFXMSrdfIc7NIj7BNYVVjtrjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HwqLL9pe6q2P7/TUPodhH9OcZnh+NuhQn8lrPGkSKN0=; b=AaayY2vgaN3ICQ8JSTvII7sN71zPqetVNG9kS5ZluiUAvBKeAUhVDZGm9xwkBvRr9pmGj2nY3TCVnCr7f7jTBCkb6NK8f9tcunKwbSkYf5xjiTOo2yuBa3nvYjpJBhmP+8VzCeabPfNbRuatGs9seMAkYgtpr9+3r+iKYdDrFzRNeWKcjxf1s8V9fe6Wm6U+AsEP0Nu8ZCzgs6n5FCWV2CMAUKfEm0qBj0+xfoTYDvSy8XwpWnB6vnvHtHp3dh0kGCxSwBMLIlO0gEo/8Ec2AHo4aa+7dZMfLjsl7Imwd7x3m3xjnLj0bd1hRuBTmL69uYMAIX7s9S8hxLsg4MRblA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HwqLL9pe6q2P7/TUPodhH9OcZnh+NuhQn8lrPGkSKN0=; b=M+lSwPY9qgmL7IfEJzwQVFIH/DmH/JaBKgllrhtTAl27eDsHeukkX81dvuLGvxp03G8Es1jucN5t/kSbjVowESjYWxT7RWwAl28sBZOmh9OQGcUl/7XAmskNDnekHYHfh4GCiG0M8n2RPOIXclaEiUjBCH31qLCvHKDMD1Aatcw= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB4994.namprd11.prod.outlook.com (2603:10b6:303:91::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.13; Sat, 19 Dec 2020 01:18:02 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710%8]) with mapi id 15.20.3654.028; Sat, 19 Dec 2020 01:18:02 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [Patch V2] WhiskeylakeOpenBoardPkg: Add USB DCI debug suport Thread-Topic: [Patch V2] WhiskeylakeOpenBoardPkg: Add USB DCI debug suport Thread-Index: AQHW0bqZVNJoqRwsekiZw1K8GMLJ26n9phkQ Date: Sat, 19 Dec 2020 01:18:02 +0000 Message-ID: References: <20201214014352.1087-1-heng.luo@intel.com> In-Reply-To: <20201214014352.1087-1-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a67f41dc-a18d-42fc-0c47-08d8a3bbee70 x-ms-traffictypediagnostic: CO1PR11MB4994: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:269; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Yo44tBCDpjICAkeMDfHzwpDmm9yuQg3sw7CJX1WYT0jfohvEdvlJD8ByWYEl6aYzSo+t9TgzgAnwa54Lp6RnCVH7puFLRMzSn0mdgZgp/QrHc1/x/jzK2SKZmHzej5BezJuwZscfeSo0WEN7v7e/DGelOJZuWklxxzL6WiSRl5hEwCDFq65vCkMk1vNb43WDxhs82662FGK3wYqfJOdYOKOX/riUo1QfyHNtTZFGYHcIPeoXHVDDWaj8aQrDUuZT4D2SYTezyMidBGgA+1ivuaqXVphmKWioeZydKPnGnLmIo7NvEbGfrfpSHqGrbMJjOFZFOWkUGLJoXlFbR2oNCuzvqFHts2flSwgvECIoXPRm1Agkn2JRzpzfcu9jLM6eOg6Ld5ykaLQyKsFO1B1Fog== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(39860400002)(366004)(136003)(346002)(316002)(5660300002)(8676002)(83380400001)(6506007)(9686003)(966005)(8936002)(55016002)(64756008)(4326008)(66476007)(86362001)(33656002)(66556008)(52536014)(186003)(2906002)(478600001)(76116006)(71200400001)(53546011)(66446008)(110136005)(7696005)(107886003)(66946007)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?dhVYRkuOyUIbs5bvcq+WLHcaitmdgB5qnDy4z9ksmnqx8P+Pqj52XZeCk5PZ?= =?us-ascii?Q?sm6DFq/uJGZOwdOnh+9B01mAzupRwXIkm+dXjTgPoisITY/gqjBCe6ykjEIn?= =?us-ascii?Q?GulXX5yL7TOTb2vFcrSDKVAeqTXO8bMCQAp9vGNo0UwspkKaKHaNNK4HirEj?= =?us-ascii?Q?Imi5MTNjOOXELnBPuDgasD9GphGK8wEhUhHNBPzbZw0mMTrRfyfNgoW7J8+2?= =?us-ascii?Q?DIuqxxzddGRRfEZXCIUPWm1raXqh8DmkRs5U6GI+ufioCII/yZVKxzpw0uZH?= =?us-ascii?Q?0PSLMAh+rjSCfXneTH0OLHfNXrgyrV13BOGJd5ePnR2NTgQuVZzMwFvTVf8S?= =?us-ascii?Q?ZvOr/wt6JQtKAJ/9ftxbrqXUyVKEKGWGfaKQZS77uLgiASCFGwP5CgRyPBsB?= =?us-ascii?Q?yKopCan/q3iqSSmIffSmM3OiTNb+2mu0rDiGjzg/fPORIhddpLny9IDC+NLF?= =?us-ascii?Q?yT6E6ukBtRacId6Dvp/qgnPw8bJV2KW4Ukv7+tUpJ1AbtMSrJykfxk/KmnKM?= =?us-ascii?Q?peFeTKgGRO1dptVYjYvhhqjHyN7RGWGi+N4lz2M3Sq27sHxWyFe1ydBjTjfo?= =?us-ascii?Q?LxMPnH0A6H4jBUXBBBGlfHabYS336qoxeH6VVyzuOI2kwF3MW6ns1Qs6Id9G?= =?us-ascii?Q?JgaghDhvOwRBrt48ZvtNdMfG5dxxJnJ31K6xD9KdPJkYa1JS2BL4zycTEMr6?= =?us-ascii?Q?fcuZQOs2prdQUvOshzvEra4Ct+wFtHl7ctjZD+6aZGk+eroX60oDGv8zT0ON?= =?us-ascii?Q?hOcKJcLuLq3UDFDqneqc6EMZ66v01AAHaPto2lu0YTmG+IYyAykEeowUEINu?= =?us-ascii?Q?3ssbK7CI2SVqlYHNwIKXeuvgG0VM0UReI81JLrZlrDcWYFt1nZcenxZY4X11?= =?us-ascii?Q?oXrGl5H2EM8a+OsPOmedXObl1OLEuc0kSL/DeHCIr5W0QXoozUrnXPeOd8MZ?= =?us-ascii?Q?C6FHSbCQ6PfqtRXQsrw6V5MrEMccsgUBj5XwzLNc7q4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a67f41dc-a18d-42fc-0c47-08d8a3bbee70 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2020 01:18:02.5988 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IYwXfzrtaQW7EeEbwOOVIMcOMZa8KBoLhw93nmDkjtSMzUgpH69n3AZpYG3hVhuT5Wk+lj0h+uROWfx4YbcuyJfzb2WxlKy0eB/MNFZIPZo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4994 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/2f81608 > -----Original Message----- > From: Luo, Heng > Sent: Sunday, December 13, 2020 5:44 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [Patch V2] WhiskeylakeOpenBoardPkg: Add USB DCI debug suport >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3081 >=20 > Add gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable for USB DCI > debug feature, feature is enabled if PcdDciEnable is TRUE, it allows to d= ebug > BIOS via DCI cable. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Heng Luo > --- > Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLi > b/PeiPchPolicyUpdatePreMem.c | 8 +++++++- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLi > b/PeiPolicyUpdateLib.inf | 4 ++++ >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds > c | 2 ++ >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk > gPcd.dsc | 2 ++ > 5 files changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > index fbb9549e44..196460e170 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > @@ -554,6 +554,7 @@ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdNCT6776FHWMON > | > [PcdsDynamicEx] [PcdsDynamic, > PcdsDynamicEx]+gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnabl > e |FALSE|BOOLEAN|0x20000001 [PcdsPatchableInModule] diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > index 2d48b09175..bb34f89fb5 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpd > +++ ateLib/PeiPchPolicyUpdatePreMem.c > @@ -83,7 +83,13 @@ UpdatePeiPchPolicyPreMem ( > Status =3D GetConfigBlock ((VOID *) SiPreMemPolicy, > &gIshPreMemConfigGuid, (VOID *) &IshPreMemConfig); > ASSERT_EFI_ERROR (Status); - DciPreMemConfig->DciUsb3TypecUfpDbg =3D > 2;+ if (PcdGetBool (PcdDciEnable)) {+ DciPreMemConfig- > >PlatformDebugConsent =3D 3;+ DciPreMemConfig->DciUsb3TypecUfpDbg =3D > 1;+ } else {+ DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2;+ }+ > PchTraceHubPreMemConfig->MemReg0Size =3D 3; > PchTraceHubPreMemConfig->MemReg1Size =3D 3; //diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPolicyUpdateLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPolicyUpdateLib.inf > index 478e2d0512..252f92f487 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPolicyUpdateLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpd > +++ ateLib/PeiPolicyUpdateLib.inf > @@ -230,6 +230,9 @@ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdEcPresent + # > Enable/Disable USB DCI Debug+ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable = ## > CONSUMES+ gIntelSiliconPkgTokenSpaceGuid.PcdIntelGraphicsVbtFileGuid > ## CONSUMES > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdSmbusAlertEnable > ## CONSUMES > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdSataLedEnable = ## > CONSUMES@@ -243,6 +246,7 @@ >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSystemFmpCapsuleImageTypeIdGu > id ## CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## > CONSUMES + [FixedPcd] > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize ## > CONSUMESdiff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > index e161bf06f4..84d4ec1331 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > ds > +++ c > @@ -399,6 +399,8 @@ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3Tbt|0x1 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3TbtClkReq|0x1 + > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable|FALSE+ > [PcdsDynamicHii.X64.DEFAULT] > ###################################### # Edk2 Configurationdiff - > -git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > index 83ada3c95c..4a7ba4d5f0 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ gPcd.dsc > @@ -389,6 +389,8 @@ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3Tbt|0x1 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3TbtClkReq|0x1 + > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable|FALSE+ > [PcdsDynamicHii.X64.DEFAULT] > ###################################### # Edk2 Configuration-- > 2.24.0.windows.2