From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.13425.1605396896840050993 for ; Sat, 14 Nov 2020 15:34:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lVWhJWCl; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: eze7zCFtOkIleSfo7JKDI8LjiXSeA8tUV/WY4xzluu7ZCaRgT1yrRP15tuj60/DA6urPn8/fJW NI3BFAoz8LPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9805"; a="255315027" X-IronPort-AV: E=Sophos;i="5.77,479,1596524400"; d="scan'208";a="255315027" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2020 15:34:50 -0800 IronPort-SDR: hiMIm92tRrpRD8lNJMjVXNQdvng/6ToAoWyqs6oh61dVyyWtN8LRF0GTdpwLKc3dPK6fapg9EU LnycZkAU8TQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,479,1596524400"; d="scan'208";a="357991745" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 14 Nov 2020 15:34:50 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 14 Nov 2020 15:34:50 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sat, 14 Nov 2020 15:34:50 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sat, 14 Nov 2020 15:34:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cxppoJxnFBIg5r9MeRkk3O75MlV0ExSRIBHoVX+xyhBd8vWVmGgweYzsy3w8mRvnSbMcenmSJ710dL8OhJuSZzwt7gToK/Y8B6lGytVsp9lDV/fRXUB6oGw8qaaOu1qyv+RzHikoerZ8a/hlMe1hhoAsVqWmpToah96R6CgvZEqlxEaNmnm8qtXpDgJe8fNEiKk8zmzt8+DU4zJ/cS2cOyoOFsirfeJrJp7N7akcicX1+tKuB355vOFz3M5K6aKv7z3j5JqNGIy/Pc7OZD0Q2A6EH2lxhsXbvYgYlnuVQ5cSq1VM1v83L8p7smbVQZHkbzcwjTxEJLpG+HuOFPaNdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dFDXf7bFsTj1mTQVE850c4XQYA7EnLrX2l94dVLzPXI=; b=Jst1UpLnMrsyC3VIXjvWezjmIvUFZwCHXlVB+Tx0eEteEN7TOfPW3NZKZDjjuDZwSXhJeu/jwcSN3mY0pJldVjOyNLX63t79e+23+CLEdSf6HrDki2rUFdngTaeV6ZavHGCFxfwKd+OHzL2E6O6xnVvUOKgTOkPw+RkJPHJ+B8VeCyNZZlqzh4S72uxpx7DIYWWf6LphcHQwgtalxSxW2HL6t8mNl8mmx3KN1FV5TKtb0SyUbHUrjlT4ycwFkZfWWyOozgOzLj6I3XuI3aj5p8rksZ3uYyYE+bsC/lifdpN1ij4HtQOIdeiuNeF6HqxJkmuf+F/dmQQyWcFe95SXYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dFDXf7bFsTj1mTQVE850c4XQYA7EnLrX2l94dVLzPXI=; b=lVWhJWClDcufEosTAvoAdyMVbIUadqfBU0vTdr3B30o+uIkOa4Z7mWqHzUosbZBQuajsTmK5DrDFyJsqXL9h9vKEj7S8VFVqHhhbq2L89pli2SRg0zRxFKGG53WS71SNUc3ldTlC2PsJJ5zLgSH5bLj4UqtGQkbbMecULE+zIPo= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB0014.namprd11.prod.outlook.com (2603:10b6:301:64::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Sat, 14 Nov 2020 23:34:49 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710%8]) with mapi id 15.20.3564.028; Sat, 14 Nov 2020 23:34:49 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Chiu, Chasel" , Liming Gao Subject: Re: [Patch V6 2/3] OpenBoardPkg: Configurae PcdSerialTerminalEnable Thread-Topic: [Patch V6 2/3] OpenBoardPkg: Configurae PcdSerialTerminalEnable Thread-Index: AQHWuKAIlf6BTHIw1UCOgnWVUFAEP6nIS9tw Date: Sat, 14 Nov 2020 23:34:48 +0000 Message-ID: References: <20201112030031.1481-1-heng.luo@intel.com> <20201112030031.1481-2-heng.luo@intel.com> In-Reply-To: <20201112030031.1481-2-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 465209c5-4ae4-4337-cff4-08d888f5e0a9 x-ms-traffictypediagnostic: MWHPR11MB0014: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:206; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lxrx8Bzsti0YicDX20yyuCGmH9wrjuzjEhBgLu40bySYRtNEyQaEEbuxgi/bt51iZgm8JDpIK9+9TUgURrnWjw6ofqM85PpfQbrXa9o6j3WB1x7qp7K7T07oaTpvLt08CuGyM7CmC5HW2/HN3hA8y/pnd4xjCaCVz5JRkmmPb1gB+SWrDjZ6eO7S3GlcLhHc8l1GN5q9TGesUcdS0i2EbpbpFcxh3DbfipxhKBBudI+x1poSId2FWldfJvx9kRf5S/8oozFTI5hRlup6gPzitHTHwKBDRhPU8p/2mlVzyxDBDSV295P/l1TqYSiHo4BgZO0YS3J/C47c9IJepcKZXkFCTdg5x9/FrHpPYQ3zdrg3LtM+hK41MY1eG9RgMoCXsJsMd2KMhqVCgI72ImI5WQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(376002)(39860400002)(136003)(346002)(8936002)(9686003)(52536014)(55016002)(86362001)(316002)(76116006)(8676002)(5660300002)(66946007)(64756008)(66446008)(71200400001)(4326008)(66556008)(66476007)(7696005)(54906003)(2906002)(110136005)(6506007)(53546011)(966005)(478600001)(33656002)(26005)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 1bkvrClEaMFiTjaFrCuYJdHevhF2TO24Yq+SsjrJLE1Dy1affu2M1XdsShqZyl1DhjrcEotDNtb+kazykuDw7QzLlJfvTxvzJV1Hd1GZ1eGPHSKcIRT0s2019NtiREwm6JJUgeiDmp5PFrQQBU5mh1mi9JC7Kj9xRvLGkaWe6SiW4MY57zdZVpMV3gGtx+YsC7xsDogT3qFMUUrHhH5eSYIT5j2wv9WeKci53GvO+WGD9S/mRbwZmbZb750P3wB7jNFx0uMjJEgmpqwHCHgbFZJr6N0K5N6hRl/WGIkLOi8Y6qjtnNg8oDcXLf4mxYr3RV8mlhGUbo5RsiAxheW+/YDivZ9zjatgCto+OxLwY9oDnUQxclziufkZCpkGzorh5HOhX5Wbkq3fpp5i8hllSLu3TH8jRC1WaWSOOkusaMUztBz1fANTQk8P2E3oztzTMtDhGqz+j1JtFseXYG4uvIJMa7E0Ag8t/XkdwWMMqQGzOgsUOGSTR11dwbFt7IRAw4afGkDAyzBT2wCrUHYdVPxZblsD9/QOUurbM7eh8mSOuCC7lWYbdYfAvs/OogVVMXVkdSj3G/VwqWweQX1cgLAG+QJQpD55MdvSUA0b58i2Bj8OO288qnCRHCPi4UMrPa/nimLrYK3IVA5u1aCqaseOtqCPGo/baG44nD5fYwQlci5DNJBMizqmIB3HnRctb+kHtNp+wXPBEoSyWdEVnntog4q4FLW4zlxxtVhngMY1DYbAka2Gb/MbiCdDCIYQr9PDjAvphd9YWCro4JJ4n8NPGUNI5Br9UZwc228JawIDEc6wUmbEn/1z+isZ3grZDubrlxU5Sh9jwz5jlibdu1k9zcyw+txYZ4hd5q+kjZ0cZAl0nprm+KDxRZJGBp1VW/2FUM1zT+X/tMQ8wxI72A== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 465209c5-4ae4-4337-cff4-08d888f5e0a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2020 23:34:48.7276 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oYLpmyTbDHKuo0+YpiEaS3ZiczkoN+ce+vSBSPh5/EL4QukzBmNIwF7jNQxsaYGZhrqYjHS5gaVP+P75kyIHD+h1kIXqdFZf29FQ2vMQPlw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0014 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone On 11/11/20, 7:01 PM, Luo, Heng wrote: >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3014 >=20 > Enable Serial Terminal Feature for UpXtreme, and disable it for other > platform by default. >=20 > Cc: Eric Dong > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Heng Luo > --- >=20 > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPc > d.dsc | 1 + > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > | 1 + >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds > c | 1 + > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds > c | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk > gPcd.dsc | 1 + > 6 files changed, 6 insertions(+) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd.dsc > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd.dsc > index d611e99fc1..589b002d06 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd.dsc > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd > +++ .dsc > @@ -131,6 +131,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > index 352416a489..44dacdf082 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > @@ -130,6 +130,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > index 9e8b148753..725596cbf7 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > d > +++ sc > @@ -168,6 +168,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > index 52cdf9ec0f..251f46f812 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > +++ c > @@ -50,6 +50,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > index d797ae9d94..e161bf06f4 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > ds > +++ c > @@ -127,6 +127,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|TRUE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > index 5d769e8153..83ada3c95c 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ gPcd.dsc > @@ -127,6 +127,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE-- > 2.24.0.windows.2