From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.3377.1632880169857161404 for ; Tue, 28 Sep 2021 18:49:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wc/yUgc3; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10121"; a="224496650" X-IronPort-AV: E=Sophos;i="5.85,331,1624345200"; d="scan'208";a="224496650" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 18:49:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,331,1624345200"; d="scan'208";a="519528256" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 28 Sep 2021 18:49:27 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 18:49:27 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 18:49:26 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 28 Sep 2021 18:49:26 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 28 Sep 2021 18:49:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mf03X1246tCWVF8l7H1YfgnY5Ydd+3GnGIudes9sBX/gUYQmW3EtvkTBj6uhBQVYQ+v0hqPED/qf6PdQXJC2z0ti1tQ0LufzrVGzgy006CuZ2l/6wgi0snHjPbhqZu1gyAYZZSm7EvHLApzrcDynPotiuUt8Vv1o2N6EfC3UO9LRfYp6X3YGtvNMKemlxguZg3+ck2kpkShQ3dfMhFYxFaZxOuKM8gYNYlFsnwf+lsHv1zaZC4tLptO2P5yj3bjQ1yaptNsm0Mt4N1kowsQ4nMM2K/as/Duk6+mx8xrwywbOZHarfTGUsQdAgo71aN9uyKLUhrabBDTsyqAxXAhwqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=BiXnNYTPW/i9irrsZvD85/Aq9OjhxuKSm2gRSiaJqG4=; b=dF8QLt5GhyUR8pDudfw1YGfX5zuKUom1bt8ZM5G4v01tS8C6zSoywPBciQdu3fiiks3LQFvMO9gAd8QXtlM0C4iNKRyUz83jBe9bVdQUDPBjWMpN9zO+lpl282Cd4Xtje+ub8JVjL0Jwsc/nLQTKDgYeOIxeh0kwZFoR/lHqCM3jggPy3jyMPZsOuTByLCDqhqe261PlDF/m2rAOxXpuULu6enold3Uugk2S3WW8pkCS1WUG+HvPeZcPaMEvLqQURkJ4aaQBXTiZEioMD28y642IZ8EEh+4tb7tUT7+ikReLTU+eciCWcz6Ql8yLT6G3mCMLPqvpM+f1MesqGo01EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BiXnNYTPW/i9irrsZvD85/Aq9OjhxuKSm2gRSiaJqG4=; b=wc/yUgc3taq3J+Gy0rTPMylz9U6GNpnT/+G/1ZvepvBdaa8ZFTEpCu8CZVUsrGcm2bgokNu00tJKzxLdu5OF3WOvQK71PN6t9NcZQRcOHg6XJ0sHD02VBJTWc19t4ETHA2Nm5qm2DTQaZetmcGVVbjRsD26XsevoJ4m2C1tu75w= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR1101MB2286.namprd11.prod.outlook.com (2603:10b6:301:5b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13; Wed, 29 Sep 2021 01:49:25 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed%11]) with mapi id 15.20.4544.021; Wed, 29 Sep 2021 01:49:25 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Desimone, Nathaniel L" CC: "Chiu, Chasel" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build Thread-Index: AQHXtM3cOa2vFVQrIk+Gff7gTP6b7au6PppQ Date: Wed, 29 Sep 2021 01:49:25 +0000 Message-ID: References: <20210929010323.2653-1-nathaniel.l.desimone@intel.com> <16A9255C60D9E335.27626@groups.io> In-Reply-To: <16A9255C60D9E335.27626@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e97ef4a1-c96f-4211-b29b-08d982eb5dd3 x-ms-traffictypediagnostic: MWHPR1101MB2286: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:605; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uhEtXHQbDKgpabzN6GxnzE6/r7xnVNPt4sbdCLCzhp7gFOHH/plXHsShcCuLb5+j7nS3EI2HNawuVHdFUHVuuYklBWgoSusUmNCeyZeao3O2Iz2YoXV8V30uVEvw8O4sJV3BDD1MvSe1Y/OHYgIeUuEYKCo1Dd4q9NSeHzxnWjDT/tH/oSPfRBQ9/otVHfloRNVazSiZUOh80nMOvUnOhZUPbGChuUwhlwfI4cLn0Fxucv0vgMSWCwQKKDqnhHbhut1l67lLLaFeQYENvsyOwFJbLYBM8NvMVJ51TDA2RlrrlNHTl01gGwG6I+pjA1zDaXgCM+jSziWvmDiTzwaWDP3H8MJKPXLqvsjosqlOm6njqA7a9CjsH+xCNLGstjqsiAJil2+MD13XyD7MwYpsT93Dk76g2XP6XZgY2tndWLGCEIeXINyKR3LKdWGB3UOxM6MGeP5ttBM/3s72hPqd64d0rSJWUwqg15vBUHu14nBrRqIXwDgnd+1rcvTlkAxOGxESuEfrwrcmcXBTFbjx5R+EL/IW87Wxnt/4FIOu1uoNe+vyWGpyY/A+bNOr0dGKlPzApWOz2ByN9oFf2t2JM928cMJU6shyAm1kuUjWy96tSABy9q6QaCfN0HoRFfVj3j+VmalWOm3nwbnpYZ0AL1MRUCEn1dj97sZcDSzFCR7apD3Mp1ZA7TIdk7jVdv5LgdAM17ffd0Z/bJEDu871eh+d3tXnOh+NM8rcmwyhuZJnfUaQmnflwfiea/0sDvwbMM6ubQdHsldbyy9J9HsupFbTgkOOBGYOpXJfqqjutQ21qn+2NItKORp269ROfHPqAAXC2+OTbwxL7HNvr3wvaw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(83380400001)(966005)(86362001)(316002)(107886003)(8676002)(55016002)(38070700005)(66446008)(64756008)(186003)(66556008)(66476007)(7696005)(5660300002)(122000001)(33656002)(2906002)(9686003)(76116006)(38100700002)(8936002)(52536014)(71200400001)(53546011)(6506007)(26005)(4326008)(110136005)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7RwHb7D6mNHUM18pIIJTCcZXQdzKVoFgme6uqCWqtr3Hpq19OuCja0A65SHh?= =?us-ascii?Q?eL2qD7ACJzwTmW8BLYOrcfr7m/jLxRtVrbUo+ctRCxYNdbOxgjuaOqI5vgdA?= =?us-ascii?Q?4Huhn00WbnAS7NyXupBOyh4+KEWi4QEKuQ+AUGxkAP9UGOA7ukCur958M/ln?= =?us-ascii?Q?lr7mcGIIDi2pfIARSmKu6joEiI/LbM/9+2PFvmlxeXbj5mDG+LMjFhZn4q+z?= =?us-ascii?Q?97rKX20Jw2c2tudVxP4eRV7H0s/ID4Gu6p9Gzf7iMCeaESv6VGdhTGLWcrMV?= =?us-ascii?Q?DGFK+qm6G08/8DsOi9+gCCxAd2x2KcFmkBp13x6lKRZ0T0Cj5nlsr3dxmVKk?= =?us-ascii?Q?yqbAaCFM7KYtWdxoMhrca4xM0STwpmDlIVkm9a8+xLK+ooMy11sZ9B6qsavn?= =?us-ascii?Q?toew2r3VvIzzrAemCtZjBH/8BY+kPlzFKSxHmQzDCik9mdwltC62SARUe6BU?= =?us-ascii?Q?dypIfMVowgsChsFia8BlxSMswelVOFUa0NAgq7VjHpRwqRVu7U0jcbc6ODxL?= =?us-ascii?Q?rxtCS8l5SQWPJ5pdJ9/NgU7R72DQQG/RYpET1RpCp9BkK7Mc2vusw0nKEmgr?= =?us-ascii?Q?+xfeN5frwBl1XD+/LZhsncVcNY3M9LHf9jqvGc6aJ+8QSXTMCaBArEmZoblk?= =?us-ascii?Q?EBWGwT8cYpMZnL+F3JB3808sxyFLNyvbWMXtG1JORWPgVDa66424U3UjG4Dl?= =?us-ascii?Q?GgjU4LZ1Z2IQIWDKVCIjiAA5I0gvxF+8fhkNkB3WisWmkHdv3AN1Lu/v0wnr?= =?us-ascii?Q?qV6xXX0YvHy9w02up7Qkj0D3rov2pB6fmvYozuYtMApKfi20auCxqxbJ+L0d?= =?us-ascii?Q?AtM+AxzPLTlnhB267lx/YcHqVTkKHcz32XfTe3UriHT0/aMb5zcAwqQGqe3f?= =?us-ascii?Q?kxjx5DjrTGARQXH9oj/xXD0rTO7T8n7ZNQBKNhmvlI+PKwEtSXvJc7WUHAp8?= =?us-ascii?Q?1KZsXFtRkg4fpSBsRTQ+cbi6gknbN8awWBBgYL/P6MOuaG8+3j+6YnjeB+as?= =?us-ascii?Q?PAfWdUnvI0QuoVPvZoj7EW8rsc9FBtPPG4uVvXAvADgTw4ghHRiRnOI7Yy9L?= =?us-ascii?Q?KIEryRwWQQvmJUMc0lTIU7IfYTs2g9kOtRM0PcsLfUCJdV/0Pz9yfLPmL4YD?= =?us-ascii?Q?Ta68PDqtRnyeILXVuwUREIT44AMkkIFbMxCUnVhCLDY9dHcH1OkZDnbFNmLi?= =?us-ascii?Q?ROXSlbcTIAlLOkSj1x+vuBcLZb8TlqRtGjajzZ5pNnY6fzPnMAPz+3Fnnyok?= =?us-ascii?Q?JarnfDl92HFrROq5aQ5uIaET7Qw043/Bm1h874rwJl+i3hQpz4m0eOZ4hcVY?= =?us-ascii?Q?o0DvvHQxYbMi8o+qzARpVdzH?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e97ef4a1-c96f-4211-b29b-08d982eb5dd3 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2021 01:49:25.1006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gurREqILSX6J3M+Enyy3XUkj6wdKJqW3S4OfP9PwOOislno8y8OvS0r8KMOpjcPeiGUNZzfIltbXTp8le034JtYFjyFmlY7ik8NjEbOsFgk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2286 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/437dd50 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Nate DeSimon= e Sent: Tuesday, September 28, 2021 6:03 PM To: devel@edk2.groups.io Cc: Chiu, Chasel Subject: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix= Build Commit d281e9e broke the build for KabylakeOpenBoardPkg due to DxeMultiBoar= dAcpiSupportLib having a dependency on BoardAcpiTableLib that was never dec= lared. This change adds a correct declaration of the library dependency and= fixes the build. Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 3 ++- .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAc= piLib/DxeMultiBoardAcpiSupportLib.inf b/Platform/Intel/KabylakeOpenBoardPkg= /GalagoPro3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf index 9fe27f9fda..dc597c4808 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/D= xeMultiBoardAcpiSupportLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi +++ b/DxeMultiBoardAcpiSupportLib.inf @@ -1,7 +1,7 @@ ### @file # System 76 GalagoPro3 board multi-board DXE ACPI table support functional= ity. # -# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -26,6 +26,7 @@ BaseLib IoLib PciLib + BoardAcpiTableLib AslUpdateLib =20 [Packages] diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Board= AcpiLib/DxeMultiBoardAcpiSupportLib.inf b/Platform/Intel/KabylakeOpenBoardP= kg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf index e5de9268e7..8438b16a6e 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib= /DxeMultiBoardAcpiSupportLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/DxeMultiBoardAcpiSupportLib.inf @@ -1,7 +1,7 @@ ### @file # Kaby Lake RVP 3 Multi-Board ACPI Support library # -# Copyright (c) 201= 7 - 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -26,6 +26,7 @@ BaseLib IoLib PciLib + BoardAcpiTableLib AslUpdateLib =20 [Packages] -- 2.27.0.windows.1