[edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg: Fix boot failure due to FSP rebase address

[edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg: Fix boot failure due to FSP rebase address

[Oram, Isaac W]

Fixed boot failure caused by FSP not being rebased to the correct address.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf b/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf
index a14afd693b..1f5e0fd48b 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf
+++ b/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf
@@ -11,7 +11,11 @@
 #        The FDF file for WhitleyOpenBoardPkg should be adapted to leverage FlashMapInclude.fdf
 #        format found in other OpenBoardPkgs.
 
-DEFINE FLASH_BASE                                                   = 0xFF000000  #
+#
+# Note Whitley unintuitively has multiple "FD" in a single BIOS flash region, so the base should be for FD.SecPei
+# and not the basis of the BIOS region for the FLASH device.
+#
+DEFINE FLASH_BASE                                                   = 0xFFCA0000
 
 SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset              = 0x00020000  # Flash addr (0xFF020000)
 SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize                = 0x00040000  #
-- 
2.27.0.windows.1

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg: Fix boot failure due to FSP rebase address

[Nate DeSimone]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Oram, Isaac W <isaac.w.oram@intel.com> 
Sent: Wednesday, August 11, 2021 4:34 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg: Fix boot failure due to FSP rebase address

Fixed boot failure caused by FSP not being rebased to the correct address.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf b/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf
index a14afd693b..1f5e0fd48b 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf
+++ b/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf
@@ -11,7 +11,11 @@
 #        The FDF file for WhitleyOpenBoardPkg should be adapted to leverage FlashMapInclude.fdf
 #        format found in other OpenBoardPkgs.
 
-DEFINE FLASH_BASE                                                   = 0xFF000000  #
+#
+# Note Whitley unintuitively has multiple "FD" in a single BIOS flash 
+region, so the base should be for FD.SecPei # and not the basis of the BIOS region for the FLASH device.
+#
+DEFINE FLASH_BASE                                                   = 0xFFCA0000
 
 SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset              = 0x00020000  # Flash addr (0xFF020000)
 SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize                = 0x00040000  #
--
2.27.0.windows.1

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg: Fix boot failure due to FSP rebase address

[Nate DeSimone]

Pushed: https://github.com/tianocore/edk2-platforms/commit/bede362

-----Original Message-----
From: Oram, Isaac W <isaac.w.oram@intel.com> 
Sent: Wednesday, August 11, 2021 4:34 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg: Fix boot failure due to FSP rebase address

Fixed boot failure caused by FSP not being rebased to the correct address.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf b/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf
index a14afd693b..1f5e0fd48b 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf
+++ b/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf
@@ -11,7 +11,11 @@
 #        The FDF file for WhitleyOpenBoardPkg should be adapted to leverage FlashMapInclude.fdf
 #        format found in other OpenBoardPkgs.
 
-DEFINE FLASH_BASE                                                   = 0xFF000000  #
+#
+# Note Whitley unintuitively has multiple "FD" in a single BIOS flash 
+region, so the base should be for FD.SecPei # and not the basis of the BIOS region for the FLASH device.
+#
+DEFINE FLASH_BASE                                                   = 0xFFCA0000
 
 SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset              = 0x00020000  # Flash addr (0xFF020000)
 SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize                = 0x00040000  #
--
2.27.0.windows.1