From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.17555.1628736705739592264 for ; Wed, 11 Aug 2021 19:51:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=yhq+0oOj; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="213412781" X-IronPort-AV: E=Sophos;i="5.84,314,1620716400"; d="scan'208";a="213412781" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 19:51:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,314,1620716400"; d="scan'208";a="571338090" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 11 Aug 2021 19:51:44 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 11 Aug 2021 19:51:43 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 11 Aug 2021 19:51:43 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 11 Aug 2021 19:51:43 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 11 Aug 2021 19:51:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hjQ5/oN/sPgN8oGEPQF9dCT+pbtmHEPfWAQP2vj0bhBAw0gmAp5mlLUsOMLCPRYic6gKkhJRSMrmkBh93qRPeN25Lb1SoWul2EHcWRiJzEF/JnkfSLeiX22VqSXsYjlTLDua8AWWAwtKiaRV0WC5/eMkfCYXgIAGb+JVwDa2d1VhlL0sbGqNnpfIe7z/+paAMjek9opjRbVn4KJMyUEftYTWWcCp+lKhzsHr/oOfQuUPrSfGDvqvhzA6JjkEATygc/kdyyjVF6KRNuVGdBbYVQ94uIaxepy7zPjJtozNvVOIzWgU8XZ77Ao32ezuN6ia2XG9YhUE2uh4R7GJi2ky9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=niUP6PbLoFiSA8oWmTbh/TLGJJ8WpJLOeHr5BkbKOe4=; b=H25fYSBoS9CIrRl2wBJKQk98coWW8ItgSTwOaDEJCYI9U3MFNA5wPc4Coi1EC/H81eX7vd/CiyfTd8wGittoIn3QYIW5tIs+ys9YbStyP+tXO41RtB8aSHkPZWUvJqZnaah/S48MOaOaO4jNz58SylRDe2WZM5kpEBsmAtlWceVrbP8SZIadcu9E4ktq16r8JdFOHCHbvVXo/nEJIoAFg/jqN6haGyq2Qt6usrNgzkilZqACFvxUI327wmolT3DngQ+PoD/l+WMSbHvEMrpwioy6Se/d4y2Hvz/kT6hgK0JDGK9HcX3G57jRHRx2lbZTix7WEnXIFyck3x9Nb16Cvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=niUP6PbLoFiSA8oWmTbh/TLGJJ8WpJLOeHr5BkbKOe4=; b=yhq+0oOjP8aE3BPz60r8FivYXpCCYiQI+ooL6A4KEgMDHgci5DxyiA9rWaH5qaVSXfDdn5jCFPYVkBpu8TSX9mmRiPOSSP/vAZI69aMB7GFz+1pilpX02MZRgdthmo/ZPKQBgoFO8s3GO4CjJEhfzI90UY8q9j/VLdYSRe68JDI= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1456.namprd11.prod.outlook.com (2603:10b6:301:b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Thu, 12 Aug 2021 02:51:35 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4415.016; Thu, 12 Aug 2021 02:51:35 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg: Fix boot failure due to FSP rebase address Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg: Fix boot failure due to FSP rebase address Thread-Index: AQHXjwmL95LdhjRxn0u8cDQNZVd2M6tvK9SA Date: Thu, 12 Aug 2021 02:51:35 +0000 Message-ID: References: <353ba5254502ca957ca39c0abae74ea068532aee.1628724753.git.isaac.w.oram@intel.com> In-Reply-To: <353ba5254502ca957ca39c0abae74ea068532aee.1628724753.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e9f6e82d-74cf-43d8-0ca2-08d95d3c1948 x-ms-traffictypediagnostic: MWHPR11MB1456: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:913; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Uajs9jJzaorhK0IrqgOP4VrqDg7IWN15L8KcrZrn+bjhR5/Lggg/xCtA8bTHD/s9k0fimTuIEx8pCfFfP425TatAIvxKGynRc1B5cCZ61+/x1qLh5U6YEYoHhH21OiucsSMeOqlimb2H2UFtxgHNoDe7vojZLCnvKVqodLqmTqwYBqwpa4k4APBuefESHLKBk8DpOpAIdtVhvtvjOcJl4wud5qOP2ALDVbKEjaguwdGtlEaVmB7ZJXBK9n9wjfG6uIt2vEjoCNVNoWj9tHP0V/FrVnJq/Uair4Sw5dzrCU+V5asGFzZIXxlcwq2CFZPkNrYqc/nsQ+ktvszpdBQBGgQaBSHto571UnbcpxV1S8u9AAOzIEYQEXWQnraRerKSVQw+HqKkMd3jpA91S8rtYOpbGY/Xx822fduVZKhGblrEpyWXRP01XrWMMU1V9icpffRImUQNGjsxJpqYZVpOJVcx6t1+/w3HIixShBjc0SuyquqDKKd6jYozden8ZORalCO6e9AgCstw8VpuJWdTOVitFmZSZcO5X2kpwZu95qOz6B8tXhdVMEiBK4EerzP348adqA2VZGZ/wq+9YQlMazE8OF9MltZPHPsr54tk3Cq+nw/W/P/WkTpNt/hYrGd+aDLqI7qK+05BAjR8xES5Mok8mbUd/X/wJAmCTdeOcq2wJTaEb3DoW7UfmtW8u/HLCBCFqGHtEFZ0OfV9Gchq4/FR75RUmceKNPHEimt4NNzR7dMppyQ4ZtzpXlGqjUS4pGT7A6SV+RlY+W8YrhNNQlpCXCLM5D+vcsurBxxIN9o= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(396003)(376002)(136003)(39860400002)(107886003)(2906002)(478600001)(26005)(316002)(110136005)(86362001)(186003)(33656002)(38070700005)(966005)(52536014)(6506007)(8676002)(76116006)(64756008)(66476007)(8936002)(66556008)(66446008)(71200400001)(66946007)(4326008)(53546011)(5660300002)(9686003)(122000001)(55016002)(38100700002)(83380400001)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6JlMFzLfHHv7xz5pVodhmk4i7XaPWQGSFCqYfFl++HSmfECfAoAY3XsGRkmF?= =?us-ascii?Q?vGarZgtKsaMM1wltZ+vcsQomUGBOalXmjOcgRly5Br69DKCMHBC98MXUGN2B?= =?us-ascii?Q?GMKet69TnHPrMfw4JRGAb9O8UgwXQ+4cF2TR2KRzhdkuVNTVXDZpIo2PTkbK?= =?us-ascii?Q?nFuQ/j8wy7TpLrG/RMhz0PJNjIuzG52TxjUIiKZGIl5iOAqriai3Bymvff7u?= =?us-ascii?Q?u9JAWUtxh29Ji2b9rAJZKg0ubUxJDbcJTo/BnwiWrxO5xQPQit0gWojNVB6e?= =?us-ascii?Q?7sc45s7PV4s17Ujr2Yrrt1QUNT4CMJxbPmWIy5Y1u5Dq4+vnzBa5X9E4tGKj?= =?us-ascii?Q?vNHn+GwdkXyBMoQSE0vRr5qRRU8vBMNPruM9JCYbME0s8pIVxaP7zNhqarp4?= =?us-ascii?Q?KkxjQcoG9oYcb/CNTtJIJkPAOxoXhRsWCkfqjmRpDdFM9lcqOvKgvDNGqegc?= =?us-ascii?Q?20ZepcfJMo2eScUdnM7ZyAn+8Jqe/NDQJepFTsJV57oIZLN+02ZdnI4sqCbT?= =?us-ascii?Q?9VKNnYmYE08zufVoExULx3ulPquHAtx0uifboLbWoNs+UZLJofbkWH7o0Zot?= =?us-ascii?Q?KeMz+T0uMUuf6oS2Vw3h7KJu9JgWkbVFGtj9zgJwNd++nJPARVZTweEGStTG?= =?us-ascii?Q?BSpGxLLjB4+KyK4UQxFOyJf9bDtbM7FuAgnNbOIIrkL4GU2JFH/WOI8ylsUr?= =?us-ascii?Q?5qLIJ6NoXDMCf27DKJva5tcngzRJFKcpp2ZQOc1w3wU302ckZtAyEIk4kqvU?= =?us-ascii?Q?ALzoIQDcniKx1D0Bf9JUEUl+8EAgj36x7BXKn065+610e768ewIGPfd1OYI1?= =?us-ascii?Q?nPCMhwdGH+5Ph2oLWtVdYtyfuRO80nnerADPcr+wgVAguNzdtuqkW5vc/vG9?= =?us-ascii?Q?9IjHDeEoMlfzwdv4RyzbvR6NcO+KQDhDMvWT2eG9+af/riuVBCzmGgIRI5tK?= =?us-ascii?Q?Ow9aoghYE4jDKzQ/UQlQB2BjNBXqQYX5IFnmTJF8YvLtXL6zk9aVdHPAehh5?= =?us-ascii?Q?YMSA6TJ3ebMsHIC2JP5xx4HNTHwsr3Zyux8C5SFZxuLgyG/7FcdMwWrNLRtp?= =?us-ascii?Q?MFy4UERxkd+nTbhEE8LYGr7jze2cW9pSSurp4S9uaeZFlKAWGLYInw2mkK4+?= =?us-ascii?Q?plAAqmUGaJkQawTCtT1/II3ht8RwzaoSh0XJReUDP7gLd2nZrIMe1T9Sd+Ex?= =?us-ascii?Q?JIrxWAKayIFNSOLBU9hpbanSL7SLxQstVnTj8IctbQQ/F+UiE+P308HT6YxL?= =?us-ascii?Q?gaSjFPsTBoDm8ESRnWCKDSAgY1QLGjtNJaVbnpx0JwiSyeI1H8Mm05ZnuLK6?= =?us-ascii?Q?qZBInbmxS4vnnF2gT1W4CV7f?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9f6e82d-74cf-43d8-0ca2-08d95d3c1948 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2021 02:51:35.1859 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LTGnd+UIkLNHxux4kHTLq6IwBwHJkFb9L9yMFnBLZhf+yPZmev5RzyGGLYa8drYXJarxIowmqlzEMAVIQlH/PqrQHa6RnHBWl37DFL0x2cI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1456 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/bede362 -----Original Message----- From: Oram, Isaac W =20 Sent: Wednesday, August 11, 2021 4:34 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg: Fi= x boot failure due to FSP rebase address Fixed boot failure caused by FSP not being rebased to the correct address. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf b/Platf= orm/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf index a14afd693b..1f5e0fd48b 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf +++ b/Platform/Intel/WhitleyOpenBoardPkg/FspFlashOffsets.fdf @@ -11,7 +11,11 @@ # The FDF file for WhitleyOpenBoardPkg should be adapted to leverag= e FlashMapInclude.fdf # format found in other OpenBoardPkgs. =20 -DEFINE FLASH_BASE =3D 0x= FF000000 # +# +# Note Whitley unintuitively has multiple "FD" in a single BIOS flash=20 +region, so the base should be for FD.SecPei # and not the basis of the BIO= S region for the FLASH device. +# +DEFINE FLASH_BASE =3D 0x= FFCA0000 =20 SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset =3D 0x= 00020000 # Flash addr (0xFF020000) SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize =3D 0x= 00040000 # -- 2.27.0.windows.1