From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.1130.1628205281300119491 for ; Thu, 05 Aug 2021 16:14:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=YzPih0TZ; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="193865420" X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="193865420" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 16:14:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="467697165" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 05 Aug 2021 16:14:39 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 16:14:39 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 16:14:38 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 5 Aug 2021 16:14:38 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 16:14:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BeibL46jvmuY9jmxThFGvMvx52S0YtMvz002/Erq6OoSRMCuwgrlTac1q1IglI4zELMdVMBIMhsnZX8+tgQ69XH+J264UviXT6hK0H/eKMziQRDssDwHJJp9CjCLCo9XdZdpvjDX4x3nC9yG9Mb5sZyX+3tOy8UoFJx074Y41AlYPn5H8THg8KDl/rVsUlFkzu1dmMAoZWzB/5mfhXhVGtzCXHa+M3hvJksILE5/SrZ86R051maNvwE8VjVLR2BKXW9GStno6yknmTY893Q0aBVP95JtMZaBGniUaQ/f5OjsrwV4WGuWvJgvqjuBG/SI7oW7WDvePPxz3tLcc6OVcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BxAUKxxWlliwYmZ5pLkVWnYoBo53q+gPCDrwmgPqkzI=; b=ivzfQcmL2g/JS6AdLvXoDllfW4q3XSNwy0ayMs2T/+N0cN6/lp39twFRqI1USgPtT0FMSwv0CWaTCJlXDUMROtFlSgzSY41FXWOKgROShPqV84AEG2u1fLwUkN7+TzYhho0bLTNiHnealECZsXOaqMTH35+elGFsSPDGCyt7j+Ac34uBW1fpxwB2CrYRCbWG35YKj+GJWhU2wpWf2JLpAIOY73rw6TfRylkMOkWs1FHeKM25XeK0/e9KHKs/H5uHB/0X32ohkM2M789LgPHkMJIuRwEI8gnwpsWbHnb0RDbxJP/ZPTew58C2tT1FMZWGJNl1YaPMGxz6qGT+f0lz4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BxAUKxxWlliwYmZ5pLkVWnYoBo53q+gPCDrwmgPqkzI=; b=YzPih0TZq9QzaHCmUkIWdbATWbvWkPEn77E8fvN2mWAB/5pRoYitU8gyuECjuCp4S6AMHnfU3Km0bSK0gTwJrnCgq1Hk0hsBYbXBqaaXlVz5fSsGjNVTrDPWHyrQdPzwrUvIY45AWCrFUUySVLsKh6Qj470uWTH6QC9gU/iAajk= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1725.namprd11.prod.outlook.com (2603:10b6:300:2a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16; Thu, 5 Aug 2021 23:14:37 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4394.017; Thu, 5 Aug 2021 23:14:37 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-platforms][PATCH v1 3/5] MinPlatformPkg/TestPointCheckLib: Fix incorrect array index Thread-Topic: [edk2-platforms][PATCH v1 3/5] MinPlatformPkg/TestPointCheckLib: Fix incorrect array index Thread-Index: AQHXigpEoTm5wUfSr0eMsZsnGSq5JatlifVg Date: Thu, 5 Aug 2021 23:14:37 +0000 Message-ID: References: <20210805145706.2470-1-mikuback@linux.microsoft.com> <20210805145706.2470-4-mikuback@linux.microsoft.com> In-Reply-To: <20210805145706.2470-4-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8672be9-aea5-40d1-4bbd-08d95866cbb9 x-ms-traffictypediagnostic: MWHPR11MB1725: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5Cq+zFKvUdLZn3y53thHJgb/Gi3Ejtqzt2Z84BT7tGbpec7Qa73fJxRAeykiug3RCLbChxzmEurNA1/U2ujhNeOgGoqQySShFTZ5Hwq4/CKkvX3cOccJBlTi35PlUaPJli/vdYsOgvIiLu7PBz2ywIGDHQHF/Gqnzudqkj1r/WGbw6YdlCZPL9NDjpgLjkPIpuZyHmS87kOb4neP8aaK+1/O/UrAgXEZphfRCr9CBIbKkYNpiNyuqQ6JV5T1zVY8TlkHoxTG1f8e8y+UVKmeUvhacGZletPa+6gKc1I9CStxD132BjU3oG2LFGZVnkwlGh970JdHDb32Z9+JDAxKm0hn5a2LJlSIzLUn95tCGEsEaLis9BtFGnRiTTkz1PUe/i0Ee6gFtFpLmO0mYVJmKIqJrgT1grif3Pm+GLnFuyyqzpHLlZn6oJj5dJ6pFzQnR54MpReCQ+qLxVfAobwcvZfquZjfLJq+S0z17M34sr8zNHi5kn8vMRSbs/Ua6bikn62rzaKccUcv/NAjEJMK3hgeK+puYvHQ39fe76G602COfL+Ya6IPqFaYLbemN8KGtTdFrE8aB/fqOQQwUPNTbSp+MFtQ0FVz+8jWtVAe8n36uMOgZoBUdkSWrMGApbcV1qRD1w+y05d9GgSPQP1fgf3L0eh0JFzLOxiYv+80zq7U3FtSwk6E+dzPE0kv67GdQSF+qvhTaRhv9sFWFbMWgp3YKgcIfPlsRBUTVk7aFSb0/KfVNsLGcNCQRDRlDjtrc9wKopmbkLaEqHOPDwLBNiYLaPVn9y54BiYRXn2tTfM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(508600001)(9686003)(186003)(26005)(316002)(7696005)(53546011)(110136005)(55016002)(2906002)(64756008)(8676002)(71200400001)(6506007)(5660300002)(66446008)(54906003)(8936002)(66476007)(66556008)(33656002)(38070700005)(4326008)(122000001)(107886003)(76116006)(83380400001)(52536014)(66946007)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eCDcMrKd348ZiwC8HsZT+cW7y7ByruMjGMLIYrzttYP2FQtmcDNw1ag3DEg0?= =?us-ascii?Q?iwAIhzuzwe9lEqaQ2nkw6RrXcgePL1cYy3G24sCarYkWVfs9rl8iuDmMmPZ9?= =?us-ascii?Q?D4SSTkLzD123Q8XbkTOd16MPb5rG9acjHYu6/PPvH5HqGgCEJGH1dxcLR/ua?= =?us-ascii?Q?q19veSddz52vtm8LR+nvWEBrO5rGbYL1qNF0KGukhaFZHHNx4tGgwLs4uroV?= =?us-ascii?Q?kh4OMXykwsNcl5yPp0YNHO4wRXRK02cOUJ+Dl4s5zZSR/Kr9c/tHrQkMH90O?= =?us-ascii?Q?OMzFxJ5jGgaa4pgZ5KTsmuJE1tu58vdUUrFqj0HApw2mJfMcnMtq5TAyvNO6?= =?us-ascii?Q?qNqKGp0v1gCW9Ie1JEIgqMyf6s+8nowjdBX3104Rzk58TYVWDR61XnrNLbbA?= =?us-ascii?Q?5y0XIikL+QOqZUeKp6aEKg2rCAcVVTEssKHZzEjaDy8nWnpyzESr7J7LGhAa?= =?us-ascii?Q?Z6rpVulrcKdK9ZJnjZEG2+aH5r+WKyJ4bC2T0i4p8XAWL+JzqjDR+TCx8Hr9?= =?us-ascii?Q?KlfMJhORknJQFqEiW2ERDlc0QuOSEVoKRNh4+vcUgZ87HdcyU1wb7HArJbMR?= =?us-ascii?Q?P2ZtT0jHvW7DZsVu2v+Od4uyQ8KOTBAkRILRUbkx8m0Td81mb7FTE8Hayfj9?= =?us-ascii?Q?wa86LJNqlrGW/MKowSPB2VdTEZlL42J/8X04PF629si+wSMYdHGLJgyiwHL3?= =?us-ascii?Q?F0HLh1lhwU9lERug8vgzkiQulfwDNHArG1cLWH4HvUgKrDMqJIO68hBZhlhu?= =?us-ascii?Q?ScPx2kSyhHN9WXcohGipLRIRbhzlGEsoqdBsLMZqiEDsXOSJxQAiDkx/TpYk?= =?us-ascii?Q?8fdEYFDFQyU4ZbRUp1/4zaWSx5NA1hgp4rGdx/PBCjufxQZMFsnmElJV5hhi?= =?us-ascii?Q?UMdAvsGbdVbycrpJMNBM4qPHQZUUBrrEl6rQuFYyrsSVUKO4nNjceG3hJPG+?= =?us-ascii?Q?vWjQI7PcrVYuowIxMpu+av2CSt7rgYjevAzutKwu5z8EtYt2GR2MPZHdajjt?= =?us-ascii?Q?VcPDOfDIgssWxhd1PmYBCazSrI8ciMQrp7j+Yxx2PQDUEB1ve8yUE4SCRixS?= =?us-ascii?Q?Bufyk11CvEzlPwaRmhmhKpLrC4outZCmZnXaIPSFGgZMYPNCGuK01PJ5L5xe?= =?us-ascii?Q?P+yRaMe/KU/lZx69Lh0GRQhgqWmtiTyrs0vGh2eWiPH8zk32T4Wv1DcqGO7Z?= =?us-ascii?Q?+PSVzf1Fql/KrNlY2LCcr6jNahckCpV9gykllB7BL5IuEc1tngCiEGxUbw7N?= =?us-ascii?Q?XpfLruCsgqoK1Uc8i5FzjvX7jkCVLxcbu1WvbnyCAewskwWoewMLjGBXoc74?= =?us-ascii?Q?mlheDd1HBnduMiziFRjgMBaB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8672be9-aea5-40d1-4bbd-08d95866cbb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 23:14:37.6753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PAMl4tYt5/pos+2wZzGH648ZpTIFq2uO7SyFiCQj4zAEFtJaJBlTaegc8QdkqWO9nzhXOuaQcrNLf5SBinnkPbFV8zjVwh6BWQTGcpu5U/8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1725 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Comments are inline. Thanks, Nate > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, August 5, 2021 7:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1 3/5] > MinPlatformPkg/TestPointCheckLib: Fix incorrect array index >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3520 >=20 > TestPointSmmEndOfDxeSmrrFunctional() uses the incorrect byte index to > skip the test. It should use byte 6 instead of byte 5. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo > intCheckLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest > PointCheckLib.c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest > PointCheckLib.c > index 4b4f874c7bbc..3e8b2621cccd 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest > PointCheckLib.c > +++ > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe > +++ stPointCheckLib.c > @@ -109,7 +109,7 @@ TestPointSmmEndOfDxeSmrrFunctional ( > EFI_STATUS Status; > BOOLEAN Result; >=20 > - if ((mFeatureImplemented[5] & > TEST_POINT_BYTE6_SMM_END_OF_DXE_SMRR_FUNCTIONAL) =3D=3D 0) { > + if ((mFeatureImplemented[6] & > + TEST_POINT_BYTE6_SMM_END_OF_DXE_SMRR_FUNCTIONAL) =3D=3D 0) { I think we should have a #define that describes whatever "6" means in this = context. > return EFI_SUCCESS; > } >=20 > @@ -125,7 +125,7 @@ TestPointSmmEndOfDxeSmrrFunctional ( > TestPointLibSetFeaturesVerified ( > PLATFORM_TEST_POINT_ROLE_PLATFORM_IBV, > NULL, > - 5, > + 6, > TEST_POINT_BYTE6_SMM_END_OF_DXE_SMRR_FUNCTIONAL > ); > } > -- > 2.28.0.windows.1