From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Oram, Isaac W" <isaac.w.oram@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH] SpcrFeaturePkg: Close the event after first callback.
Date: Mon, 11 Oct 2021 22:00:25 +0000 [thread overview]
Message-ID: <MWHPR1101MB21607ED3ED9739148204332ACDB59@MWHPR1101MB2160.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210726073025.1028-1-AbdulLateef.Attar@amd.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Monday, July 26, 2021 12:30 AM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [PATCH] SpcrFeaturePkg: Close the event after first callback.
>
> Adds CloseEvent in callback routine OutOfBandACPITableConstruction(), to
> avoid multiple installation of SPCR table.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
> .../OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> crAcpi.c
> index 85ac48cfa5..86c40e90b8 100644
> ---
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> +++
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> cr
> +++ Acpi.c
> @@ -368,6 +368,8 @@ OutOfBandACPITableConstruction (
>
> Handle = NULL;
>
> + gBS->CloseEvent (Event);
> +
> SavedDevicePath = GetSpcrDevice();
> if (SavedDevicePath == NULL) {
> return;
> --
> 2.25.1
next prev parent reply other threads:[~2021-10-11 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 7:30 [PATCH] SpcrFeaturePkg: Close the event after first callback Abdul Lateef Attar
2021-10-11 22:00 ` Nate DeSimone [this message]
2021-10-11 22:01 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1101MB21607ED3ED9739148204332ACDB59@MWHPR1101MB2160.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox