From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.3404.1621903508005405673 for ; Mon, 24 May 2021 17:45:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=YG8xvqTU; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: GHsHva1eD9CFqw2Ui0Tm04a+4V2D90oJCthKLbcpEHI0L9nuAgUsCIUKjrmr+B8ssa9nyakTkB E/Ub+plcWRGw== X-IronPort-AV: E=McAfee;i="6200,9189,9994"; a="223227664" X-IronPort-AV: E=Sophos;i="5.82,327,1613462400"; d="scan'208";a="223227664" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2021 17:45:05 -0700 IronPort-SDR: xJcvJpx3Qsz4AiY0GOonPGCITSXK+cky9BrGQ69J4mARIZlYvMrGHsUHMJY21iyZDHvErpJvlo xlvP+wWivyfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,327,1613462400"; d="scan'208";a="476148762" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 24 May 2021 17:45:05 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 24 May 2021 17:45:05 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 24 May 2021 17:45:05 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 24 May 2021 17:45:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JY2uKKdVno5oZoXrlkXRhNpGgYnqL5aoh3kozHjtuNIvsRHAcZP1ErPaU747fwN3+jDTTdM22VkeMsmaCNowDPaSQ5tNXGgwenoNok6dflUjhW7q7C+nMiHaOx1fzWCV/ny9q5raiJY0G87xFFJ/zShO5Vmlo3MG31v6AB4lJkGc62kouB0ruHVhZAxfCGSPCezeeXEJNCqAcoa00boHIFarUzye7VKbeIylj5QvyDqZRbcnAg7r7gKQUDFwP2h3tlfDKnQviybsruoqWAVKeyLZMmd5UwfkLXAZL2Yc1+5u59scb3yV81eeLwiJAW+sBmyPuTfvZH6HmtTekN3VbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jzW6XAv5xd6fXFue/EM5gWIvx2qtRPE72OqoUcgHVTY=; b=YS7Ezz/rptTPq8leqMzLiTpDGZuuwJ1NKZPBeO52bCyKTZ2tu4biUGetBI/vsXYGbS0WRcenl08TdedgktdPvQuQ86aM6hFJQb8ufi1puyD+6Y5lt+Mf3d2zAh+NZ3SvehpJvNrv8aXOjp5SCTJIPCqt7B4shYA7ZRua/RMsqIQ2NeDL/lM8QrPRVuzC7ElYkSoCXtRizQoHQ0kilYAB5R3wP6l/h0zJL57/rdgnvyowBN/5oVKaPc7GNLW7g/P0/0zkUxfTW/UZyHM49HlGyodbc2xJ5BfjP54uoyFn8E/GprD2Bw7z9DLKT7CKgCxFvsgoJPmCZlzT3a6FITIrLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jzW6XAv5xd6fXFue/EM5gWIvx2qtRPE72OqoUcgHVTY=; b=YG8xvqTUL5nQZvkESelDNEle+YUn8pTNDDnkOJ043JS+1Ox7pqnvimJOqlfHIKb+hwjsT/8E58iPqHk24VPQ+2UlA4uHUXDLHcIcgZQX8/X+lSDGNdogjy5zDVXebntWz+HFxloS8+qXg41aXVSchI8sPUISmbxV4ZLY1rOLZWw= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1456.namprd11.prod.outlook.com (2603:10b6:301:b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Tue, 25 May 2021 00:45:03 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::c8d6:1114:7da4:1d2c]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::c8d6:1114:7da4:1d2c%9]) with mapi id 15.20.4150.027; Tue, 25 May 2021 00:45:03 +0000 From: "Nate DeSimone" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Zeng, Star" , "Ni, Ray" Subject: Re: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs Thread-Topic: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs Thread-Index: AQHXMcNq56tnY5b7UkG9n0UzmatWiKrzlObA Date: Tue, 25 May 2021 00:45:03 +0000 Message-ID: References: <20210415064847.15537-1-yun.lou@intel.com> In-Reply-To: <20210415064847.15537-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 30cf6d5e-30d9-4d84-b67e-08d91f1655a2 x-ms-traffictypediagnostic: MWHPR11MB1456: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M12r2C37ICS1SFiAV2qlkXyVNG8H5AL4+8hN3+3/3bokgC9SQaIdGku54MQkzbeYtbUGCeEISG9sxOzMxsu2xPNhxjrCdrPOwoi72VYFKT+kOrvVJ5WlOmjqkO5oAjgsrDdzsmhDepdOnk/753xkNAij9RYZDxtmiInI21eTcYiiGHBC+kZGg+2B5kevUz2BV36QQnf/pOwPlnBuvoxFyi415MFdNN26zGS+UcREW+hvoA1qnCnRj8QhgZvpzieiicMGayTVyNE/W10LFT3ZkSBafyCdq49T8gn9J7EJvxoXeBIsllwmyYQ2fx6mt7XLnUyfKQlyRkQhuPg8PCtfncQetPKdmYSHFUeFMh2fa6VeG6vjqCaUt8J3/Fe6xmd9zVB0kk3IWj48Rw6G3DqnLWdHELzkn6e9mVDM1MIHBWv3FR1INKpVGOkoJWLTnNdM+NLgyTalobDNBQPcUq6CreosFlAcoYfks/rZqmjoxXnXBJ1rpftUk02oFPdyfAbIkOlVS+lkdeS80xnNUCnIpWWXNKp2wBoH0LiGcj0Q7CIXAGqrPcPJjI+PFPBprUqbUQZa7zbhR8usCH7vCIBF78OvwI1xPXcL5IPttILDNJufJw4Ssl+eMIoMs4/uVNRc5T8hcMRDorqMohF1MdyXtgZgjE1WnssN/cdIinLNONKchF9jkBCryvuXpmipvF1ztCvY58W80fy3nuXKgZUK3e57dfXqRw1t37NS8fXjSQ4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(366004)(136003)(396003)(376002)(54906003)(52536014)(110136005)(26005)(33656002)(53546011)(122000001)(83380400001)(4326008)(8936002)(107886003)(2906002)(186003)(316002)(71200400001)(19627235002)(5660300002)(6506007)(66446008)(7696005)(66946007)(64756008)(66476007)(55016002)(966005)(478600001)(38100700002)(8676002)(86362001)(66556008)(76116006)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?HUPEpvgip9g4c9QSu3XSM08k5k4UdF6EaYVISM09kl9vt7JCJAbbL9LAABWD?= =?us-ascii?Q?dK5Pp5I/J4x72YMjov41Y+cCoKQiZDGa+hIjzYjM8eDQA2WJQH17ByAZwXcq?= =?us-ascii?Q?9O4O/MN/Q+kiVG7HPtX5g5QlTvcnuiQa9XTVU+l+FZZ3HixJY/sjl12osuGe?= =?us-ascii?Q?4s/sAYKeMVXoD4tmvMGOdZEp2SbEY61XXr+/6e581Rkqi81AhMlgvekcDhZ3?= =?us-ascii?Q?p2alYrx9dTcNYHAXHusQOTn6qOu+zz83Mnmo6cKuwBUjdxzWfNv4oYDZp7tR?= =?us-ascii?Q?q6n0pSOnRu4BQeA3LAgzTTxQ4kppPCsEBrxBp08qi703928tRnTjuCISxPzK?= =?us-ascii?Q?TXZutte84UCA7H97lRShXF2MrQ4EE62e1r5dJJziSVWH5vvh3UMfb3N1+/UG?= =?us-ascii?Q?UtZodZudXSurhlqTPFYkGvREEhugqSZwl88JdbtUQ11uhxI6ZCT0tsLkTEdX?= =?us-ascii?Q?E9DZNoP1c4IXoUQRaMoHKW36R4zZbfR4hAKtXNxpPCuHrWFwCPMrhQhJd9io?= =?us-ascii?Q?eXeqqD5IhmplKt8IapJpSblC/lILGpPeYWJkb1WikjTYsIT+li8iDsnrBeU6?= =?us-ascii?Q?cGuTEgOj73kHvH2Tl6PPpmnmFbZIXwChS0uanouAry4rc2k/ZgE+FQdTEPcF?= =?us-ascii?Q?5aLb7C3577FYWlsEl+5wpFmW8N2tXNuUYcGitmgkdlbmDAyp1DaH9BDnfSY9?= =?us-ascii?Q?96jIJMq4rwWbGYeRYiI6831sixyH2sCnf54CHnX0VYyVJ4GExq4bMel8zwiB?= =?us-ascii?Q?4kCyP1bTxY2gIgRVQ7fY3+IEOUF/M8N0b8qx4OC1KfMViE1oDM/m7xgmMBQN?= =?us-ascii?Q?FOxMrjV+VklXlos6ukyGIqiNIvOO38kAcjXPjASs5y5FmIKDLLJqkOSllZjh?= =?us-ascii?Q?PggnX+IkJGjpJbn+OcTUcBdU5VGUBprs8gt5QOu+D9mt4/CS9B229qn+z/aW?= =?us-ascii?Q?16L5bIS9dygb8ztIxfzx9SpAU2WcCMDDx1lVofOmk1gttRzdl6eIBTw84yhQ?= =?us-ascii?Q?lBBswIXIasHAX7xV0LrCI0uXSFCWs7HSb+NRCEqsnevu89ZlDqtZzXMV+FQm?= =?us-ascii?Q?vQ4EvLrWE2940ROVMiMG6GqCy2CsAzQ0deBQprroBsEe6QwkWRkHWBGLONcM?= =?us-ascii?Q?UH1iDxLzacjKjQ37pHIY7i6bazAIrnUwg89ZMTQeo85IIOSKiPwJEQhOJ0Y5?= =?us-ascii?Q?QA/ytEzuyMMtnaRgFtHADQNfFAoyOdHUfmOsAOj1c5lgsxt3lBAoXrgcWLl8?= =?us-ascii?Q?auPz7eUDdsjrQNbZcIHL2XgkDvLE0iSeez/J1M4ZVry+8b9CISFsNm73UcNE?= =?us-ascii?Q?nxErEdtiXTijALVOmGV4cyMR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30cf6d5e-30d9-4d84-b67e-08d91f1655a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2021 00:45:03.3605 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wqOYQt5CtUP6srXBFoSmslE+s4TSaB+l1XrDHuNZlP2qcul2VUvzKN8G6LZWlnkfGhINDcRLviEu6/uz+nwKh4+8dy9sScLzyBbKiFuw2OA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1456 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Lou, Yun =20 Sent: Wednesday, April 14, 2021 11:49 PM To: devel@edk2.groups.io Cc: Lou, Yun ; Chiu, Chasel ; Des= imone, Nathaniel L ; Zeng, Star ; Ni, Ray Subject: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3334 IntelFsp2WrapperPkg defines following PCDs: PcdCpuMicrocodePatchAddress PcdCpuMicrocodePatchRegionSize PcdFlashMicrocodeOffset But the PCD name caused confusion because UefiCpuPkg defines: PcdCpuMicrocodePatchAddress PcdCpuMicrocodePatchRegionSize PcdCpuMicrocodePatchAddress in IntelFsp2WrapperPkg means the base address o= f the FV that holds the microcode. PcdCpuMicrocodePatchAddress in UefiCpuPkg means the address of the microcod= e. The relationship between the PCDs is: IntelFsp2WrapperPkg.PcdCpuMicrocodePatchAddress + IntelFsp2WrapperPkg.PcdFlashMicrocodeOffset =3D=3D UefiCpuPkg.PcdCpuMicrocodePatchAddress IntelFsp2WrapperPkg.PcdCpuMicrocodePatchRegionSize - IntelFsp2WrapperPkg.PcdFlashMicrocodeOffset =3D=3D UefiCpuPkg.PcdCpuMicrocodePatchRegionSize To avoid confusion and actually the PCDs in IntelFsp2WrapperPkg are only us= ed by a sample FSP-T wrapper, this patch removes the 3 PCDs defined in Inte= lFsp2WrapperPkg. The FSP-T wrapper is updated to directly use the ones in UefiCpuPkg. Signed-off-by: Jason Lou Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ray Ni --- IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamInitDa= ta.c | 6 +++--- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec = | 8 +------- IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspWrappe= rPlatformSecLibSample.inf | 7 +++---- 3 files changed, 7 insertions(+), 14 deletions(-) diff --git a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/= SecRamInitData.c b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibS= ample/SecRamInitData.c index 96b47e23da..e57b5b57be 100644 --- a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI= nitData.c +++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecR +++ amInitData.c @@ -1,7 +1,7 @@ /** @file Sample to provide TempRamInitParams data. - Copyright (c) 201= 4 - 2020, Intel Corporation. All rights reserved.
+ Copyright (c) 2014 = - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifi= er: BSD-2-Clause-Patent **/@@ -52,8 +52,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED= CONST FSPT_UPD_CORE_DATA FsptUpdDataPtr =3D { } }, {- ((UINT32)FixedPcdGet64 (PcdCpuMicrocodePatchAddress) + = FixedPcdGet32 (PcdFlashMicrocodeOffset)),- ((UINT32)FixedPcdGet64 (PcdCp= uMicrocodePatchRegionSize) - FixedPcdGet32 (PcdFlashMicrocodeOffset)),+ = FixedPcdGet32 (PcdCpuMicrocodePatchAddress),+ FixedPcdGet32 (PcdCpuMicro= codePatchRegionSize), FixedPcdGet32 (PcdFlashCodeCacheAddress), Fix= edPcdGet32 (PcdFlashCodeCacheSize), }diff --git a/IntelFsp2WrapperPkg/Int= elFsp2WrapperPkg.dec b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec index 6852bf1271..a3b9363779 100644 --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec @@ -1,7 +1,7 @@ ## @file # Provides drivers and definitions to support fsp in EDKII bios. = #-# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
+= # Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
# = SPDX-License-Identifier: BSD-2-Clause-Patent # ##@@ -56,12 +56,6 @@ ## Provides the size of the BIOS Flash Device. gIntelFsp2WrapperTokenS= paceGuid.PcdFlashCodeCacheSize|0x00200000|UINT32|0x10000002 - ## Indicates= the base address of the first Microcode Patch in the Microcode Region- gI= ntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress|0x0|UINT64|0x1000= 0005- gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize|0x0|U= INT64|0x10000006- ## Indicates the offset of the Cpu Microcode.- gIntelFs= p2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset|0x90|UINT32|0x10000007- #= # Indicate the PEI memory size platform want to report gIntelFsp2WrapperT= okenSpaceGuid.PcdPeiMinMemSize|0x1800000|UINT32|0x40000004 ## Indicate th= e PEI memory size platform want to reportdiff --git a/IntelFsp2WrapperPkg/L= ibrary/SecFspWrapperPlatformSecLibSample/SecFspWrapperPlatformSecLibSample.= inf b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspW= rapperPlatformSecLibSample.inf index d7f8301bef..027b127724 100644 --- a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspW= rapperPlatformSecLibSample.inf +++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecF +++ spWrapperPlatformSecLibSample.inf @@ -1,7 +1,7 @@ ## @file # Sample to provide FSP wrapper platform sec related function. #= -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.
+= # Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
#= # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -76,8 +76,7 @@ gIntelFsp2WrapperTokenSpaceGuid.PcdFspmBaseAddress ## CONSU= MES [FixedPcd]- gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddre= ss ## CONSUMES- gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRe= gionSize ## CONSUMES- gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOf= fset ## CONSUMES+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAd= dress ## CONSUMES+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatc= hRegionSize ## CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdFlashCo= deCacheAddress ## CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdFlas= hCodeCacheSize ## CONSUMES--=20 2.28.0.windows.1