From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.3822.1607503713554508898 for ; Wed, 09 Dec 2020 00:48:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=nP8ELXbp; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: NDUKr8mxxlcIlpwMYvslT4wnZBUHv2dxzcBXyYNQlNx6ZGpnFfOYxnXt2fLfrNOZU2VBlCdn/H tOIdllJ3btAA== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="161804381" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="161804381" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 00:48:32 -0800 IronPort-SDR: XIaBwJqkak1bIRIG63KbARnZJxgyxR6HRqinp0N0YNnYTuzaNNDZlg5OGhyjMB/MgERLqXFGFs dyzDr1W8QObg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="318190584" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga008.fm.intel.com with ESMTP; 09 Dec 2020 00:48:32 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 00:48:31 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Dec 2020 00:48:31 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Dec 2020 00:48:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDEDx8AV1lYt5iKB1NIGz00+Qvk8W7erKfZ2RrGLdn41u+HrdEp2KRDCM6HLceMqmVf5lMJenRP4GJswYzgEFa2B5OmH725yaGXdKubMAueoQxUM5evG0zhf+WpZ+3IpYQHNfcMZffVM87ey2YBSy8DgR4pPmK7VFiQDqcA0a9BzidF91Qy9ym/yX5dNwyjPUf7skjuOLWZGsDH/FtePiEalfsOIdVsN0l1mH4ej5vui4OLKCYucUHbGnoF7/ooEtFIJIUYvqR43TMpCpt4mnrz/ybmwBWbuGHGp0qZxToK3v1B3g5OiS8W7K9P7LPPmd+PD9D7PU3+qa9QwGTk3zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YmcpMzppvItoxJryZq5Cm0PC730YLdLmpIipzGCiXpA=; b=hV4IITaJNPBQpPW/iwWY1K0M0ll0DYmYuua4SRSodF6vkepMjf3r+mBeOu74RXhatki53ofDZZzw+xcACLOsqZ2Hf683TJZfFQd1VBAEeSRcnUEesZKHY5spHbpDlNCJ6vNrb+VZY5/yD/Z2QCCZ4eSmwS7LMb85dU3Mbdnt40sLjmUMEd4ax3YrDPUPMABbKNNzPOPRujg1oqW4hkW/R+C3RHjRtGnIFagWJIKtdbb3UJur1OV+MgB66Lqxz7Vh7TEbxCMo93hSF0HGgcKXANGezu1OZtk3ZzR6JCZ6BfQWfw3wr9JX9yEaJMujaphDeSOYV/ATNGrlMd1J0uHfcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YmcpMzppvItoxJryZq5Cm0PC730YLdLmpIipzGCiXpA=; b=nP8ELXbpdNEr+dJreybk8QI3WsrQjmBhkNskOqZW//6NH8jMRG0M3u71yRlzVw+cNfC28onerQ8Uer6mz+z3IOEtAjZ7Dzraf55MbSXvM64KziJJLtJFXkeg7uLw0sEd8hLB85A/8B78eNHElcvogeOSkpv0fLaPxkPCwCqPBWw= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB5028.namprd11.prod.outlook.com (2603:10b6:303:9a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Wed, 9 Dec 2020 08:48:26 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710%8]) with mapi id 15.20.3654.012; Wed, 9 Dec 2020 08:48:26 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Chiu, Chasel" , Liming Gao Subject: Re: [Patch V7 2/3] OpenBoardPkg: Configurae PcdSerialTerminalEnable Thread-Topic: [Patch V7 2/3] OpenBoardPkg: Configurae PcdSerialTerminalEnable Thread-Index: AQHWu7g8zKdDpbMhB06l2OTf4KK/U6numJnA Date: Wed, 9 Dec 2020 08:48:26 +0000 Message-ID: References: <20201116013124.1983-1-heng.luo@intel.com> <20201116013124.1983-2-heng.luo@intel.com> In-Reply-To: <20201116013124.1983-2-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 926e8e94-d24d-4066-6eef-08d89c1f31db x-ms-traffictypediagnostic: CO1PR11MB5028: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:206; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SZZYl14wXQUDyNxtIYxuIAAwVLYl0MyHMnwln8WihrdV9NRlkd/9pGB34FMZWuIizkzey8K0SzWX2Ay3cX8PT/epN4x6n5U+q43oPpHRMHvSkJsAh08SaWM2Ssf2CZaC/0/bcG2oXlPYuuXOFfTu0ktxAVAKWZ8VgamFfeH0SIy/ZGhEL0kKGI2p6jxQ3slj55ZAvRJ5K3+I861GlduufwZ1497tDCfXjBKZJhxJg/ZoJ1joaPXPSsxKc8D6S6/2IvHVJk7ZK3O4adBTrgZAz8Tp81kHYZINSy3waGPJHx+XGrfXg0MHcsuBDGUFOqqm9MFyaKJfZgAqNlEfpEePI2s2/eBq1xSLoKr7JXCnUOiauu7/7VIZ6ht14jvwGVwZ8ICXh6bv8eB3WwyglaMHVQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(136003)(66946007)(7696005)(52536014)(5660300002)(110136005)(186003)(9686003)(8936002)(66446008)(26005)(6506007)(71200400001)(66556008)(76116006)(2906002)(54906003)(33656002)(4326008)(86362001)(55016002)(53546011)(66476007)(64756008)(8676002)(966005)(508600001)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?AZYkEtZiXtvEIwxtr8Ll2mJRJvrxr6/QwV8xEJi1W0tNBTy9oCJ9BAsHVYeq?= =?us-ascii?Q?FQh3nD2fiAGpKPkcf2iCRelxjjShmfbCnLOeabNCl+9eoKRnGCIqKnIP8SeK?= =?us-ascii?Q?U+iVfWqQd7SxSvW1ZHuGdXLCtRcfpFZCwMDu6PG6xoPlYDEiXZgcoLdGNdQk?= =?us-ascii?Q?7FQB4U3Lf+L7CdAdg83pnOtOUVgRZR/cdmAfScq+CDo26r100evEo9AU9ka8?= =?us-ascii?Q?IOCdeuKFLm0E7O+TXM1+wMD/R/GPLCpaO/q0NbKuydbMj4Uu5dF/8nFeu23H?= =?us-ascii?Q?CGY8Qt6IRO58Z8YqqJ+BggTQax+0HfxoHjU95s8gis9F1y0BGHrt4LqVPwON?= =?us-ascii?Q?OyL0lUR5RIQ/e9GfMSAc2RLehKbgQhRAlAGHQm8EPQUkwdRG/dR59jvwEbJ4?= =?us-ascii?Q?BGPS8MCkdkja+gJ5v+zBwI8SBlaGDFj2oymap05oHRlRDs6CBF88/GtW4fKP?= =?us-ascii?Q?VKJPr1RGB2E5sRDDp0SDpXI7ygBopK66naQPY/623yvsWBld1t6XivEpHBra?= =?us-ascii?Q?o4KRU0OrCqhP8AGBJEHE71Htql6gxZHWRESdvdYM2FITxPnkdQOwxbulKt69?= =?us-ascii?Q?XmjeJgUcC3w4sYshK3KgnAH1k3ypyGOy9WvaTLP67MxHzzpDovMAxUGdkaea?= =?us-ascii?Q?D9m0Fwtiy2cHS3Fn0w5giB5ewC/63q5vGrIV49EbflCe3I3aCFLhfyrj4VHx?= =?us-ascii?Q?XC38mWb7NWLQh0dbs163daw4jVf0k4ca45qD1K/ZARprXZPbM76tj0fqLvoS?= =?us-ascii?Q?oregyjGwQSIV/nA+Em450c1c+ThnS0ns6OFQL6LgnwFmPhUjbPFMMZ0PmUzB?= =?us-ascii?Q?JHxJyLzW3PfgF7rbICWY0mGn8hgtorcTilI1dD1XL4F6niSi+NwRo4r4JmgL?= =?us-ascii?Q?+S9Qoxg/+OiYKsQ/NB7Zu1bQuSz9YfIhBT8JiBz+jvbJGXHzDzMsGBZgyTQ3?= =?us-ascii?Q?J18chAGNp3jTtYtv1Ye9mt3WdttTrcQwvztO2d0spPQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 926e8e94-d24d-4066-6eef-08d89c1f31db X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 08:48:26.6259 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xu8pnpCq0ZBAf5jJEK+bi5dy47/tMl+iQxUHQ4kgo+ZwWHLr+5ibnFaFq7rTwxzdXUfbTqtQpOZ7z5MyvL8rs1QTzgAGaDe3BJCPBmElebc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5028 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Luo, Heng > Sent: Sunday, November 15, 2020 5:31 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Chiu, Chasel ; > Desimone, Nathaniel L ; Liming Gao > > Subject: [Patch V7 2/3] OpenBoardPkg: Configurae PcdSerialTerminalEnable >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3014 >=20 > Enable Serial Terminal Feature for UpXtreme, and disable it for other > platform by default. >=20 > Cc: Eric Dong > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Heng Luo > --- >=20 > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPc > d.dsc | 1 + > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > | 1 + >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds > c | 1 + > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds > c | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk > gPcd.dsc | 1 + > 6 files changed, 6 insertions(+) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd.dsc > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd.dsc > index d611e99fc1..589b002d06 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd.dsc > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd > +++ .dsc > @@ -131,6 +131,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > index 352416a489..44dacdf082 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > @@ -130,6 +130,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > index 9e8b148753..725596cbf7 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > d > +++ sc > @@ -168,6 +168,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > index 52cdf9ec0f..251f46f812 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > +++ c > @@ -50,6 +50,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > index d797ae9d94..e161bf06f4 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > ds > +++ c > @@ -127,6 +127,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|TRUE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > index 5d769e8153..83ada3c95c 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ gPcd.dsc > @@ -127,6 +127,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE-- > 2.24.0.windows.2