From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.3711.1607993354573317335 for ; Mon, 14 Dec 2020 16:49:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KqGGmZY8; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: KldVHUsbek0u/xKx8VG/Dox7OYkB+h4+XyL3AlDP6hYxiVlr9HGy45r/9jf5flTnLAHUOxZQoh 4NYpND2NRGEg== X-IronPort-AV: E=McAfee;i="6000,8403,9835"; a="161857961" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="161857961" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 16:49:12 -0800 IronPort-SDR: 4vAOoAiDgoM1dP1ZtFzCu7vQvzqGB1sWv3RlxYqhSzxrRZvt45Vxgtu832t5NlgBK5LFhy/pTu obH7eYW4qOnw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="411497493" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga001.jf.intel.com with ESMTP; 14 Dec 2020 16:49:11 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Dec 2020 16:49:11 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Dec 2020 16:49:10 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 14 Dec 2020 16:49:11 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.55) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 14 Dec 2020 16:49:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gD6xZ5H3ArZoOANrr7e5c4YLws1glKTTjKaQBgi/vyM6hDwtezJcadmC8JdMKhqHw0dfOMwvxLkswQTrK6hQdM4WqHeNA6lo/MjwE7+56XLYlr/JrQLh25zepnHWMNeueO6YNqW0DqG+HjSpRK0QAeCXoeJxzbTnnieavE7Gsm+uRhXqb49WwggygKOrbtZ1aJcGcDKuJziYb7IpwU0wYPx/RhEZXDjDAQO949c7TYo5jHk6ceCnx3IPbMwIPUkII25EIrbNBh8Ra6c9iC41ZaEQAZG5jdBUs/upSTRpadwAQaMbNcbWyPqGknfBbycl2Nu+P9q7dilILmN2fqMgrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=52jaTdjMQai4hSm43YlDJShAiENOc3Gg1AwJkjhOAbo=; b=g9yNSpMaD+l2P6ZgKln7ju3vxdlZM8w7brkVI+r+mTzDTyLBAX4z9/EKEKzgnZ0pKV4j2AREySHB/epFkJi+HAHDSqsVGqEKrJifcnLaEOyzKPxwpNtZC8+o1XGhaMoZC/7styqbNfhFHgQGlfiE7PwCN68p4Ia3Ma/0KV6r/k78KUGB16/w7IqBCIw1yc1WkWN7I9gYY+ICAxJc52t+toH54LzGolDqOXmLwbpuYfhOA7wNDHnPGtl6IIQlOei5neNztJ7TrS/iT7T7HDahS3925hOLKst0WatnI4MDSn+HvTPT+AnBf1xou230MPHv4nBDDovI0fJ1fqkKr7yGcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=52jaTdjMQai4hSm43YlDJShAiENOc3Gg1AwJkjhOAbo=; b=KqGGmZY8uYbaZvsWMzRzVAzbyIGAYVWATuSQ9vsxGFShBI6X1TUdDTeEBR6HYpCcLu2OqmqX6cakdkY/norvsWkLF05HvMOq94FstJShB2oxoXNDd0wElRV3cWfapKNo6d0hhc93HB2mg751trr9D5g4/YA3uM03P0UxyUt15sA= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MW3PR11MB4523.namprd11.prod.outlook.com (2603:10b6:303:5b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Tue, 15 Dec 2020 00:49:06 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710%8]) with mapi id 15.20.3654.025; Tue, 15 Dec 2020 00:49:06 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [Patch V2] WhiskeylakeOpenBoardPkg: Add USB DCI debug suport Thread-Topic: [Patch V2] WhiskeylakeOpenBoardPkg: Add USB DCI debug suport Thread-Index: AQHW0bqZVNJoqRwsekiZw1K8GMLJ26n3UFdA Date: Tue, 15 Dec 2020 00:49:06 +0000 Message-ID: References: <20201214014352.1087-1-heng.luo@intel.com> In-Reply-To: <20201214014352.1087-1-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5eb3e30f-2c84-46d8-946a-08d8a09339f3 x-ms-traffictypediagnostic: MW3PR11MB4523: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VWQl5SCmyRznFMSdNh04RKwlsPQyGoaMTd8sN4UiA2QozKLb9EXcV2lJhXWSU0SHqgpC4yFNVwEm0AjwNx7cD9OtJIMRxN0ypMKJpv1pcPl89gTpJHMx2ral4kxp2d1uVD6l5cO65MkMiuBW9SMHnr7KNnl37z+gt63pO7bHLDCZladRf4Z0bEULbdf97+2ELVpCcoMl9At/kernWJlNLv7e+h3zNgctQDhIauoLI48coO2jjGsmAh6hfohAgb0KJ4HdoHfxXRZfgJp87hb10j9zwXEa41kG0sNLS+TVZzj3e0TF2o6Hk5Fey1W6cASPXqW90GdcwQH5gK4abFZO1QmtGPUXUgR5LwJoSFlH7VERBrRlp0hwSx7pY54XSRmPkDctcgu6S3JkafrEv1x1hw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(136003)(376002)(110136005)(5660300002)(9686003)(186003)(8676002)(7696005)(2906002)(55016002)(8936002)(66476007)(4326008)(26005)(33656002)(66446008)(64756008)(66556008)(53546011)(71200400001)(107886003)(966005)(83380400001)(6506007)(76116006)(52536014)(508600001)(86362001)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?mOr4o5z9NMdhSgD0i6q6f9ySzUsNDtso4820iF9LeIoO1+XQvQ6xCn/AhtG5?= =?us-ascii?Q?8ctvWve0iMVI8a047BYEm2uYsdWWLGmNGUEsJ7LXrJkhwleeUyerC9PUzsVA?= =?us-ascii?Q?D5I0ZJWh6RikMPWNP9wCL0mG6wPn2m3zZ2eksvLHacO2KzmnlxC91WayFDjM?= =?us-ascii?Q?wlKtOS8Uff10N9piR3GVUf1SyCYHJx3g2aQmhiNhiJV8e7w1MnB2vIaeJd1N?= =?us-ascii?Q?vA3RDGhdfrgP5BfxedJ5MfGOXwdYOkqMIzn4vfFzDc8wjwR1tczHj6vKNcf0?= =?us-ascii?Q?V6XLZCX37SXRPTSDLibY09HzvZQLNuiSelubZVwL1AeWo04iWSWWAv9KS8cK?= =?us-ascii?Q?bO8/DDughPeQFP7187XI4MsufvZVNYaIyI1sXdRfEcJ0DmEmnK8WlPnc1396?= =?us-ascii?Q?GgCg5C2WUHSATBYZ84RZqHWJLrh9a4Kp6OOAR9EvLGRdfLvzOYmrsL7QN2oN?= =?us-ascii?Q?3X1ijX/e437s37enmh1NX+lw8GWapHx6zsgwubkYZjX7911JAFg+zVRXqlXb?= =?us-ascii?Q?FMHfef3bKvX0JQXuJMJ5+08OK9dZM6UoQ1aRFvLCWBergtAtg3bcoYm11KST?= =?us-ascii?Q?yGZgP4QJDvn9Nn470nst9r4EUs/R9DhXGzz0WE1MhfwMZh3eONk+liBfu+Oo?= =?us-ascii?Q?sNz5BCf7GsU6aFBKhvBbH+LLa6utzBy+huydph9bZRUkEhbhMkrV6Zv+4Dye?= =?us-ascii?Q?cUVKaxQ56YlkOAw/NQ28VwUhSPlErwQH7x1Ctu7l8LuuBWQj7+psrSVftKXl?= =?us-ascii?Q?V0N8Ojk4i3gKNF2n34m4rR3XNwZXD8H7ZFtesnClEbk9MWzx/FfuGO4YzfOB?= =?us-ascii?Q?YpHF1XZ9d15pFzR1ZdeQTGhvpc4zK/slhP6P8FU+AGa7Io7+BKLu2+dbANDF?= =?us-ascii?Q?vJroMp8FWy3qhgphw7HAWToIflHck+oB3xw9oypdnhH99lBQSjEa9ruq6vCe?= =?us-ascii?Q?XIL88cO2i+EkSlCAPc2zC4Ia/WlhCKh2PM9MJqzcryg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5eb3e30f-2c84-46d8-946a-08d8a09339f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2020 00:49:06.5096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GvasEyY81IaBcVsxjcoGkwGFA5yZWGWB2DE97jL9aRVWM4Kp4KBNv+K9bs42JVsr1CVGBVU0HsCfpauOb7AJsRsEm7glqrAhePHDk+2rmwU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4523 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Luo, Heng > Sent: Sunday, December 13, 2020 5:44 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [Patch V2] WhiskeylakeOpenBoardPkg: Add USB DCI debug suport >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3081 >=20 > Add gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable for USB DCI > debug feature, feature is enabled if PcdDciEnable is TRUE, it allows to d= ebug > BIOS via DCI cable. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Heng Luo > --- > Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLi > b/PeiPchPolicyUpdatePreMem.c | 8 +++++++- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLi > b/PeiPolicyUpdateLib.inf | 4 ++++ >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds > c | 2 ++ >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk > gPcd.dsc | 2 ++ > 5 files changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > index fbb9549e44..196460e170 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > @@ -554,6 +554,7 @@ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdNCT6776FHWMON > | > [PcdsDynamicEx] [PcdsDynamic, > PcdsDynamicEx]+gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnabl > e |FALSE|BOOLEAN|0x20000001 [PcdsPatchableInModule] diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > index 2d48b09175..bb34f89fb5 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpd > +++ ateLib/PeiPchPolicyUpdatePreMem.c > @@ -83,7 +83,13 @@ UpdatePeiPchPolicyPreMem ( > Status =3D GetConfigBlock ((VOID *) SiPreMemPolicy, > &gIshPreMemConfigGuid, (VOID *) &IshPreMemConfig); > ASSERT_EFI_ERROR (Status); - DciPreMemConfig->DciUsb3TypecUfpDbg =3D > 2;+ if (PcdGetBool (PcdDciEnable)) {+ DciPreMemConfig- > >PlatformDebugConsent =3D 3;+ DciPreMemConfig->DciUsb3TypecUfpDbg =3D > 1;+ } else {+ DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2;+ }+ > PchTraceHubPreMemConfig->MemReg0Size =3D 3; > PchTraceHubPreMemConfig->MemReg1Size =3D 3; //diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPolicyUpdateLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPolicyUpdateLib.inf > index 478e2d0512..252f92f487 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPolicyUpdateLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpd > +++ ateLib/PeiPolicyUpdateLib.inf > @@ -230,6 +230,9 @@ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdEcPresent + # > Enable/Disable USB DCI Debug+ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable = ## > CONSUMES+ gIntelSiliconPkgTokenSpaceGuid.PcdIntelGraphicsVbtFileGuid > ## CONSUMES > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdSmbusAlertEnable > ## CONSUMES > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdSataLedEnable = ## > CONSUMES@@ -243,6 +246,7 @@ >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSystemFmpCapsuleImageTypeIdGu > id ## CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## > CONSUMES + [FixedPcd] > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize ## > CONSUMESdiff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > index e161bf06f4..84d4ec1331 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > ds > +++ c > @@ -399,6 +399,8 @@ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3Tbt|0x1 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3TbtClkReq|0x1 + > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable|FALSE+ > [PcdsDynamicHii.X64.DEFAULT] > ###################################### # Edk2 Configurationdiff - > -git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > index 83ada3c95c..4a7ba4d5f0 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ gPcd.dsc > @@ -389,6 +389,8 @@ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3Tbt|0x1 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3TbtClkReq|0x1 + > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable|FALSE+ > [PcdsDynamicHii.X64.DEFAULT] > ###################################### # Edk2 Configuration-- > 2.24.0.windows.2