From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.3954.1591821211741096577 for ; Wed, 10 Jun 2020 13:33:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=TDEox+9i; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: 83aL0prDj3AYTxQ08uBxSTmMXs6CB+LbbNSkRbkf62VX7/QpHxDIk6AJ5JmTTQVNk/MqQPD2Pf KbcGpqPeU1ew== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 13:33:31 -0700 IronPort-SDR: v+wFS3LztDYpzTdUhsid4PDpZg9HNLjGUsMOvdCwtc3W3M55ZORnkkIJqCbZ/w2Q1SyrTRUl6O UtG2cc+/5FeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,497,1583222400"; d="scan'208";a="271366318" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 10 Jun 2020 13:33:31 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 13:33:30 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 13:33:30 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 13:33:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gXHk/aSoCApO5lcrB3BnxIBh8QrENcRBDxQip2xaOztrWqdeY15VyuBMw0lidAktjRQqV0+SxtlzQXOfuIiTULD9LhPtE3uoRQqooo9a5XDu3EOH3wKuxVy7GQmZPpoUTRCWc12srnzCJaVj5KeBfF10wCLTOWq5Ih7Iwwu0nk08GuFjwx+Tadj+4VkdCl/auhHlt8EX5/7B/AGRcQJZbaq+FENZDUAck2OxuljQjS1PCW1IVYgCdrjlU1sZAU954bGBA32r3xcS0bNdcw6/tLPrOqNL1FpbfIJyU4WmMMBjxPl6Gq458eaSryTgj++OxL+KIxgNPqBFeStILoIG8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10EjmTfnoczknrtvl8/8qJQcH00sTKRiFxoRJ967y/Y=; b=EblPAUmBTavTwRqHglfQuiYy5yAcBQEkcebD1UQVjnZr3kbm6/zde4PKAty9aS8gKGJpO2BUy6tl46iWxy/qZYntg9IDxGhcsbHD984bQZuchJEtLLqEurWBhXwruX+igtUZbfaz4i/V2wzfKmO9YtusioS4U4fmVyxXvktSDi6eh6dtJuyZpmf/tonEhqRu8nNr8wBCdF6fop2yFuov2edO9u7jj4NcgwI1wjcgPtlWxn+OgH16IaMPyo9DzQroBng9v+PwadELoMoVQ5xlfZv/ZCU7gXVJgkTrx8qt/Ld0o/QfQtqRVExuTZoox4tXJY2z1QXcZElt/i3xjJUS8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10EjmTfnoczknrtvl8/8qJQcH00sTKRiFxoRJ967y/Y=; b=TDEox+9i1HTfOkY3bFmxTcaAw5yISkcbST3cLnJGtDVizhjjgXF8xa+D1jqX5greEQE/m9WKDa4sPDrejDaH/pLkMKdG+H7HzlQWBDrb4xvx9D0UCaIMmLu9zeN9Ku4b1leZ7VpPTsfodfNPt49jBh4yKjEqUEtQ8IatOnTije0= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR1101MB2158.namprd11.prod.outlook.com (2603:10b6:301:59::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Wed, 10 Jun 2020 20:33:28 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::889c:c0bd:5262:7c80]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::889c:c0bd:5262:7c80%8]) with mapi id 15.20.3088.018; Wed, 10 Jun 2020 20:33:28 +0000 From: "Nate DeSimone" To: "Tan, Ming" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type Thread-Topic: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type Thread-Index: AQHWPlCPs9WsVjv9mUergLAYOXz45qjSUCdw Date: Wed, 10 Jun 2020 20:33:28 +0000 Message-ID: References: <20200609112353.20824-1-ming.tan@intel.com> <20200609112353.20824-7-ming.tan@intel.com> In-Reply-To: <20200609112353.20824-7-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmZjOGU5NGUtMjhjZC00NjJhLWIyNDktYjBiMTg2YjQ0NTVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZk95dDZBWG9SWmNKQThCQWhRYWR3V1VUaE05MzBPYzlNVFQrMUQ5S0t6UVVTSm1sOTJFRnp6MEJNbVduM25hQyJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2581741f-3580-4e07-b795-08d80d7d88a4 x-ms-traffictypediagnostic: MWHPR1101MB2158: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1265; x-forefront-prvs: 0430FA5CB7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JksaMDRXGiFm87JewIZzear3JT5FzzQWo10IycPQW4Qm7R46T+5MVw1gOsR+kSgdeqlFIrj5bHPlFmRsUxUxOdAdA+AbeOvyYgaph5Uhym9p7RIlLiLBa7I2gy4pWkkW0/ZnJLVR35IB+Y16A5oJQ23PabCmMhLQ708CgmbNwYCuTeNG4ZG0J4ePc/o0+EpywGCXa/snMRS7idzxFkOWY38Uez9uW4O0IR53DLKAP6QnZw8sV6Ejs2sU4sjjoypQ2gx/N8RgTeZIfGv90thOKvLER7Ve3aZ7v3rRDU4kdm6bbyRKcEYgeTe4bZV9uDHxzHLgPINDpeLfNj3gmQjKG8XiYZar5DsIJxGhV2tzsQQqko1uxGd1f/Rk98/WwloQiWi6Oq+JelmsUPM/4wEmNQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(376002)(346002)(39860400002)(366004)(396003)(86362001)(53546011)(107886003)(4326008)(26005)(2906002)(33656002)(186003)(6506007)(8676002)(55016002)(7696005)(66556008)(66446008)(71200400001)(83380400001)(8936002)(54906003)(76116006)(66946007)(478600001)(110136005)(9686003)(66476007)(64756008)(966005)(52536014)(316002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: uGGtT4rvC5mFq4yrySjw2B3Z5+Wm9ji/ZQuSD8bPD55cR9/KCZY14/tt04i4iPtMU6v+s++TqGn74KUFKTrxNwbetEfnhlBrZjuKKi54/C0+pqUnuIaKE4JXHkmECPASv0h8+GViV8d6/V6JnWvzHKSJHo4pVfcrYUUdcTI4HZQcu01JCbE5Vlp0xBsi313su+ylPZKkN/8CuefKG4k4+UfMG2PobKvw8ZgLo8DxEL2+QOOHVdjqZVFOMWYXdikXMbcOttCt86rBe4bFwKSaTwWOeD5MfFHzQyv5Sjlu/Ra39BUxIsAYuoFvPGJHI1fhgiz+iVbObKVPbQgh4/7tnH+hJXTYLCsBdqAkAanTKwy03IhP82dpZsY/f7OJ6MPldaClwxtjlSuAfM6aXeWT8BUtmXT8+xJGvy9DsDY3EDpL2/lyMMddQfrScSWk/wvxCF7dG3+6hZ27QJ360OUk56bhY2/sIEp0oB7IIcjfhDjgr+AQqJg5KGDtpdp7VcTh MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2581741f-3580-4e07-b795-08d80d7d88a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 20:33:28.6445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 16PA/22DigHT0MOOVktRBphypkcvlr3J5uWHB9RzTrhQ7ldfY2uFvgP740I7eYGLAzGMBys45QBgDMgnidi05UC0iWyKqDrT/+va9QW+GRY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2158 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Tan, Ming =20 Sent: Tuesday, June 9, 2020 4:24 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs= type REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2791 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeM= odulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedA= tBuild in dsc files. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Signed-off-by: Ming Tan --- .../CometlakeURvp/OpenBoardPkgPcd.dsc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPk= gPcd.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgP= cd.dsc index 1ccdb28f12..d611e99fc1 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPcd.ds= c +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPcd +++ .dsc @@ -75,12 +75,6 @@ # Edk2 Configuration ###################################### gEfiMdeM= odulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSectionFirst|FALSE- gE= fiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE-!if $(TARGET) =3D= =3D RELEASE- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!= else- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE-!endif = gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE gUefiCpuPkgTok= enSpaceGuid.PcdCpuSmmProfileEnable|FALSE gEfiMdeModulePkgTokenSpaceGuid.P= cdInstallAcpiSdtProtocol|TRUE@@ -207,6 +201,12 @@ !if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHa= rdwareFlowControl|FALSE !endif+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCo= deUseMemory|FALSE+!if $(TARGET) =3D=3D RELEASE+ gEfiMdeModulePkgTokenSpace= Guid.PcdStatusCodeUseSerial|FALSE+!else+ gEfiMdeModulePkgTokenSpaceGuid.Pc= dStatusCodeUseSerial|TRUE+!endif gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIo= BarEnableMask|0x80 gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoPciBarRegisterO= ffset|0x00--=20 2.24.0.windows.2