[edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements

[edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3532
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3533
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3534

This patch series groups together several bug fixes and
improvements to AcpiPlatform.

Note that the following patch from a different series that is on
the mailing list is currently required for MinPlatformPkg to
build:
  https://edk2.groups.io/g/devel/message/78711

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (4):
  MinPlatformPkg/AcpiPlatform: Use PCD for WSMT OEM revision
  MinPlatformPkg/AcpiPlatform: Use CreatorId and CreatorRevision in
    headers
  MinPlatformPkg/AcpiPlatform: Set X_GPE1_BLK GAS structure to zeroes
  MinPlatformPkg/AcpiPlatform: Remove unused BoardAcpiTableLib

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 7 ++++---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Wsmt/Wsmt.c      | 4 +---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h   | 1 -
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 +-
 4 files changed, 6 insertions(+), 8 deletions(-)

-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 1/4] MinPlatformPkg/AcpiPlatform: Use PCD for WSMT OEM revision

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3532

Updates the table to use the standard MdeModulePkg PCD
PcdAcpiDefaultOemRevision to set the OEM revision in WSMT.

This allows board packages to easily configure the OEM
revision value.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Wsmt/Wsmt.c      | 4 +---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 +
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Wsmt/Wsmt.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Wsmt/Wsmt.c
index 6880f47fa6a0..1c60ed28a1c4 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Wsmt/Wsmt.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Wsmt/Wsmt.c
@@ -18,8 +18,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // WSMT Definitions
 //
 
-#define EFI_ACPI_OEM_WSMT_REVISION                      0x00000001
-
 EFI_ACPI_WSMT_TABLE Wsmt = {
   {
     EFI_ACPI_WINDOWS_SMM_SECURITY_MITIGATION_TABLE_SIGNATURE,
@@ -37,7 +35,7 @@ EFI_ACPI_WSMT_TABLE Wsmt = {
     { ' ', ' ', ' ', ' ', ' ', ' ' },
 
     0,
-    EFI_ACPI_OEM_WSMT_REVISION,
+    FixedPcdGet32 (PcdAcpiDefaultOemRevision),
     0,
     0
   },
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
index 5d9c8cab50d5..7c5173b16d7f 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
@@ -47,6 +47,7 @@ [LibraryClasses]
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId
+  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision
 
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 2/4] MinPlatformPkg/AcpiPlatform: Use CreatorId and CreatorRevision in headers

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3533

Updates InitializeHeader() to fill in the CreatorId and
CreatorRevision values from PCDs instead of being hardcoded to zero.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 2b51c34ef2fd..6919e3196143 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -572,8 +572,8 @@ InitializeHeader (
     );
 
   Header->OemRevision     = OemRevision;
-  Header->CreatorId       = 0;
-  Header->CreatorRevision = 0;
+  Header->CreatorId       = PcdGet32 (PcdAcpiDefaultCreatorId);
+  Header->CreatorRevision = PcdGet32 (PcdAcpiDefaultCreatorRevision);
 
   return EFI_SUCCESS;
 }
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 3/4] MinPlatformPkg/AcpiPlatform: Set X_GPE1_BLK GAS structure to zeroes

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3534

Updates the code to be compatible with a recent Firmware Test Suite
(FWTS) fix that improves adherence to the ACPI Specification.

Relevant FWTS commit:
https://git.launchpad.net/fwts/commit/?
id=4ad3e374bf98931c84adcf6e523982b5ebb83748

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 6919e3196143..fe57ec4f7bb7 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1321,7 +1321,8 @@ PlatformUpdateTables (
     FadtHeader->XGpe0Blk.Address    = PcdGet16 (PcdAcpiGpe0BlockAddress);
     FadtHeader->XGpe1Blk.Address    = PcdGet16 (PcdAcpiGpe1BlockAddress);
     if (FadtHeader->XGpe1Blk.Address == 0) {
-      FadtHeader->XGpe1Blk.AccessSize = 0;
+      FadtHeader->XGpe1Blk.AddressSpaceId = 0;
+      FadtHeader->XGpe1Blk.AccessSize     = 0;
     }
 
     DEBUG(( EFI_D_ERROR, "ACPI FADT table @ address 0x%x\n", Table ));
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 4/4] MinPlatformPkg/AcpiPlatform: Remove unused BoardAcpiTableLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

Removes an unnecessary library dependency.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h   | 1 -
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h
index bd11f9e98864..827d273cc48a 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h
@@ -31,7 +31,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/BaseMemoryLib.h>
 #include <Library/IoLib.h>
 #include <Library/PcdLib.h>
-#include <Library/BoardAcpiTableLib.h>
 #include <Library/MemoryAllocationLib.h>
 #include <Library/AslUpdateLib.h>
 #include <Library/PciSegmentInfoLib.h>
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
index 7c5173b16d7f..b301a6519cb0 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
@@ -42,7 +42,6 @@ [LibraryClasses]
   HobLib
   PciSegmentInfoLib
   AslUpdateLib
-  BoardAcpiTableLib
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId
-- 
2.28.0.windows.1

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements

[Michael D Kinney]

Hi Michael,

These all look like reasonable changes to me.

Acked-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Thursday, August 5, 2021 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3532
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3533
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3534
> 
> This patch series groups together several bug fixes and
> improvements to AcpiPlatform.
> 
> Note that the following patch from a different series that is on
> the mailing list is currently required for MinPlatformPkg to
> build:
>   https://edk2.groups.io/g/devel/message/78711
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (4):
>   MinPlatformPkg/AcpiPlatform: Use PCD for WSMT OEM revision
>   MinPlatformPkg/AcpiPlatform: Use CreatorId and CreatorRevision in
>     headers
>   MinPlatformPkg/AcpiPlatform: Set X_GPE1_BLK GAS structure to zeroes
>   MinPlatformPkg/AcpiPlatform: Remove unused BoardAcpiTableLib
> 
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 7 ++++---
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Wsmt/Wsmt.c      | 4 +---
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h   | 1 -
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 +-
>  4 files changed, 6 insertions(+), 8 deletions(-)
> 
> --
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#78740): https://edk2.groups.io/g/devel/message/78740
> Mute This Topic: https://groups.io/mt/84688758/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
> 

Re: [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements

[Nate DeSimone]

For the series..

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> 
Sent: Thursday, August 5, 2021 9:38 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3532
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3533
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3534

This patch series groups together several bug fixes and improvements to AcpiPlatform.

Note that the following patch from a different series that is on the mailing list is currently required for MinPlatformPkg to
build:
  https://edk2.groups.io/g/devel/message/78711

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (4):
  MinPlatformPkg/AcpiPlatform: Use PCD for WSMT OEM revision
  MinPlatformPkg/AcpiPlatform: Use CreatorId and CreatorRevision in
    headers
  MinPlatformPkg/AcpiPlatform: Set X_GPE1_BLK GAS structure to zeroes
  MinPlatformPkg/AcpiPlatform: Remove unused BoardAcpiTableLib

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 7 ++++---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Wsmt/Wsmt.c      | 4 +---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h   | 1 -
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 +-
 4 files changed, 6 insertions(+), 8 deletions(-)

--
2.28.0.windows.1

Re: [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements

[Nate DeSimone]

The series has been pushed as 2bb0314~..d281e9e

-----Original Message-----
From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> 
Sent: Thursday, August 5, 2021 9:38 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3532
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3533
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3534

This patch series groups together several bug fixes and improvements to AcpiPlatform.

Note that the following patch from a different series that is on the mailing list is currently required for MinPlatformPkg to
build:
  https://edk2.groups.io/g/devel/message/78711

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (4):
  MinPlatformPkg/AcpiPlatform: Use PCD for WSMT OEM revision
  MinPlatformPkg/AcpiPlatform: Use CreatorId and CreatorRevision in
    headers
  MinPlatformPkg/AcpiPlatform: Set X_GPE1_BLK GAS structure to zeroes
  MinPlatformPkg/AcpiPlatform: Remove unused BoardAcpiTableLib

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 7 ++++---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Wsmt/Wsmt.c      | 4 +---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h   | 1 -
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 +-
 4 files changed, 6 insertions(+), 8 deletions(-)

--
2.28.0.windows.1