From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.1139.1628205330219025024 for ; Thu, 05 Aug 2021 16:15:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=xxnSruoA; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="236245883" X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="236245883" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 16:15:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="523054161" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga002.fm.intel.com with ESMTP; 05 Aug 2021 16:15:29 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 5 Aug 2021 16:15:29 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 16:15:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 5 Aug 2021 16:15:28 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 16:15:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLlz2oFof4e4wSNzcggHtx/kl07W2TlAORBy2wRXeJ8rH36aEcTeZNf0JmGzPj+ccH8SI34uL3m8gAv71/YqiVT1Xjz5kNoMZWmO6rHjZfuUfQ0PyG4TIfGw3IpustLmh3DIg6Q5v6HaXYjPWuPDDOyS+M7y2t3cEWkzY/Xnuz1CqJzOr8G/M/n0kktmayqJzGgcQItJ+YJ4OSKc62YjtVfkfhggPTXgPWznHbVhdjafelXgTyYKxGi/n2kzdJ15IXjCi4hND8Sf48B8QBR16UxJzK20q7pDD9XQPNbBXuPTk8fmAlq2kf3aiNNmysFvW1C2hsLqOAEUN1a6vqJR5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3IuPOtOMOmD8xhbE8H2L/fLfrQKi+bxxE/5m4rCBCjA=; b=RDMDaUGQj0zfcJtOLCwFp4E3Ls+BcUecTtwC7fo+mRZFHRWwCQfM9e8gvaoz+LjF8RZHj+gyx24+5ATQ5vbAwtBVuqm8R4DjfUFTWkzv716PTi+3FK44zbj8r5mZvnOBJKO0q3hwRDftELRTM9wTPJlJ6TwqFtr+MdJiQSD1CsEzbbt4Fy8jAxdJ/H7dMPuuKWTs9yjxy/O632t5uwtS/Cag8ilGUgYBsCL54q1hFSi9SY7Akeigw0893hHUUgqzOi33YFUFBd28+LeU587/NRb/V1RoyzlH4d1GxkUzHS2O/7mF+NZQzDJ9PIQco8GwiLe7nxvdsxXyrurKiuKRDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3IuPOtOMOmD8xhbE8H2L/fLfrQKi+bxxE/5m4rCBCjA=; b=xxnSruoABmgRCRqsuzCt8xDVrjNLJ8Z78wg53s55rllXnBVRoctfX9+dYqB4bj3OFG1cxDAwNAkYLuMBsvfgtocksq3ZbL8E5k6otNgpkplwugOXeXd4Y2LRPMEpHAiHwU2ov6zYu6AXL10R9vijApEPZeH4sTPTCIRPGj3+D+I= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB4787.namprd11.prod.outlook.com (2603:10b6:303:6e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15; Thu, 5 Aug 2021 23:15:27 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4394.017; Thu, 5 Aug 2021 23:15:26 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-platforms][PATCH v1 1/5] MinPlatformPkg/TestPointCheckLib: Fix MessageLength cast issue Thread-Topic: [edk2-platforms][PATCH v1 1/5] MinPlatformPkg/TestPointCheckLib: Fix MessageLength cast issue Thread-Index: AQHXigpCjMceH2knh0y/TePTxv+u5qtli0uw Date: Thu, 5 Aug 2021 23:15:26 +0000 Message-ID: References: <20210805145706.2470-1-mikuback@linux.microsoft.com> <20210805145706.2470-2-mikuback@linux.microsoft.com> In-Reply-To: <20210805145706.2470-2-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ed24e3fd-cd47-4972-39ce-08d95866e8a5 x-ms-traffictypediagnostic: CO1PR11MB4787: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wnucnURGaFFhOlNZ6bps/dEpnThqAoGeMiSjvUI6zJvFyBs+76ccc+rtWTcCZcZJizedcHmsQymHVzuOtmbMZIL5UQ5mTK8gEhry6VGkp2d4+kGxi+Xm2/MLU16qNinOVZiC4V2wgCqYF3cacmy/LJG9tZwbN4eWfGWqJjnknpO30yUOdhevdu8JOSZYITGDnvB3Gk2Dl4AhTdxIz96+j3yrdKS76O1wUZml7OL/qo/oWHfG1Gyjnv3VY/8RLLeOYWQEMioFyIOTxrWBspnqUiw+Y4edw19I4w3QrDv+VivSxQ4VG4MDbJj3FRvyN3zo73qySl+PKDxd0Vp3+B1ER2CKGelmJ6ux9nJOIH4O1HqZ6RKkywT1pUUhOF2vIfCgjw6dKLVc5vP8l+Kow+t/SN14U0X9LGZlcYAWiQ4csdPc1WtwedQ4suXUVvq9ImaweCrmujVWDskjo9LPWQTxXALO7FCQ+QmOlUNHVX34v8cNhMew/NbCLHcTPbczaLR9TPKKIN0DwPOFzeKfSE9VfQy8tsS/UaD/f1ka4VlJnSBBP39lNVcjOyagHLLHueRxDSY+2phUnVZfw3/mDuM+GxvKmMkffMAjgonLMqMnxMJQbJTv8b+lme4AloDVJXcfijeZZXcIlu9Y4wz8nbHJjgpdvV3ScyMZtt2gC9zxCTD1/wIxydy09FWz++mTCQiWQWQbDFoSUStKCnCzfXyqmSfJBGkhtavwGZnylCjyXmoQfmYxa2HPetVdEF3E/hvmGr+PI5VeipJ9RiaOAuudfmlR4YnoG6JZxLKuLBwhE3nB+PWByp4Uy+f2VrpS29E7DvJK+QdwJZZc5PqhcRrQTw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(186003)(38070700005)(83380400001)(33656002)(38100700002)(66946007)(86362001)(966005)(26005)(2906002)(8676002)(122000001)(8936002)(4326008)(6506007)(53546011)(52536014)(107886003)(7696005)(9686003)(110136005)(316002)(54906003)(5660300002)(76116006)(508600001)(64756008)(55016002)(66476007)(66556008)(66446008)(15650500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sfbhngf6gCJYgmsXKf379cx3JM4ysVYWuENNHieo/P/yn7C+BAdxjgYZSXro?= =?us-ascii?Q?q/44KUzq28x34cPiBjhBVZmlV9jLIbES0InHaq27tB73wjp5Z1/miqnV0kB8?= =?us-ascii?Q?6WCq1MBn3bfQY9CMev9hMOoSCMMtKvAswwYNwdi/UpVV148dYmnYfu3ynfXA?= =?us-ascii?Q?8p8AE/zK9zN9N9JQ2g0FwDwWTXtIsnpDX+gD6lJtTKRk0exUmmQsR5rhNuF5?= =?us-ascii?Q?CIdIamryaAh+OwTqXKFzplobZBAuFENcN+dSiHI8w/FtYWXLNqmrVYHzm11r?= =?us-ascii?Q?2vh4YrvKbMDFQ5zO4biDD/PPSzzcw4np/dYC9Ydf83blOEjJu/5kuQl2ldq5?= =?us-ascii?Q?3JJ7cOEWgxWrzjtpFWJTM++fovrAGmHzfGePm3IBifgWLupSk6YZ3IvzRR3E?= =?us-ascii?Q?0C1YNCUSTqC9MzHhh1d2LuLYXu/xmh5ubSXZW7eXTDtiAKWlK3fotlSPsEVh?= =?us-ascii?Q?8tg3tpYyj6J59b9iP52k9WXJTbzfhZXHh+tPtEkKBMYmLIWKd9SR4rRw7Zvf?= =?us-ascii?Q?5N2JyMkoNo///KqGzZvdvgbkwF+Uyn7eWhekTesHPCpElCaTaq38GalUVcD8?= =?us-ascii?Q?xfKs7CpGjGDZHrEwk155cxOFyHUuCigBpZ/0t+6k7M9hPT/axXBMzu6K6gAS?= =?us-ascii?Q?//UV0/Cwm3YQJsDV2GgeBeq4OPWNOOQHAEngpDTyi+83mUf+t3ocDZRXm+bO?= =?us-ascii?Q?GwytwVe1neC4Ah1uuJ51pME8B38OOrQPLlqLQzdQQxXdwlbIv99U0h9n7fAW?= =?us-ascii?Q?wbL/M0y8fm4PcQbBQ6EVFbB4Xa62+7aTKY5vx/tYF0HtGqe+lAiZQxNTN74V?= =?us-ascii?Q?tl7BORiSVxWysev1jyQ6RvbCzWIfwWg0AzMblEOYgwllPZZ1yS822pDDiQ1X?= =?us-ascii?Q?iTwY8PJzsyv1tqURGnq/+FWJYN9TE4ddl3LuslS47m8uG+mC91l/sfzH7Mke?= =?us-ascii?Q?qy+ntveDC1dRgHTVLVa6DnL5y3DHqihLhIyut5nW6KnjA/SvMhWho/MgqBh3?= =?us-ascii?Q?pOHhBR3rsx6dIV6EW/zgGjIfFaVfzUVhpuhyxhou9pq96CFfUBAGCMAJTcc9?= =?us-ascii?Q?r/qQr/1SLIIEbIFf2uy3MXWdow/YvymV7wxotXWuk/cU2D7RFM4TrA1poTTh?= =?us-ascii?Q?smq2gEJfmToLESDzcc6EmWyiV72d3Oss1RQlE0RqXHdjx5rzJOdgv+iQ2VP+?= =?us-ascii?Q?xwqhkrpgQSQiSTM5bCU7ZihFTQFeH4xodbwVZaT/Pu/Qs8ZGVlgj1UsVbhZH?= =?us-ascii?Q?tFd9AhQ0w+GJ/372atp8M2BRSSdV8JGZxOaU13X6pKjLRvgNrSU3BVCw1HMr?= =?us-ascii?Q?fMo6dwvF7pHlM3TVXg/X5/zS?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed24e3fd-cd47-4972-39ce-08d95866e8a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 23:15:26.1067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OBRg5DG9ZREAHfGaDHm9qdqvzu05yO0BgPy13jvStKRBTPIdnE0xLDriRYEVNdeyZYFRUYEzt6OJMmlyw7bE+7biA+ysxZehJFGchucGyuM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4787 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, August 5, 2021 7:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1 1/5] > MinPlatformPkg/TestPointCheckLib: Fix MessageLength cast issue >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3531 >=20 > The MessageLength field of EFI_MM_COMMUNICATE_HEADER as defined in > MdePkg/Include/Protocol/MmCommunication.h was updated to a fixed size > as opposed to UINTN to avoid ambiguity between different caller > enviornments. >=20 > This change updates the MessageLength usage in MinPlatformPkg to support > the new field structure, in turn, fixing a build issue. >=20 > Original edk2 change: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3398 >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS > miHandlerInstrument.c | 4 ++-- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.c | 15 ++++++++++++++- > Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.c > | 10 +++++----- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.inf | 1 + > 4 files changed, 22 insertions(+), 8 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > SmiHandlerInstrument.c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > SmiHandlerInstrument.c > index 3ceeb821fb95..80e8d26f4e1d 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > SmiHandlerInstrument.c > +++ > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh > +++ eckSmiHandlerInstrument.c > @@ -106,7 +106,7 @@ GetSmiHandlerProfileDatabase( > CommGetInfo->Header.ReturnStatus =3D (UINT64)-1; > CommGetInfo->DataSize =3D 0; >=20 > - CommSize =3D sizeof(EFI_GUID) + sizeof(UINTN) + CommHeader- > >MessageLength; > + CommSize =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + > + (UINTN)CommHeader->MessageLength; > Status =3D SmmCommunication->Communicate(SmmCommunication, > CommBuffer, &CommSize); > if (EFI_ERROR(Status)) { > DEBUG ((DEBUG_INFO, "SmiHandlerProfile: SmmCommunication - %r\n", > Status)); @@ -139,7 +139,7 @@ GetSmiHandlerProfileDatabase( > CommGetData->Header.DataLength =3D sizeof(*CommGetData); > CommGetData->Header.ReturnStatus =3D (UINT64)-1; >=20 > - CommSize =3D sizeof(EFI_GUID) + sizeof(UINTN) + CommHeader- > >MessageLength; > + CommSize =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + > + (UINTN)CommHeader->MessageLength; > Buffer =3D (UINT8 *)CommHeader + CommSize; > Size -=3D CommSize; >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestP > ointCheckLib.c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestP > ointCheckLib.c > index c012e0afcbaa..e5efbd059954 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestP > ointCheckLib.c > +++ > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTe > +++ stPointCheckLib.c > @@ -12,6 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include #include > > +#include > #include > #include > #include > @@ -520,6 +521,7 @@ TestPointDxeSmmReadyToBootSmmPageProtection ( > UINTN MemoryAttributesTa= bleSize; > EFI_STATUS Status; > UINTN CommSize; > + UINT64 LongCommSize; > UINT8 *CommBuffer; > EFI_SMM_COMMUNICATE_HEADER *CommHeader; > EFI_SMM_COMMUNICATION_PROTOCOL > *SmmCommunication; > @@ -620,7 +622,18 @@ TestPointDxeSmmReadyToBootSmmPageProtection > ( > (UINTN)CommData->UefiMemoryAttributeTableSize > ); >=20 > - CommSize =3D OFFSET_OF(EFI_SMM_COMMUNICATE_HEADER, Data) + > CommHeader->MessageLength; > + Status =3D SafeUint64Add (OFFSET_OF > (EFI_SMM_COMMUNICATE_HEADER, Data), > + CommHeader->MessageLength, &LongCommSize); if (EFI_ERROR (Status)) > { > + DEBUG ((DEBUG_INFO, > "TestPointDxeSmmReadyToBootSmmPageProtection: LongCommSize > calculation - %r\n", Status)); > + return EFI_SUCCESS; > + } > + > + Status =3D SafeUint64ToUintn (LongCommSize, &CommSize); if (EFI_ERROR > + (Status)) { > + DEBUG ((DEBUG_INFO, > "TestPointDxeSmmReadyToBootSmmPageProtection: CommSize conversion > - %r\n", Status)); > + return EFI_SUCCESS; > + } > + > Status =3D SmmCommunication->Communicate(SmmCommunication, > CommBuffer, &CommSize); > if (EFI_ERROR(Status)) { > DEBUG ((DEBUG_INFO, > "TestPointDxeSmmReadyToBootSmmPageProtection: SmmCommunication - > %r\n", Status)); diff --git > a/Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe > .c > b/Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe > .c > index 3cc5ccfef6f4..8416b36f56ae 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe > .c > +++ > b/Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubD > +++ xe.c > @@ -122,7 +122,7 @@ GetTestPointDataSmm ( > CommGetInfo->Header.ReturnStatus =3D (UINT64)-1; > CommGetInfo->DataSize =3D 0; >=20 > - CommSize =3D sizeof(EFI_GUID) + sizeof(UINTN) + CommHeader- > >MessageLength; > + CommSize =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + > + (UINTN)CommHeader->MessageLength; > Status =3D SmmCommunication->Communicate(SmmCommunication, > CommBuffer, &CommSize); > if (EFI_ERROR(Status)) { > DEBUG ((DEBUG_INFO, "SmiHandlerTestPoint: SmmCommunication - > %r\n", Status)); @@ -155,7 +155,7 @@ GetTestPointDataSmm ( > CommGetData->Header.DataLength =3D sizeof(*CommGetData); > CommGetData->Header.ReturnStatus =3D (UINT64)-1; >=20 > - CommSize =3D sizeof(EFI_GUID) + sizeof(UINTN) + CommHeader- > >MessageLength; > + CommSize =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + > + (UINTN)CommHeader->MessageLength; > Buffer =3D (UINT8 *)CommHeader + CommSize; > Size -=3D CommSize; >=20 > @@ -233,7 +233,7 @@ PublishSmmTestPoint ( > TestPoint =3D mSmmTestPointDatabase; > while ((UINTN)TestPoint < (UINTN)mSmmTestPointDatabase + > mSmmTestPointDatabaseSize) { > TestPointSize =3D GetTestPointInfoSize (TestPoint, > (UINTN)mSmmTestPointDatabase + mSmmTestPointDatabaseSize - > (UINTN)TestPoint); > - > + > TestPointLibSetTable (TestPoint, TestPointSize); >=20 > TestPoint =3D (ADAPTER_INFO_PLATFORM_TEST_POINT > *)((UINTN)TestPoint + TestPointSize); @@ -286,7 +286,7 @@ > OnReadyToBoot ( > EFI_EVENT ReadyToBootLaterEvent; >=20 > gBS->CloseEvent (Event); > - > + > Status =3D gBS->CreateEvent ( > EVT_NOTIFY_SIGNAL, > TPL_CALLBACK, > @@ -295,7 +295,7 @@ OnReadyToBoot ( > &ReadyToBootLaterEvent > ); > ASSERT_EFI_ERROR (Status); > - > + > gBS->SignalEvent (ReadyToBootLaterEvent); } >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestP > ointCheckLib.inf > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestP > ointCheckLib.inf > index 2ae1db4ee483..54b4015d6767 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestP > ointCheckLib.inf > +++ > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTe > +++ stPointCheckLib.inf > @@ -32,6 +32,7 @@ [LibraryClasses] > TestPointLib > PciSegmentLib > PciSegmentInfoLib > + SafeIntLib >=20 > [Packages] > MinPlatformPkg/MinPlatformPkg.dec > -- > 2.28.0.windows.1