From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.13199.1605396892926758436 for ; Sat, 14 Nov 2020 15:34:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=al968tz9; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: Dty0hc0qWg3jmHqLcrmAZ133QAFrT85U0juvpyA0ic8PnUV3cP+zUg3CCAQhp5iuvDc2eLZe0C Eh5a+65dWEdw== X-IronPort-AV: E=McAfee;i="6000,8403,9805"; a="158383462" X-IronPort-AV: E=Sophos;i="5.77,479,1596524400"; d="scan'208";a="158383462" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2020 15:34:48 -0800 IronPort-SDR: eSN+I5wMIQu0eBpRAV+RtrGCzpFndDS011ec033HWWTjlhBh+2EvfnsZeXjrn1reQ/4sia5kV0 NCtGtJlrauQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,479,1596524400"; d="scan'208";a="309516136" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 14 Nov 2020 15:34:47 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 14 Nov 2020 15:34:47 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 14 Nov 2020 15:34:47 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sat, 14 Nov 2020 15:34:47 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sat, 14 Nov 2020 15:34:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzNiAFgOgPBWzJtcw7ib2EU0CZp5Tprdzra3cO2pP8wdnhI3BN/v2NDNVevizKH0oeNkyr50lShcC1dvf1bcChwIRx0c08cAFdKy8sMgHOko6RGoG8HoiFZALdXNc+6JIidxC7MoV3iZEAZZSL0MPrr74dwCHasXtX4CfFFCRW59u+E3tCl5kIv2s0CUhk+Cou3STn+6obLONKxxXir58gFmr2BHJcfX/pjsXbwG2TKKUawciVbsRPMsGLex10UvkYezxhxJ7EZThwCXRve0nftqXGmMmjA4gNo0J5oZCXcwdUAArgsPvzQhTIp8R6eCjCMGFeaUak59GOhPa/WnuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQo+x7eVMN2sW7ouzj7ITCaUyCtbvI/NEYeJ5n06KTE=; b=hbLX0CFYbr3rW35/u79NVFDNL2TUYire89VH8QQiB71WBWJ1LeDx2sIhihwsUQpCZiBjrXLnYX4ZQiMP0eZiVGL7gCbGABzFnn5P+o+EG/XVxmgPEmMS/htVH5AATuJAQBv0XnSKppUWoDimwi8W1MHqi3M5MN2JudAy5r9x0CYTjPry0N42WGDL0XPOmC7UbHACm1KVq6LFnTqIfTQH8ZJksRFm2qmUpmU5CjNynWNTtcTogbApvyCW4p2SlFJPuLtSTh6jUIZMc4/8crfLlGWOX2udI1XXPTmDNUaxPZWOwaKVafrl2U0k5vvnuRG70RUZ+tPLkvkaJhKuPdWJ4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQo+x7eVMN2sW7ouzj7ITCaUyCtbvI/NEYeJ5n06KTE=; b=al968tz91cVItoOgn+7xBRlgxmjAG+sEY4+XCyioCWuUpxzVH3hx4KtHnR6+BinwFnxGQL0+nJ0aJ1vhK8CNRGJNUxQ3QdVlJW2aPafgKKLnjrmi9QqN2wVuPCNSxL3SaLkfn9pq4awaSWw2k3om8lyQr6NW+Uk1nCg38nqg+IA= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB0014.namprd11.prod.outlook.com (2603:10b6:301:64::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Sat, 14 Nov 2020 23:34:46 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710%8]) with mapi id 15.20.3564.028; Sat, 14 Nov 2020 23:34:46 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Chiu, Chasel" , Liming Gao Subject: Re: [Patch V6 1/3] MinPlatformPkg: Add PCDs for Serial Terminal feature Thread-Topic: [Patch V6 1/3] MinPlatformPkg: Add PCDs for Serial Terminal feature Thread-Index: AQHWuKAIS76oic3QrEm83yL5+21kR6nIS9VA Date: Sat, 14 Nov 2020 23:34:45 +0000 Message-ID: References: <20201112030031.1481-1-heng.luo@intel.com> In-Reply-To: <20201112030031.1481-1-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 59b66618-d29f-44b8-cfe4-08d888f5dee6 x-ms-traffictypediagnostic: MWHPR11MB0014: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:972; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8YEI7vk44tKhywABL+oJYuJ7FYWeMhCTUggd0KpBoy0NlPJubSccWqB9h6P/ydhZyUeiGm8xAgbHeTOqxJnm8rXm523GGfk06rSzDbShFxvTSl6zu2dihSlHdfJppHHX7wakkjAZhPbLURBFStc1KZVb285k6Gzx2GDn5CmJ3ZgHbaHnVIukWbloWQBj+9YF3+RDq1YW4G5+uhickQkscVlGgu8ePzZd3lVttD8e5uCDPip3DjUYswZsZAIB9N+xXlRvXLwDr6gISITy0LmvrG0bLa1jlI69iTN5mfPgAVckozYXRa80aGruH6auNjLCbbL8qbHq7gfbY7fRwZ/i6ZM1d3szGytdHVdepE8DjBhJ/HvxWEuHPMcDUTS0ZLA+lJMtYcdW/WmSo4ChEVpdBA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(376002)(39860400002)(136003)(346002)(8936002)(9686003)(52536014)(55016002)(86362001)(316002)(76116006)(8676002)(5660300002)(66946007)(64756008)(66446008)(71200400001)(4326008)(66556008)(66476007)(83380400001)(7696005)(19627235002)(54906003)(2906002)(110136005)(6506007)(53546011)(966005)(478600001)(33656002)(26005)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: m3anyInZ/NPtjkLKJHgud8IcBSKntOicXHn4z+mJj0I3hCZXCagEfKN/kqmeoPbAjVl2gozxhg6nfrdL9GasfmdCyLyM92Gl4Nwdb6A80NJva/S5mlz4wqhjrvfVIdC+3iGoHtXx/ShZR4c2V7wbBgzD5bg5nBZJvNTnnyMqVYWOFB8RjE7fy7Pk1GTHj2M8Enhu1DJyHzGWHcyErvgdpvR/u9sn01xrttLASa2ncN7syFzsCzY7gJN3i84wkxc9Sb+iIKnnGK6kQrbBicKnmRp1Arc3yjqA8lg8d0JEYT1il2VXivlX6dk+fvtTA6vilem7mvxP2zIhBgz9PKmovAZlHt5pE09339akUb/eBf8Oe3jRfgA6FD026Bffc5DBRhNL1JLzeI6bIUPkmc3Mwyfqm7tU/Wsf5zdVQBQlFISqgyBgZUFPZhZdW64T3WLqU0QY1InQQzvnAlxpm/8f8JpUPlUdKT9B8pZz7o8dpZRZDNe/DRcLxPhiYEl4M301131j1aChwNHhZbYn0WB/wWhF8uue3RriFU7GzUQJHW/ENXrRBJXa0bqDzc1417E57rLGWHZjPWo9aaN+C6nRu/RKiBFW3baCa2X5QegUDKpVqvH2u7ra9LFLQeqcSyGRaVTr4fdwzJJjolyu8+zMA1OyvSHaTS8wEJokUXr0QMzUSE6M5Im13N5M5FMXwUcL0atIJ0eDG8AzE+Qlmk6wv2qGUGP2fykQRWuqlTZC7JKNLG8Q5rPvsxUWDXsN8wtmVQWJHM/dAvsEG+iHXLeYkrqeZBelkKstxbqUVmVbrTx9/EPXPMb3qD+UtG7TW6owhknYlwg9YpUo/+FhAYsOx3ZBfnGOFtBS7rzP9n3cJHKGybpjmsMFRez906GJcziXoGYBVCt2TErHeIiYDpemLg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59b66618-d29f-44b8-cfe4-08d888f5dee6 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2020 23:34:45.3791 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZURJAkb0GFT7JpRJfLClvqm/13V5YOrFUtnZ1atf947O56Z2Erw5+tbuXrE3PpIFcNi3dmljjEB3RNm2yDEx7mTq33NHNaHd9jWcdFfyJX4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0014 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone On 11/11/20, 7:00 PM, Luo, Heng wrote: >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3014 >=20 > Add PcdSerialTerminalEnable to enable/disable Serial Terminal feature, th= is > feature supports console redirect after the shell is loaded. >=20 > Cc: Eric Dong > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Heng Luo > --- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 + > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index 7ef189dac8..2a831f2669 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -318,3 +318,4 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable > |FALSE|BOOLEAN|0xF00000A5 > gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE|BOOL > EAN|0xF00000A6 gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable > |FALSE|BOOLEAN|0xF00000A7+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable > |FALSE|BOOLEAN|0xF00000B0diff --git > a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index 112ddff7d9..d0b5593817 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -1,7 +1,7 @@ > ## @file # Platform description. #-# Copyright (c) 2017 - 2019, Intel > Corporation. All rights reserved.
+# Copyright (c) 2017 - 2020, Intel > Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2- > Clause-Patent #@@ -44,6 +44,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE > ########################################################## > ###################### #-- > 2.24.0.windows.2