From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.33473.1628838265269846560 for ; Fri, 13 Aug 2021 00:04:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=atVO5ACp; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="195102120" X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="195102120" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 00:04:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="528253418" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 13 Aug 2021 00:04:24 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 00:04:23 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 13 Aug 2021 00:04:23 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 13 Aug 2021 00:04:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BFZo5hZpf89sY1OhzvbPSNGuJNH7XdxIJ3wLv01yhLj0qsijL0dh9GJ5B/q68rBWUx0Am9Bkp3HPjj3ODfjIAup7s67M2mJ+OXv/WL/1z/v2KRlNwdGpazww8PqViVueiIlSZz3vYgZJL9kYsnlnGFUDAavIlmNblosRN/PAwz/PWgoOakYSUjHIRijTYvoOsz5jy/FuoFDOq+6HRNjDYBR6Dqe9rO65BVN+zPYNZ5Pz3uOxV2Ul9opdOloN5otSQ6pRe+AEklRc4VJS0B0Mn7ZDcbn4hLYc2dLNtNoAfJM9mSSPCX7MYkFiqSUCZlsaPsgdHITuoEif5s7GHBjlMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0XQQD6BYAVdcQp5QYNEYcVqdLVXtV8Wptb/FZ/j+dus=; b=n/DCULhqrI07vNPMbN514vTNISpSSqsHaZ312Idwa85OJisouDtKU2lQa6pXN/5OaaW8hQnVaxittfZBUsm14DvhuSBrh4URDUgbcXst8cOHb83T7uGWwr4TjRaBmIeVtPIlYxZm5lvu1iupBEd5Gmk9nvEehAvwGsTf2x0hCapqLO9g2RCgXasRkW0qMDpx4e9SRLLNQFUBXbgZFbZsnchP34r1p8yUW1apobfwr9tfnGFWHKplD1Z0X4ZI4O0kHGH1MvTx+IX/t/JmJSrB6u4Sp5ZpSqhFJtbXt0B9MHximoHJ/GO4OV/MDKCCYv3CxJO6z0GJ1XIwI3+thq0TIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0XQQD6BYAVdcQp5QYNEYcVqdLVXtV8Wptb/FZ/j+dus=; b=atVO5ACpDo0h/DX8258F9WQyiLfoRs+wMjHNR9Wm6AvX5qwMTpxbe2e1tWX3+FyhTQGxf/nGVn5cPUCi7RBRGA744Hh3kSynm88tq4DYkJ4MVOfmRPAOlB1IzSkwbbSlmueoyXe85OdosEeU+C33aNfNhffry0CmuLK0JYr8WgY= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR1101MB2093.namprd11.prod.outlook.com (2603:10b6:301:50::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Fri, 13 Aug 2021 07:04:08 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4415.016; Fri, 13 Aug 2021 07:04:08 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "benjamin.doron00@gmail.com" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile Thread-Index: AQHXiWs63HbFscZPE0KamtNcfGL2L6txD/gQ Date: Fri, 13 Aug 2021 07:04:08 +0000 Message-ID: References: <20210804195900.6373-1-benjamin.doron00@gmail.com> <20210804195900.6373-3-benjamin.doron00@gmail.com> In-Reply-To: <20210804195900.6373-3-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: db2acbec-ce8f-44d8-b944-08d95e288be0 x-ms-traffictypediagnostic: MWHPR1101MB2093: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Th7ZCvUj5dcktV+zbucnlZPXCx6qqaOq2LxcU6E9lTbp69WT1UhjMfQ4D2hPf328g0RGOHCRnDc1MsNSKw5HPTHSyAOcVQjtAtGSXN4MaO4nkIxAzkyLNih4EIq/iKWZKVmi6GV77YXJ10cbObN3w+EKc7o0+E1beCZLUxrK+pPrw5eidt0eG+YcnmxvQqgrkE+Oy88YVRfdbvc+5iRyNNMofSsjF5FgTWIOfwrulLF0e1r5D39LHmLY8XaFj4QordaGlXAdIyFxBmhqnksvJ4aXjVytoFApGpk5Zi881jCeZm/iLGkd6Xc9tP6EK9eQsBsrwOVzo8xKRiC/DWnu3EnMejAVvt9mUPfj/K1ZHBmI5hpAIdkBJawEYbq/RcTbg7LuxGbI6wTatEmE85JbqnVN9pwvUzmYOqp8Xw+zZKv5oNvmWBgSd31Pb2iZJw+hwIp0i2IaE08z/P+GApcRILQWIR1uXJo69PNbjOkSbmpRcvuRS0RQ7/iyyvjTt9WcMabflLplBcBlkWnnmC2Q6WubaTn30El1eOZtEerCZ1XlbsucN68L8GmJVTAC/Wh6ISmp0A3e8/lCs8do6LbNppT0bVsjVIFkxPfNyBiTLV/OU18yivtdLLsT3CRfXSJi+bQL2CdtusHYiVjkMmetPDZM1SJssQsVfKVUcZuBrrIZ6JcVBPo86bmNwUNoCeeaB+fu9LwcE+l7vt8uzDrjPi1BXE8me1bTeYsNYu+rwWxgbZURNuaZ0+q4ZJql2yRewHWLhWkCkPqeIilDTil+m/dG9EvJpuJbmt1xFREPxen+nFR5fGCEOMfNJV3APvIUWL1un4rPWEGQU5WPJwQs9k6ysiOGmVEo1XYvP5UP5CA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(54906003)(71200400001)(110136005)(186003)(26005)(76116006)(83380400001)(19627235002)(2906002)(4326008)(55016002)(8936002)(38070700005)(53546011)(52536014)(9686003)(66946007)(107886003)(122000001)(66556008)(38100700002)(8676002)(66476007)(966005)(6506007)(86362001)(64756008)(7696005)(316002)(33656002)(5660300002)(478600001)(66446008)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?deQgtZl7Zvfga6veLV3lIw/bhP4VVtPNkCNZuo7RUvRrwv2pHOfR9RehatQJ?= =?us-ascii?Q?iqcAr1Y2mK/fvxYChAeAmRF+LWytOWM2BPyXXOtOrRFgA/8L/Ql1JDvdu9px?= =?us-ascii?Q?/FWtEPs1+sO1fL6pZq8xb0CzJIOWRf8PM10ftnx2yiWt8+hsuJuXmc5Qp/To?= =?us-ascii?Q?faHvRKHlHdQKMeM+2xvLLBFlnR3JbnDfEVzjvEuoP7pzweNKT0B1nKQOFVyJ?= =?us-ascii?Q?emZ8II3nqqsvFwD7FTAgYq6FcAUh2gfaeh8/8irqvssc6XmNes/+0bNF8GXe?= =?us-ascii?Q?wZDcqKYlUj0UiYmIqApPQwgHm7DCdbYd/sW4NbguPw78wDk9lGklRHHYtXbe?= =?us-ascii?Q?UPFtuaSMUnkdYSVOw2QEJHlrc8djIgLs0+sA89TfopbKaNODjwLm3wfad/yR?= =?us-ascii?Q?qRp1AL4pn3s6TwWkYZkGr1CDcWu/awyUZzEBA/Qs2j1AGLj/LkepLOJyC5O1?= =?us-ascii?Q?3DDtxmSUnQXe2OSlDdb+EFI/ZyA9/TuSgsvXcrGaDgpIdaKpluAmnW9/GfY+?= =?us-ascii?Q?Jos2wotZJC4alRjwGIve++9xHGH+i5MBnsN2UiSTv/QMtkPjvhjxZ7VWi7WZ?= =?us-ascii?Q?I20v1vh3k7Z0tS3zAaY84N4C2iibBBS+gd/LJF5U4C6iPXRb1Pr7DEK3umPd?= =?us-ascii?Q?JmKDhqeUhAArPqdcrdPG4xHKXgYHQQAEi6uh0yfVJ7tb/P0tyo6OI2nrw7RY?= =?us-ascii?Q?RNpgGxMcxBASfM+a8WRS/f0kLHYx7Zem4nYMziD1uerMYmpfxqf85RnMtBJx?= =?us-ascii?Q?V6xX1rXgWsa1fGTIrmzTHcv7H3MKAtC+UCQZjhMe2KISh0mLRWZX5UU74wuA?= =?us-ascii?Q?yyuZAlGUhZzqZwZaSM35BSHR/J68ARIcKvBQ4Zp1x83I0mM/1lQuWjcNGfRd?= =?us-ascii?Q?gDKdp6LZ0k+9Tu8IJ9IzCv9GR9xImxHBbJWJGnqszpjyyFIXeKz2RPP/I7NN?= =?us-ascii?Q?ruhCP/EyTtDCXksddM1n6y71oC4YvxUNwaoXBJFkOUmpJ2wmvM9Q3COTLKtu?= =?us-ascii?Q?J+HVvTyXXbmAPIVxyEgY8PP+qJ0h2It0H3sJ5GWSgjsLW6lWxiJ14EZaPjZ4?= =?us-ascii?Q?oRDc+mOlVkTvSN8zn0s+90U0iD1TEWcwcE/oGMKt6N/ZBWqNTBbzXLH6TgP5?= =?us-ascii?Q?Ym+JzIFFrOix3gKawPnVB5Q/1qAkF8JkfvusWgKXGUtonKHdd4SQxPnYepOY?= =?us-ascii?Q?IjXhaC1Vu3MLWIcOyn9t1u4JrTsTVvOrlg6CG5bGbJOOv0A2/vnhduzrw8qw?= =?us-ascii?Q?DbiH6UdpdahyKyQf3ehwRB6lLUpfZ0BnColTmeUEOaVvD4Ib//0fuL51rNO4?= =?us-ascii?Q?ouEMcYJXzr3dDfRlboNlOkFB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db2acbec-ce8f-44d8-b944-08d95e288be0 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2021 07:04:08.6409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1Z/RL+uEnkLe5hnhuX+9febxT5ANWJ8/UZ9W3ZAh6SZMU0UdxpxfNmd11MSHfaEjMamJjbq8DgdHk4SoMydiZg720Mtw2mMVH0ZyHDbhgsM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2093 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Benjamin, It would be good to add a check on the status code returned from PublishAcp= iTablesFromFv() to the debug log. Something like this: Status =3D PublishAcpiTablesFromFv (&gEfiCallerIdGuid); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCa= llerIdGuid, Status)); } Status =3D PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); if (EFI_ERROR (Status)) { DEBUG (( DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", PcdGetPtr (PcdAcpiTableStorageFile), Status )); } I know the original code doesn't do it, but I imagine this will be helpful = to some poor soul who is trying to debug issues with this later on. Thanks, Nate -----Original Message----- From: devel@edk2.groups.io On Behalf Of Benjamin Dor= on Sent: Wednesday, August 4, 2021 12:59 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: M= inDsdt also installs all PcdAcpiTableStorageFile Follow AcpiPlatformDxe (from which this module is derived) and install all = ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platfor= m/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc222453857..417cccc18b5a 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -227,6 +227,7 @@ InstallMinDsdt ( Status =3D PublishAcpiTablesFromFv (&gEfiCallerIdGuid); ASSERT_EFI_ER= ROR (Status);+ PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile= )); return EFI_SUCCESS; }diff --git a/Platform/Intel/MinPlatformPkg/Ac= pi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt= .inf index 3437bc489cd3..3e14c4e9a65d 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf @@ -41,6 +41,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTok= enSpaceGuid.PcdPciReservedMemLimit + gEfiMdeModulePkgTokenSpaceGuid.PcdAcp= iTableStorageFile+ [Depex] gEfiAcpiTableProtocolGuid AND gEfi= FirmwareVolume2ProtocolGuid--=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78665): https://edk2.groups.io/g/devel/message/78665 Mute This Topic: https://groups.io/mt/84670596/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@int= el.com] -=3D-=3D-=3D-=3D-=3D-=3D