From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com []) by mx.groups.io with SMTP id smtpd.web09.201.1603838209122050805 for ; Tue, 27 Oct 2020 15:36:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lzC7wUTT; spf=fail (domain: intel.com, ip: , mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: beFrASHZDxMC2JwjV3i3Ya3Dlw0uzSKcyLtUqpyVynU1kJhHDZLkT5pJC73OZMyZ33otsIWxRk x/kspIh4J7/A== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="155141512" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="155141512" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 15:36:50 -0700 IronPort-SDR: WdzuzHN90UtNTklV6Gdqg34zb/h07+5ZWD8bW1Lf12OObyka5dC3sbb4iNkjSrvzEopomm5PCp 6eYmwnboXj0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="535983266" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga005.jf.intel.com with ESMTP; 27 Oct 2020 15:36:50 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 15:36:50 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 15:36:49 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Oct 2020 15:36:49 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 27 Oct 2020 15:36:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S0oFEMLRuuOy1Luz/GGVRfd93u9en3djFRCWmje/MNfz/tLjOnkn7+DA/1sZkdoab+zrFUzF5z2Vxlia0I+gaPUaGXSjUAgwmWhKlZTIg1Lua4UMdbMYbslPqxc44W7XeJYyooBIHszfMrP/Fet0+XXW35FsJDhto/OeihqH9IH4JMHQBRF02rdn6taRAiqtlbFrXW3ARwz+rCuMkV0sLa/+M5WYwuCy4vg7/t2pTMO+xFdteCz830iqsjIoEnPpF1DCpThi8qgL7WV4BIWwcgfaQ9h8GnRKY/FeEso6D20a2ZEHv+NIDmJBneB0JmMVCD+5+DXHY1X8rWl/d1XUQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8+zDmVmWPbiVZKAuFS/mc+bk4GCZ6Epzy1IeSstLW4g=; b=JUU5Lg7uv68CaJRXu7xaiDPFpQ8PkevkgGH+jWKTWOIbuS4nU12uyfZIgKKxFRjK5lqRCorUx3estAzGvcp4Bk71/E+6QKOPnCQC/tAIRFvf047kmIKsC2dOdFKg85FS1lyLJeSOhQVxn4O730mnJ38jvsOwKssQtYne0aXT0zgGOYswmX1HSyG/Z5I2LpUxYR49Ws6VfK6flIda3EuvGFiNd6CrFStgltN0yVNFc89L3ANubWDnZsiDxQzhyVlWjPLLTvKZdlNY3t2xBJSZ4GafQcoOdiHzvg51J7mrnIxQ9zJ4lRIcGvK663BXhK1TQrkaAv7Y3hW8mwsW6eeXGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8+zDmVmWPbiVZKAuFS/mc+bk4GCZ6Epzy1IeSstLW4g=; b=lzC7wUTTGfv/v9KiD0jjjEmH+q+FHspV5xftz9BusRSecQs1LYyD2OznftNR09hXuDEzVwTf0ZGtb5rTZoviMlUwBdZhJ9lRB46z4TOZprpMIFF7172cIt3rbKCyVI7TuflN2yTSOuZePDe6xIO+lRtnkvH4C2H4OuTXnzYW0H4= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.27; Tue, 27 Oct 2020 22:36:48 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::75c9:81e9:2646:791c]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::75c9:81e9:2646:791c%4]) with mapi id 15.20.3477.029; Tue, 27 Oct 2020 22:36:48 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Chiu, Chasel" , Michael Kubacki Subject: Re: [Patch V2 2/2] UpXtreme: console redirect after the shell is loaded Thread-Topic: [Patch V2 2/2] UpXtreme: console redirect after the shell is loaded Thread-Index: AQHWqRR8kHrSRKu8ZEyzm+5Zxj0NxqmsD/uQ Date: Tue, 27 Oct 2020 22:36:48 +0000 Message-ID: References: <20201023081356.5167-1-heng.luo@intel.com> <20201023081356.5167-2-heng.luo@intel.com> In-Reply-To: <20201023081356.5167-2-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjk4ODdiODktYzEzZi00NjUzLTk0NzMtOWRlM2YyOTMwNWNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOWYyZXY5c1ZzRnZwcGtsU29GOEJ4TEF4Vk45bjA1bVB6OWo4a2RqNDZWeWJtMFBsNVN0bDZlc2pRVHdSUFdGNSJ9 dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2e351205-68f4-45ee-6542-08d87ac8ca83 x-ms-traffictypediagnostic: MWHPR11MB1805: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mqj7o1OntftjTAr09nOICzP5wTFTfe7Ak4h5Rfhg6Ijp9xbBg0wvQxrxKhYhh1TePZUscgCHN+dsYY+buU66dGup1k8l3bAo+x4TQZ9OzduOTVHMt309DCoSXnDW1BgB+zTM18v3/op3+VRtEtpXBvreHgoprdGmxJL1z2xeeHKJuGxlowg+gEqQFCBlnyqngFkCDBpy9Zne0yElnGUrrCA+3lw3bsodrtG67k+VK2eM47bVl7MWzNzlSGdSg5lcIfOHXLknuIeBRJd3jp0X1elfdOwSraPC3i5imWQZ9WNinO39pvXYonc9/HYZNq8Aja28AdAp84lVWdM/HMXvD7ErrnNKeAwF2y6oLcN5xJaM1bacTM2yJIBqXGZDilbakZ5A+kfcuTsr7Zxwo/IoCQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(376002)(396003)(39860400002)(136003)(346002)(966005)(316002)(478600001)(83380400001)(4326008)(110136005)(2906002)(33656002)(9686003)(54906003)(66446008)(55016002)(8676002)(7696005)(71200400001)(5660300002)(86362001)(64756008)(52536014)(66946007)(6506007)(66556008)(186003)(66476007)(53546011)(76116006)(26005)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: nQXVg2xd7kiNJU3tr4uw1CqL0133JmUzDlVBMSxUY4mVVa/BKsXerKW3rEkJiMjm6S+sSrTDjJ5Ls3+Tre6lptQXhpHOdif/wwh920LpMdNfFyncK1WAR9W2XJPz+pSTzEUpdZF/ruPMq3LidiSpMu8RYJo1jEXgK7laUJzrFJVX41pXzgKucKq9QXIMo3fdNcPW65OC/VEFtmE+7cqM+40yYghIlZTf3jxBoXY3MwNA1Q8FojTIaP7nLNUjzCrvzD5HYCAavKivQphgpejvcrfPi4cK1w3+16lasAvnVChB4kfcUog/dYVNpP9+h4D3v7Wp7kBdVidanS6ofB1nLpeuilNErCEPROD8cPlWsSk5fS/XXI2Mi2sHzgwQvWv3umOHrsjUj9Wud8ualHVj3gJEL50SpwAmEvOTKjoFE5n2FtMaFW1M5BFU1lO6KGKW5UCxJIfv+piXPOw/WUs+8bGq3EBiwiNxoRQdQnWW7oH1ZNqVZ5E6JTE7WbwVemi4cAUGw+fjhiFa5XxVcAo+JZvPjxcysQ0eVUwqNHNdtG5K9cJB1WGTXrb3I/cIj08KwXUObypHofX93YDRE0NXtvGjB/F5ppzBB/j9KyNGml0upemJnuB5Om736+xHTfivnLCjlCGSUBFVDxWPI3sc2A== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e351205-68f4-45ee-6542-08d87ac8ca83 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 22:36:48.1572 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MeFAyfVj82QyUIgyZqVF0+dLoDX6pxyiZYmsz1qXrkTpbO0VZxDHk22oEUNfXrbK5IlKsOrEOTpD9yMrN4puIkJ2fERLQoM+GtGY9BZIR7Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1805 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey Heng, Please see feedback inline. On 10/23/20, 1:14 AM, Luo, Heng wrote: >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3014 >=20 > Use SerialPortTerminalLib to get console redirect after the shell is > loaded: > 1. Add SerialPortTerminalLib to BdsDxe driver, to add the serial device t= o > ConIn and ConOut variables > 2. Include SerialDxe and TerminalDxe to the Up Xtreme's OpenBoardPkg.dsc > and OpenBoardPkg.fdf >=20 > Cc: Eric Dong > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Heng Luo > --- > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 9 +++= +++++- > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf | 2 ++ > 2 files changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg= .dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > index fb493973e2..4c472cf9ee 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > @@ -39,7 +39,8 @@ > # > # Include PCD configuration for this board. > # > - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > + > !include OpenBoardPkgPcd.dsc > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > =20 > @@ -82,6 +83,12 @@ > [Components.X64] > !include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc > !include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc > +MdeModulePkg/Universal/BdsDxe/BdsDxe.inf{ > + > + NULL|SerialDebugFeaturePkg/Library/SerialPortTerminalLib/SerialPortTer= minalLib.inf Should only be included if PcdSerialTerminalFeatureEnable =3D=3D TRUE > +} > +MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > +MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf > =20 > ####################################### > # Build Option Includes > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg= .fdf b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf > index 0d99114961..e15cb7dfa9 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf > @@ -342,6 +342,8 @@ INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBri= dgeDxe.inf > INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > +INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > +INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf It would be better to put this into Features/Intel/Debugging/SerialTerminal= FeaturePkg/Include/PostMemory.fdf Then you don't need to modify the .fdf file for every BoardPkg to enable th= is advanced feature. > INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.= inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > --=20 > 2.24.0.windows.2 Thanks, Nate