From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.27661.1628536709641536844 for ; Mon, 09 Aug 2021 12:18:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ydl7uIik; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="214747121" X-IronPort-AV: E=Sophos;i="5.84,308,1620716400"; d="scan'208";a="214747121" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 12:18:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,308,1620716400"; d="scan'208";a="421571283" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 09 Aug 2021 12:18:28 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 12:18:27 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 12:18:27 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 9 Aug 2021 12:18:27 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 9 Aug 2021 12:18:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gkh8ST3aDvPIYeiNjb+uj+4Y/KeEZkjfYrFxOEL4QNNmF9yOOXYkuNdfFvvi9NkbTgbvq903PLj2AKbXpKutYSmNBFn6giZX/o8jJgLqfyHx+sa+tmXCO5voWFTf704ZR5s8ElgjY9AfFVLsXx9qDOnT6iBkO6GJt9PGYc6lgr49BP+v6q67/4JKW70FhdQP9isOBrCpVAx7uWEigsf+pXNVLABV+LU6nm4YMXcSWath12xuEDyZ0S4hIzWB2UP7Rwe5DhoBmUQgImWu2NrhrdtE/93pEAo+JQvUX+ncvKNxYhDDpZGJRVGkxia6H59HEQKnEIo2kKJhZDo34RztNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FSa6Pu1ynpaVrfk05X/sRv/nBHbgzaE4ThsFUgBLspU=; b=RNA3imo87GD4ZNO13M/X8HiVC332445zl/ymHLFDLjPI+vHhVShq610rN3JMrvN3smIHRmkN4w8O54lanoCnPfX/4/Jo/JJQEDer5yKdYFXfruAhjUkYOQe+/UdZDRPpytwy1eknvTvjfdNyiRFmHTHB7jOj1W1f8LYmz92dpA8WILftGnLgFRe0z1C+yIoLBbyvXAfH23GBBCYHdDBbTcvfZqYh9Cj7m9bNDc2vr0mYdIipPp+zLEhFEr8kNMEYFSLQmPc9qDsDtsYAG8M1wrNPgS357oyrJv7Bb+pzmGZsjxRjWT42nRtL3JxFHR06U5ItmpxoTE6OdtSEY+EhVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FSa6Pu1ynpaVrfk05X/sRv/nBHbgzaE4ThsFUgBLspU=; b=ydl7uIik4VRl66c93wyumDIDqzMdEf+jA/eY7Ru6+CwkdqUZ1g839suUPtRMPKYezvAogm3nwDJTxvChOc6U7iR+nwhH0WRmVpl2XbvkOfPadTp5B513nB8pAUvsu+M9KipsfmKxZYFTi+eSpXUgpydHmLXt2Wlr1VL/vdovl10= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR1101MB2333.namprd11.prod.outlook.com (2603:10b6:300:70::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Mon, 9 Aug 2021 19:18:25 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4394.023; Mon, 9 Aug 2021 19:18:25 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-platforms][PATCH v2 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements Thread-Topic: [edk2-platforms][PATCH v2 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements Thread-Index: AQHXimMLxOhaiXzYm0qM8TvuettB/KtrkcgQ Date: Mon, 9 Aug 2021 19:18:25 +0000 Message-ID: References: <20210806013250.2928-1-mikuback@linux.microsoft.com> In-Reply-To: <20210806013250.2928-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 325fc11c-80f1-4578-d55f-08d95b6a7655 x-ms-traffictypediagnostic: MWHPR1101MB2333: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w2v1yt5tr2W6Cg3P0SJCRYU4wyEGqA2qpNqAiiqKLyrHqRGsrFHdx4z8t/8/AcIkn7kOykiDS6Pax3ezmzS7MvqB4ysVqqJYGvalj2Kqzdk6ijJ6r8WZNjwNkUhEDYHm2sJellRKyeNhpliPYEGdmazOvY2UmrFnvJfgK6wGWRlEO3A+kwAbS2+f2T8obix9U/veNYv/r6i2fyKSde4TZsdTl+f5VrvGm88oHNim+xRXLUcwxq5ak72QKMedfG/1u2Jr72/aviRGd8D0via5k+xcVkO8Yi4PemhA1Wujpg5uevGJVmJ5UJHd66ydFIwiAV59OSdt650xi0lEEzUeHixQq6vgNKXIh46hII/g+DEqHZ0ojNt+LPPetT1qXwlHoo8fJCWHe90lBvK+JGZpgC2TGavS+z5yjQqt1o4zSGKTXKD5iy8T2BaV6LWMyDOJK9OEHXzN7ifG+k3S8jlIgsrQtbGmny2iPpFvjicVc8d+wwG2f/56E+fTWu2Gyzb5IiPYjCIDDhVZXyLUDcDOq7RuLCg/gVUrWrPjPoDWzNLLp7Ix3JgoE01D0kyM0lZFprApGj3feBjyun1Z2jsHtHTLzFaIcDwmzUFOYlsU/DA27YACc9s/uKMdwD1MQ61qweIbX7jB9XW0sl55QtPPQwOwaY2E+DDeV8flY8Lm8qJXK4e+Ez9pl5O6236HcCxEy+MtWENTv2sVQMJJ67C4m49qgmmyEpN4h1HWMIh2ZVpG+aq2E2IVdBdeBBXgaIuF35cd4qg5/3fbC3WIBdDGYEOmjAaCyUzddy3A6aHEEvi2e8/o58T5DCHK5aQWibXLR+cH15x1h2SVHbaUeXxL7g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(26005)(4326008)(478600001)(316002)(2906002)(52536014)(38070700005)(5660300002)(38100700002)(66476007)(66946007)(66446008)(66556008)(64756008)(55016002)(7696005)(122000001)(76116006)(186003)(8936002)(9686003)(71200400001)(33656002)(107886003)(83380400001)(6506007)(53546011)(86362001)(8676002)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eoEwg/12SI0ihEylnwYEbwc5CQxMsBdGvGDwzRsn13HIiTyqXF7maMrHyXdv?= =?us-ascii?Q?YG6mabZCu6L9QxZJeWwk8wLI785r+uPav7Dcr5rxwFeAFmGyyZ9Es01uquuB?= =?us-ascii?Q?c+tdvfrXONPa9Owaz2N5szHEkgXSr447lYLN5+x5RYxfHC5CP9jGYGIkx1py?= =?us-ascii?Q?Rojy5S3QGjyq2YiCrAtC93otxvHSK5+kNNDePAYQJi/w0wPbrzcIIKtiJfJ7?= =?us-ascii?Q?+Acn/LHtt59NwQnOv3nALJVNpbXPPIxQpo69JrvBJ0AR3/oppE0x7xFryZFA?= =?us-ascii?Q?A+LBZIdLBFqgjQh3qZD4wXtAL+2SOT1O22aiM9lLs+gimJ0XLRZ9aarlzndN?= =?us-ascii?Q?ucFUViEbd+mLTBd3pB8kIeyl9X1IGmDhJwgYxm73KIaqTdyV+Be9najmN4vQ?= =?us-ascii?Q?qDdqBVeBTFJFYr+8ZpoS9gZXlCNAq6IHsTnYyokmMN5Po+LeDnzQ8oCMdfXu?= =?us-ascii?Q?qQN/qZbDb6oZ3syFBx6O0L7zb37Hu8/Ii/hbsS8K5wntgXW3hNadeCukFG3e?= =?us-ascii?Q?ZyehMm4vAM3mrdJuqwTm8DW2QtchwLFXgVxcVdXAI/jeMJ31zzb1u36xbVpe?= =?us-ascii?Q?ObCp3ernY46usj00BEtHZ7a7bfghSDhd0EHauTfNqmBf5knZcVuF7MqA/PIn?= =?us-ascii?Q?IA81uCwd+ZWjahitldio+gYsSIsPktU8Puwsx3JZN38UtOuqZGpyp29bOlvl?= =?us-ascii?Q?hTrUb5tHuHuDsbDECUoFqpLO0LCpfi2Llg4ktrn2tpKXdt5Y+lfZcpc80hKa?= =?us-ascii?Q?BHp/DfxEJW8Hjd6XWdbOGzz0JXspXmb+2PJrFDgSjhTuvzR+0VF+me1H2CXi?= =?us-ascii?Q?pXUUn7JYQVocqXXOSrU77x75tsqtJ35jix8VoYSafTDlOVxZlpGTmoXckS/d?= =?us-ascii?Q?8MBNsGvp+zYwTOSSZlJBoKDpDdIVteJoe0bSnQ+4PgOwQUIQa9knU/Ktbk4v?= =?us-ascii?Q?DPeo0UjeNEstLkNeBoAdWPOai9hbbzL97VyWqt/MqZck4iHSSQ16Qf1bLyzA?= =?us-ascii?Q?clu17VzjEuNBS+vVkKlLo8ONib0gsJkhk7JkF1UFTvqCGAvmVhS261rZgTgM?= =?us-ascii?Q?btOXSGQm84qRV8paT+7+Vd8jzLypzPdjIM6Y8ktMAeZpQTyzL5FV/+FPELyb?= =?us-ascii?Q?1IjE1gGnTOrjVzOmmJRiaZeCSPDNaUeTUyq7mNoGmOTpLf6KkhxwlBVPGrHg?= =?us-ascii?Q?wdXv2ceYYxVAlUUQ6UsbJjTsh30PWuwJadtjewzq2lpgumJUzfHXcvjtbjhW?= =?us-ascii?Q?zSjMQy9960OFyR3t2+nCFXIzGYkJfB2c0vECqFjlZ1XnAjeL+5hlnuUzBcUc?= =?us-ascii?Q?BHY4SfQ9mOSwTAuaAzHnEzuC?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 325fc11c-80f1-4578-d55f-08d95b6a7655 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 19:18:25.8523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XtgQrJ+f9xy5G8Yb5ziDB+XfQcTu0G6sFGpBnxuspDuOW9ZeCc8wvoF/T/yT59bGyl/b83uoBrqBPaKSpTCXPXOFS6qlJyYpTYQHuYJrfyE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2333 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the series... Reviewed-by: Nate DeSimone > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, August 5, 2021 6:33 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v2 0/5] MinPlatformPkg: TestPointCheckLib > bug fixes and improvements >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3531 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3518 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3520 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3521 >=20 > This patch series groups together several bug fixes and improvements to > TestPointCheckLib. The first patch is required for the others since it fi= xes a > MinPlatformPkg build issue that occurs with the current edk2/master branc= h. >=20 > V2 changes: > 1. Added Reviewed-by replies received for v1 series 2. [v1 2/5]: Added a > ZeroMem() for the ProtocolCapability buffer 3. [v1 3/5]: Added a #define = for > the byte index 6 parameter >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki >=20 > Michael Kubacki (5): > MinPlatformPkg/TestPointCheckLib: Fix MessageLength cast issue > MinPlatformPkg/TestPointCheckLib: Set required size field in protocol > MinPlatformPkg/TestPointCheckLib: Fix incorrect array index > MinPlatformPkg/TestPointCheckLib: Improve adjacent region checking > MinPlatformPkg/TestPointCheckLib: Make OutTable parameter optional >=20 >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA > cpi.c | 32 +++++------ >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS > miHandlerInstrument.c | 4 +- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS > mmInfo.c | 56 ++++++++++---------- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckTc > gTrustedBoot.c | 3 ++ >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.c | 15 +++++- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo > intCheckLib.c | 26 +++++---- > Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.c > | 10 ++-- > Platform/Intel/MinPlatformPkg/Include/Library/TestPointCheckLib.h > | 1 + >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.inf | 2 + > 9 files changed, 87 insertions(+), 62 deletions(-) >=20 > -- > 2.28.0.windows.1