From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Cc: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
"Pandya, Puja" <puja.pandya@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>,
"Bjorge, Erik C" <erik.c.bjorge@intel.com>
Subject: Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Prevent environment variables from causing install failures
Date: Sat, 19 Dec 2020 01:01:38 +0000 [thread overview]
Message-ID: <MWHPR1101MB2160A5236BDEB56407B997F0CDC20@MWHPR1101MB2160.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1651B62A411DB85B.25702@groups.io>
Pushed: https://github.com/tianocore/edk2-staging/commit/b5d45cf
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Thursday, December 17, 2020 8:47 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>;
> Agyeman, Prince <prince.agyeman@intel.com>; Bjorge, Erik C
> <erik.c.bjorge@intel.com>
> Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Prevent
> environment variables from causing install failures
>
> If the following two environment variables in the global system scope:
>
> PIP_INDEX_URL
> PIP_TARGET
>
> It will breaks the EdkRepo installer's ability to place files into the Python site-
> packages directory. To workaround this, the installer should temporarily
> delete those environment variables.
>
> Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> edkrepo_installer/EdkRepoInstaller/InstallWorker.cs | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
> b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
> index 679b4f4..0dadbbf 100644
> --- a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
> +++ b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
> @@ -576,6 +576,8 @@ namespace TianoCore.EdkRepoInstaller
> Action ReportFailure = new Action(delegate () { FailureReported =
> true; });
> Environment.SetEnvironmentVariable("PYTHONHOME", null);
> Environment.SetEnvironmentVariable("PYTHONPATH", null);
> + Environment.SetEnvironmentVariable("PIP_INDEX_URL", null);
> + Environment.SetEnvironmentVariable("PIP_TARGET", null);
> if (VendorCustomizer.Instance != null)
> {
> VendorCustomizer.Instance.WriteToInstallLog = new
> Action<string>(InstallLogger.Log);
> --
> 2.27.0.windows.1
>
>
>
>
>
next parent reply other threads:[~2020-12-19 1:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1651B62A411DB85B.25702@groups.io>
2020-12-19 1:01 ` Nate DeSimone [this message]
2020-12-18 4:46 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Prevent environment variables from causing install failures Nate DeSimone
2020-12-18 16:59 ` [edk2-devel] " Bjorge, Erik C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1101MB2160A5236BDEB56407B997F0CDC20@MWHPR1101MB2160.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox