public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch V2] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib
@ 2021-08-09 14:59 duntan
  2021-08-09 20:01 ` Nate DeSimone
  2021-08-10  0:42 ` Chiu, Chasel
  0 siblings, 2 replies; 3+ messages in thread
From: duntan @ 2021-08-09 14:59 UTC (permalink / raw)
  To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong, DunTan

V1: The newly created lib will be consumed by SecureBootConfigDxe.inf in CoreDxeInclude.dsc
V2: Add SecureBootVariableProvisionLib in CoreDxeInclude.dsc

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: DunTan <dun.tan@intel.com>
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index b154f9615d..c3d05fc913 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -139,6 +139,8 @@
 
 !if gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable == TRUE
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
+  SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
+  SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
 !endif
 
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
-- 
2.31.1.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Patch V2] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib
  2021-08-09 14:59 [Patch V2] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib duntan
@ 2021-08-09 20:01 ` Nate DeSimone
  2021-08-10  0:42 ` Chiu, Chasel
  1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2021-08-09 20:01 UTC (permalink / raw)
  To: Tan, Dun, devel@edk2.groups.io; +Cc: Chiu, Chasel, Liming Gao, Dong, Eric

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Monday, August 9, 2021 8:00 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>; Tan, Dun
> <dun.tan@intel.com>
> Subject: [Patch V2] MinPlatformPkg: Fix the incompatible change about
> SecureBootVariableLib
> 
> V1: The newly created lib will be consumed by SecureBootConfigDxe.inf in
> CoreDxeInclude.dsc
> V2: Add SecureBootVariableProvisionLib in CoreDxeInclude.dsc
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: DunTan <dun.tan@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> index b154f9615d..c3d05fc913 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> @@ -139,6 +139,8 @@
> 
>  !if gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable == TRUE
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> +
> + SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/Secure
> + BootVariableLib.inf
> + SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableP
> + rovisionLib/SecureBootVariableProvisionLib.inf
>  !endif
> 
>    SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> --
> 2.31.1.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch V2] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib
  2021-08-09 14:59 [Patch V2] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib duntan
  2021-08-09 20:01 ` Nate DeSimone
@ 2021-08-10  0:42 ` Chiu, Chasel
  1 sibling, 0 replies; 3+ messages in thread
From: Chiu, Chasel @ 2021-08-10  0:42 UTC (permalink / raw)
  To: Tan, Dun, devel@edk2.groups.io
  Cc: Desimone, Nathaniel L, Liming Gao, Dong, Eric


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Monday, August 9, 2021 11:00 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>; Tan, Dun <dun.tan@intel.com>
> Subject: [Patch V2] MinPlatformPkg: Fix the incompatible change about
> SecureBootVariableLib
> 
> V1: The newly created lib will be consumed by SecureBootConfigDxe.inf in
> CoreDxeInclude.dsc
> V2: Add SecureBootVariableProvisionLib in CoreDxeInclude.dsc
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: DunTan <dun.tan@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> index b154f9615d..c3d05fc913 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> @@ -139,6 +139,8 @@
> 
>  !if gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable == TRUE
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> +
> + SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/Secure
> + BootVariableLib.inf
> + SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableP
> + rovisionLib/SecureBootVariableProvisionLib.inf
>  !endif
> 
>    SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> --
> 2.31.1.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-10  0:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-09 14:59 [Patch V2] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib duntan
2021-08-09 20:01 ` Nate DeSimone
2021-08-10  0:42 ` Chiu, Chasel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox