From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.3944.1591821188758363808 for ; Wed, 10 Jun 2020 13:33:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=RxaEucz6; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: eLN8zsqkBfBhHmjXW2hDSP25EqZJNVd9Qama/Rx7r/uz9+sWy90bapTa/KJroo5c7tMk0neApm nIWBq0pf1uSg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 13:33:08 -0700 IronPort-SDR: 4Y+hOed1wfnVaX+V4bExyHTC9GGjXFo9Acp0ikHztQs1Xzl94s0ylCUMyT7upRKn/RBlBqh9Pq pRDuf98q0OnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,497,1583222400"; d="scan'208";a="260509859" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 10 Jun 2020 13:33:08 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 13:33:08 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 13:33:07 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 13:33:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P/EfdSwM/LTFXf8C56I4VfgJFnSDIqw3EIzFqA5Cyxyo19Y9oaMdNTNr8QyL9CBVe2MhU0Ctld/OGYRESBj953+39mLM7BBN/dq1BUuBnsxhPQzgJGgUmL8hHjpbI6Zgssh3dfHT01LFCJktzJVdUv04JtPgGz7YnmfIpFSA1yv8KVM477M6jTX8ebva4f4196E8gCICHUtLmrpYhcl6FEwDufHPoqerNYY25nJsBZeBIJox9A94LE+PkcNA+52O3zJ5Le8lPV1GUl+wGwW4nHMEsw7iECkhlHEHWl0W8N3UFwsHS0Cy0ea0J83EZXtEfwsJeWxKoPPa4KOplAiV6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4BR8505v9NcmCQN+Pyo3A4rVVAz34769w0n+2Kyc2V8=; b=X9iCYCAWSehtiiEDuapEilZNdgP8+5jeOYNHsbApKolZkLzNWCxpgILZbQ9Y7+qzUsY2pPf4oy7UegdG+QVeuGSK/+ccgQk4FiszwuDfrUGYqtusCArABFLnZFVNU2XKRVVafSsbxtto4Ql8gcVfW9OmNfm3M23TXd7Df0K0hyHhml8SCA/tlu68p0XgaMYKpPXLLNyekFRKj4Eci05ZUZTzNoniAwVkhiaMNZOz+6KwmrI2sONbWusTbdHIuzYBRm8ILXhLVrvE2I9NzfBNrqAshBOAR1CmANPGoBXNzDZDzpcdj5SvuYgigwdyNqCBs1E02qK/i8lI4w/v1PrAMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4BR8505v9NcmCQN+Pyo3A4rVVAz34769w0n+2Kyc2V8=; b=RxaEucz6Grine2Riy8V88Xo9OEWFrl00WWc/iSqYWy/noaX7s/4U+Mlo1b4rzFqa2uzNkAkrdxTyD4tA8/j+rdU5Tqoaw5Hpj0GmPHRUdY3LW1isXn4Z+iM0VCuUSe1e48X0Pt8oHMPjjVrDQV1hEZ+7KfDBZNffVJPjd5Nv9x0= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR1101MB2158.namprd11.prod.outlook.com (2603:10b6:301:59::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Wed, 10 Jun 2020 20:33:05 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::889c:c0bd:5262:7c80]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::889c:c0bd:5262:7c80%8]) with mapi id 15.20.3088.018; Wed, 10 Jun 2020 20:33:05 +0000 From: "Nate DeSimone" To: "Tan, Ming" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: Change some PCDs type Thread-Topic: [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: Change some PCDs type Thread-Index: AQHWPlCOMvBAWJuTeEa7WbYGuFwIk6jST/dQ Date: Wed, 10 Jun 2020 20:33:05 +0000 Message-ID: References: <20200609112353.20824-1-ming.tan@intel.com> <20200609112353.20824-8-ming.tan@intel.com> In-Reply-To: <20200609112353.20824-8-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTk2ZWU2ODgtYThkOC00MTFmLTk5YjAtYjc3YWY0NTIyMmIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS3NRWWVDN2dnQ0NnY3ZwNDJlSWVzc1dyaG45RWRhRFlUajBpTHZVOThobFFzSXJCS2kyeWZDTDg0MzArZmlCKyJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4bfb6484-ebe0-4735-5a7a-08d80d7d7aec x-ms-traffictypediagnostic: MWHPR1101MB2158: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-forefront-prvs: 0430FA5CB7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A60BOR79oqKiNZXz37iSSzIGjiI9y7SSWJkg7HDF9pZwesTVvAtJ2v39cl81R5ZDSZtgy+XMaAmcNEsUl4ZlGdVYL0F87ec7v4klLfmAGbzc0WzPzzSNeStENfP6kFf2NOLUm6o/Iz5t4mLchYRGJiiWLMuXx4wlIRwobh8pw38h+C3ITOZU1kEnGF2N5ERkH4D9pOIgSBYze1TWcsU+ZgApLZqe0DpWRDnvb813JvzF2RDPElFflIYvyrENGeuqy5HeG7t8dhhDW8w8uQlbagThl7ruBji+VxVtj7d+XVHOgaiw2FEZDd6GvLcduRS8+Hq3VE2XvUS0XxSgYzciqQUde9rRBsP46Ih8T1v1Gj6IxNI4BdWYBx1Uj4fCQuE1Fb5t197h3EAFtt/MKKrJ7Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(376002)(346002)(39860400002)(366004)(396003)(19627235002)(86362001)(53546011)(107886003)(4326008)(26005)(2906002)(33656002)(186003)(6506007)(8676002)(55016002)(7696005)(66556008)(66446008)(71200400001)(83380400001)(8936002)(76116006)(66946007)(478600001)(110136005)(9686003)(66476007)(64756008)(966005)(52536014)(316002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: vxKXVaA/PrE/LtKIpEf6xakUu5hwMsCx0qJv7V3Kjobt4Qcydei3GZoDZykLpYyHt81EOWe1BBJX+JXGULy8gC9GYFWMWFCxu85BrImfyhG7mnHrqeu+awXGipaTjh5jlqS7wfXrZDPXMrRujZ1DnFeJYVgDF0CTEq5lU9Vl3EwUNLHIOxRpBAr/9Vuk1Q8Oq/n/EP33pt6yrWoUS27Rssqdqrnu9Jgt27XTNEppBHqRysOf1i2tfQ0b/Tv1Q+ESt/+h3HvB4VcRAhBh68JKjs6XYW0AQW730T46fXQucYmAM9OCHhkMxDQqwICl+KkOxqLo3fKSL+8Q7kTGVArvTZWMPH1kVgC7KeAh75wmBtg8w96F9aCazsRpqAoU/tiYQ1263pqHWg/Q7xo7ahyG8DKiCXe3CGrs+3kRRDzRy7yppABRMExUP/HaqBxur2c2t6ou2cq1hy0e901eugrwv6MzgJL7ztCPJ4pCPj7VfP0= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4bfb6484-ebe0-4735-5a7a-08d80d7d7aec X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 20:33:05.5329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oX7ylQVcPIc3u7vK+/P+y/adIb7iWPslI8yoUAlmbAC3ko8q14HCcoV6MDncUIbuk00S8BKBtu9OU8v1kmztScIYQi39330/1JQqi7sj3jU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2158 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Tan, Ming =20 Sent: Tuesday, June 9, 2020 4:24 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: Change some PCDs = type REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2791 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeM= odulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedA= tBuild in dsc files. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Ming Tan --- .../GalagoPro3/OpenBoardPkgPcd.dsc | 14 +++++++------- .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 14 +++++++------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd= .dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc index 7393897249..352416a489 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc @@ -1,7 +1,7 @@ ## @file # PCD configuration build description file for the GalagoPro3 bo= ard. #-# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# = Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
# # = SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -69,12 +69,6 @@ # Edk2 Configuration ###################################### gEfiMdeM= odulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSectionFirst|FALSE- gE= fiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE-!if $(TARGET) =3D= =3D RELEASE- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!= else- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE-!endif = gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE gUefiCpuPkgTok= enSpaceGuid.PcdCpuSmmProfileEnable|FALSE gEfiMdeModulePkgTokenSpaceGuid.P= cdInstallAcpiSdtProtocol|TRUE@@ -206,6 +200,12 @@ !if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHa= rdwareFlowControl|FALSE !endif+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCo= deUseMemory|FALSE+!if $(TARGET) =3D=3D RELEASE+ gEfiMdeModulePkgTokenSpace= Guid.PcdStatusCodeUseSerial|FALSE+!else+ gEfiMdeModulePkgTokenSpaceGuid.Pc= dStatusCodeUseSerial|TRUE+!endif gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIo= BarEnableMask|0x80 gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoPciBarRegisterO= ffset|0x40diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Ope= nBoardPkgPcd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoa= rdPkgPcd.dsc index 916b5189fe..9e8b148753 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d +++ sc @@ -1,7 +1,7 @@ ## @file # PCD configuration build description file for the KabylakeRvp3 = board. #-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserve= d.
+# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.=
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -107,12 +107,6 @@ # Edk2 Configuration ###################################### gEfiMdeM= odulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSectionFirst|FALSE- gE= fiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE-!if $(TARGET) =3D= =3D RELEASE- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!= else- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE-!endif = gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE gUefiCpuPkgTok= enSpaceGuid.PcdCpuSmmProfileEnable|FALSE gEfiMdeModulePkgTokenSpaceGuid.P= cdInstallAcpiSdtProtocol|TRUE@@ -244,6 +238,12 @@ !if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHa= rdwareFlowControl|FALSE !endif+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCo= deUseMemory|FALSE+!if $(TARGET) =3D=3D RELEASE+ gEfiMdeModulePkgTokenSpace= Guid.PcdStatusCodeUseSerial|FALSE+!else+ gEfiMdeModulePkgTokenSpaceGuid.Pc= dStatusCodeUseSerial|TRUE+!endif gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIo= BarEnableMask|0x80 gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoPciBarRegisterO= ffset|0x40--=20 2.24.0.windows.2