public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Michael Kubacki" <michael.kubacki@microsoft.com>,
	"Oram, Isaac W" <isaac.w.oram@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib
Date: Thu, 13 May 2021 21:26:38 +0000	[thread overview]
Message-ID: <MWHPR1101MB2160C7888C47A6426A17AE02CD519@MWHPR1101MB2160.namprd11.prod.outlook.com> (raw)
In-Reply-To: <167636B28070B26A.12361@groups.io>

Pushed: https://github.com/tianocore/edk2-platforms/commit/65f5eda

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Thursday, April 15, 2021 7:47 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>; Michael Kubacki <michael.kubacki@microsoft.com>; Oram, Isaac W <isaac.w.oram@intel.com>
Subject: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib

With all the refactoring done during code review, I misplaced the MAX_VARIABLE_NAME_PAD_SIZE macro. This patch adds it back.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../Library/BaseLargeVariableLib/LargeVariableCommon.h     | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
index b6554764b7..d6db9f6c66 100644
--- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
+++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVa
+++ riableCommon.h
@@ -44,4 +44,11 @@
 //
 #define MAX_VARIABLE_SPLIT_DIGITS   6
 
+//
+// On some architectures (Ex. Itanium) there a requirement to // 
+maintain DWORD alignment of the variable data. Hence the // maximum 
+possible padding size is 3.
+//
+#define MAX_VARIABLE_NAME_PAD_SIZE  3
+
 #endif  // _LARGE_VARIABLE_COMMON_H_
--
2.27.0.windows.1







       reply	other threads:[~2021-05-13 21:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167636B28070B26A.12361@groups.io>
2021-05-13 21:26 ` Nate DeSimone [this message]
2021-04-16  2:47 [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib Nate DeSimone
2021-04-16  3:07 ` [edk2-devel] " Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR1101MB2160C7888C47A6426A17AE02CD519@MWHPR1101MB2160.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox