From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.560.1620941202898019748 for ; Thu, 13 May 2021 14:26:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KLLSzdSZ; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: EOgIU9OaL2+w8kG8YL9fg6WlV+5SVIhYaZGeoy1TFV27zM7XOSZ0cQ4vspsHqHlLINh7RKeuxY rwmGm1iwd29A== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="198096679" X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="198096679" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 14:26:41 -0700 IronPort-SDR: g2X1WVzTWxZy5UCoIb/achJo4PgeN9PdGvLYgY0jPuKXkzpuUTFGxJ4Mqc9jpMxITrqIwFlIR0 xv+gl7AWrbLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="437807050" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 13 May 2021 14:26:41 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 13 May 2021 14:26:41 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 13 May 2021 14:26:40 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 13 May 2021 14:26:40 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 13 May 2021 14:26:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KmPKVbmVXw6iw8OVGRgj6n/C+/oaVU2tgdOFdfaWxXiUPW968TCBsMdBo50dj/RZrDk3rnSMgmnCCEvVJkv5eE3bXjhOiEVgCdy1D/zFI9jKKEJTLAb6pbn3VDumUpjZgFX49Q2HNQbc4ra/0qq2whfx0rk41JVgU1XW9tZkkzrjEvGyIbudne/jcSS3KyPv6/5KSZk0JYEx/4QM2rd1UPF+7+gmvC2DSSSPRm0GOcClVFyXh3h3tgKD9W5ZUvTE7OrdsSmtqcmARZgHd+v5afVbG75vQd6Ln3xq/dTw+Z7b1PVn/n40zK+eqeZxWOOU3dqEtgASLegB+Q3N2KVavw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hadjf336ANe9uHB+udGljQDKUY1NXBEkpuUubzz5ghQ=; b=mLP5dvdk3xbQgEzfkdWWU52Js1bA5+gPHwOSsJUToCJD3A9Jih/8ekHeigFFfPeTP20OXRN7vcddBk6TcyeumM62H+4ccdKSeBUuQZ6vmgn9v7fv9Je8Y8gAgZIWAYyGEVbxlI7gpM71b/AeEE6B0jETs8DVKg2Ezs1FpOjLaeOwTXoNVdmhcJ9YApyx18Vyo8bNVvBtTlbGNcUqd54V45uYR5RvA6cyO4jrihg/HrbUakkd8UFXJN4OHvkLgINQrFi5IMFubnutMOgbFTeBnmfp0olSr0aCykmqoru/jjVumj0f1rXW5ON6gBgKrY616AeHJ9G5PuSTrRiTwf/X4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hadjf336ANe9uHB+udGljQDKUY1NXBEkpuUubzz5ghQ=; b=KLLSzdSZYnQlzeJRfoEbxxpog5aFHW9s2Z94zqzCR1hqudW6KL9E0kg0gpe4oKcWvVnoLMOYLUubYxsmb7P7N9e3SvsI/Usz93PZ/4OQRdewpojG47w5onKtISKDzF4CVR9HH7DgSLJyxz0XeJjFDnI8HWgPBRtbXCqqT/WJEO0= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1293.namprd11.prod.outlook.com (2603:10b6:300:1e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Thu, 13 May 2021 21:26:38 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::6540:bca7:645a:6788]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::6540:bca7:645a:6788%5]) with mapi id 15.20.4108.032; Thu, 13 May 2021 21:26:38 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Desimone, Nathaniel L" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" , "Michael Kubacki" , "Oram, Isaac W" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib Thread-Index: AQHXMmrjAUCsNCV55EyeamTCQk5ScqriGF8w Date: Thu, 13 May 2021 21:26:38 +0000 Message-ID: References: <167636B28070B26A.12361@groups.io> In-Reply-To: <167636B28070B26A.12361@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bec4bf90-65d0-4a5b-ab1a-08d91655cb3e x-ms-traffictypediagnostic: MWHPR11MB1293: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:549; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1Wnl/Wa7XwYoi0PckB9qK+FxxwQ+fqiGGjT/cczU1WfrV3zAUoPluZ8MTDW9t+Omf0nmNTzIp225z2W4BjVNmy9a39Xu5AaEG/JgML3osYDeH1yqRxlfyCXvxF4pbahR2sBuZj1Ax5owdDuBc4GgRIzQtk3AiZC6KgQSiURxH5pWF+4DuHFap0jW00fxv7dxkpsZbVm24ST+CP5Efkd/zIYLFCugg0m92biqfx9nZiGCJB+MJGKbvQ63VVj2YQUrFIlhhnTxTWoTHm5vV5LHWhoZwGnnp5h1tFtWhRfjBaVnP9P6MWUfRLeCdttTEpBp6aUahVCRrMbK2Zl6Z09w5+mkQkMgdZFzkv/GRedh+Gjvqnuc1iDrZ9D9FR3ayJn7wSOH3X3BUWefrhA/gFHAb1Qes4QDqvL70URIRoAfnLjAqK9iqb9/Z0e/ZoG5OOeAXWAqDPLQW8rJBk3XLoQWdA3L1V+0hq4ekkCyjmlJ6DS8abPAvnu1V0wwc/JPdTfxERlKCamv6pP6ibiaDx2ZEErRtBQTivON1bu7/QAmHY0QtXxPLbrtU5/wx0JY6QpnqSsKVg4LONrPfUj6WdPWGpBifBq+xFuWKgueIeoOOLkJmVEHBZDIAVeBpd8SnCOrrVux+XYuFXfzblr7pK1Oh7Br/gr57U6SnwnM6LQAOFMYeGrmsKLVlWQ1WpqHkNk6WxdauCl41I5+f3vs1OJR8LE9FUdtFJDuobOCw79HKYc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(966005)(107886003)(5660300002)(186003)(38100700002)(53546011)(6506007)(9686003)(498600001)(86362001)(26005)(8676002)(4326008)(66446008)(66476007)(110136005)(54906003)(55016002)(64756008)(83380400001)(76116006)(7696005)(33656002)(71200400001)(66946007)(66556008)(52536014)(8936002)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?BWlQU0g/qP/Ew0GpmvTukk44NQMJjss5ihtDEVnyhIDO/X3RepzNMy0lf7Vj?= =?us-ascii?Q?8W9r3NLfS2RdMYBtLJfJpiIgNIsMrgJMoadlfV8yvfu3Z/Jrmm29NWL6cR+D?= =?us-ascii?Q?rvvIAdeWUTGuN6lF+saYRpRIMQhoMbsCKNwD9DIBj2e+awN69xtOVUzagDml?= =?us-ascii?Q?8LXRBaXmbGZ3N2DzAiiOikRgMeyUPp3lEUQwO4bIzUxXwFh33o7D6y8k156K?= =?us-ascii?Q?Fwza+AcVhOrzkhw32nc3zk9QEdOI1rtb5UvKaPDP4DmjOZkAQ7j6WOvEYAHL?= =?us-ascii?Q?zS9NYihEFhP6j4eYXklBAWFJtscNdUp80+RFybzWlf7huz51CSIIN9FmjCUx?= =?us-ascii?Q?gPYTrUpKI2KwhViAMPucBxq4ITz8mXLwqyiCFFzWNanvNiXTwGv4SljS6tyy?= =?us-ascii?Q?oXuwmwFDlMMdi3PGrLhnObf7y347o/DkgrN7JHaDc9HK4ofnA9Z4g2KxJba3?= =?us-ascii?Q?n0tcYu7iUH/FidklUWqi+cObMKpeM0/Brzt8RiCL2UIaiBMWkl+7p4TaCI/p?= =?us-ascii?Q?fgFkkRSDHCuquwmcyCHSV3IxtgLyJEWefWRI4qDQeNuDej0dzh2hS7nzIQt4?= =?us-ascii?Q?Grxe7MM521f+H8l7+uX2XTfoFv7g0/QEWHTHdS8wYu4lxWq7VpWi5qQ8Nu/b?= =?us-ascii?Q?JgPiSakobiya6uU6ssbMEQedDc4GC4sI9PVUhDt0EDePldZO+uunxjj1C3fZ?= =?us-ascii?Q?Te/zYOj/HuArrLbuQNZluDNvHhNoo1QKXOdwWsHteneqVT0hZhoZjaND2ysH?= =?us-ascii?Q?POY/j6ZL5mPDqDuGwfLQ0t9MJpre3V6wj8f/BAuspLbHXf0gu0HOf3MNOjv3?= =?us-ascii?Q?pLCSOJYpnugGKfE9cB2u9FhwwjyPww7Tww1xyN1XahZ/yiyYs84C7+wdIwTS?= =?us-ascii?Q?fHvssplgjqg5rAkpxKhdp5DuQ00pZ8PoeMetjczHUXTQSYHHnWtCkInfQs+7?= =?us-ascii?Q?uSlX/2WZntGtsDC1Mreb2lcCOXSzd/sLnW4+X4MihucV/AdavVMCndQ3LE/m?= =?us-ascii?Q?z7dGnrMEqQKBc+EPZzCB054UbxfzIJSBDDZYGKIpdD3y0xl+dizSdYKfHqqg?= =?us-ascii?Q?v5hKVt3q9tgeFYMlmcgjaz7lmm90yni+p3T6dMIGFmAgQikUc7Sv1kTiccn3?= =?us-ascii?Q?Sd6yZq7fA3GEkqaWfe6HXQ5shuum1/aCBrp3sElfBHTN93oxLTWTH5AGbrgZ?= =?us-ascii?Q?/E08JLcISZd99uKmXoxu1ZnR+xoVnbmMk0x2MiKPK8fQO1Q9NaWex6j4Eti8?= =?us-ascii?Q?vMkgSSPVPe5CoHAXcdGV/icOCkwTtz5fwbkUxU3HWE0KiZ486IdUW0mBZo2c?= =?us-ascii?Q?PLzq8/beZJlz/PCy9fYxk2jR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bec4bf90-65d0-4a5b-ab1a-08d91655cb3e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2021 21:26:38.6159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fqlbYU48gLND+iirCuzrYrSTtJmhCCJu8Q86j876STrlSpisMaqSDkWU+cWvSzvLipcbPOwsKmqdarLtU0qYzSkoxVkEa5buoApd8PQ+66A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1293 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/65f5eda -----Original Message----- From: devel@edk2.groups.io On Behalf Of Nate DeSimo= ne Sent: Thursday, April 15, 2021 7:47 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Liming Gao ; Dong, Eric ; Michael Kubacki ; Oram, Isaac W Subject: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add miss= ing macro for LargeVariableLib With all the refactoring done during code review, I misplaced the MAX_VARI= ABLE_NAME_PAD_SIZE macro. This patch adds it back. Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki Cc: Isaac Oram Signed-off-by: Nate DeSimone --- .../Library/BaseLargeVariableLib/LargeVariableCommon.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/La= rgeVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariab= leLib/LargeVariableCommon.h index b6554764b7..d6db9f6c66 100644 --- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVari= ableCommon.h +++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVa +++ riableCommon.h @@ -44,4 +44,11 @@ // #define MAX_VARIABLE_SPLIT_DIGITS 6 =20 +// +// On some architectures (Ex. Itanium) there a requirement to //=20 +maintain DWORD alignment of the variable data. Hence the // maximum=20 +possible padding size is 3. +// +#define MAX_VARIABLE_NAME_PAD_SIZE 3 + #endif // _LARGE_VARIABLE_COMMON_H_ -- 2.27.0.windows.1