* Re: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib
[not found] <167636B28070B26A.12361@groups.io>
@ 2021-05-13 21:26 ` Nate DeSimone
0 siblings, 0 replies; 2+ messages in thread
From: Nate DeSimone @ 2021-05-13 21:26 UTC (permalink / raw)
To: devel@edk2.groups.io, Desimone, Nathaniel L
Cc: Chiu, Chasel, Liming Gao, Dong, Eric, Michael Kubacki,
Oram, Isaac W
Pushed: https://github.com/tianocore/edk2-platforms/commit/65f5eda
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Thursday, April 15, 2021 7:47 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>; Michael Kubacki <michael.kubacki@microsoft.com>; Oram, Isaac W <isaac.w.oram@intel.com>
Subject: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib
With all the refactoring done during code review, I misplaced the MAX_VARIABLE_NAME_PAD_SIZE macro. This patch adds it back.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../Library/BaseLargeVariableLib/LargeVariableCommon.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
index b6554764b7..d6db9f6c66 100644
--- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
+++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVa
+++ riableCommon.h
@@ -44,4 +44,11 @@
//
#define MAX_VARIABLE_SPLIT_DIGITS 6
+//
+// On some architectures (Ex. Itanium) there a requirement to //
+maintain DWORD alignment of the variable data. Hence the // maximum
+possible padding size is 3.
+//
+#define MAX_VARIABLE_NAME_PAD_SIZE 3
+
#endif // _LARGE_VARIABLE_COMMON_H_
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib
@ 2021-04-16 2:47 Nate DeSimone
2021-04-16 3:07 ` [edk2-devel] " Michael Kubacki
0 siblings, 1 reply; 2+ messages in thread
From: Nate DeSimone @ 2021-04-16 2:47 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Liming Gao, Eric Dong, Michael Kubacki, Isaac Oram
With all the refactoring done during code review, I misplaced
the MAX_VARIABLE_NAME_PAD_SIZE macro. This patch adds it back.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../Library/BaseLargeVariableLib/LargeVariableCommon.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
index b6554764b7..d6db9f6c66 100644
--- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
+++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
@@ -44,4 +44,11 @@
//
#define MAX_VARIABLE_SPLIT_DIGITS 6
+//
+// On some architectures (Ex. Itanium) there a requirement to
+// maintain DWORD alignment of the variable data. Hence the
+// maximum possible padding size is 3.
+//
+#define MAX_VARIABLE_NAME_PAD_SIZE 3
+
#endif // _LARGE_VARIABLE_COMMON_H_
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib
2021-04-16 2:47 Nate DeSimone
@ 2021-04-16 3:07 ` Michael Kubacki
0 siblings, 0 replies; 2+ messages in thread
From: Michael Kubacki @ 2021-04-16 3:07 UTC (permalink / raw)
To: devel, nathaniel.l.desimone
Cc: Chasel Chiu, Liming Gao, Eric Dong, Michael Kubacki, Isaac Oram
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
On 4/15/2021 7:47 PM, Nate DeSimone wrote:
> With all the refactoring done during code review, I misplaced
> the MAX_VARIABLE_NAME_PAD_SIZE macro. This patch adds it back.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../Library/BaseLargeVariableLib/LargeVariableCommon.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> index b6554764b7..d6db9f6c66 100644
> --- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> +++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> @@ -44,4 +44,11 @@
> //
> #define MAX_VARIABLE_SPLIT_DIGITS 6
>
> +//
> +// On some architectures (Ex. Itanium) there a requirement to
> +// maintain DWORD alignment of the variable data. Hence the
> +// maximum possible padding size is 3.
> +//
> +#define MAX_VARIABLE_NAME_PAD_SIZE 3
> +
> #endif // _LARGE_VARIABLE_COMMON_H_
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-13 21:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <167636B28070B26A.12361@groups.io>
2021-05-13 21:26 ` [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib Nate DeSimone
2021-04-16 2:47 Nate DeSimone
2021-04-16 3:07 ` [edk2-devel] " Michael Kubacki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox