From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.27913.1628537196881850931 for ; Mon, 09 Aug 2021 12:26:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Y9Y7P9WX; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="211656050" X-IronPort-AV: E=Sophos;i="5.84,308,1620716400"; d="scan'208";a="211656050" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 12:26:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,308,1620716400"; d="scan'208";a="420954268" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 09 Aug 2021 12:26:35 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 12:26:35 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 9 Aug 2021 12:26:35 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 9 Aug 2021 12:26:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CzDUrGFw13lihB8IuCGq/Gg1+A/pC2rCCsLtsBfW7XoeLMfv6jyKpRXwmg0MgXcYBf0t+Rc/IjIvruXxJ1lg7WF478v1Y2coYn+Omg36Mn0IwV0lz36CXx5JgkiDlL3hwiKnF2IiKMmFyWwbEJxyAES8f6u0q/ccsNqVOgV/KPGaRI6Xf/m6LEJ7Lhcgzw4Vi3+BSBhfLzqOgnmuNuwmnZVENoNzXGcVdVhAWz55vbLGN+btZFVkSKeM44sxJ7zTpk6YtAhD9qlSY7YFXQ4uAz3kf31PBv+ktiguj6dQ+pZ+KlIkL95tQW4Ut+htzy5kmzQsQZnJLqKRtjkR/Ue8Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I2/qbFhkBKUPs4v0REnQEs8ku4qwlj86hW82rdfvb+g=; b=WFE59ReogNmvVgVa/n7gwp4sAf5cukmMaBfMWkf6MgSsA7iVeRkiiBL6TSi+R39ikZF8B8qIIYYWiQaz2U7dL5heZcyTdlJoS66HSvQiKzO60zSPIOYfON76Idi4z2xZI3WWv38gcbFdPUvYreDnx4c+VYMLu+zK3yHtu6VPTW1kKfOsVM2WyiwPmbaXjvwaYAGsLs4miHaPnaU8uuArlYZ98tuJAThBAdIjQ/GksMs9x6/AIIkN5ZnqC7rM6lPKYtFmClzTUKIBv1EI88r7DR3mPzzYHr8Mu5SedXvXtgU3pMizWkEfwzOykk4HUkpvsSJnNdmug4k4bXnAM+YDlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I2/qbFhkBKUPs4v0REnQEs8ku4qwlj86hW82rdfvb+g=; b=Y9Y7P9WXWe+umTAbaJAroYaTR2zpBbHPkNxZpjTJPWIumruTaI53HMqEIiO0q3buL0UxncQEJaCoDUL+jEtUKE0vdpMM4ks9f+KB6Xl2M96lDiE1igsfl3bc8lnfL/L5UF3FeqrG4mYo1+3XPDdU+jDYZZYgQsIpqykur2HGuBc= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB4900.namprd11.prod.outlook.com (2603:10b6:303:9e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.19; Mon, 9 Aug 2021 19:26:34 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4394.023; Mon, 9 Aug 2021 19:26:34 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-platforms][PATCH v2 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements Thread-Topic: [edk2-platforms][PATCH v2 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements Thread-Index: AQHXimMLxOhaiXzYm0qM8TvuettB/Ktrk9Ag Date: Mon, 9 Aug 2021 19:26:34 +0000 Message-ID: References: <20210806013250.2928-1-mikuback@linux.microsoft.com> In-Reply-To: <20210806013250.2928-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3414166e-b10d-4433-8a2e-08d95b6b9954 x-ms-traffictypediagnostic: CO1PR11MB4900: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3OFYC8NqR6W4a9km4WJyr2ruY45KN9LpqSIKquJPJM433BgX0z/XkVU9nJ7XETKMXJc/i8zkBzj7zpjt4qFNb7gJeIVrtWuw2jJo2ZvHJZZslCDAsHpjReM6n7GrWjTW0NiIbEARTthmxeK7u9DojTod4i55ENoKfT/kk+04/IRJ6ol1c2w6EFTVVToRvAVpPaYgW8BluxzoMYLYhRT6813BKVUgYwFa9rpoMUPRXtOVq4lGd0ZbCe97xh7jkjNuC+sKEBnaB/lEk8a9HqRI9XB+bcH4ZFl9BXv6DvJrJWkXcz0qXRQiVLoC4/uwdmEk3ORiSEiwTsnZewqhqZ6crbe8XtZVONREKkTjxU3Uf9w+OYoi+zToTayS2F1PhHNRkNU+R6AppRRNOz8illA5bBdwHxUbopBWIVICqQ3w+nS54/48Ewpn/Io7FWXzg4TJBPkgFN8YpnWDzqrxhoPI8bJ2s6Ak6+av/jqCKcVi3LJMQDdYAy1I75OPAwnXbyKLxogwWZvNFox1Vay56jYc8Sid0B7wTNhuHVpGD9AbOJds820foUxRBtvksKsH6c26NnMb6G9paBdkt72EUxl0P/kX8+8Oq6CYg+qEZ0RBrbb4qtYmy5Ic+NIGIcfeWLh25/Qly9MYLXYlyqkLamOXXis7pw7HHAfzgj3+YmyB0ZoW2dWU6rPnhL7iO8qqIRwy0Dw+KB3plNcUTY/0ztA20wKspyGl8r+glKbnDHRDUZBviOBzKugNEVGdJzgVtCgP3/9UmTV5+r8602JkeHCQ5yXHpPiRzOTXzzGOHxLcnuuQfr8atfIP6Ri2+RaDshLQxutsAX0r/s8Rv/ONq7A/nA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(9686003)(83380400001)(71200400001)(7696005)(55016002)(86362001)(66556008)(64756008)(66476007)(66946007)(76116006)(54906003)(66446008)(52536014)(186003)(107886003)(110136005)(38070700005)(122000001)(38100700002)(316002)(5660300002)(4326008)(2906002)(8676002)(8936002)(26005)(33656002)(478600001)(6506007)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+7WH+fE0MCACeEpRSVam7l2WWW7rJ1KWgZ5Pdjx+UfdgvKmb+PcxMfoBTSlU?= =?us-ascii?Q?ROLEAts/pWZpZRbe8/qKwQdhUjlQUclIMQCQl+ImIUmGbqiaygfvqwG/eHY5?= =?us-ascii?Q?2+RxO6nKkL5pR9bj8mtKaWxKevysyaXOkeeV2GvFOPOm6cYf73V9CPWSO++3?= =?us-ascii?Q?3IOnr1EF4qLazE1O458j9yq63KoST3Bk4OKZHUvjm+hQrNSRTDwnfH4tlpVZ?= =?us-ascii?Q?0NulpiOcGev1qsWip4i1GJIcS5dnzmFbi1uWf60KELRmUDOFHez4itmNdFIi?= =?us-ascii?Q?4yIqEjwwHOC9H5+5qmZaB7knBG4r/FxjSkqWC7PGyJXtto1eRwQ+pHrVmmtO?= =?us-ascii?Q?AER2Xs4CJGLyFBWHUv8eU+G1QDNLXbykrMlM7ZPh5TMtPOp7kODXb0fYN0UP?= =?us-ascii?Q?XVCqlisGlipx8iVhSwkz3RtUVpj37RCs0tDSPZlxk+iDiUvQAL2XKfi5gxox?= =?us-ascii?Q?luTtV/BAO9iixZqva6kLljArXjF3pDFVtrW2/Sjic2NCrx64brPAeKQPX8uU?= =?us-ascii?Q?g2JEBL48dLZrhDkB6CrxbYA3brfnot8YMKXZBNTih+P1mV8Q63X0+g32+l2N?= =?us-ascii?Q?i+t4tQiyrbwYWad7jaV9yg4Me0NjLYkFxN45y58WV2DYGGkv53oRY3IWao6y?= =?us-ascii?Q?lEbJv4Zsfb5oHnVDDMQNhW8C7ETafpyFqHFt4RFwHdKHoBUfy2WSvI8Q9if4?= =?us-ascii?Q?Na+Qe1SS2WPy7I2OGTNOFRbe+ZrVfwNYCbxJS8w1dQT0ZwLycNkhnQlj7QId?= =?us-ascii?Q?nzBueONMu+p6asJBebSTbv2qFwaWQwWe7rUJRyO49HwtlwuU4oeOb2hTpjyL?= =?us-ascii?Q?yN7owL927sOJeBvkcYJ84gLji4ziJPGABkWJGgu6s7E2C1VwzVz8ThdSQ2ax?= =?us-ascii?Q?cFGHiJB7tjxB0UTU+JxB4kgHcUJlWG2atvtzcedRjhKH7ph4jdOH5lWpU/3n?= =?us-ascii?Q?MzTQ+EBUNZkD2Wznq5N8L62mh4QeJ//4Z1d0hdAoC58Sk95jo+ZLkJ+Vbjrp?= =?us-ascii?Q?Rjwk7elELsWtShHdE1nWWIm2KxFDbb8M0i/xEYGybotrkELc6cyn6AH1i85R?= =?us-ascii?Q?Hvzs72e/2cCTj5P6LY2dz2NYlbO+0dxZRf3/gb6AVVWTvdHEW7Os47FkRqeP?= =?us-ascii?Q?84z9/5hRUb0xRtGswzAgiadf1ZgWKZLT5t1BTgZyEMtA5d/4P9MEEX1fO4sE?= =?us-ascii?Q?1Qw6o3Bj1lrL/tY0Q2FKFG7U9YRKbLxNCOQh/H6fEbvqYirBr7H3S8ApjLhX?= =?us-ascii?Q?fYVlGRO4obYGLK+dLk13MxVAPy3BDm0tVx90FtevvLZouvvYFOXfHm5awKLb?= =?us-ascii?Q?PmmpxCq0CQucenJXkZqXKTws?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3414166e-b10d-4433-8a2e-08d95b6b9954 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 19:26:34.0679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hNTFRsE6umogbUjDaWlAU6+Dnutqt0Dyray/H43NqWNP75nZ1dWLag1YPY3m6Cs4O4WEAuHEhEawma7c5IjhC1Ya3KR09wvlCzKfgqXOz84= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4900 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The series has been pushed as 5b257da~..89fb75a Thanks, Nate > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, August 5, 2021 6:33 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v2 0/5] MinPlatformPkg: TestPointCheckLib > bug fixes and improvements >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3531 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3518 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3520 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3521 >=20 > This patch series groups together several bug fixes and improvements to > TestPointCheckLib. The first patch is required for the others since it fi= xes a > MinPlatformPkg build issue that occurs with the current edk2/master branc= h. >=20 > V2 changes: > 1. Added Reviewed-by replies received for v1 series 2. [v1 2/5]: Added a > ZeroMem() for the ProtocolCapability buffer 3. [v1 3/5]: Added a #define = for > the byte index 6 parameter >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki >=20 > Michael Kubacki (5): > MinPlatformPkg/TestPointCheckLib: Fix MessageLength cast issue > MinPlatformPkg/TestPointCheckLib: Set required size field in protocol > MinPlatformPkg/TestPointCheckLib: Fix incorrect array index > MinPlatformPkg/TestPointCheckLib: Improve adjacent region checking > MinPlatformPkg/TestPointCheckLib: Make OutTable parameter optional >=20 >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA > cpi.c | 32 +++++------ >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS > miHandlerInstrument.c | 4 +- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS > mmInfo.c | 56 ++++++++++---------- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckTc > gTrustedBoot.c | 3 ++ >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.c | 15 +++++- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo > intCheckLib.c | 26 +++++---- > Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.c > | 10 ++-- > Platform/Intel/MinPlatformPkg/Include/Library/TestPointCheckLib.h > | 1 + >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.inf | 2 + > 9 files changed, 87 insertions(+), 62 deletions(-) >=20 > -- > 2.28.0.windows.1