From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.25565.1629946337732777054 for ; Wed, 25 Aug 2021 19:52:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qen4M9r2; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10087"; a="239846181" X-IronPort-AV: E=Sophos;i="5.84,352,1620716400"; d="scan'208";a="239846181" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2021 19:52:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,352,1620716400"; d="scan'208";a="426003520" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 25 Aug 2021 19:52:16 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 25 Aug 2021 19:52:15 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 25 Aug 2021 19:52:15 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 25 Aug 2021 19:52:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nvYay7yMvdKDHdACAmjhOzuze91cvEZ382WXKVp+dMTR3b+0WaTOgpkl6JInjT+mYyj7TQ/N2a81kPrmd9Qy80pp1qOgdAyXD2MX1FCsDMhyGS1HxbtVutxjrwy1817Q55XQsCSk1cnjVE7YXQq8bFRFiMf37CqJ/GtSinLGwz/Xu0KpThtE8WsrzRNp9zyjv1PbGrdneW/cmNkAkRtXpK918s+J54fRYWum2W5XJsGbbNIEPPMoq3nDrZD1zL/MY19eWvsBuI5k8IkrfLQGiNoYk3TTU4dvkihveT9hMgr13fXjbGSWp7Xu38Tno2uM3uKESF1hZmxJEp8Un5kWsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CohsQ72idE2Ux8xisIyOszyzVZGTfiCgxsRvwnbSLx8=; b=oFoNOC9yyPmsnFu/3x1iIRtYUVwIQoNj02FcH2y39anTppXEmsrohMkpd4AN9ZU8d05uW9GSSmBWWNbWcWKOfA8+T6vHFcsSOfuBIZD2k3ar+igY55+YqX6p7Pubf9wL0Xl2OMgl6BCo5p+ZkCW3rnt1qiOd7e09A04tFCe4U/NzElj5Dob+j6Dj6yeu96SO8XS8VxMrDoIxi23lLIT98xsm3fzCEGQSjmYUMQgniSdAGghLrfIM+rYOQskdKgBycTfZqomaQjKn+m4190FjWdxj6aeTL6lTAcfcnodsloYKOGIRC6scuteCavEb4t0l2HadBHr/lIjaw2Pn8/clwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CohsQ72idE2Ux8xisIyOszyzVZGTfiCgxsRvwnbSLx8=; b=qen4M9r2yeVzWwUumyJgbFDJsclilvYKjuD1T6LpbvYYrFzcN4vziRvMbyUpfvmkOzAhL6E2g5VWxXdrpVoZj/jZE3jicYDJKaaU519NtfKu4P2EQBJH64ebExl0MPX1/o/8uv5cRwXdMmiQ0kSgZhrnng8IdGeKsMp89dYB6Qk= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR1101MB2287.namprd11.prod.outlook.com (2603:10b6:301:4e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Thu, 26 Aug 2021 02:52:14 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::4421:2284:94aa:8d3a]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::4421:2284:94aa:8d3a%3]) with mapi id 15.20.4436.024; Thu, 26 Aug 2021 02:52:14 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "benjamin.doron00@gmail.com" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile Thread-Index: AQHXiWs63HbFscZPE0KamtNcfGL2L6uFNvHw Date: Thu, 26 Aug 2021 02:52:14 +0000 Message-ID: References: <20210804195900.6373-1-benjamin.doron00@gmail.com> <20210804195900.6373-3-benjamin.doron00@gmail.com> In-Reply-To: <20210804195900.6373-3-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1a86a0b-5d7b-4403-ec36-08d9683c824a x-ms-traffictypediagnostic: MWHPR1101MB2287: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OX7Lri8DNNzK+1jaAUlYueHbznywl1rzrz0dcbpN8h8FYFL56F6NLrIWnNF+jAGn1oeClL8WyeRl4BA2Ven1ROFlhX7ahorwHJAPPL7hEJ6CAJKCm/4Itc7LtBaRxdywiMuL7nCsAY0F5s8PDUdEGs8HeUNWtxz01NqoOhmxz5InFFUymFd006Ixwa/t7003DqWPidTdxVTUtN83GVjYUdqXZ5OsR5qSSWmzNsQSYTpPr/P3BpPiadhwZiqcZ6kabqUiHj9u0alsqIZCFT9CBktmXF7ImQjwNRHPcfsC2RC+NVVg8u7L4c9Mahyqp3hZcVvYChSYWU/A0oEf/CjYX6IDllnMRKbGlnPd6twsNg60Y4JWLPimP553DOp+6zNYoggiNf5a6yAtBsfxMl09iZ/LOpZmwfEBhUmHG83x3hl7XYSuOlA+Ceisg7Cym5C+B7X+cWWqn7xjt5hpbWFUtXSiXpK6zPO5JVElz81Jmwj9yy5hgiKXtKMxvvOtzEYcQxFNjKEVSLW2SSixdNfEdTPQsQ2keSj6Bwmx+xnfK71px1l1V7GG2HYfdryju7mzlJiqCtSB2xqx2F6SKjjUxxTWLhTfwMUSKjjHiWZ6ouqLON4x7nqaFIrjzp8pj1qNRiohZ2kq2HPIgc3xwp9YY1FqXx5vk1jyZFXrKHKVrCPmwB2WDB+bx6ngUXbe41yLIeJANEkIFge46nWGclhC4CZ4/VMq36A8XW+onGlqZIid3u/q/QpbtQK0KjOETi0XH31UUNBrs9uLrBwP8DUWOGTQfYEa5sz09N/hblAG7t4HoaaVoKSbFtac6kumfBWF8xm7dbtI26ToWi6jAeQPkDGANE92J67206rL/PAnwXY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(366004)(39860400002)(396003)(376002)(53546011)(52536014)(186003)(2906002)(6506007)(8676002)(55016002)(83380400001)(8936002)(26005)(478600001)(107886003)(5660300002)(9686003)(38100700002)(38070700005)(316002)(76116006)(54906003)(66946007)(110136005)(71200400001)(66476007)(122000001)(7696005)(64756008)(66446008)(66556008)(966005)(33656002)(19627235002)(86362001)(4326008)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yLPjVOhWZhQwaGI24OfggtX/pn8t7NWcZB31oiX9/9rmlx8kIpsQ7mfKodjR?= =?us-ascii?Q?cZ9NYOBwnsGTpPq0lBjZgsHbmLr/7Ffw6obelMeuq4LKX/don37c1zI5hABX?= =?us-ascii?Q?CzT2NKnGMYHaERT4+chbHAppcP6vISIMpWi9lvq8sR2X+63WNKaf1nCN9IeU?= =?us-ascii?Q?56J4sDsPD0MW4ti9s5jOKbBvrdxIJb7CsvayF+bFMgTk5johhLYRNOkkOlu8?= =?us-ascii?Q?Th8Ypr+/IZcyWDY6sVdvAZrxM8iHe6yxIH1+GocM5UBhB740rPPQeLc+ub+T?= =?us-ascii?Q?NoA29Ce0vF7ADguV9H73XW9LlnYdv3OT9rPA40geHVOnXrthHiIFm7HW+Kmx?= =?us-ascii?Q?CAP+cPX27y+Ahbfw9ls/uzhvqCPF4ItgcsDrl905BUu/qiNdh9/HDugCx1Tr?= =?us-ascii?Q?EH2kVaK1aul852edDeXC4F5pl/V+8+R314J0F++sgg8q2Y3rGLk2ubGY/UnW?= =?us-ascii?Q?l7H655aa7dBhX0HzUarOyxPszuLb09qkHnDBwxEhLsAbxevUxQfUs+H6ZP0y?= =?us-ascii?Q?E5arMDDShAHAysQcV9yyQUVxzCTBFyvvFhY+kUi9n5ZPQ0iMbLamSHTro5dt?= =?us-ascii?Q?NnWGcZdgHi/jnsLTCDXPA5jI9DJRf4f+CpwYxvxDblSS3BxYAPQsI72txUce?= =?us-ascii?Q?WN4G9usFUXgyiHCiESyp88ibEREptzAgbArUl3oa+PoB/QxX0dA7xRfpr2nP?= =?us-ascii?Q?ZEpM+WfceyPyfWkCpewvwMKnxMANojz6nIFUAX+p7U6+18Az4FH9FJZ309m9?= =?us-ascii?Q?hGGrZS98fDWuobFEN6Rw6F2wYCfQW9sCasm2jlF8aGimSoTVYet7IdPT/dPz?= =?us-ascii?Q?270uUCOOqxfzEwHPWVf+qjFbbd80o4hOI3Sseng4DD4d90zlIC4dnTNZqhju?= =?us-ascii?Q?LS9Fy8dR6QP9icfleMKh5N7L281TGKbmL7cXxOsh4MOLlYEu98FhHwforB2U?= =?us-ascii?Q?y8YOViZnKwIuHjmxW16+RaeueDN5Ye0uwdBszG5yGCCqEXNhfB2W8rXuSeup?= =?us-ascii?Q?ZYH8dnK5TYX71JjI1jA8PlQPc9D0Pfxh7Nhnh6l2ehmLVHmuCmnJ6ImoGgTK?= =?us-ascii?Q?QuLk8JRPa/l5Ukvvy6XApCbM/8XJqPcz7Fzno69i+NuDlrXUtm6+2QD3ylv/?= =?us-ascii?Q?UbdiX7w5odwywmOPh60CUjFTTZxOsYAJPMdbRHhHhoeuWdsywxp/O2mFxNDw?= =?us-ascii?Q?mKoQLtuFKmoeEGc4AzNwtljLYDPa3/RzIf4POezzb11a5g18dAbNbpgUB4lg?= =?us-ascii?Q?I4/YL5aik0gn1fZYxZtjH8G+ebPSaGMnJPY64AP5StuhnocZ/EuWad9XGOqy?= =?us-ascii?Q?Ubw6/co69LCyVMt0RZA0f0N0?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1a86a0b-5d7b-4403-ec36-08d9683c824a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2021 02:52:14.2080 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cEv+FWMCYPOF+MLYPqLjWJmVOcwYOQsKtdtZ7PXNXMfB6ikeOiXFp+louLdjuy+iTVzRVy2v0iEIQ0IhIk9x1dcrbJflPYm3a5I6yAGyfIE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2287 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Benjamin, This is a compilation error in this patch. You have added the usage of gEfi= MdeModulePkgTokenSpaceGuid to MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf but t= hat GUID technically does not exist when this .inf is being compiled since = the .inf only references the following DEC files: MdePkg/MdePkg.dec MinPlatformPkg/MinPlatformPkg.dec You need to add MdeModulePkg/MdeModulePkg.dec I suspect you missed this error because all the currently existing OpenBoar= dPkgs do not use MinDsdt thus far. Thanks, Nate=20 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Benjamin Dor= on Sent: Wednesday, August 4, 2021 12:59 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: M= inDsdt also installs all PcdAcpiTableStorageFile Follow AcpiPlatformDxe (from which this module is derived) and install all = ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platfor= m/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc222453857..417cccc18b5a 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -227,6 +227,7 @@ InstallMinDsdt ( Status =3D PublishAcpiTablesFromFv (&gEfiCallerIdGuid); ASSERT_EFI_ER= ROR (Status);+ PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile= )); return EFI_SUCCESS; }diff --git a/Platform/Intel/MinPlatformPkg/Ac= pi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt= .inf index 3437bc489cd3..3e14c4e9a65d 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf @@ -41,6 +41,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTok= enSpaceGuid.PcdPciReservedMemLimit + gEfiMdeModulePkgTokenSpaceGuid.PcdAcp= iTableStorageFile+ [Depex] gEfiAcpiTableProtocolGuid AND gEfi= FirmwareVolume2ProtocolGuid--=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78665): https://edk2.groups.io/g/devel/message/78665 Mute This Topic: https://groups.io/mt/84670596/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@int= el.com] -=3D-=3D-=3D-=3D-=3D-=3D