public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 3/3] MinPlatformPkg:change Several modules.
@ 2020-12-16  8:40 Yanming Zhu
  2020-12-17  0:35 ` [edk2-devel] " Chiu, Chasel
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Yanming Zhu @ 2020-12-16  8:40 UTC (permalink / raw)
  To: devel; +Cc: Liming Gao

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3034

The duplicated FILE_GUIDS in several files have
been changed to make their GUids unique

Cc:Chasel Chiu <chasel.chiu@intel.com>
Cc:Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc:Liming Gao <gaoliming@byosoft.com.cn>
Cc:Eric Dong <eric.dong@intel.com>

Signed-off-by: Yanming Zhu <zhuyanming@byosoft.com.cn>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---
 .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf            | 2 +-
 .../MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf    | 2 +-
 .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf    | 2 +-
 .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf     | 2 +-
 .../Test/Library/TestPointLib/DxeTestPointLib.inf               | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf
index 1ddca75e..0b43ab60 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf
@@ -11,7 +11,7 @@
 [Defines]
 INF_VERSION = 0x00010017
 BASE_NAME = DxeAslUpdateLib
-FILE_GUID = 8621697D-4E3A-4bf2-ADB0-3E2FF06559CA
+FILE_GUID = 1BC79513-CDD5-4993-A161-618015C6C66F
 VERSION_STRING = 1.0
 MODULE_TYPE = BASE
 LIBRARY_CLASS = AslUpdateLib
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf
index 5415446b..75bdf459 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf
@@ -10,7 +10,7 @@
 [Defines]
   INF_VERSION                    = 0x00010005
   BASE_NAME                      = SmmMultiBoardAcpiSupportLib
-  FILE_GUID                      = E0238683-D3FD-4D97-8874-37C6157E2906
+  FILE_GUID                      = DEA4470C-706B-42C5-93E1-5F0694182A6B
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = MultiBoardAcpiSupportLib
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
index df1d780e..28b17d39 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
@@ -10,7 +10,7 @@
 [Defines]
   INF_VERSION                    = 0x00010005
   BASE_NAME                      = ReportCpuHobLib
-  FILE_GUID                      = F19AA754-CE24-448D-B755-1F939B00C25D
+  FILE_GUID                      = 704FC922-D192-42D0-9B10-1BAECC1EDE73
   VERSION_STRING                 = 1.0
   MODULE_TYPE                    = PEIM
   LIBRARY_CLASS                  = ReportCpuHobLib
diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
index cfb9c7b8..8454a4e5 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
@@ -10,7 +10,7 @@
 [Defines]
   INF_VERSION                    = 0x00010005
   BASE_NAME                      = SmmTestPointCheckLib
-  FILE_GUID                      = 74A1F91F-AD11-49C5-96B8-A579F4AA65F1
+  FILE_GUID                      = C1F70E6E-F9A6-46B9-B0F4-9FD0591265BF
   MODULE_TYPE                    = DXE_SMM_DRIVER
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = TestPointCheckLib
diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
index 17e5b756..7e53b439 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
@@ -10,7 +10,7 @@
 [Defines]
   INF_VERSION                    = 0x00010005
   BASE_NAME                      = DxeTestPointLib
-  FILE_GUID                      = 9FDFABCE-7931-462F-8EDF-8C43AD58169C
+  FILE_GUID                      = 7963837C-17B8-4954-9E26-3D290D54D295
   MODULE_TYPE                    = DXE_DRIVER
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = TestPointLib
-- 
2.28.0.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH 3/3] MinPlatformPkg:change Several modules.
  2020-12-16  8:40 [PATCH 3/3] MinPlatformPkg:change Several modules Yanming Zhu
@ 2020-12-17  0:35 ` Chiu, Chasel
  2020-12-19  3:17 ` Nate DeSimone
  2021-01-20  0:14 ` Nate DeSimone
  2 siblings, 0 replies; 4+ messages in thread
From: Chiu, Chasel @ 2020-12-17  0:35 UTC (permalink / raw)
  To: devel@edk2.groups.io, zhuyanming@byosoft.com.cn; +Cc: Liming Gao


Hi Yanming,

Thanks for fixing this issue, would you help to use below subject for all MinPlatform code reviews?
--subject-prefix="edk2-platforms: PATCH"

Also I cannot find [0/3], [1/3] and [2/3] of this review patch series, if it was single patch please remove [3/3].

Thanks,
Chasel


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yanming
> Zhu
> Sent: Wednesday, December 16, 2020 4:40 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH 3/3] MinPlatformPkg:change Several modules.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3034
> 
> The duplicated FILE_GUIDS in several files have been changed to make their
> GUids unique
> 
> Cc:Chasel Chiu <chasel.chiu@intel.com>
> Cc:Nate DeSimone <nathaniel.l.desimone@intel.com> Cc:Liming Gao
> <gaoliming@byosoft.com.cn> Cc:Eric Dong <eric.dong@intel.com>
> 
> Signed-off-by: Yanming Zhu <zhuyanming@byosoft.com.cn>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf            | 2 +-
>  .../MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf    | 2 +-
>  .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf    | 2 +-
>  .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf     | 2 +-
>  .../Test/Library/TestPointLib/DxeTestPointLib.inf               | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdate
> Lib.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdate
> Lib.inf
> index 1ddca75e..0b43ab60 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdate
> Lib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslU
> +++ pdateLib.inf
> @@ -11,7 +11,7 @@
>  [Defines]
>  INF_VERSION = 0x00010017
>  BASE_NAME = DxeAslUpdateLib
> -FILE_GUID = 8621697D-4E3A-4bf2-ADB0-3E2FF06559CA
> +FILE_GUID = 1BC79513-CDD5-4993-A161-618015C6C66F
>  VERSION_STRING = 1.0
>  MODULE_TYPE = BASE
>  LIBRARY_CLASS = AslUpdateLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/Smm
> MultiBoardAcpiSupportLib.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/Smm
> MultiBoardAcpiSupportLib.inf
> index 5415446b..75bdf459 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/Smm
> MultiBoardAcpiSupportLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLi
> +++ b/SmmMultiBoardAcpiSupportLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = SmmMultiBoardAcpiSupportLib
> -  FILE_GUID                      = E0238683-D3FD-4D97-8874-37C6157E2906
> +  FILE_GUID                      = DEA4470C-706B-42C5-93E1-5F0694182A6B
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = MultiBoardAcpiSupportLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Repor
> tCpuHobLib.inf
> b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Repor
> tCpuHobLib.inf
> index df1d780e..28b17d39 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Repor
> tCpuHobLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib
> +++ /ReportCpuHobLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = ReportCpuHobLib
> -  FILE_GUID                      = F19AA754-CE24-448D-B755-1F939B00C25D
> +  FILE_GUID                      = 704FC922-D192-42D0-9B10-1BAECC1EDE73
>    VERSION_STRING                 = 1.0
>    MODULE_TYPE                    = PEIM
>    LIBRARY_CLASS                  = ReportCpuHobLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPoin
> tCheckLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPoin
> tCheckLib.inf
> index cfb9c7b8..8454a4e5 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPoin
> tCheckLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe
> +++ stPointCheckLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = SmmTestPointCheckLib
> -  FILE_GUID                      = 74A1F91F-AD11-49C5-96B8-A579F4AA65F1
> +  FILE_GUID                      = C1F70E6E-F9A6-46B9-B0F4-9FD0591265BF
>    MODULE_TYPE                    = DXE_SMM_DRIVER
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = TestPointCheckLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
> index 17e5b756..7e53b439 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPoi
> +++ ntLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = DxeTestPointLib
> -  FILE_GUID                      = 9FDFABCE-7931-462F-8EDF-8C43AD58169C
> +  FILE_GUID                      = 7963837C-17B8-4954-9E26-3D290D54D295
>    MODULE_TYPE                    = DXE_DRIVER
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = TestPointLib
> --
> 2.28.0.windows.1
> 
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH 3/3] MinPlatformPkg:change Several modules.
  2020-12-16  8:40 [PATCH 3/3] MinPlatformPkg:change Several modules Yanming Zhu
  2020-12-17  0:35 ` [edk2-devel] " Chiu, Chasel
@ 2020-12-19  3:17 ` Nate DeSimone
  2021-01-20  0:14 ` Nate DeSimone
  2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-12-19  3:17 UTC (permalink / raw)
  To: devel@edk2.groups.io, zhuyanming@byosoft.com.cn; +Cc: Liming Gao

Hi Yanming,

As Chasel noted, I don't believe this is actually a part of a patch series, I believe it is a single patch. Please be careful to mark your patches correctly in the future.

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yanming
> Zhu
> Sent: Wednesday, December 16, 2020 12:40 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH 3/3] MinPlatformPkg:change Several modules.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3034
> 
> The duplicated FILE_GUIDS in several files have been changed to make their
> GUids unique
> 
> Cc:Chasel Chiu <chasel.chiu@intel.com>
> Cc:Nate DeSimone <nathaniel.l.desimone@intel.com> Cc:Liming Gao
> <gaoliming@byosoft.com.cn> Cc:Eric Dong <eric.dong@intel.com>
> 
> Signed-off-by: Yanming Zhu <zhuyanming@byosoft.com.cn>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf            | 2 +-
>  .../MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf    | 2 +-
>  .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf    | 2 +-
>  .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf     | 2 +-
>  .../Test/Library/TestPointLib/DxeTestPointLib.inf               | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpd
> ateLib.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpd
> ateLib.inf
> index 1ddca75e..0b43ab60 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpd
> ateLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslU
> +++ pdateLib.inf
> @@ -11,7 +11,7 @@
>  [Defines]
>  INF_VERSION = 0x00010017
>  BASE_NAME = DxeAslUpdateLib
> -FILE_GUID = 8621697D-4E3A-4bf2-ADB0-3E2FF06559CA
> +FILE_GUID = 1BC79513-CDD5-4993-A161-618015C6C66F
>  VERSION_STRING = 1.0
>  MODULE_TYPE = BASE
>  LIBRARY_CLASS = AslUpdateLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/S
> mmMultiBoardAcpiSupportLib.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/S
> mmMultiBoardAcpiSupportLib.inf
> index 5415446b..75bdf459 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/S
> mmMultiBoardAcpiSupportLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLi
> +++ b/SmmMultiBoardAcpiSupportLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = SmmMultiBoardAcpiSupportLib
> -  FILE_GUID                      = E0238683-D3FD-4D97-8874-37C6157E2906
> +  FILE_GUID                      = DEA4470C-706B-42C5-93E1-5F0694182A6B
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = MultiBoardAcpiSupportLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.inf
> b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.inf
> index df1d780e..28b17d39 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib
> +++ /ReportCpuHobLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = ReportCpuHobLib
> -  FILE_GUID                      = F19AA754-CE24-448D-B755-1F939B00C25D
> +  FILE_GUID                      = 704FC922-D192-42D0-9B10-1BAECC1EDE73
>    VERSION_STRING                 = 1.0
>    MODULE_TYPE                    = PEIM
>    LIBRARY_CLASS                  = ReportCpuHobLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest
> PointCheckLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest
> PointCheckLib.inf
> index cfb9c7b8..8454a4e5 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest
> PointCheckLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe
> +++ stPointCheckLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = SmmTestPointCheckLib
> -  FILE_GUID                      = 74A1F91F-AD11-49C5-96B8-A579F4AA65F1
> +  FILE_GUID                      = C1F70E6E-F9A6-46B9-B0F4-9FD0591265BF
>    MODULE_TYPE                    = DXE_SMM_DRIVER
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = TestPointCheckLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib
> .inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLi
> b.inf
> index 17e5b756..7e53b439 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib
> .inf
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPoi
> +++ ntLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = DxeTestPointLib
> -  FILE_GUID                      = 9FDFABCE-7931-462F-8EDF-8C43AD58169C
> +  FILE_GUID                      = 7963837C-17B8-4954-9E26-3D290D54D295
>    MODULE_TYPE                    = DXE_DRIVER
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = TestPointLib
> --
> 2.28.0.windows.1
> 
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH 3/3] MinPlatformPkg:change Several modules.
  2020-12-16  8:40 [PATCH 3/3] MinPlatformPkg:change Several modules Yanming Zhu
  2020-12-17  0:35 ` [edk2-devel] " Chiu, Chasel
  2020-12-19  3:17 ` Nate DeSimone
@ 2021-01-20  0:14 ` Nate DeSimone
  2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2021-01-20  0:14 UTC (permalink / raw)
  To: devel@edk2.groups.io, zhuyanming@byosoft.com.cn; +Cc: Liming Gao

Pushed: https://github.com/tianocore/edk2-platforms/commit/ba19046

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yanming
> Zhu
> Sent: Wednesday, December 16, 2020 12:40 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH 3/3] MinPlatformPkg:change Several modules.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3034
> 
> The duplicated FILE_GUIDS in several files have been changed to make their
> GUids unique
> 
> Cc:Chasel Chiu <chasel.chiu@intel.com>
> Cc:Nate DeSimone <nathaniel.l.desimone@intel.com> Cc:Liming Gao
> <gaoliming@byosoft.com.cn> Cc:Eric Dong <eric.dong@intel.com>
> 
> Signed-off-by: Yanming Zhu <zhuyanming@byosoft.com.cn>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf            | 2 +-
>  .../MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf    | 2 +-
>  .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf    | 2 +-
>  .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf     | 2 +-
>  .../Test/Library/TestPointLib/DxeTestPointLib.inf               | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpd
> ateLib.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpd
> ateLib.inf
> index 1ddca75e..0b43ab60 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpd
> ateLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslU
> +++ pdateLib.inf
> @@ -11,7 +11,7 @@
>  [Defines]
>  INF_VERSION = 0x00010017
>  BASE_NAME = DxeAslUpdateLib
> -FILE_GUID = 8621697D-4E3A-4bf2-ADB0-3E2FF06559CA
> +FILE_GUID = 1BC79513-CDD5-4993-A161-618015C6C66F
>  VERSION_STRING = 1.0
>  MODULE_TYPE = BASE
>  LIBRARY_CLASS = AslUpdateLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/S
> mmMultiBoardAcpiSupportLib.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/S
> mmMultiBoardAcpiSupportLib.inf
> index 5415446b..75bdf459 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/S
> mmMultiBoardAcpiSupportLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLi
> +++ b/SmmMultiBoardAcpiSupportLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = SmmMultiBoardAcpiSupportLib
> -  FILE_GUID                      = E0238683-D3FD-4D97-8874-37C6157E2906
> +  FILE_GUID                      = DEA4470C-706B-42C5-93E1-5F0694182A6B
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = MultiBoardAcpiSupportLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.inf
> b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.inf
> index df1d780e..28b17d39 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Re
> portCpuHobLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib
> +++ /ReportCpuHobLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = ReportCpuHobLib
> -  FILE_GUID                      = F19AA754-CE24-448D-B755-1F939B00C25D
> +  FILE_GUID                      = 704FC922-D192-42D0-9B10-1BAECC1EDE73
>    VERSION_STRING                 = 1.0
>    MODULE_TYPE                    = PEIM
>    LIBRARY_CLASS                  = ReportCpuHobLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest
> PointCheckLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest
> PointCheckLib.inf
> index cfb9c7b8..8454a4e5 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest
> PointCheckLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe
> +++ stPointCheckLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = SmmTestPointCheckLib
> -  FILE_GUID                      = 74A1F91F-AD11-49C5-96B8-A579F4AA65F1
> +  FILE_GUID                      = C1F70E6E-F9A6-46B9-B0F4-9FD0591265BF
>    MODULE_TYPE                    = DXE_SMM_DRIVER
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = TestPointCheckLib
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib
> .inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLi
> b.inf
> index 17e5b756..7e53b439 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib
> .inf
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPoi
> +++ ntLib.inf
> @@ -10,7 +10,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = DxeTestPointLib
> -  FILE_GUID                      = 9FDFABCE-7931-462F-8EDF-8C43AD58169C
> +  FILE_GUID                      = 7963837C-17B8-4954-9E26-3D290D54D295
>    MODULE_TYPE                    = DXE_DRIVER
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = TestPointLib
> --
> 2.28.0.windows.1
> 
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-20  0:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-16  8:40 [PATCH 3/3] MinPlatformPkg:change Several modules Yanming Zhu
2020-12-17  0:35 ` [edk2-devel] " Chiu, Chasel
2020-12-19  3:17 ` Nate DeSimone
2021-01-20  0:14 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox