From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.4683.1607509824353479723 for ; Wed, 09 Dec 2020 02:30:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=YTdjpu0H; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: mlfMAvsQv1YG2g84teK63n++lqZ5oz6D/hRuvX0q0u0vZvYapf8q0t592Xj04T8Ikr2yTHVNwk sBySsHaAYPcw== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="153292690" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="153292690" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 02:30:08 -0800 IronPort-SDR: k2WEeHHb/aHouMigkCLEhIAF6M8p1vulL7OkR/qx1JRhHcngWyP6GvbGSHAYA7wDrbpQmcVwBJ u5WnCmAHNuFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="368137636" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 09 Dec 2020 02:30:07 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 02:30:07 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 02:30:07 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Dec 2020 02:30:07 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Dec 2020 02:30:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WW34IVGW9jIHYVZ7HjsT+8RUIs5RDz+y5Hs0ndHiME51vlZav9IN1BwIR3m7znnuavGahL9v1HVd+Ic7zklwB2qs99tkP8QdD3rOR5QzchjrYOTm3l6YIydTKve2WJOCzu8WlDloS+3IjPq/0y8vNbD0sfN7l4sm8q6uwZCXLAH1h+m9WPKh6XrvGaDZ82YOQ4xiaiOUvemPHzNrgWVe6hN5bIwz5vrCBHpoIR3nRVBafHBc1rCbwjZBzZdRZd2QP3GUxFb5of0ksTq/mSK9jtrGtZuEPcM8uxIjPMQug5mMP4w9HhG5+o7bpCPNy2NGIZYLNBUQ4cq6qHKZqcUBow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WzRRuWfhr6FEsFeChL4p5JbOG5W67pl9haYSjuBAyFc=; b=npaXKMdYuS2jLFaJHyFv+PX/x9AIcKa9lrGrO/PCpwTiekKUNfaWA4HgOHKLESotNYWxfjgyQisW4neGTrjlZP+/ZWwJTB40JsLrqBs79LmIDtYX11PjASUJqBNVh3QQE/F24biMduxlvjYlDxK6LL88ZgPzpod5w9JkFNBg13JiTP45FoJHuGOlf7CxIg65ehWYT/7Biyon8HJyRr8vShJAq7edBkrBca2uoMRYODEf2XUWu9UXYTO/BagbBFO38if1FiD2AcKvMhIwm6QRt8ufK3JYK7oHSNGN28ldrKt5P3LRv2ePkd83WC0iKcNuseR37ehaGb1DaVUfZVRuVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WzRRuWfhr6FEsFeChL4p5JbOG5W67pl9haYSjuBAyFc=; b=YTdjpu0HZWhTHBxEwDCt8vjB+MSgW5cYX0U9nXftjefIwBDANKYLMEdw1lSmo5iYsegbOX6wFjxotkYdAyFNSsKRrGNiWzmphK7hsG2OAl9384Q1VVql68JQO4hQJ99zZUHGIHVrsqUcHYDFFdct9iU8hOBfSO5BNg+PB9AADi4= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB5201.namprd11.prod.outlook.com (2603:10b6:303:95::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.18; Wed, 9 Dec 2020 10:30:05 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710%8]) with mapi id 15.20.3654.012; Wed, 9 Dec 2020 10:30:05 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [PATCH] UpXtreme: Enable USB DCI debug Thread-Topic: [PATCH] UpXtreme: Enable USB DCI debug Thread-Index: AQHWvv1GdX6bBPxN1E++zIOc+k6Vn6nupnaw Date: Wed, 9 Dec 2020 10:30:05 +0000 Message-ID: References: <20201120052316.3707-1-heng.luo@intel.com> In-Reply-To: <20201120052316.3707-1-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a687ded-d60f-4396-1f7f-08d89c2d6513 x-ms-traffictypediagnostic: CO1PR11MB5201: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PfEIdj35JyaybJxbq8od5EfabCbmK7UoILyTGVC+CGk6L8fHlrdYDI+ErIEwjdnbzqJ0raHDhYNBohoHqIbfKL4b4gHIPL2h8YxfbzBHCW6Q89tJ7yN9C7GsTHlz5IgRT6g/MMW9PFyUS7TZBwKXb2iOc1yl+zYWrs+w2IftabdI8Xd7h+wWrVjjdJV/rDw5jfjAXpi2oleAxvEqd49ckXKCzW7DvxILmTWQY4XOAuHR6obvizDZTNSKoDUYqlW54HQOcRBN9UA8p3H+Yojh01/LMfy8w9z76g76BwDT9dx049zlWlcsJoRuOQKXQyb2e3cE+LKqOxxsPKG2lSLfTGwGk6qbNn4YxLlXd9Sri0g7NaNLfnvxUqA9cnvau0Wkf6Cg2ARHXCKaqlGIBFGSxw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(346002)(136003)(366004)(376002)(4326008)(76116006)(83380400001)(508600001)(110136005)(52536014)(107886003)(71200400001)(8936002)(8676002)(6506007)(86362001)(7696005)(5660300002)(966005)(186003)(33656002)(9686003)(66556008)(53546011)(66446008)(66946007)(55016002)(19627235002)(2906002)(64756008)(26005)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?fLxYBJ4KFvEFIZPR88S8Wugndj6n/AErYur7HZOSWzmrRWruQzgsj0tRHORc?= =?us-ascii?Q?R4fLeP6+e6qWVt0yS/5CEfyUSGSY1G7NOUxR/L4QLbmrTh+47CaES+w6HSIh?= =?us-ascii?Q?IGCJSlZZWQvVnfLEw3CwugvoRBZ4sD+W66KOimdHeikEA5LRSsWF9UEOHMIK?= =?us-ascii?Q?WjoNzsX2324VE4gaitZBtqNzwSMYByyJUAC/GVI38b7ldF+gk08pm+pEOSuD?= =?us-ascii?Q?wD84jU6TTCb4KNJ9XF976BlwkeBTEBPR6/GHoovBnQUl+y2CBZ7stRzXTIsg?= =?us-ascii?Q?g9wlqLRfPTnsLi8pOlnY7lO0UqSc9d4Bi5/gojS0SFFMKMgheXsciU6ucXuF?= =?us-ascii?Q?0mr//wCAoWECnr9ntRotXdvWS+I/FgQy2K4YuKB9dT2d49x/yLlwrpM1DIHd?= =?us-ascii?Q?m640YnkV/UMsOsiu8QsKy6gXK4qhYfND99OAxKB0FpARWy1yynSx1+iE7vWJ?= =?us-ascii?Q?3O0TWHG3WN8Fuz292GYSzinPEEEnoWnhMECtECJWln7m9kd7xHowpqHIuvDp?= =?us-ascii?Q?KLs5ojbojZmsBHOEA/Fl0BmrexvknNboEKT97ZDPPcKlXcKciNolxP0ZZFsC?= =?us-ascii?Q?eVu0x6gHcr+DsCNqOmp6AKtCRgZE8yvTnGkS0oIbPoyqIc3vsRL0tlaL929/?= =?us-ascii?Q?QnI3pYjenH/Vpi2/x5OrG+l6Bc+HCkDtroMbIMxZe6avuFI2EDOhPKL0zWZP?= =?us-ascii?Q?6La+KRJd4eIxSIgTlC48LFK7w6KMpmqhYp7GnkgU4+EyjPOIOJg2jQ/NKKD1?= =?us-ascii?Q?7VlzTSWuxaUCZXbN6cE5LuxKlrWPINqxRmLA3PIk2Fe1SQ8ZBosWKwNGF4Lz?= =?us-ascii?Q?mcmXmJiIjvL1gwALEnYIKRrmRTc0W8wffjCzfEj1TvFQiCQu91zQ76+OEqI9?= =?us-ascii?Q?+D/SEapxQ5QzAJWceZHYcQ8D0Fzuc+TinQxsKeoo/aZKCc84kkoYUhZ1pw+D?= =?us-ascii?Q?fbN9d5lYULbJEvLadTEMnB81w5cJzej6sdP5/9Ybp80=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a687ded-d60f-4396-1f7f-08d89c2d6513 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 10:30:05.4609 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NytnAlxi0sXvXxMhzYK1JgulTb9Bh25w1uP9STdsJvGdd4l30Jio+ZZucaPh9HKc4XXnGaBuMdf14E2R2ETbCYSOzfoJdBAiFAXn5NMK4Hc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5201 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Heng, Please add a DynamicEx PCD to control the enable/disable of DCI to WhiskeyL= akeOpenBoardPkg. It is probably not a good idea from a security standpoint = to have the default configuration leave JTAG enabled and open. Other than t= hat, look's good! Thanks, Nate > -----Original Message----- > From: Luo, Heng > Sent: Thursday, November 19, 2020 9:23 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [PATCH] UpXtreme: Enable USB DCI debug >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3081 >=20 > Allow to debug BIOS via DCI cable. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Heng Luo > --- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLi > b/PeiPchPolicyUpdatePreMem.c | 1 - >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar > dConfigLib/PeiCpuPolicyBoardConfig.c | 5 +++++ >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar > dConfigLib/PeiPchPolicyBoardConfigPreMem.c | 7 +++++++ >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar > dConfigLib/PeiPolicyBoardConfigLib.inf | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol > icyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c | 6 ++++++ >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol > icyBoardConfigLib/PeiPolicyBoardConfigLib.inf | 1 + > 6 files changed, 20 insertions(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > index 2d48b09175..ac5b583f89 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate > Lib/PeiPchPolicyUpdatePreMem.c > @@ -83,7 +83,6 @@ UpdatePeiPchPolicyPreMem ( > Status =3D GetConfigBlock ((VOID *) SiPreMemPolicy, > &gIshPreMemConfigGuid, (VOID *) &IshPreMemConfig); >=20 > ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > - DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2; >=20 > PchTraceHubPreMemConfig->MemReg0Size =3D 3; >=20 > PchTraceHubPreMemConfig->MemReg1Size =3D 3; >=20 > // >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiCpuPolicyBoardConfig.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiCpuPolicyBoardConfig.c > index d1d1920823..d4c5136c0a 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiCpuPolicyBoardConfig.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiCpuPolicyBoardConfig.c > @@ -44,6 +44,11 @@ UpdatePeiCpuPolicyBoardConfig ( > Status =3D GetConfigBlock ((VOID *) SiPolicyPpi, &gCpuConfigGuid, (VOI= D *) > &CpuConfig); >=20 > ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > + // >=20 > + //Enable processor debug features >=20 > + // >=20 > + CpuConfig->DebugInterfaceEnable =3D 1; >=20 > + >=20 > return Status; >=20 > } >=20 >=20 >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiPchPolicyBoardConfigPreMem.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiPchPolicyBoardConfigPreMem.c > index 01bb75525b..c79718f4ee 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiPchPolicyBoardConfigPreMem.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiPchPolicyBoardConfigPreMem.c > @@ -25,12 +25,19 @@ UpdatePeiPchPolicyBoardConfigPreMem ( > { >=20 > EFI_STATUS Status; >=20 > PCH_GENERAL_PREMEM_CONFIG *PchGeneralPreMemConfig; >=20 > + PCH_DCI_PREMEM_CONFIG *DciPreMemConfig; >=20 >=20 >=20 > DEBUG((DEBUG_INFO, "Updating PCH Policy by board config in Pre > Mem\n")); >=20 >=20 >=20 > Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, > &gPchGeneralPreMemConfigGuid, (VOID *) &PchGeneralPreMemConfig); >=20 > ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > + Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, > &gDciPreMemConfigGuid, (VOID *) &DciPreMemConfig); >=20 > + ASSERT_EFI_ERROR (Status); >=20 > + >=20 > + DciPreMemConfig->PlatformDebugConsent =3D 3; >=20 > + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 1; >=20 > + >=20 > return Status; >=20 > } >=20 >=20 >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiPolicyBoardConfigLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiPolicyBoardConfigLib.inf > index aaf0abbf04..affb322c59 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiPolicyBoardConfigLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > ardConfigLib/PeiPolicyBoardConfigLib.inf > @@ -54,6 +54,7 @@ > gPchGeneralConfigGuid ## CONSUMES >=20 > gEfiTpmDeviceInstanceTpm20DtpmGuid >=20 > gEfiTpmDeviceInstanceTpm12Guid >=20 > + gDciPreMemConfigGuid >=20 >=20 >=20 > [Ppis] >=20 > gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > PolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > PolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c > index 00cf73dfd9..5d75bc5e1c 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > PolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > PolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c > @@ -25,12 +25,18 @@ UpdatePeiPchPolicyBoardConfigPreMem ( > { >=20 > EFI_STATUS Status; >=20 > PCH_GENERAL_PREMEM_CONFIG *PchGeneralPreMemConfig; >=20 > + PCH_DCI_PREMEM_CONFIG *DciPreMemConfig; >=20 >=20 >=20 > DEBUG((DEBUG_INFO, "Updating PCH Policy by board config in Pre > Mem\n")); >=20 >=20 >=20 > Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, > &gPchGeneralPreMemConfigGuid, (VOID *) &PchGeneralPreMemConfig); >=20 > ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > + Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, > &gDciPreMemConfigGuid, (VOID *) &DciPreMemConfig); >=20 > + ASSERT_EFI_ERROR (Status); >=20 > + >=20 > + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2; >=20 > + >=20 > return Status; >=20 > } >=20 >=20 >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > PolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > PolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf > index 15ef223050..5de11d62e4 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > PolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > PolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf > @@ -54,6 +54,7 @@ > gPchGeneralConfigGuid ## CONSUMES >=20 > gEfiTpmDeviceInstanceTpm20DtpmGuid >=20 > gEfiTpmDeviceInstanceTpm12Guid >=20 > + gDciPreMemConfigGuid >=20 >=20 >=20 > [Ppis] >=20 > gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES >=20 > -- > 2.24.0.windows.2