From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.670.1630200481049751845 for ; Sat, 28 Aug 2021 18:28:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=un+JvW4G; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10090"; a="279141537" X-IronPort-AV: E=Sophos;i="5.84,360,1620716400"; d="scan'208";a="279141537" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2021 18:28:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,360,1620716400"; d="scan'208";a="426803865" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 28 Aug 2021 18:28:00 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Sat, 28 Aug 2021 18:28:00 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sat, 28 Aug 2021 18:27:59 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sat, 28 Aug 2021 18:27:59 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sat, 28 Aug 2021 18:27:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VsPhL0rf2vY/vzMOIEPbKJEkVQ6QMDEwImuJ8ihlBHscfR68gafk0SgkqHhv8rAmBNEZus2u+t+UQqeZFRHKulAbPhfUT9y72j074nwSxRbNGUGfiBZ9wylTSuiK1TD6p6EH6JVU5gg4haAmYEht2os8tzJqzn2P4s3I9DQSyGbiEVETmO90it6NzYBlz07iq4DwkeFn2OgfrPOg1a4HAcWOh0U9cLeD+al1XtmCcPn53ldOYLVGC6ThW6Y6evfDpaof1v1oefr5bgzIa0TNH84N+LNhgbLeND9XkA4VPb7fnebeIVXDAjAzDfArLPIpqp6iNADZ/AafdUrOhWKi6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VrgLkNraoUjEF/2UoW7iXtTvRemr5z9AT26Lmp/RDGs=; b=cMV4151xFWhbuqx+PHDhtP6DA6xf7bZOV9/eA59rkkkEMQFzCcN0c9aTU7gtJgmDb/85/p32ezJux+YLWS6NwK8oOrFp5VOmYHXTeB2GB1tFkdqnyJjdeMn3FYEoylXjfXnaWig0CqbHvsI+Tj0LY+N+Ew3jH2BFuJZGHqhFZIJJFHDbA17TGsA3OUR4HzlsKqOsXBNwT4TzYVMU1WRK+TQjS8lQ2Qh/JiXTc+PXQd/wMeLFOLe2uMxZiAl4ou3H1aatk/7guKDt3heUgiLw+XXAl5MrtJTOIF6gSkZje9chmbvFQdYX0X2HLUCFyd23lKGlrVPEYXyN1WCuO/wlag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VrgLkNraoUjEF/2UoW7iXtTvRemr5z9AT26Lmp/RDGs=; b=un+JvW4GqHVPTo4yFpEIFDevOM6cKU5PS59HJP1fuE8jYHKQa1CTmvr4/va5Asd5kMBpfUca/lqBSnoaByr7dvOyZgTi+OzOqlpPMx28maa11Nib0uaLiCyGXhK1IuYvLJ9frJ2iR0O96WikW1s7RmsEHsiEehkZ2aCu4AY7ShU= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MW3PR11MB4603.namprd11.prod.outlook.com (2603:10b6:303:5e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Sun, 29 Aug 2021 01:27:59 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::4421:2284:94aa:8d3a]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::4421:2284:94aa:8d3a%3]) with mapi id 15.20.4436.024; Sun, 29 Aug 2021 01:27:58 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "benjamin.doron00@gmail.com" CC: "Dong, Eric" , Liming Gao Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check Thread-Index: AQHXnETTOewLAPSWHUCAA/7P8VTr06uJsYqA Date: Sun, 29 Aug 2021 01:27:58 +0000 Message-ID: References: <20210828194205.6083-1-benjamin.doron00@gmail.com> In-Reply-To: <20210828194205.6083-1-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e8171be0-caa1-41d1-09dd-08d96a8c3c4f x-ms-traffictypediagnostic: MW3PR11MB4603: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R2V237gsM5WXAcghBmMMkyOMGNatzMjnTGxgxnNND5y4Yc+lLdDubm87o7qGtmXt9nFE58hTBgcQweGoZZtsL+WNmGyPyO2nY2i2uK1RX5RTh9Sli3okiBSV8wbbUipy9UNdAVLwEEcbjW8LQMKwHL+ev2+D/gTsB0SKFPUeFd5maVViluV0qsLgBPcsXmSRynD70+px53MJnObYjnrXi6kNga9sRuiU/M6GqRYIBOcj5OWSZCymoRdYSN6VE865Gtgq1MJdD1aSa4ZYGeeYSVYvUQ3Yxd7pK6XCYNxcKsGVDY8H9rFf/pxBhMnyrfkmjBcCOJ0/02aqFj6LL5g5BWb4jqryEqR7+oB0UQKJ2id8R4iZv+LSqTuLU/8II8EbmAs3JdKR8Z6H4nLjE7MI14zrVXI4dn674ry3xRrjujEjUAaHrPcUdFHoP7da1yeQfVEjqlevGU1MjkSODgpSTFvqpJ2pzzDe5zurLqIWD0SneB/0kE26ZPRfPIOTtwYoydpVZqZZYXVfreapcPyvQC+Fxe0lwk1T7bGzcL+UmTRlP2SxotiVF8jSZL+yhak/xtGklKy9uRk8U0hFa3sdbEcNosFbNlnjy9XkEd8nb/h/M+b+QDWkNKzUyvzDUDSnJ63fJHdlNZyCef4eSqRbuTS1f3217ODIdDQXoZuHBhTh6RrIKuVeoOdK9ff+RCkSIEq5Ye2qQq/B4cjTw6OpyJ/nFe4RCpDHtXqC+7o3uu4PL53UtQjVzqBv0K7bhfW7eDBAK2QbJ/XBFMrcI/qv3oPHSPmrAom4TbtYtXaZqxfcX7GKPqeaLkDTxsm5Z9Wwm+gl56lKw7MoepUukdbc/IgmMsRQUnc4xTOPhAz3WjY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(366004)(39860400002)(346002)(136003)(76116006)(122000001)(2906002)(66476007)(66556008)(966005)(52536014)(64756008)(66946007)(66446008)(33656002)(83380400001)(316002)(55016002)(4326008)(19627235002)(8936002)(38100700002)(8676002)(5660300002)(38070700005)(110136005)(54906003)(9686003)(53546011)(6506007)(186003)(7696005)(478600001)(26005)(86362001)(71200400001)(145543001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ySnAVezGUc6jfv83tPf+umteM+NFKAFrJ0M5pkJtofjEHNTyumFS0fIk+9AT?= =?us-ascii?Q?Ctk/h5AYqzBqNz49ew2F4F8Sx3Wf50quoxfckTe+x786Jydaefu5wmAVGJkf?= =?us-ascii?Q?NKPgul09SDfYtN59MWYIJ4G3BHvbfgXIlvxEDCL0YqWWQwirbh9b08C6Csy/?= =?us-ascii?Q?oeCfpRJARGadJzrS1K6PDhprhigwsZK7wome25pJTQoI1zuco2mh/heSsn6U?= =?us-ascii?Q?h1AHoSMmpf3C6xXIAhhspvgsjTP4qdGm8yv5zVXpPF56FNCt4rvjxpORyOvZ?= =?us-ascii?Q?Jx124OTFsEL6dLAZ4EpA5aAAwyTfGJgEoPhsk39ZpLoHAbyilDbkioaFOEmd?= =?us-ascii?Q?HfRx56JAOInlQtlQ2mBFmET+VxHRqo0O9v+a7kBd5qvooa0dUXaXKeB1HHdg?= =?us-ascii?Q?7siLFQoa9qiUXC6RlsWAd4faZfP25S04RPx27VKFqzHfWICpzATHDcMe0iMM?= =?us-ascii?Q?+3vhUN3Gk1ESvPphzFxTH+vB/a2odyLJJ49NBItqj+PgNi0WjybQ5F1fnN4J?= =?us-ascii?Q?gYyFR+YLBHDKm42nnXUvmDb9VNe/Hgu/0Ohgj6Hr2uoCseSnf9l0+fQz5U1a?= =?us-ascii?Q?wKZA4z/kON5bSZa1TsIPN+wQegorEJj61qxVkmIbO0SSCeNUrxRJWQL2LH/B?= =?us-ascii?Q?gdCNQ0Amr4lvhUjuumWA0oS3HDO48Uw/B+yPtAvQKyAyMZ1DVOdbSQKkCmMY?= =?us-ascii?Q?QMpJY2b3T88AZvTCQtFEDxabZF0CWbqygXe2AQbSlFRQ46yrrL8/x4Kbb6al?= =?us-ascii?Q?JSh2TIrcOJIdG/30Cc8Y4YoS7RWL0i8xLYEImxC4qNIU+RYrF3FxrtFwMVtQ?= =?us-ascii?Q?QjYaoWWYldGyWPbohjVjHaoL/7Fi7WT1ck0+v1a3bMtlNEZcmPUAKY1nShH7?= =?us-ascii?Q?oPS1HGye2X74bI84l0vrmCkhPfIP3x8ixDwBjrpg69xeoykd8dhYjH/AqISH?= =?us-ascii?Q?Wx2d3dOolwCaLXCkgvhILdGenF+iYOl0s6weDyRvFFwHPWxwvqOlIaN1j08L?= =?us-ascii?Q?oWRHB9fG+g3rImm+WdC8pCVz9s0ofSitW1sMynb0Fh5y73BONoEIGiS6G1fL?= =?us-ascii?Q?LFfqACFKGEcaVhuN2X5sNbRTxAwIdc3d+TLtZFnSPqQYF6RYkAXWIRtNORGo?= =?us-ascii?Q?XbKh1U+eVxB+VSwkRNOTAu+fy72uKU3OslO8a1Q0DiXEcdYLKLAAYNJvLFLh?= =?us-ascii?Q?S2XWYwkpV3rJSw8Bw7n5VVYIgP83Izz17ayOd4RmouSuO5PbProxKfLyLDoR?= =?us-ascii?Q?0pUfwwO0KyyORuKGaM5IZKnlIxkaHA5+rG4p8dTOM/Xt4MC/bX7m6pLVnwnv?= =?us-ascii?Q?54E5IkZ15SL42p4RntqCdCHs?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8171be0-caa1-41d1-09dd-08d96a8c3c4f X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2021 01:27:58.7465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NK8wlQMmYNSsM//eLCmI3PNjzSJ4DIdIG0iSGfGJLfcR9+l1ri5q1VguC04NF6kUGGBdDBGM9zfGTVuZpxJQ7pn7+kQGbf4bK+yhzQ7acmg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4603 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Benjamin Dor= on Sent: Saturday, August 28, 2021 12:42 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Liming Gao = ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHoo= kLib: Fix mSetupOptionNumber check If CreateFvBootOption() fails, RegisterFvBootOption() will return LoadOptio= nNumberUnassigned, which is non-zero. Therefore, correct the check when att= empting to register hotkeys, to be able to detect if UiApp is not present. Cc: Eric Dong Cc: Liming Gao Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c | = 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBoo= tOption.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBoot= Option.c index a07abb214913..1fd0de3961cc 100644 --- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption= .c +++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOpt +++ ion.c @@ -440,7 +440,7 @@ RegisterStaticHotkey ( // // [F2]/[F7] //- if (mSetupOptionNumber) {+ if (mSetupOptionNum= ber !=3D LoadOptionNumberUnassigned) { F2.Key.ScanCode =3D SCAN_F2; = F2.Key.UnicodeChar =3D CHAR_NULL; F2.KeyState.KeyShiftState =3D EFI= _SHIFT_STATE_VALID;--=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79914): https://edk2.groups.io/g/devel/message/79914 Mute This Topic: https://groups.io/mt/85215635/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@int= el.com] -=3D-=3D-=3D-=3D-=3D-=3D