Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug

["Nate DeSimone" <nathaniel.l.desimone@intel.com>]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Wednesday, September 22, 2021 2:35 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1]
> WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug
> 
> Fix issue with missing debug messages on ESPI_ENABLE configuration.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
> ---
> 
> Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHo
> oks.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform
> Hooks.c
> b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform
> Hooks.c
> index fa695358bf..8a93f41678 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform
> Hooks.c
> +++
> b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform
> Hooks.c
> @@ -116,6 +116,13 @@ IsAspeedPresent (
>   IoWrite8 (ASPEED2500_SIO_INDEX_PORT, REG_LOGICAL_DEVICE);
>   IoWrite8 (ASPEED2500_SIO_DATA_PORT, ASPEED2500_SIO_UART1);
>   if (IoRead8 (ASPEED2500_SIO_DATA_PORT) == ASPEED2500_SIO_UART1) {
> +  //
> +  // In ESPI mode, assume this SIO logic device always present.
> +  //
> +#ifdef ESPI_ENABLE
> +  DeviceID = 0;
> +  PresenceStatus = TRUE;
> +#else
>    //
>    //right now, maybe it is ASPEED. to detect the  device ID.
>    //
> @@ -143,6 +150,7 @@ IsAspeedPresent (
>    if ((DeviceID & 0xff0000ff) == 0x04000003) {
>     PresenceStatus = TRUE;
>    }
> +#endif
>   }
>   IoWrite8 (ASPEED2500_SIO_INDEX_PORT, ASPEED2500_SIO_LOCK);
>   return PresenceStatus;
> --
> 2.27.0.windows.1