From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.3427.1634259420762010078 for ; Thu, 14 Oct 2021 17:57:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ZsbNPTeH; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="251265446" X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="251265446" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 17:56:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="548938368" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 14 Oct 2021 17:56:59 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 17:56:59 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 17:56:59 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 17:56:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bydthKGY1rnxwVNon6V+N5YmOnkZUE+YxxBohHOMAlLdFtij+KJieEsVc57N3teEP/IREc6ohtD6aeGHV3V1sgiVYJh7jkCq8IM34b7WTHfRlyuvdhmnYW5DO0uG3qbhj2FfzHEcoNDtjSGPUTgQjh9oJ+rWR0cXjxvlyCzfNvPfibyoOjkCdKaHEnDOOSQfpGcs32Ncdy842uUXBh0tmn27KYr/aG3FpqIzuBpnRLZErAEWh0YLNhZQBFFw6z6EgwmIhMlaRrcqwvritFFsPMwIMqunmUSAwNR5uopmAQX5alC5LWk+1lWDBazoZUQAZkW97lH1H32NHEgYoiKy7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ReWrp5YFzUgOPE6zMnbLvcTs6GRtDpBne9Hwm3a+ro=; b=Q/dRWHvhEZZwylG6UWuQ87xucG6nkwSPmqsGKbg3nGQWYGwKWyktc20dM/OkZmaVe+vsjV6ZVMca9LN8F+ZBTekFHP6GenXp0IMNoZAfDuZcugEAczJNdisaaEGp7lLzQsz18jVEefRIXADfqsD8L+GUAjcxsL3KHnL0etkpSKDebEg/4k+4Z0A0Q26CIugtNz8KZqa30XvjGhvgMbh2vRQFRoSSJEdo0pVbNDHUNJpTmoI7aXt82o5yfaqE2Xr72YxYCstdMCDW7IT9S9EtP2GLniGcEic9FjmvnQ214OBpxEnKk1cvYVs/55ZVY1Whk2Xk9JSDRaYSv11UKE6iMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ReWrp5YFzUgOPE6zMnbLvcTs6GRtDpBne9Hwm3a+ro=; b=ZsbNPTeHIbnBDro38JKmkjW2QNM3Nn/kWQ5uRgJ08whGBdTdG/W7OZo+F0Wpp0piee09lVB9ZErs0UEUi+2pb0PNQggkIGoGnXNiwrKizNI0mZcKx97jn+dMVLTFJa9O8Xqx2yL1CyvoqRiaMKn7gEywlsE3QUMhxGhsA5P22ps= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1760.namprd11.prod.outlook.com (2603:10b6:300:10e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 15 Oct 2021 00:56:58 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed%11]) with mapi id 15.20.4587.030; Fri, 15 Oct 2021 00:56:57 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug Thread-Index: AQHXr/mzTCD/IHDIj0mAlt0BAfwbmKvTXxYw Date: Fri, 15 Oct 2021 00:56:57 +0000 Message-ID: References: <16dbdfd1700b810a61951c1e6cd6227d1d3c697e.1632346388.git.isaac.w.oram@intel.com> In-Reply-To: <16dbdfd1700b810a61951c1e6cd6227d1d3c697e.1632346388.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ebd7701a-964e-40f7-cb6c-08d98f76b068 x-ms-traffictypediagnostic: MWHPR11MB1760: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1360; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WfiQNKnXXLDqaeexHTeCx36C6N/EPW6cvu3H1hQ+UaPqm0Z+0d0phQVf7tXlkF4LyW3JoLkDiJgoSD3/FY0U+cqauGEfWewQRNFWoVHB7o9kYZLanEsoROzrWZGVLmCeTD30JiXM5F0tEms4i4eGGHkOEFbb71KP4jMi+cZX/mRObFthWzP7Ff7SIMYVuEvKh9biGqsiG3TzVzSqmaYFm7eWorAvXUximrxRnomQexQ1hhGoNOP7EqPm4Ms+fSyJhTy4xMY/uMFf3C6qMMXReFcVDDo1bhF1fENr8i599jvsqH0ApZOOoGoUT7CxBLo4bsq+hPTcm2Kq/iN03dzPnHL6j9rS2o/RpQWxdN+isDWqpgmsxoUDer4Hdu26HZJOuZ7ELdl0qmHLXEjpwFQttUGCiNpFM0NrAvpuVQ2qDyKGyOqi/xG4iLnFp71A4XCRXUam0nEIa03auSjmMxphLlfKmn7Q91YQqvqpvhdL+ngU7PrMVuGdBfp3emtRLlhrMd3xPzsge2BH6fN+25AeWLiIu5ByAKT/CNYgZHZEWkroAyvJEyRmp4ZGTq9m3N3406gDXoN9TFWFGWAjN8+ob3nm2sFN6/k1QMPgGj5BZz9kbE2+HzsOjjLyklz8tpYPGNtYu6T8tmG/Tc46D5Lpc8iFbTgXvHfGlHB2v03NVgIMGyA/LVV+3qZj1ym2wwBZcLnjGh8c5nxfAnPH2SBwxQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(38100700002)(33656002)(38070700005)(86362001)(82960400001)(52536014)(110136005)(107886003)(64756008)(4326008)(55016002)(2906002)(9686003)(7696005)(53546011)(66556008)(66476007)(5660300002)(26005)(316002)(66446008)(508600001)(71200400001)(8676002)(6506007)(186003)(83380400001)(76116006)(66946007)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z1IQLAUJ/WfNmdBJrMl8M3TEZOJt92KpYmVzdB3tXz8Dbl3973jIqZlKMaVO?= =?us-ascii?Q?aSTfMYGw1RX/T8raL5rVzumIitHZ8yiaboVlhf5TT8SmgR4fyD0GXe9Czf/t?= =?us-ascii?Q?R/nWvCx3v8E0oCuvHY0AVEDYB93ij0obzt7C1LETLuf7VXtqi4SKNiCaYghI?= =?us-ascii?Q?IzNA5UvNSrdtw4ZaBnFn6kX8f7VNMNglboxPRoxJSMTJpfGjULHmJGgHVLII?= =?us-ascii?Q?Wc1dv+cX4iUWvrRfxg6S3XrP8FgZHkOr7QSDpuvn1hWRbbG3H8obxc9OXwO/?= =?us-ascii?Q?O7Za9SwYpb/UOIi3wz7TsmCQNKeLVyMu4a2twqBlPHDQFOasc/oEFC5d2w5g?= =?us-ascii?Q?YvZhWCU3GpP7F/MGKhMpETYd+sMOZvoyZzuYdiWkdq7BD5w4mfufsJK8Uvx2?= =?us-ascii?Q?cm9zWXCnfDYRiSUJ5Cd6vFAwuRTix0JLd2P1TLGmMIhDj7qN6UiRz0pGX/YW?= =?us-ascii?Q?wkEPRH5da17uH8V9z7Mq/13IB5IXdEkLb3FxrO+st3R5lkIHrw59HPVIlAaR?= =?us-ascii?Q?2ObTj1fp9jIusnLCmLtRXtDrMj3WUq381BYlPCLhL8CgSfkiDuVNh/03KnnE?= =?us-ascii?Q?PanUgTt1QcghNXlhDziFYYiDmrAKl9VX0T0RbzLcSQaCbow9u5Zx0S1uv8pL?= =?us-ascii?Q?/Qod+iaqMTUP+w8xZhj+uNuQgJy4Zemi3N//9ucwy9zhGqWZM3Nww6GUxRQ9?= =?us-ascii?Q?HLz1QCXGJpf77h8c8RzkbrhnN2yr+aAgT5qxF4tc75oDjxIckHJatRtbL4OV?= =?us-ascii?Q?GqTVGbO7kJHPVUUlqtMqZS4m7VuIlEs3nlO8CXeR5FxvqmgHO609BaPWO86c?= =?us-ascii?Q?6lH4VQ1+MxcYrLfbGsWaBNC0LZqqhQ3QAV0jSbeOVDRlGkeWXzO7rlsUYvsQ?= =?us-ascii?Q?XVlt4qoc2o6g8Tlfydx0eX0BZJxf0evJbAfS4X1n/sN9equ6n6j1kz1wrj+O?= =?us-ascii?Q?3U+64EyBoZoRHnNjm8iRJQDcc+VDw+/l+w6bu8aHiF80r6/tz1eHGvKl61N9?= =?us-ascii?Q?yet5mAokTugWlU3bvOxgq+bBEdgBt2dqpg8wTQVkW8JRkNBvHS87vspfyzdH?= =?us-ascii?Q?iznOyTUeLoO8Cr0bv0u6SvrL/VBBb1gUy1NzZfAz39b3kh8/rSk3uhwqAvzY?= =?us-ascii?Q?+LxFfC41Y7LXoCnccMw4vGwziCwFIczGEj8HwbMi3ET7rQ4GKE7szgTOVjiX?= =?us-ascii?Q?Q3HcfnKo6qgypNP2oskybcvqk50VNqmqFM7cnTXjmkj3uSbHO41//Sm8iwKF?= =?us-ascii?Q?kXwB6rsTxmCpJ3mpbKgThhYC3vXyghUrDbeihXUt2S+mNkaMifJMx7aQIROJ?= =?us-ascii?Q?C0ZzoayHrOudNv0uUUOIk+us?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebd7701a-964e-40f7-cb6c-08d98f76b068 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 00:56:57.7107 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qWIveUP2TdSPgH4JWNV+jdPxWOQkm++Qtfk+H88eyJ4JrxHSiCZinaQKpKnfxdR0B4vLltS6cvCc80pBF23JXV6DpEaKGHFKr1K8LgbqWzg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1760 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Oram, Isaac W > Sent: Wednesday, September 22, 2021 2:35 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug >=20 > Fix issue with missing debug messages on ESPI_ENABLE configuration. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Isaac Oram > --- >=20 > Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHo > oks.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform > Hooks.c > b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform > Hooks.c > index fa695358bf..8a93f41678 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform > Hooks.c > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform > Hooks.c > @@ -116,6 +116,13 @@ IsAspeedPresent ( > IoWrite8 (ASPEED2500_SIO_INDEX_PORT, REG_LOGICAL_DEVICE); > IoWrite8 (ASPEED2500_SIO_DATA_PORT, ASPEED2500_SIO_UART1); > if (IoRead8 (ASPEED2500_SIO_DATA_PORT) =3D=3D ASPEED2500_SIO_UART1) { > + // > + // In ESPI mode, assume this SIO logic device always present. > + // > +#ifdef ESPI_ENABLE > + DeviceID =3D 0; > + PresenceStatus =3D TRUE; > +#else > // > //right now, maybe it is ASPEED. to detect the device ID. > // > @@ -143,6 +150,7 @@ IsAspeedPresent ( > if ((DeviceID & 0xff0000ff) =3D=3D 0x04000003) { > PresenceStatus =3D TRUE; > } > +#endif > } > IoWrite8 (ASPEED2500_SIO_INDEX_PORT, ASPEED2500_SIO_LOCK); > return PresenceStatus; > -- > 2.27.0.windows.1