public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Luo, Heng" <heng.luo@intel.com>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable bar feature
Date: Thu, 7 Jan 2021 07:19:20 +0000	[thread overview]
Message-ID: <MWHPR1101MB2160EEDE2E9CF3AD9CDE169DCDAF0@MWHPR1101MB2160.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210107061809.86-1-heng.luo@intel.com>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng
> Luo
> Sent: Wednesday, January 6, 2021 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable
> bar feature
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3158
> 
> add:
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> in dsc file:
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
> 
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds
> c        | 3 ++-
> 
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk
> gPcd.dsc | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> dsc
> index 84d4ec1331..316a2a94e9 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> ds
> +++ c
> @@ -1,7 +1,7 @@
>  ## @file #  PCD configuration build description file for the UpXtreme board.
> #-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>+#
> Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR> # #
> SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -181,6 +181,7 @@
>  !endif    gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE+
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
> gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800diff --
> git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> PkgPcd.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> PkgPcd.dsc
> index 4a7ba4d5f0..7b710109f0 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> PkgPcd.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> Pk
> +++ gPcd.dsc
> @@ -1,7 +1,7 @@
>  ## @file #  PCD configuration build description file for the WhiskeylakeURvp
> board. #-# Copyright (c) 2019 - 2020, Intel Corporation. All rights
> reserved.<BR>+# Copyright (c) 2019 - 2021, Intel Corporation. All rights
> reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -
> 181,6 +181,7 @@
>  !endif    gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE+
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
> gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800--
> 2.24.0.windows.2
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#69901): https://edk2.groups.io/g/devel/message/69901
> Mute This Topic: https://groups.io/mt/79493970/1767664
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [nathaniel.l.desimone@intel.com] -=-=-=-=-=-=
> 


  parent reply	other threads:[~2021-01-07  7:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  6:18 [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable bar feature Heng Luo
2021-01-07  6:41 ` [edk2-devel] " Chiu, Chasel
2021-01-07  7:19 ` Nate DeSimone [this message]
2021-01-14  3:42   ` Heng Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR1101MB2160EEDE2E9CF3AD9CDE169DCDAF0@MWHPR1101MB2160.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox