From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.453.1620940763582400540 for ; Thu, 13 May 2021 14:19:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KhvxMc+b; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: QucaddrG6xKX8jwIrzfIQKbnKuxChTFRHA0iLKXET34r8jJf6bn5GIxhqgXFwYyxZTLjUC+Vvg IuNTcCO3tRSA== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="179650739" X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="179650739" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 14:19:22 -0700 IronPort-SDR: WsrN8F/9beXddmbeArOR19ghTPuCJ+pj+WSvhyIOGnyPmbcxMy6tEhJBGwNydUykGCNwOTV2dW CmkqVVpDYYpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="435999287" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 13 May 2021 14:19:21 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 13 May 2021 14:19:21 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 13 May 2021 14:19:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 13 May 2021 14:19:20 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 13 May 2021 14:18:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SyPIuqjPwoSQV9FPdU+of8khpMIasJ/42EJfjaC4ygTjjP3ZZ9J/RO1T5Bwrx4X7p5PptwjYnsMDa0IXXLd4vBQo3WXioaYe2ghsucGv0OCASd6Wwd515/al1fk6s3YdQa7kAbvkqJ4q8N0ubg22wUky4UMhnRw0Xum6mI3eXp2eXaSWAlP+gvEOw8LaCKzpn8yUa3MB5FgooBmPsnH/0lyUl8aJexOrUOfsZbxBL66LmgbGvasAsiXrtxifQfYO67d4OYnTut0+OBqaVetU/Ja9/7lb9pzKoM2QYZUd51/ZetEzptLmInhSNB7Fk8sPyNh4owFCbi9J1SclYMeP3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x56BoKmZ5zACrC7h2Rv1SeIJfj2/uq79FYFfzUFfiUc=; b=iqkvEfm3OqoCugwVaH+4lOCwZpzaTmtJZifp13C6Z0w4ekKY8i4zyhspB00cd+VJWWmnFujOlL1hLsO1AddYlhGh+5iWUi9KQBUGRUvsP40DA0UwqFeH2BhyKLUF886e1DGRayHE1wPVh/XRs048sCUmxsYWIwSfVeg/TICAeSZE1yFQTnhNOXiFeY9tYF+FiPVfRipuZzGWDH9qsML69MwwN6vJTes8CG/csg09joyseEtfXaTM22moPabDzK6AeFcvmS4QNHIQdX9t6Jk8BQQSraCDOprkCgB1KoWHn43/PCkhOlluP5H6ck2hsSSiTR0IX5lIopPCQw1u4kSt2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x56BoKmZ5zACrC7h2Rv1SeIJfj2/uq79FYFfzUFfiUc=; b=KhvxMc+bnJDAHAfI28URoxMT/Am3Lp5Jv8LIq8mRb8b7JnZotsalmVkHPwkJzvYJ2yXbIIF9nntYOBMw8ApZVybHrASiWrGz2hFJIkADNsCpczFlder6xRcrkAduDSZDsuNbKWB4OJWvQI6ihAiE9omVv03Ee/5Yowf3JGAOxAw= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MW3PR11MB4746.namprd11.prod.outlook.com (2603:10b6:303:5f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Thu, 13 May 2021 21:18:54 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::6540:bca7:645a:6788]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::6540:bca7:645a:6788%5]) with mapi id 15.20.4108.032; Thu, 13 May 2021 21:18:54 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , Michael Kubacki CC: "Agyeman, Prince" , "Chiu, Chasel" , "Kethi Reddy, Deepika" , "Dong, Eric" , "Luo, Heng" , Jeremy Soller , "Esakkithevar, Kathappan" , Liming Gao , "Chaganty, Rangasai V" , "mikuback@linux.microsoft.com" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 00/35] Consolidate SpiFlashCommonLib instances Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 00/35] Consolidate SpiFlashCommonLib instances Thread-Index: AQHXMmjAxoWvG5GWekqC+YYhHNHK+qriFVKQ Date: Thu, 13 May 2021 21:18:54 +0000 Message-ID: References: <20210416023152.771-1-mikuback@linux.microsoft.com> In-Reply-To: <20210416023152.771-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 306d611d-16e4-4831-4d49-08d91654b6ba x-ms-traffictypediagnostic: MW3PR11MB4746: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3OCkWuOAwuZcCX1SG+PZM+2pxH8/GseO7neBLhAQzJj8z25V5UOy8jijfagV3r1ItiOSSmZoZCKtLk13nj+rPdp5vbdP5Rk/lHzHagUkYp5sVmTEFZ8BgErkVUKzsaYub+b5P6+YQO21D9EDAdDGqYrfoLD5oJPftIiYnrC50sClWL+cvncAa3xGDSCmNknloInNbCt4ID0Rbgo/xLFaI/9J2ESo3z+LAVLfq/DAq5jh0m9cKD7rs//Jv5SPlU4EiJeFTIaBZedGLnayYw9qoASu7+xdS6LclzC3AAG/Tnzua22etTfkZypuasYgOb6XvBWJtXdRlCNgk5xLcALfi4Tle1vkeUG0k9QY4bwKXUJDRLVkD+6uk/SGrvu9U4OnSH2IMS8CMJJfopyEszg8UotjpLz9R7JLeK26BpYIzxJh0bf16MImGzQArCuFnOauZlus54tGQI3Fiqh2vQ5riKAQOFwnCnh+cHDOk97NAuvhadYwDwXStdwkqBtgUL4hi+i+Iuxoid59xAm7aY/B2HeTuLFGtzkt+1EcTvZvRADMVGXvhbVVTWKkW6xPFkRde5nikdzVtv3a5IGA4qvFVzBHrqLSd0IMJ1MEXVe9ETOt4w3OOgkXz/v5Q23lst3EB30gWceqdKIejur1/qfPMXMNuEAoDYIgsOQOxxdDxjeH8vywVmuiXijqZ43t71DfoJTvrSChiJScX80MXzEUGWmQoSyXb+JRq3FFwYOkiKQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(52536014)(54906003)(26005)(110136005)(64756008)(76116006)(66476007)(19627235002)(66556008)(66446008)(66946007)(30864003)(5660300002)(38100700002)(122000001)(71200400001)(6506007)(7696005)(9686003)(83380400001)(33656002)(86362001)(8936002)(53546011)(8676002)(55016002)(4326008)(966005)(186003)(2906002)(498600001)(559001)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?W53MgEqzSlPWu4DamMeKOzJ0LpQk4mlVKp/J5SojeaCr2PAsU1i/nOcRZ5HZ?= =?us-ascii?Q?HOMRTWTFK62A09ywihGBUD0p3DnBnpNdXCkYFQVencN9oBAAzYE392eAGi7P?= =?us-ascii?Q?5IXRefNnBgYOI6d0aoORWILyIFmeZPQEv6Hd9+Xo6iblq5kFZuncd98q7XAY?= =?us-ascii?Q?QHIfLKQ5WAjb5zcIEz44MzSDL2GJUqX4ceByQpEWUXr+qo8V4Ax88TDLbL+d?= =?us-ascii?Q?3pMd/OaSSsGmYAlu4W4/jC3K5tjJu9bTn7X8JSIpkOC6jk9nWPsYBNMUSr5d?= =?us-ascii?Q?iWom+kln4fc0DLh8b46S+pv+mWm9bHtRDw4JvAbqkwAiISuKgj6i/AFkTf1h?= =?us-ascii?Q?YExtTmMJy3vv9jvkdo/jx1oIfJbyKAyKlv8FV8PSnANrFN6qjGc57Q5C1eA4?= =?us-ascii?Q?Tloa2R8UXeqWGVk8re1VWSWFAHjtmhJ47mSwcqhDIH97BPF8ajpM89YJoSDo?= =?us-ascii?Q?MSOS9f8LypGb9XoystobBRbeHVxYonP0NP7thoi4QZmSfS+1kwIaD6UZ4DDE?= =?us-ascii?Q?AmipaZpw80PoPkq1rKZJhCZH8/QaBctij2JXgd4rFpVv/5ba9PzfOnufFgJu?= =?us-ascii?Q?JrtUZrbxAOAyY2JqIjhRFu0gYWmyzT1fXMsMDb6ProfZa1ymoMl/ehC8v3q4?= =?us-ascii?Q?w/SS/EwEoy+Vz57z9jxBZcYsiK9Kis+7n7teWlQAQLMUtrzC2i7GdxSghap6?= =?us-ascii?Q?0UL6a3pcA32ocHC0B+RUFa9CtlBfWEfBreCsD0qexc7JKEA+48SDKGXdI7jS?= =?us-ascii?Q?FhuqIHxywHwqk/TZT9Q0iy9y/SGosLoEKTGqbt/cwn2ZcjZFTusczA3nmuht?= =?us-ascii?Q?AtgUAgseBujQ4kP5jLgt5FZf3xxzrniXKLmOt1MMlsXxIfteATdcVLRYSx/I?= =?us-ascii?Q?iN+0rAz8LrDTb8fHSfuOkO9VPx27+y7tkmeA5dyBB1h14LF4+sdH8tVC4CGa?= =?us-ascii?Q?Tub4LeEAy3zTRwZJif3AHtq7quY0TkICozY4/ewkvQTWrk36VzXeUlPDJPWo?= =?us-ascii?Q?MOiXzyX+LsJCoRhDHqg/tlrUXh3VtgHu/Lr1uSWDmM7P/SNCngVr7wk8yOtr?= =?us-ascii?Q?CEYrVVjUaW7RpavkKK0Hn8QZ0AI/qou/J2qIW/yrPkfyO+xmpcCfSV9si7r2?= =?us-ascii?Q?U56K41sGdu9v0KqG5YnTtuk2HIhcQpJODEgucbkuk4CbPOFjzoLf4uT0SqQ5?= =?us-ascii?Q?oT5rSNXWqybr5Q2aPYLv+TTro4oQN3pZSN6nAJvUdbf13Lx8MXobMoUFMFgx?= =?us-ascii?Q?Yoqyj5meXDeZEZtmKun8LCvHFuEGGqf1XMA2EiTXftv5IHzCAUqtf0bZNlfy?= =?us-ascii?Q?FKUTHrNcCtg0Nbwjk5ll4A58?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 306d611d-16e4-4831-4d49-08d91654b6ba X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2021 21:18:54.7612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MsGFNpVg1QARq0hXWP303127MelWvJIxGu6bLaKhP5Ao68IZcWDptl2IglDp3iIyqsdPltTXEGa2G/utGiPYO3RhLVbwFejnCwfK5dw/X7Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4746 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, You patch series does not apply to edk2-platforms master branch. I tried bo= th today's tip and a snapshot from Apr. 15 and I could not get your series = to apply at either point in history. Based on some of the SHA data I see in= the series I suspect you didn't have the parent of this patch series deriv= e from a commit on master branch at the time you generated it. Please rebas= e your patch series to latest master branch and send it again. Thanks, Nate -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael Kuba= cki Sent: Thursday, April 15, 2021 7:31 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chiu, Chasel ; Kethi Reddy, Deepika ; Dong, Eric= ; Luo, Heng ; Jeremy Soller ; Esakkithevar, Kathappan ; Liming Gao ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [edk2-devel] [edk2-platforms][PATCH v1 00/35] Consolidate SpiFlash= CommonLib instances From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 SpiFlashCommonLib is duplicated in multiple places across the MinPlatform d= esign in edk2-platforms.I'm planning to build some additional functionality= on top of SpiFlashCommonLib and, ideally, this duplication will be consoli= dated into a single instance usable across all current library consumers. This patch series focuses on consolidating the various SpiFlashCommonLib in= stances as agreed upon in https://edk2.groups.io/g/devel/message/71701. Read the BZ for more general background around this series. I only have an UpXtreme board on hand so maintainers/reviewers of other boa= rd packages should test these changes on those boards. Cc: Agyeman Prince Cc: Chasel Chiu Cc: Deepika Kethi Reddy Cc: Eric Dong Cc: Heng Luo Cc: Jeremy Soller Cc: Kathappan Esakkithevar Cc: Liming Gao Cc: Nate DeSimone Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Michael Kubacki (35): CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry WhiskeylakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GUID to INF IntelSiliconPkg: Add BIOS area base address and size PCDs IntelSiliconPkg: Add microcode FV PCDs IntelSiliconPkg: Add PCH SPI PPI IntelSiliconPkg: Add PCH SPI Protocol IntelSiliconPkg: Add SpiFlashCommonLib IntelSiliconPkg: Add SmmSpiFlashCommonLib IntelSiliconPkg: Add MM SPI FVB services CometlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs KabylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs SimicsOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs TigerlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs WhiskeylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs CoffeelakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs KabylakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs SimicsIch10Pkg: Use IntelSiliconPkg BIOS area and ucode PCDs TigerlakeSiliconPkg: Use IntelSiliconPkg BIOS are and ucode PCDs CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib SimicsOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib WhiskeylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib MinPlatformPkg: Remove SpiFvbService modules CoffeelakeSiliconPkg: Remove SmmSpiFlashCommonLib KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib SimicsIch10Pkg: Remove SmmSpiFlashCommonLib TigerlakeOpenBoardPkg: Remove SmmSpiFlashCommonLib MinPlatformPkg: Remove SpiFlashCommonLibNull KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add IntelSiliconPkg.dec CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol from package KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package SimicsIch10Pkg: Remove PCH SPI SMM Protocol from package TigerlakeSiliconPkg: Remove PCH SPI PPI and Protocol from package Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommon.c = | 196 ------------- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommonSmmLib.c = | 54 ---- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/FvbInfo.c = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceCommon.c = | 4 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceMm.c = | 8 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceTraditionalMm.c = | 0 Platform/Intel/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/SpiFlash= CommonSmmLib.c =3D> Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommon= Lib/SmmSpiFlashCommonLib.c | 0 {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSiliconPkg}/= Library/SmmSpiFlashCommonLib/SpiFlashCommon.c = | 3 +- {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconPkg}/L= ibrary/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c = | 12 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlash= Common.c = | 196 ------------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlash= CommonSmmLib.c = | 54 ---- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c= = | 194 ------------- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSm= mLib.c = | 54 ---- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCommon.= c = | 26 +- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c = = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/Include/Fdf/FlashMapInc= lude.fdf = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf = = | 42 +-- Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/Pei= PolicyUpdateLib.inf = | 2 +- Platform/Intel/CometlakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.in= f = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude= .fdf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc = = | 10 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf = = | 44 +-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclu= de.fdf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc = = | 10 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf = = | 44 +-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSilicon= PolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiSe= rialPortLibSpiFlash.inf = | 1 + Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec = = | 2 - Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc = = | 6 - Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc = = | 9 +- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf = = | 2 +- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf.inc = = | 8 +- Platform/Intel/TigerlakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 8 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Include/Fdf/FlashMapInc= lude.fdf = | 4 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/WhiskeylakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPolicyUpdateLib.inf = | 1 - Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.= inf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Fdf/FlashMapInclud= e.fdf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/BoardInitLib/PeiMu= ltiBoardInitPreMemLib.inf = | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc = = | 10 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf = = | 42 +-- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Include/Fdf/FlashMa= pInclude.fdf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc = = | 10 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.fdf = = | 42 +-- Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolic= yLib.inf = | 4 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Protocol/Spi.h = = | 295 -------------------- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf = = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiCommonLib= /BasePchSpiCommonLib.inf = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpi= FlashCommonLib.inf = | 51 ---- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf = = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec = = | 8 - {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceCommon.h = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceMm.h = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceSmm.inf = | 6 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf = | 6 +- Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Libr= ary/SpiFlashCommonLib.h = | 2 +- Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Ppi/= Spi.h = | 4 +- Silicon/Intel/{TigerlakeSiliconPkg =3D> IntelSiliconPkg}/Include/Protocol/= Spi.h = | 0 Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = = | 19 ++ Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc = = | 17 ++ {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSiliconPkg}/= Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf = | 21 +- {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconPkg}/L= ibrary/SpiFlashCommonLibNull/SpiFlashCommonLibNull.inf = | 3 +- Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyL= ib.inf = | 4 +- Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/HstiSiliconDxe.inf = = | 3 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h = = | 26 -- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/Spi.h = = | 293 ------------------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf = = | 1 + Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpiFl= ashCommonLib.inf = | 53 ---- Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf = = | 1 + Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec = = | 13 +- Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec = = | 11 - Silicon/Intel/SimicsIch10Pkg/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Silicon/Intel/SimicsIch10Pkg/Include/Protocol/Spi.h = = | 295 -------------------- Silicon/Intel/SimicsIch10Pkg/IncludePrivate/Library/PchSpiCommonLib.h = = | 26 +- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommo= nLib.inf = | 50 ---- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BasePchSpi= CommonLib.inf = | 5 +- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf = = | 3 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiCommon= Lib/BaseSpiCommonLib.inf = | 1 + Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf = = | 1 + Silicon/Intel/TigerlakeSiliconPkg/Pch/PchInit/Dxe/PchInitDxeTgl.inf = = | 1 + Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec = = | 8 - 89 files changed, 323 insertions(+), 2407 deletions(-) delete mode 100644= Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommon.c delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFl= ashCommonLib/SpiFlashCommonSmmLib.c rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/F= eature}/Flash/SpiFvbService/FvbInfo.c (100%) rename {Platform/Intel/MinPla= tformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/Sp= iFvbServiceCommon.c (96%) rename {Platform/Intel/MinPlatformPkg =3D> Silic= on/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceMm.c (94= %) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPk= g/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c (100%) rename {= Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}/F= lash/SpiFvbService/SpiFvbServiceTraditionalMm.c (100%) rename Platform/Int= el/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.= c =3D> Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFla= shCommonLib.c (100%) rename {Platform/Intel/TigerlakeOpenBoardPkg =3D> Sil= icon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c (= 95%) rename {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelS= iliconPkg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c (83%) del= ete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCom= monLib/SpiFlashCommon.c delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlas= hCommonLib/SpiFlashCommonSmmLib.c delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonL= ib/SpiFlashCommon.c delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonL= ib/SpiFlashCommonSmmLib.c delete mode 100644 Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashC= ommonLib.h delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Protocol= /Spi.h delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFl= ashCommonLib/SmmSpiFlashCommonLib.inf rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/F= eature}/Flash/SpiFvbService/SpiFvbServiceCommon.h (100%) rename {Platform/= Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiF= vbService/SpiFvbServiceMm.h (100%) rename {Platform/Intel/MinPlatformPkg = =3D> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServi= ceSmm.inf (88%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/I= ntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf (= 88%) rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/= Include/Library/SpiFlashCommonLib.h (96%) rename Silicon/Intel/{Coffeelake= SiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Ppi/Spi.h (85%) rename Silico= n/Intel/{TigerlakeSiliconPkg =3D> IntelSiliconPkg}/Include/Protocol/Spi.h (= 100%) rename {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/Inte= lSiliconPkg}/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf (69%) r= ename {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconP= kg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.inf (91%) delete m= ode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCom= monLib.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/S= pi.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlas= hCommonLib/SmmSpiFlashCommonLib.inf delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Include/Library/SpiFlashCo= mmonLib.h delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Include/Protocol/Spi.h delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonL= ib/SmmSpiFlashCommonLib.inf -- 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74153): https://edk2.groups.io/g/devel/message/74153 Mute This Topic: https://groups.io/mt/82133937/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@int= el.com] -=3D-=3D-=3D-=3D-=3D-=3D