From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.4034.1607505181180157291 for ; Wed, 09 Dec 2020 01:13:01 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=YSHdVvYV; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: NiVQOO/JtAMg5RtAOHayXMSjrruazyVXdv4eattAZOsCSFRnzxnxdVt9kbuPOphgWPMO9STPUY F/KzTF21w2hg== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="153283446" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="153283446" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 01:13:00 -0800 IronPort-SDR: UUd65ws14q32IM/J2zAnmPOO33UADfEaCdB6uQ9YyKx/FXURCmys+b4x/6okO04lAclhjznlse qzDDR/10c4AA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="318199201" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 09 Dec 2020 01:13:00 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 01:12:59 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 01:12:59 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Dec 2020 01:12:59 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Dec 2020 01:12:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4d9xTia1/8aoQP4ySrUs/vsG4RwdEVaZXrBUEYqIcXS8wmiFgbcIO4elnWuqjWHW9WHoimFsNYrevs4Mo5UO3gIWX2KRw5u+hA95oyWHKLnSgI2vU1jYTCoEiyUmCmssc92yHF6xVg24WY8+Nr+COkbi4MUow+5rkEWBsTGi6CtWLNNk10Q980Df78ghwLnwhjPHTpG8gbKnTmHs9aZvelPDiRJ9zBd+366xqJPBtZHa4yrojknoTFLK+SmAi8rB8/h69T4JGsVf2xY4ioMZ6xVyQT3Ts2oSPIwdq2eIqF84XaXAeQn2J7SPVbdt+UBdVb19twqpeGVONVxHFkuOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xTCBxzuXXSXwNNkwA2kbgL/dRr8diL+3VITpbhMQIG8=; b=GrlGtTAgcMCF4vPFKcfrXAC7vULaLxM3T/d/A6AdA5uNZj4Atmw6cU4P1VsMAP8S4WkaWU+Ppl/5jeEnnqGAp+SK+5RueyC116rWC6p4+gzFOH0AUXz82T4mJ4RoIZD4ldKKObCRBujAueUgEmrpoBpBZIUjLJmSVoZkzVR6jo3sWDgAyMZf3ptXHuXMc6/X1hSKGbfMSGKQ8GJwHetqvexEnFEO1I09+pCVlcMGAcm/gOKIELEKfkxmG3CK9hE3jBa2I1k4KFBS4I+UVazhQJ7b/bbKCWjlwTIibq8/belzk7AqtaANuUdEhhujJwFveCzaq98SwIzCZ/RKwgz1pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xTCBxzuXXSXwNNkwA2kbgL/dRr8diL+3VITpbhMQIG8=; b=YSHdVvYVcRXkjo/AL1LgZLH+8tF8NZ//RdzQIsKyB9ou2tslRixemy1UCS7wqKRLS8Yx5hfgEk4M8r3XWsfAyC4jCUOHrnawKqFomF/FaIXUX2NrS/jEA0I8LycrbWt5V+esv2IbODdf8ACwzhsgry4fDwav2vfJuS6LdQhE9d4= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1760.namprd11.prod.outlook.com (2603:10b6:300:10e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Wed, 9 Dec 2020 09:12:57 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710%8]) with mapi id 15.20.3654.012; Wed, 9 Dec 2020 09:12:57 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Chiu, Chasel" , Liming Gao Subject: Re: [Patch V7 2/3] OpenBoardPkg: Configurae PcdSerialTerminalEnable Thread-Topic: [Patch V7 2/3] OpenBoardPkg: Configurae PcdSerialTerminalEnable Thread-Index: AQHWu7g8zKdDpbMhB06l2OTf4KK/U6nun4Bg Date: Wed, 9 Dec 2020 09:12:57 +0000 Message-ID: References: <20201116013124.1983-1-heng.luo@intel.com> <20201116013124.1983-2-heng.luo@intel.com> In-Reply-To: <20201116013124.1983-2-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f6164346-a17d-469a-c4f1-08d89c229e74 x-ms-traffictypediagnostic: MWHPR11MB1760: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:42; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w3Gd1OwPJmKza9ZCkiSo3T+axFI48TLKI/kpyYnuPzKp+eoKNSQxyqZunMV7QjR2r6to+ED6Ly7fJK5U6Eyy8twFUfUmt0BNKNPCbHkCxh2qnMz5l4vDao3cePac0ik1bgKIqRh5TP84wPY+9VhyWcJbvECrk4zoQzqsMn09X3I+PEI9O0PwB6CcJQNzeBxhdhSoRCcrlZxP77uYjhC4jhP8J6oPXsP9VoKQ23kCE1Z+Hji2cshuCT5fh3ex4U0vmzXQ4/s33oToNxZp97Z+p78lQ2GThCq1Rxk6xVaCcdpaoKU0nsBVmavh7cvk8rkn4AY0lA5OK1I7RR2HI/4dMVoRTJCXWLeo6zBqDpm/irIWuLy2/3bQy+nr59pX8DSEGIhRHE2xcj3hFEofRfvClg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(346002)(376002)(54906003)(2906002)(33656002)(966005)(86362001)(71200400001)(55016002)(186003)(66556008)(110136005)(4326008)(53546011)(508600001)(83380400001)(66446008)(66476007)(52536014)(76116006)(64756008)(26005)(8936002)(8676002)(6506007)(9686003)(66946007)(7696005)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?qWM8gkg5qDQgHXiVeWPSrQpPJoWC3eP73mEoHlcRYp1KkcyLzgzQUUrBcGQM?= =?us-ascii?Q?S9Xs0qxD5v0b54IPtZBV8BQYdv0mW8+hw898oZcHvXWYUqy0yFBFBwZU11AI?= =?us-ascii?Q?yZxkLaptqIpjfxC0+V2NbVFZ2LXYIoNhBD3mTlSl6cNpQCpfVn4NhzoR5j1m?= =?us-ascii?Q?unfuXN6HBrtk7PDw6r2AHPAsQdAHLH4Xx+a3qgBtqWy4d5L0yI9ekptv9jnF?= =?us-ascii?Q?cXLxFNsG4YKijCeCJ7lZx3Fe6BKMjUIR7nh06fah7T4Y6Br2yh4YLC5g3okn?= =?us-ascii?Q?HRlEkBMrxW4Zc1rzJFaSL79TUvp5nBc+OM3UKZXTETDy1ypniLHDXBnN7JBr?= =?us-ascii?Q?qEFv22a1pjS40LnlA8Z/zV2w6Ft4wriFnAxbigTF2Tb6wDctEjI5RfcRBBjl?= =?us-ascii?Q?/VQQmqyba0czeZYep4utkToC7fPpPMjJ+MWPwqeK4f+1DfhBpYxZTYceb92T?= =?us-ascii?Q?Yz0uRCI0MOMSn7Ch/ENdvlX+NOrEQFtF5RG39IJB3SkCXhbW0JXKKWXTCum3?= =?us-ascii?Q?cuv8XgUtPb1zP3O4T+hxASA+9ZG2R5jfYlF8VMpG0VhRG4RPLx8qzB1qYX/h?= =?us-ascii?Q?LUEcEktFjeG3hQOzw/ViuEzMkJ3TPpRbHAWcqVeqtb1mUOwAzvHHgqyuA/1i?= =?us-ascii?Q?0NB9v5J44AOcCK+3btyR1fzKaPl3aJgfLems7sBNyIjJsDdX8AMKIn466KnN?= =?us-ascii?Q?NelZKI40vkklIMn8DB9qEG3pNWTTqHD//aXVNtj8cQkOwPBpRSyFDe50Rbd6?= =?us-ascii?Q?1OBKp7orvmSnRtgsoAO42aD5HyOaQR0bytNzfswskMQOJnilmQT62b1favyH?= =?us-ascii?Q?hjyCNg3h8TMD+mvaLXuaEw2DIUsgyCSGo6mhltBo9JYDB/9DN1nat9UzElTs?= =?us-ascii?Q?4nA5mO0O4KISGIi+Kwf1gckbd5M9c1GOkHlO2rOu/z01ZciB4acLEtHI6y+L?= =?us-ascii?Q?Sby15zVKm+hWp+8KRkdyI3AGXYiSv2QNHHaEKnaOD2M=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6164346-a17d-469a-c4f1-08d89c229e74 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 09:12:57.3369 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cDoJHl721izTNRvP4RMSUCv9b2UM2FG/oWSwGi8RbZia2Guv4nrU+XNQ34yyNEdtY48kfgdiKORgwOm7gtybvRGpdKDdayLlpd+q9dxbH74= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1760 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/8f088a1 > -----Original Message----- > From: Luo, Heng > Sent: Sunday, November 15, 2020 5:31 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Chiu, Chasel ; > Desimone, Nathaniel L ; Liming Gao > > Subject: [Patch V7 2/3] OpenBoardPkg: Configurae PcdSerialTerminalEnable >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3014 >=20 > Enable Serial Terminal Feature for UpXtreme, and disable it for other > platform by default. >=20 > Cc: Eric Dong > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Heng Luo > --- >=20 > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPc > d.dsc | 1 + > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > | 1 + >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds > c | 1 + > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds > c | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk > gPcd.dsc | 1 + > 6 files changed, 6 insertions(+) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd.dsc > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd.dsc > index d611e99fc1..589b002d06 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd.dsc > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > Pcd > +++ .dsc > @@ -131,6 +131,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > index 352416a489..44dacdf082 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > @@ -130,6 +130,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > index 9e8b148753..725596cbf7 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > d > +++ sc > @@ -168,6 +168,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > index 52cdf9ec0f..251f46f812 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > +++ c > @@ -50,6 +50,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > index d797ae9d94..e161bf06f4 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd. > ds > +++ c > @@ -127,6 +127,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|TRUE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUEdiff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > index 5d769e8153..83ada3c95c 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ gPcd.dsc > @@ -127,6 +127,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+ > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE !if > gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE-- > 2.24.0.windows.2