From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.20447.1629091882014401536 for ; Sun, 15 Aug 2021 22:31:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=rfyshgdU; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="202955280" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="202955280" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2021 22:31:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="448331410" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 15 Aug 2021 22:31:20 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 15 Aug 2021 22:31:19 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 15 Aug 2021 22:31:19 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sun, 15 Aug 2021 22:31:19 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 15 Aug 2021 22:31:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m7kzr8ddneOildoy027aeNeLPhXRst+GHfCLEZalCWTts4oClk0K3IJY3/1pEhQKX60GjGgOiypiA33g+CtCemIx+YLEvzE5cPQQRWPLzi3yn87Dw8lafrf5Zchf1qJhvHOBkqOUH0jsaAhxHPly6AXmuKWf5EpsyutMEShbgR948uKPS3X2QJ1+ZI5Zzq0EtnVzbLsBM2vDIAaHgdpxLGS3Ao/kCffuCTatvutMRbK6PgJV0ULXjvhkBGTpV5klVIHPt67VUzB1AnHU7GyjS+1wPEZXD/3fNWUJXAocSJl6bGF3EgE03p40vhQA6Qvk7sbmjxSij3MAO/OjxQGT+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZ2jR67TZswiHH8B642mNy0eLLUS1tsb553261f7vCk=; b=blVbsXSNCl3wP4lfzGybX0ThNCdjR1hjgSQG+NuWR/+ZynR4Xr3C+p6vBu5eThr/zt+TUbdsZc3cZ5rpvunrhdhHqCI75EJ1Jh4b1l0mM+rpxqYUNW8VYGjI1W1R1sFXoJT2vCGPK8u7Wj5ExS4SXnpXCLugaMhojQJHqa+jvlypxYIzejkCLJeYldVY8pUkPBwuuHS2itmOUxYccg1pXDd8p6LA3MzFfSvaKZdUffzlGwyS9tUA+WMeTMBatIg/LsakU7z7d4Gzo5GjujALEjX00tuIDmWLD+n5Mg1/ClGI3VO8MyYFYQzFujxs4/hQb9pdJpJOJO9X0/5CsRNP4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZ2jR67TZswiHH8B642mNy0eLLUS1tsb553261f7vCk=; b=rfyshgdUWhf115jNsc7Hkfp8PlOft+zPel0GQoIjj0///ObNLC2WtfGsNl2g77cIubhv5fm4NVjsjNmzhmh0xVVBBoZMgkDLwDzaq27uALOEr3n47lb7S58EiicaGHkXumLV1Gz8vKiQShlWmk/8qy855M8cElBBypgIkEhWCZ0= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR1101MB2255.namprd11.prod.outlook.com (2603:10b6:301:5b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.22; Mon, 16 Aug 2021 05:31:17 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4415.023; Mon, 16 Aug 2021 05:31:17 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Desimone, Nathaniel L" , "benjamin.doron00@gmail.com" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v2 0/5] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Thread-Index: AQHXkKLa1ww7ZUSHkUW/M42rxf6CXat1mMJwgAAEqsA= Date: Mon, 16 Aug 2021 05:31:17 +0000 Message-ID: References: <20210804203630.7080-1-benjamin.doron00@gmail.com> <20210814002445.10084-1-benjamin.doron00@gmail.com> <169BB1F1F47FC595.23238@groups.io> In-Reply-To: <169BB1F1F47FC595.23238@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9746c43d-82ad-4b34-e2f4-08d96077127f x-ms-traffictypediagnostic: MWHPR1101MB2255: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9sBm8QrQlKud2paUHPdwZEz99glq4WcTT1eOuUqrKeI16/uCSHFRD37CZugyfBfVAfK0bZEFiVuMhKZaxVX4ynnl+BybmblPrsrv0EcQawc+DFRejEMod+pfKTq0W2fzSdHQ7HrDFEhKgpPYd9098kwiLN8qirBGybpGR0CPHHiYf27UVjaWqnkQ1yOE4pgth1ZFXUOXWZzYg+Axt+Itf0+FS5aYg4/Fbq67bDpbtEE3gRYYB3tp77nQwkYsVlVpt+lR/LTe621AbAnH0Rtra+YrqqOAWJO3NRBpyNeCaGdE6FRmASD2DjjRAP73f+QsmTCaGcIghfeavt60s1q+PAqK8oQ1qclPo6k82RRFnLDNiLaCQQ/+esMopwp3VL0Aa1jiEjw9vlC5BPPjt5/UI6yNPw9aaMEr/DFeqm4NrC1ULiK+0xOD56g/JqYIMfbNPfcXCD8AXUv9Y7Xv/+EDOxgv8ClLFPqGLN1Crq8nzofUZFzswMbIyKt0+YVHoZuA4c1yZRBuGEdNGdRTPhCqiA7kawhOjRZT3CIaT/Rgn6eM5Pz2Y+kBIDmFAD+/UQoGCbp9T5T6GR9eLukwdRbbragq+kFtlTJVXI0BfJA5x+T8kSjLTzIXofiBDtWPpb//CTSSGG33yoZd9wx0pqjSIXHICteSL0md1KznXrUsSwZZd8JpjEr0IrUKtcz6TxrEh7/hdUDPRrCsegMwHw0tZprTyfYnakzUaWCzJiuUpOSm7xIjpYL7X5qQm0uHfornIWKAH4lFY8g4RxJzbFeFbOfM+NgQn2f8I5yyhUN3zdTVP7u368l5kzvO2gaxXI3aF73mnS3k7gq9vzZfR08EnQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(136003)(366004)(39860400002)(8676002)(8936002)(26005)(186003)(6506007)(53546011)(2906002)(86362001)(83380400001)(66946007)(71200400001)(33656002)(76116006)(9686003)(52536014)(110136005)(5660300002)(38100700002)(30864003)(64756008)(66446008)(66556008)(66476007)(122000001)(38070700005)(478600001)(966005)(316002)(55016002)(7696005)(19627235002)(579004)(559001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NG7+1E/Q901KdMnYhsDxs9V9SixlMBRos5IXTfRnIMr8zVaE5A28LUs8QRPV?= =?us-ascii?Q?XKmjJQ2sWaOtMeBy/npr8+xiXsk9CE6uZVPQFdAYmPHncpbwVYpKOhlNWU+d?= =?us-ascii?Q?HM9L8srTy+wvz1NtwGKOu/PfDey5WTCuzsxmCbelvAChn10dSZDaXIEJEnuR?= =?us-ascii?Q?PHWWdUkMR9hB0SAeehsoznlJppN7ppatFu8M5CXft4RQxSdTHJLdquHOQWTb?= =?us-ascii?Q?+d1//NGzRERanuEZVQRTbKeZ0NlkRpGFFnez1JqHuYVxdYwe3gx/Ct1Sm2WB?= =?us-ascii?Q?IBn2f6OmkoBO+QQN7V9Dtu13smRj8rFRV3T0b5tmnEqOroVRSa/8bGVDZubl?= =?us-ascii?Q?yGPUBqyEXFd3UxMkPM9ETHrZR6ZbcC5LEkS2G0eAn+yV7O7kYqOmYI3wMecT?= =?us-ascii?Q?p2jeZq6mUYpCH9jK1W2cufDI5FQBOoPBTlG56Sx9lLxoX1T9ktNC69EeeXPL?= =?us-ascii?Q?vETWvwDci4WYIgNAv5lzEof7z/B1yxSkZBjI3syDcx3j8o4qhI3uENgL/jT4?= =?us-ascii?Q?C7EgsST5FkiKXU+5An1L7blM9q54UttnDHhKdKsDyUXQMNWydNOlsb22BinW?= =?us-ascii?Q?uN1qv/jU1h6udIvo7K4N9kiI48FPPgWp5UxxOY/fHjmDYwo0Aqj+ikU+AOXg?= =?us-ascii?Q?9CtOBkVf26zC9gLjbALBQXTrybLpfOpuwQkZPgk9X2q2IPTz7WF9umd/7Zyz?= =?us-ascii?Q?zDRl9O/ud6dGxXPTmoKASFnxzmIzxfUR4bOvjYa2hRVkriqdLz2jP0l9Oy0D?= =?us-ascii?Q?HQFSNRMKp7F+Ngz6iwO0eOlEVBZty7He+2xLWFjxI0o1QS/afYjfnLvGqzUT?= =?us-ascii?Q?Gkyh8ATPut/qO09whojjqTJW1cqYBb67bDvQTEtT09ylZrnQj9+z1n4/T2fn?= =?us-ascii?Q?6BnnXQa/C82wTtKlKKe1MRdPA9B/0/ZzrLpRUaU5fSmLySSG3nFpl2iWrR4v?= =?us-ascii?Q?tVTyGKfymkXvmcHPF3zLTOuJsUOkDp0u+MSFtKDE8REtwX5K6KpYeuefue8J?= =?us-ascii?Q?r8vUvMuYThCCo/tyH1nLjDvQKskHlaTdU5+iIWYpa9RCIBY0ISEPNvFivNYw?= =?us-ascii?Q?UPe4/OmiE9HvCUEDx2tUeSBRcHkbUDu4wbfkE2TMytd97cIIDixoOk4z0gjc?= =?us-ascii?Q?Ntchm8zlKoHuO29OsPnapzfRIXomPRmJZlzOJ3KySxRtABkvUmJk29DPDFgG?= =?us-ascii?Q?ZH6omvgbLrMZOxAB4RI3VXdUnkiK37KFyT03LN3IfjDr0JncUpoiL13CNKrB?= =?us-ascii?Q?ctgdnzKiSLFie+NSELC6xL+FCrth8XNyjZUjH22IdPx0BoHgVXcfz9d4nIHa?= =?us-ascii?Q?JZtjZQ16ZXam2GXs6aAIromo?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9746c43d-82ad-4b34-e2f4-08d96077127f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 05:31:17.6182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PxNkko0EHzcOZKi+PUscXkOkKXILVlBvt/CMkFllMKZwVgV/4KQ1xeuqa017++K836ilN9rUYBVUS8Zn0/AmVlrqmAjc6L15itoCUtl9Qnw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2255 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry 2 more general comments: 1. Please add the Acer Aspire VN-572G to the list of supported platforms in= Platform/Intel/Readme.md 2. If you like you are welcome to add Copyright (c) 2021, Benjamin Doran to= the files that you modified. You don't work for any company so you're work= on this project belongs to you. Of course, you have to be willing to exten= d a BSD+Patent license to upstream your work to TianoCore but you already h= ave done this :). > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Sunday, August 15, 2021 10:22 PM > To: devel@edk2.groups.io; benjamin.doron00@gmail.com > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] > KabylakeOpenBoardPkg: Add AspireVn7Dash572G >=20 > Hi Benjamin, >=20 > First of all this is fantastic work, it is very clear that you have put a= lot of effort > into this. Thank you for doing so! I do have some minor code review > comments for you. Here is a summary of my feedback: >=20 > 1. > KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSilicon > PolicyUpdateLibFsp/PcieDeviceTable.c: Line 16: >=20 > I think it would be a good idea to file a Bugzilla for this. Could you= please do > so? >=20 > 2. > KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSilicon > PolicyUpdateLibFsp/PeiBoardPolicyUpdate.c >=20 > A lot of this code in this file demonstrates that is probably makes se= nse to > create a top level PolicyUpdateLib in KabylakeOpenBoardPkg that the vario= us > board ports import because most of these settings look either identical t= o > RVP3/GalagoPro3 or they come from PCDs and hence the code will always be > generic. >=20 > Definitely not something you need to do for this patch series, but someth= ing > to think about for a future enhancement. >=20 > 2(a). Line 49: >=20 > I find the whole situation with PchHpetBusNumber, > PchHpetBusDeviceNumber, PchHpetFunctionNumber, PchHpetBdfValid to > be very odd. >=20 > I looked though the FSP source code to see what these policy options d= o > and it boils down to if(PchHpetBdfValid) then the FSP will program the > following register: >=20 > https://edc.intel.com/content/www/us/en/design/products-and- > solutions/processors-and-chipsets/comet-lake-u/intel-400-series-chipset- > on-package-platform-controller-hub-register-database/hpet-bus-device- > function-hbdf-offset-70/ >=20 > I can confirm that in the FSP source code that the default FSP UPD val= ues > differ from the default config block values. Moreover, the reference BIOS > takes the config blocks and converts them into FSP UPDs just like the ope= n > source code, so most of the testing for KBL FSP was actually done without > the default UPD values. We consider cases like this where the UPD and the > config block defaults don't match to be a bug, but given the age of the K= BL > FSP getting that bug fixed is difficult at this point. >=20 > Have you tried booting these settings? > PchHpetBdfValid =3D 0 > PchHpetBusNumber =3D 0 > PchHpetBusDeviceNumber =3D 0 > PchHpetFunctionNumber =3D 0 >=20 > That is what the reference BIOS uses. >=20 > The equivalent UPD and Config Block defaults for I/O APIC do match. >=20 > 2(b). Line 50: > The default for PeciC10Reset should totally be 1. Good catch! >=20 > I have created a patch to fix the properly. Please merge > https://edk2.groups.io/g/devel/message/79328 >=20 > Then we should be able to remove this line. >=20 > 2(c). Line 97: > This is OK for your initial patch series but please make sure work on = a follow > up patch series that moves this to a setup option since it is insecure to= have > this be the default. >=20 > 2(d). Line 107: > From what I remember the VN-572G only supports S3 and not S0ix. In > which case setting PchPmSlpS0VmEnable =3D 0 would be mandatory because > that feature only works in S0ix mode. Historically most systems with > switchable graphics have opted for S3 instead of S0ix because power state > transitions are more difficult to implement correctly in S0ix. >=20 > Please add a comment that describes this. >=20 > 2(e). Line 198: > Please create a #define for "3" that describes why these settings are > significant for only the first 3 USB2 ports. >=20 > Also, using a variable called "i" as the index variable of a for loop = does not > comply with EDK II coding style guidelines, please use "Index" instead. >=20 > 2(f) Line 205: > Please create a #define for "9" that describes why these settings are > significant for USB2 ports 3-9. >=20 > Also, using a variable called "i" as the index variable of a for loop = does not > comply with EDK II coding style guidelines, please use "Index" instead. >=20 > 2(g) Line 212: > Please create a #define for the number of populated USB3 ports. >=20 > Also, using a variable called "i" as the index variable of a for loop = does not > comply with EDK II coding style guidelines, please use "Index" instead. >=20 > 2(h). Line 219: > Please use PCH_LP_XHCI_MAX_USB2_PORTS instead of 12. >=20 > Also, using a variable called "i" as the index variable of a for loop = does not > comply with EDK II coding style guidelines, please use "Index" instead. >=20 > 2(i). Line 222: > Please use PCH_LP_XHCI_MAX_USB3_PORTS instead of 6. >=20 > Also, using a variable called "i" as the index variable of a for loop = does not > comply with EDK II coding style guidelines, please use "Index" instead. >=20 > 3. KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/EcCommands.h: > Line 45: > We have this in the original code for triggering some board-specific > workarounds needed on old/early builds of RVP3 but not later ones. >=20 > Given that the AspireVn7Dash572G is now disconnected from the > KabylakeRvp3, would it be possible to remove the command to EC for > reading the Fab Id? That scenario seems non applicable to the VN-572G. >=20 > 4. > KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspire > Vn7Dash572GInitPostMemLib.c >=20 > 4(a). Line 56: > Please add a header comment that describes what this function does. >=20 > 4(b). Line 58: > Function name doesn't follow EDK II coding style guidelines. Please re= name > to EcFillsTime(). >=20 > 4(c). Line 81: > Please don't commit commented out/#if 0 code. >=20 > 4(d). Line 119: > Please delete trailing whitespace >=20 > 5. KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgPcd.dsc: Line > 188: > PcdSiCsmEnable is just tells the SiPkg that the platform code contains= a > CSM. It is one of many... many things you would need to do for proper CSM > support in KabylakeOpenBoardPkg and is way beyond the scope of this GSoC > project :) >=20 > Everything else looks good! >=20 > Thanks, > Nate >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > Benjamin Doron > > Sent: Friday, August 13, 2021 5:25 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5] > > KabylakeOpenBoardPkg: Add AspireVn7Dash572G > > > > This patchset adds support for a Acer Aspire VN7-572G (SKL-U laptop) > > board to KabylakeOpenBoardPkg, based on Kabylake RVP 3. As stated in a > > later commit message, there is a second, similar board: VN7-792G. > > - VN7-572G =3D "Rayleigh". Working, supported. Uses PCH-LP. > > - VN7-792G =3D "Newgate". Assumed broken, not supported. Uses PCH-H. > > Also known as the "Black Edition" of the Aspire V Nitro. > > > > Because VN7-792G uses a different PCH, routing and GPIO configuration > > are assumed to be different. Users are strongly warned against > > attempting to flash images to VN7-792G at this time. Support may be > > added later by reverse engineering, but logs from a running system will > help. > > > > Additional build depedencies: > > - https://github.com/benjamindoron/edk2-non- > > osi/commit/7bf736989159b74012d9bf3a13a9f941036be97a > > - > > > https://github.com/benjamindoron/edk2/commit/db888a928c1c6fc94f6a767 > > 0f3402718c10c01d2 > > > > V2 changes: > > - Whitespace changes and changes for coding guidelines compliance > > - KabylakeOpenBoardPkg changes merged into "duplicate KabylakeRvp3" > > commit > > - EC (ACPI): LGMR hooked-up (disabled), other changes. > > - FSP-S configuration: Drop thermal changes not set by board, do not > > override UART2 mode (PCI by policy) > > - Set DspEndpointDmic so FSP produces correct configuration in HOB fo= r > > PchInitDxe. (However, 1ch array DMIC may not be supported by the > > Linux driver. Also, presently NHLT is not installed in any case: > > DspEnable=3D0 in HOB.) > > - Avoid indirect function calls for GPIO configuration and deduplicate > > HSIO tables > > - Make board detection work and parse PCB version information > > - Begin working on hardening platform and improving PCD > > - DXE stack guard, NX for stack, NULL pointer detection (DXE NX is > > broken) > > - Measure FSP to TPM (presently skipping FSP-S, there may be a bug > > where the first TPM command from this time will timeout waiting for > > goIdle) > > - UGA draw protocol and HII OS runtime disabled, fast PS/2 detection > > > > Benjamin Doron (5): > > KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands > > KabylakeOpenBoardPkg/AspireVn7Dash572G: Duplicate KabylakeRvp3 > > directory > > KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files > > Platform/Intel: Early hook-up Acer Aspire VN7-572G > > KabylakeOpenBoardPkg/AspireVn7Dash572G: Add initial support > > > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardAcpi > > Tables.inf | 1= 8 + > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardSsdt > > .asl | 3= 4 + > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ac.asl > > | 16 + > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/battery.as > > l | 408= +++++++++++ > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ec.asl > > | 431 ++++++++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/mainboar > > d.asl | = 79 +++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/thermal.a > > sl | 11= 7 ++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c | 1= 04 +++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c | 2= 88 > > ++++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | = 82 > +++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c | 2= 13 > > ++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c | 1= 39 ++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h | = 26 + > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c | 2= 43 > > +++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c | = 77 ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h | = 29 + > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c | = 66 > ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | > > 145 > > ++++ > > Platform/Intel/KabylakeOpenBoardPkg/{KabylakeRvp3 =3D> > > AspireVn7Dash572G}/Include/EcCommands.h = | 7 +- > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/Fla > > shMapInclude.fdf | 50= ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library > > /BoardEcLib.h | 112= +++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/DxeAspireVn7Dash572GAcpiTableLib.c | 7= 4 ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/DxeBoardAcpiTableLib.c | 3= 0 + > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/DxeBoardAcpiTableLib.inf | 4= 7 ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c | 6= 4 ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/SmmBoardAcpiEnableLib.c | 5= 5 ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/SmmBoardAcpiEnableLib.inf | 4= 5 ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/SmmSiliconAcpiEnableLib.c | 16= 6 +++++ > > Platform/Intel/KabylakeOpenBoardPkg/{Library/BaseEcLib/BaseEcLib.inf > =3D> > > AspireVn7Dash572G/Library/BoardEcLib/BoardEcLib.inf} | 13 +- > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardE > > cLib/EcCommands.c | 21= 8 ++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/AspireVn7Dash572GGpioTable.c | 39= 8 +++++++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/AspireVn7Dash572GHdaVerbTables.c | 20= 3 ++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/AspireVn7Dash572GHsioPtssTables.c | 2= 6 + > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiAspireVn7Dash572GDetect.c | 9= 7 +++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiAspireVn7Dash572GInitLib.h | 3= 3 + > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiAspireVn7Dash572GInitPostMemLib.c | 12= 6 ++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiAspireVn7Dash572GInitPreMemLib.c | 34= 4 > +++++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiBoardInitPostMemLib.c | 3= 4 + > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiBoardInitPostMemLib.inf | 4= 7 ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiBoardInitPreMemLib.c | 9= 9 +++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiBoardInitPreMemLib.inf | 12= 6 ++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > > .dsc | = 674 ++++++++++++++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > > .fdf | = 733 ++++++++++++++++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > > BuildOption.dsc | = 153 ++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > > Pcd.dsc | = 546 +++++++++++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.c | 188= +++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h | 39= ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h | 64= ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeSaPolicyUpdate.c | 63= ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c | 74= ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf | 52= ++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > PeiSiliconPolicyUpdateLib/PeiBoardPolicyUpdate.c | 332 > +++++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c | 642 > > +++++++++++++++++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf | 107= +++ > > > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cf > > g | 35= + > > Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h > > | 32 + > > Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > > | 2 + > > > > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/EcCommands > > .h | = 2 + > > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/BaseEcLib.c > > | 4 +- > > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/BaseEcLib.inf > > | 1 + > > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c > > | 76 ++ > > Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > > | 1 + > > Platform/Intel/build.cfg > > | 1 + > > 63 files changed, 8741 insertions(+), 9 deletions(-) create mode > > 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardAcpi > > Tables.inf > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardSsdt > > .asl > > create mode 100644 > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ac.asl > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/battery.as > > l > > create mode 100644 > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ec.asl > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/mainboar > > d.asl > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/thermal.a > > sl > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > > brary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf > > copy Platform/Intel/KabylakeOpenBoardPkg/{KabylakeRvp3 =3D> > > AspireVn7Dash572G}/Include/EcCommands.h (74%) create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/Fla > > shMapInclude.fdf > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library > > /BoardEcLib.h > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/DxeAspireVn7Dash572GAcpiTableLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/DxeBoardAcpiTableLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/DxeBoardAcpiTableLib.inf > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/SmmBoardAcpiEnableLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/SmmBoardAcpiEnableLib.inf > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > > cpiLib/SmmSiliconAcpiEnableLib.c > > copy > > Platform/Intel/KabylakeOpenBoardPkg/{Library/BaseEcLib/BaseEcLib.inf > > =3D> AspireVn7Dash572G/Library/BoardEcLib/BoardEcLib.inf} (58%) create > > mode > > 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardE > > cLib/EcCommands.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/AspireVn7Dash572GGpioTable.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/AspireVn7Dash572GHdaVerbTables.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/AspireVn7Dash572GHsioPtssTables.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiAspireVn7Dash572GDetect.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiAspireVn7Dash572GInitLib.h > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiAspireVn7Dash572GInitPostMemLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiAspireVn7Dash572GInitPreMemLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiBoardInitPostMemLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiBoardInitPostMemLib.inf > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiBoardInitPreMemLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > > nitLib/PeiBoardInitPreMemLib.inf > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > > .dsc > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > > .fdf > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > > BuildOption.dsc > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > > Pcd.dsc > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeSaPolicyUpdate.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > PeiSiliconPolicyUpdateLib/PeiBoardPolicyUpdate.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf > > create mode 100644 > > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cf > > g > > create mode 100644 > > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c > > > > -- > > 2.31.1 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20