From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.3871.1659063647954970757 for ; Thu, 28 Jul 2022 20:00:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QypsL3v8; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: star.zeng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659063647; x=1690599647; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vFblnswd6ZHyoTPcUGTwDMVp+XGk5PKGvLoIdgnnfxo=; b=QypsL3v8AuT9rb0HSO2QAAzfpH3IHqQqa/NwX6Iu7gTnfm43OipdezWD OrpRNuwF6rs43ypUH16XPX9yI/L1X4o/Uo/L2fNN65KDVLqGLYHxVhsgg IpGA7V8VVWCtW+H815GG5vrNbHILFLZ7yRwy1TndhO1/g2+HO9SLf7CL1 /5gzLs1EOrGmZCVWsNGuvsRfwepzEG10c3yJyJsE7onFvbh6txR+IxOn7 uleVoh5UK7cvNj1YUMFm9xt7KBgAY/YTWtk3s1bKEOW6Fa5EvBSlXvQP7 3McMffUl+cYTNw6AyeRoOh0G7lLkmw/Vz/gQYkJAFe3tPJDaiik8WBO0Z A==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="374979250" X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="374979250" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 20:00:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="669126301" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 28 Jul 2022 20:00:47 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 20:00:46 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 20:00:46 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 28 Jul 2022 20:00:46 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 28 Jul 2022 20:00:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WoASG/5DTGoef3xX1xz0Am9Z7Vx87T+rezRjKhhVFCM5pVT1lATHL2eJ5gnKeWeFC5I6Yn0uiVRr9LHvlLXzhOOp3/Q/hQC7Nqt6BPSoxXmi+ojNyVkXkhLxwoPdIek0tbrPgYJgSk5mA5xF0BtUcSlcoOg1BYsDvXKbZQij7zPjKFQi1fOyYOxYsWQLbrAYGKMs+08ARtLaVgWDveg2PLHJcPNUAjQSK+FxGLUzQ2uXtZpSlBplbmRzXnevm3T9ADK3oBWf+lUyQpKzcg4M6aUai0vkT1HPvn3F+URgS+TCYN7NWt+CaJ5/PM1ooJiw5XCDsc7mXUI/evx0+90UpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jdwkzgEMpKWFUlg/iXxEB4MMDCYy1uXbmLuMycbgNo=; b=KDO/Tg+RO7+6+p7lqL4cET4DWdOtDBHpQ95ttzoxZ9QVtLSdmwtaR0o/tiPVWe/mBgG2fMyHABUJAzV7k/s83YGlV4kF4U47oRhhBV0CLcBqHUCRfVv2lrI08j/OXGNsWsbD6z2ezqSSMNzQIiXWI3vDZtKInwymdV8LdYD+sA3GNdFkJ7oYzo4BrXCi/ddbJienIrGEU4inl4Sq3KdRZk1z8sqmBDH0lQaUIVNmrSs5MtMGPpFENAHnDhrf4ZF0LTOLWTI5iC4FkhWzCRuwh3ECDdjGF7ecFB/SSekb0/LWqSJSkyutTIibBiKu8s9DVRSgZs8BFh83ic9lTGxupg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1245.namprd11.prod.outlook.com (2603:10b6:300:28::11) by IA1PR11MB6540.namprd11.prod.outlook.com (2603:10b6:208:3a0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Fri, 29 Jul 2022 03:00:44 +0000 Received: from MWHPR11MB1245.namprd11.prod.outlook.com ([fe80::e4df:596e:d254:3e75]) by MWHPR11MB1245.namprd11.prod.outlook.com ([fe80::e4df:596e:d254:3e75%10]) with mapi id 15.20.5482.011; Fri, 29 Jul 2022 03:00:44 +0000 From: "Zeng, Star" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg: Fix GenCfgOpt bug for FSPI_UPD support. Thread-Topic: [PATCH] IntelFsp2Pkg: Fix GenCfgOpt bug for FSPI_UPD support. Thread-Index: AQHYovb6tDetb/88IEGl5YLIoL4BRa2UqMSw Date: Fri, 29 Jul 2022 03:00:44 +0000 Message-ID: References: <20220729025724.2040-1-chasel.chiu@intel.com> In-Reply-To: <20220729025724.2040-1-chasel.chiu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16907b8f-f2b0-41aa-e178-08da710e877c x-ms-traffictypediagnostic: IA1PR11MB6540:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IwD6EKoJJb5sKGFug6bOuOYkj1sWaN+qeFJb+k2PMYzZWvspxYbNFfZL0PyYMr95jweFuh8R2YAWCDhNViaSVw0xlj2MGeLgsgZNwn1YVrdnxnB03NiJg7PT13p1jJocB6LS6P/xgWS1riSTD9iEYkOos19sBRY/kb1i3mdBbOrqZybYLgao0LGwJQ2pMfEn/wrQ9CayAMeGyf6du0hvSOCX8eBKPi9zOMBefV0s0pxzRvuKAAelz1IJ9SeoJIFuuErLhS9GN1w7IbcVy6280nCzVxPXvB7GWPxHeWFpQluApmBgThqHPGP3wxIfyfiemwvg5kna4B0RF5E0GATagh6zoDQJavmVfhNtf3MIltoR+0tAsCfxczLNmzCdlTbyXq00FADy15TfcMS6qWZZkYcdnlIg5DWZcSLbsrZQSFypfvjN6MrODC44X1mmweJouDn1K1OOui8r4muJVy67jeJ8ORyIOuzw1n0b1Dm6NJogJZQLG6lfDdvJqt2rtq09zFUR0LeB92Zw/KeRdHdJ7rS6FriDAzQETNKBvgpHZAEHS/FC7elFHCOn7eqVJRgZQGHf9TU08VYqXj/nWEu9cmgk9ixLJzfBaXvcN5oSFXm07ZhEJ+SRkJSsl1dI+otmWfsehJSavgb/hCZtj34aB14n3yPvCcogE1y498AfaqwJDjZeOZ0vLsUN4g5vqF34EDw7lbwz5HLvb7N0sShs9oYPAaG0QGcZggrrytxlx+jUvBLMrI9c4s/nisF661YkVUXjInw9wXE1uBc/qtGJOeIFaMN2Lz8A0yPcdaOKhTwLNkJqWYvt4JQckUKXZstZV/Bday12E2X9yegiX20ksg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1245.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(366004)(346002)(39860400002)(136003)(53546011)(966005)(107886003)(41300700001)(71200400001)(9686003)(26005)(7696005)(6506007)(478600001)(186003)(38100700002)(122000001)(38070700005)(83380400001)(5660300002)(52536014)(2906002)(66476007)(66556008)(4326008)(66946007)(110136005)(8936002)(8676002)(33656002)(82960400001)(64756008)(66446008)(76116006)(54906003)(86362001)(19627235002)(316002)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hAevG5HDeq9x707C+9/9pXL52iS7RjABqFw3JKiK+FFnsb9+M6iEdzJc7KUD?= =?us-ascii?Q?katBMPK1zhjOInfBUsFjcUaK2Ec8D7VA56oeeXFI2ehsCTYRlknqrJtq1uzT?= =?us-ascii?Q?D+MgfmbOMbzJ4bbHzuQNJpRS4SLeuuVIc2spkL9fsdzhnZ8CzIjOlvuc6c/C?= =?us-ascii?Q?EfZHIGxwhBkDLQcgHQh/Neh5S18DAf7SIdykJt8CThSKBtdcW4uj0SIHHl2j?= =?us-ascii?Q?tGZBJOJy0Vx2vQAgM4BhgHVMffLT30J1TBDRuU9q2+dA+PBu/HRxg67MbWh4?= =?us-ascii?Q?O9+6KuJAksogLArdzmKrjdHbLcy32cbc3etP7VQCiX4YqnbjM10xLpEOc4b5?= =?us-ascii?Q?bOLTSUAKd2j6whWu+M/GptNp1vUUlQ+nAtEalRy1WG1Y4HSmdQYlvsHlmi1v?= =?us-ascii?Q?ZNh3zOHW3DAmcuPoEYynv9zKKhWdxpUoAyJOU+g2H3+3RoRI7zmG2lSF+Nww?= =?us-ascii?Q?3uwYTdSTd664uRdkytrFccq0CAlvLMAvlDSBuIAOGiIBvjYauddNmeQFRXmp?= =?us-ascii?Q?aSHOlNi/XOJI/pMm5g78hbEQmNi2PCC3AHyYwK9SEVauEJtw1pweZvzR3fo/?= =?us-ascii?Q?z8AnUd4j0cK3vaBUL69eFKU0uoktAYYS5Zt6DcvqBi3Y7Tz4AtRDkD8uNz0A?= =?us-ascii?Q?1EqEJREzAZaS1LOAzgihoGuA7Eg7gxhl3pL4fqrZnNmy1t6DBb1EBxcRUeIz?= =?us-ascii?Q?vlGKKle50wTBGg4N5xPWBhYQ91brtQbN6u+cE/LTtFqo9Z9JVmiYG+0KOx1w?= =?us-ascii?Q?TDTPvyMcPA12gl9oTC0beIyiaLdxu2RAGnOboU/HKa6xi3w0wryOSwoeM/5x?= =?us-ascii?Q?GcSmfT2VNINSuchTYHPL8m1tco5+Di0Tqu+QTpRG8Ag3Aa0+OkYtx4cNb3a7?= =?us-ascii?Q?r9arsHfA99H402bLhgXzs8VeSUC/wOTi7mdfc2PieLDRZM1z/GezMaTzIJgL?= =?us-ascii?Q?mgJOEbYiG5amn251ucIFxonIQDw8LmZCu9EVqGcCLsnRCuAISrkqk9fFpvl9?= =?us-ascii?Q?qAwiYXvZGcXaz32RVc9oT/oW2qouqr4PMgouldbvNXeVUcZ5e8INryaxsn+L?= =?us-ascii?Q?2S/PpJTecLKfbhhhrAsd1AbEjUj8h7hSAu01GHz5agOrnqbDTcyWsIn4cORJ?= =?us-ascii?Q?ynQzT5gGNQ3cRyHT3y0ROWp+0qH2Fp01rKvGddXnjMMVphvN7kD2zzddYtwU?= =?us-ascii?Q?J76mi++ECYWYUp5i0KdhNMeVBpPksJF5eQgnLVCPnIIKidgSRG/IRXiOQzqs?= =?us-ascii?Q?7dBobhD3Ec1YDXGQlPeqlsebCd8WxqQTbBOCXdiaJniJTgJTUboe4o7/hUyX?= =?us-ascii?Q?4sRiP/Yf5YHAdOvRsDJTEQR1rnYSIL2L/J8l6FkINFVtdKxARP7JdoQ0B5q0?= =?us-ascii?Q?NieulubIIrv+6VnyjXL1we5UuIz0x0xwC9S9zzhiDMvG5BqDqp/2huTREYER?= =?us-ascii?Q?MkWniKlFXNkJXgc+lej1sQSi1P7M3OVBtcXkPK3tl5dVMg3AWAeLl/vJdRme?= =?us-ascii?Q?VyFh9oTHxXGNbokeG+iNSp2nps/ZEJlzfeIzk1lo6uRRrUIw6u4YT/M063cj?= =?us-ascii?Q?6gWXaaACx7yXbXVJ1DANtSbQtQDtooahUUooJc56?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1245.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16907b8f-f2b0-41aa-e178-08da710e877c X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2022 03:00:44.2623 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fHuc6NcVM1BYWZSwoImHDYu6GgfZKWArzj6WVCgmwNdSfcOmxlJOht6MN1z5kw4YhM0ukdvhiRh1xgLNAEwaKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6540 Return-Path: star.zeng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Chiu, Chasel =20 Sent: Friday, July 29, 2022 10:57 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2Pkg: Fix GenCfgOpt bug for FSPI_UPD support. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3993 Fixed a logic bug in GenCfgOpt.py to skip FSPI_UPD when platforms do not support. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py b/IntelFsp2Pkg/Tools/GenCfgOpt= .py index 71c48f10e0..13be81ddbc 100644 --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py @@ -1301,7 +1301,7 @@ EndList elif '_S' in SignatureStr[6:6+2]: TxtBody.append("#define FSPS_UPD_SIGNATURE = %s /* '%s' */\n\n" % (Item['value'], SignatureStr)) elif '_I' in SignatureStr[6:6+2]: - if NoFSPI =3D=3D True: + if NoFSPI =3D=3D False: TxtBody.append("#define FSPI_UPD_SIGNATURE = %s /* '%s' */\n\n" % (Item['value'], SignatureStr)) TxtBody.append("\n") =20 --=20 2.35.0.windows.1