public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "Tan, Ming" <ming.tan@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Qian, Yi" <yi.qian@intel.com>
Subject: Re: [PATCH 5/5] Platform/Intel/Vlv2TbltDevicePkg: Change PCDs type about status code
Date: Wed, 17 Jun 2020 03:05:08 +0000	[thread overview]
Message-ID: <MWHPR11MB1360221BDC3C89C1BF4F64C3969A0@MWHPR11MB1360.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200609112353.20824-9-ming.tan@intel.com>

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

-----Original Message-----
From: Tan, Ming <ming.tan@intel.com> 
Sent: Tuesday, June 9, 2020 7:24 PM
To: devel@edk2.groups.io
Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
Subject: [PATCH 5/5] Platform/Intel/Vlv2TbltDevicePkg: Change PCDs type about status code

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2791

Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Signed-off-by: Ming Tan <ming.tan@intel.com>
---
 .../Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc    | 14 +++++++-------
 .../Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc     | 14 +++++++-------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index 463b952e65..1cb0b9230a 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -1,7 +1,7 @@
 #/** @file # Platform description. #-# Copyright (c) 2012  - 2019, Intel Corporation. All rights reserved.<BR>+# Copyright (c) 2012  - 2020, Intel Corporation. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -432,12 +432,6 @@
   gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|FALSE !endif   gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSectionFirst|FALSE-!if $(TARGET) == RELEASE-  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!else-  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!endif-  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE !if $(ISA_SERIAL_STATUS_CODE_ENABLE) == TRUE   gEfiSerialPortTokenSpaceGuid.PcdStatusCodeUseIsaSerial|TRUE !else@@ -483,6 +477,12 @@
 !else   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE !endif+!if $(TARGET) == RELEASE+  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE+!else+  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE+!endif+  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE !if $(TARGET) == RELEASE   gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0   gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x3diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index ee18b45c97..62ff5f5c4d 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -1,7 +1,7 @@
 #/** @file # Platform description. #-# Copyright (c) 2012  - 2019, Intel Corporation. All rights reserved.<BR>+# Copyright (c) 2012  - 2020, Intel Corporation. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -434,12 +434,6 @@
   gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|FALSE !endif   gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSectionFirst|FALSE-!if $(TARGET) == RELEASE-  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!else-  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!endif-  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE !if $(ISA_SERIAL_STATUS_CODE_ENABLE) == TRUE   gEfiSerialPortTokenSpaceGuid.PcdStatusCodeUseIsaSerial|TRUE !else@@ -485,6 +479,12 @@
 !else   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE !endif+!if $(TARGET) == RELEASE+  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE+!else+  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE+!endif+  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE !if $(TARGET) == RELEASE   gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0   gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x3-- 
2.24.0.windows.2


      reply	other threads:[~2020-06-17  3:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 11:23 [PATCH v3 1/4] MdeModulePkg.dec: Change PCDs for status code Tan, Ming
2020-06-09 11:23 ` [PATCH v3 2/4] EmulatorPkg/EmulatorPkg.dsc: Change PCDs type about " Tan, Ming
2020-06-09 11:23 ` [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change some PCDs type Tan, Ming
2020-06-09 18:54   ` Guo Dong
2020-06-09 11:23 ` [PATCH v3 4/4] OvmfPkg/OvmfPkg*.dsc: Change PCDs type about status code Tan, Ming
2020-06-09 21:01   ` [edk2-devel] " Laszlo Ersek
2020-06-09 11:23 ` [PATCH 1/5] Platform/Intel/SimicsOpenBoardPkg: " Tan, Ming
2020-06-10  1:26   ` Agyeman, Prince
2020-06-09 11:23 ` [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs type Tan, Ming
2020-06-10 20:33   ` Nate DeSimone
2020-06-11 23:53   ` Chiu, Chasel
2020-06-09 11:23 ` [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: " Tan, Ming
2020-06-10 20:33   ` Nate DeSimone
2020-06-10 21:03   ` Chaganty, Rangasai V
2020-06-11 23:54   ` Chiu, Chasel
2020-06-09 11:23 ` [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: " Tan, Ming
2020-06-10 20:33   ` Nate DeSimone
2020-06-11 23:53   ` Chiu, Chasel
2020-06-09 11:23 ` [PATCH 5/5] Platform/Intel/Vlv2TbltDevicePkg: Change PCDs type about status code Tan, Ming
2020-06-17  3:05   ` Sun, Zailiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1360221BDC3C89C1BF4F64C3969A0@MWHPR11MB1360.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox