From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.3429.1649833403290993166 for ; Wed, 13 Apr 2022 00:03:23 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=aF9ZOx/R; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: yi1.li@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649833403; x=1681369403; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AXWC4VEkdOOCknxk30ukTYhzdhRSs3vEQGqSB2I6OQ8=; b=aF9ZOx/RvKNJbjMP7/bLSCjNwUpEUE8NTbvlesc06mczzfoxZDhl9Z8h 4KVhzalNNcLlguPpYJZYv+O7wSd4OT44wf/rEUE5b/i/fQLI2xoRRSRES ZnqyyOxtLCu9P7qvXW2wQm869PAjfT9aehD6Rnmbll+b/rYQAHqE+Wr9p /U8KrLcc706e5B7QVz7AeVbK+koGJ2tSj3Vykbdl+6mWs6IQ+Xwsq6PLv MkFX1J2JpUcZT7W6TOgh6Dmg7mgepmd0+vnln1rVIHRyhc049B+nExKmh FhAXafr4zoSoazW2CpWJv7taX3Yp738jrRH5zGLRB2bFyWwj2KtPW1zcF w==; X-IronPort-AV: E=McAfee;i="6400,9594,10315"; a="262345001" X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="262345001" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 00:03:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="802579314" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 13 Apr 2022 00:03:21 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Apr 2022 00:03:20 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Apr 2022 00:03:20 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 13 Apr 2022 00:03:20 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 13 Apr 2022 00:03:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOhF1NDJiageaX15KFjHp7CV1sUbp90TwncOYUATZN/ykREqzEmxYXeMgrNxCl6OuXDHiXwx/WEaeo1kyQqN7vY89LvMGYvyk1iabYpkbAqbeGtE4rYLMgObM2pjJp7iHz5Q6eIgVgRCAFhvhrGGqyHK/OGRrXTOQpIZ6v/nuWgbKQ6vOOKf1SfQaP07rBReK/YWgxy7dGfATBFdcy4iKs4dOnhFnNMr1IuTt09c/lUYsHIWuzyVKMtbqT2iN4C6JCeC/WfNvSsNvlWJFIECTxKu8ALdplkSaUHHCxqFvm7IXu6yyBsKbPDgB/mxVa/qGfnwHOv4QlQuOLUOVb66Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zYVxYUo9BkpdiEqUtzCF5IJvDNPPZ1V96FScWpCIW0o=; b=Ln/BCtFCjUOmgCWlOSWFwwul7C8pfY7oL96x00rWwaFqcLHnf81ihMvjGN+4dKFXpLcGiFHxflLrT6GQuj36Yfk3FnOuZ4Zf0/a0HkuMEg7StG4AY1oIC4lgH1wKT5dNjEOcGIntEFkstv3Wgsct8ZJfpnQDOGul/ql1bmNXmXvde7WVr1AtPQfiqcozFytie85F1USWOwaxjroWW926dD21eCawEz7+ycNGFpxgqgPy8YJ+n1J3eUzLDJsmZ2snBtmSUVzr5u2jBacwlE9+pCUrILjwD3RvFe0xcEYn59hhPE6dfLXwo9W9Vn3EEmBGR5wuedKpa/eKEvPF+pbj7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1597.namprd11.prod.outlook.com (2603:10b6:301:d::13) by PH0PR11MB4983.namprd11.prod.outlook.com (2603:10b6:510:40::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Wed, 13 Apr 2022 07:03:18 +0000 Received: from MWHPR11MB1597.namprd11.prod.outlook.com ([fe80::dcfa:8f03:c81:6eed]) by MWHPR11MB1597.namprd11.prod.outlook.com ([fe80::dcfa:8f03:c81:6eed%9]) with mapi id 15.20.5144.030; Wed, 13 Apr 2022 07:03:18 +0000 From: "yi1 li" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customize-able way Thread-Topic: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customize-able way Thread-Index: AQHYTv8sRDDY7rl3ak61FXEkifRj+KztZSQAgAAFxMA= Date: Wed, 13 Apr 2022 07:03:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b85a14e-257c-47b4-1389-08da1d1bb023 x-ms-traffictypediagnostic: PH0PR11MB4983:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Et39V4n9pkw1S95vu1GXpsxYKBxGU5/Qx9zz/9TBCVGwYemV0lcMTNhx+tW2oR/RYFAE85IMfIbHwmltuzheZCnuLg7fbxJvD0cNE1XQAnSlCSqet6STE+Ldb9lA+3m+ds0IngI/AaGiHxVSGwp1kIBCllmH0Ley2Oo0FLkUGIDIS32kbKoejHPBzbGBYRDFTdy//a4Ih8MAI39RVboESh7DsEVytcF5aFZBip/yMM8lm2DlpqM+pzGRfiwNXHxveKgQQuqoy+F3FTpwYCoBS7IivDxMDkxSDeo4NR7UaBZdIrq96GFF/c4Np5csBEE8WrOHR4Ftpih4fd26W1jeyOnTxjJaSZ1tUKRTni//OSWdblLgW7Vbf95SEE2AC1phOG5l2aLRkoyjTzLInMmGHHxMXpQn+inN7wqJtsZeRQlAkcUbmhuumnqnEUhVxpmbFnKTGGbiPuUBFdLlJoYh7+T4jS7jaS6KxdRqP4tlLUbVs2kJUxVC9DdhNaUbztyJVloP7PgCbg+Q3wcSbtQAbS4qthMAqAQI3eOVbjcZEmZ8PeQvc8PbEdyZxoun7nfK8x0IvNGRH9pPhTNh12o9y3eQj1ODm5lK8g3bcGG7p6ajv74O07mKHek1szv+AFzxPHBFoTfp9Wr3gWeC4bC6kvz6czZVtvaHSXMepHa4I4DpVZDCDX5X5Dg5c8ZYRUuVUKY1vLMO82MfW0hrkuU2DG1tUrKPXZsL+JiqnX3aNNnYTgwx92WdhBMP9j3YAUbJuib69nL5ZdjqQaMbSOMVUG2g19QQLiQZx0bjXJVFyGk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1597.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(8936002)(508600001)(5660300002)(52536014)(26005)(7696005)(83380400001)(966005)(71200400001)(53546011)(186003)(86362001)(9686003)(33656002)(2906002)(122000001)(107886003)(8676002)(82960400001)(4326008)(110136005)(76116006)(38070700005)(38100700002)(66556008)(66446008)(66476007)(64756008)(66946007)(19627235002)(316002)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hmlENmGWO87s9aFkVsE+J2STpjCs7BuDZIGY95qn+RNRvY6SYnqQICjmlDPl?= =?us-ascii?Q?gCoXTafloHyCzEPWFbPNbb66Hlwd0IN300rGRMaDMJDcRT3aIH+gUQobgDSb?= =?us-ascii?Q?8MdkWbNVEI9YNKpFXpC9O8sgNRpRdIuvHpY3YfNat7mT8bXaShs79v7wTQDK?= =?us-ascii?Q?+a8m77QPKU4vGK+S5MFMMwE01R4FOHeeuRTDx9XklQIasDj2G/dgR+Ko2Dgm?= =?us-ascii?Q?ZHxpwTG+g3Wt7pSh1cwbdnOV7E0q6KCVjmYsehle2QoUh3HhCyuo6eLMOtYD?= =?us-ascii?Q?yGU3awcUgZXSAKk0QTv57s/eTkEJWvhgNqZf27Yy4OSWPK5Q1ICmpeTNhb1E?= =?us-ascii?Q?9MiAdpbhSZDBUUYWxwvUINRZXdVBWrAOWy4cL+DqRQJB6A0OueGzwNYb5DKk?= =?us-ascii?Q?Hwoj9gDXn2sMg9Hum14Sx2RLwYjyzWB5TrtGWvfUIYtppZ/dn0p6I6H4R260?= =?us-ascii?Q?G57v8bXX1UetoWEW8GWUvptT59+ujrjwlK64+MeilcQGnmxESw9i34B0Ff2S?= =?us-ascii?Q?PFLeMB/a2Zwhfums/Mu0AYWoHAiaVVgd626Y1LD/W/S5zPCGwdqPnyUJksA3?= =?us-ascii?Q?MTpJKnZSTkPtWRYWUt7cV3TO+UaVySRWX2kIlW4PXHYT0YASNPc/gdaqDHtV?= =?us-ascii?Q?6NpuQz7cpwLiLZhksfUr77/+OqPMi615JA559XUvQpG6MmFBu2FpWcfnqSqH?= =?us-ascii?Q?jpSVenVCF2yFY+JFn052L76OFma7scgTRsRNDkIziVutihGUiEGdofQJoYI9?= =?us-ascii?Q?qg5dLht4J8IPRwUiImdjJ5HZr0NPNJfV9Xop/z6NZqnxlGJkYIt5hU9GSuNe?= =?us-ascii?Q?cJBpk5oSzDrMkxIwN8HXpiTJJFKhaRh9LWnsfJe0afYc109rHrbcxhFXz2/t?= =?us-ascii?Q?wEyfwgRqAY1Jq2lcho8B0n/UZS2S+odNH6IDUN+PLyWLijLk+X69/iFo2g00?= =?us-ascii?Q?7vGO6qddYZBBFXjNx391gwrHwY4bl6c53Woy2hlF3zAIJ/0z1QjcEBm7+avh?= =?us-ascii?Q?pc1NDxhGA7g3eFDNRTtItnjE8gQ3bxvrbqyUi1rsWZLAdh5Gmhw8qAd4XvbG?= =?us-ascii?Q?o22EzszMr4IUpoOPjNRkLE48bJRnj9+WiqF/yuWG7lEv6RJf4YMGO4BS/CSu?= =?us-ascii?Q?+DOmgCooYzINisK4POrrGQcBONGv4LL4eGcMcsV6wKnOSV2qb/Xp2G6dndV6?= =?us-ascii?Q?cogmMy174IYZ6rvsbO1fGuyid/i6c7vb/fbGTnO+ceqwfP7zELHN3Et+yWMI?= =?us-ascii?Q?6QMZ3g/lNomoh2Kp73qwEVOsoGutFUEqLwBP0EkmmqmUwUxh7NXS+grLYk1W?= =?us-ascii?Q?RjY5klgIwz0+8qUqQ6rXKmz3928ewrXBjgpAwZBq+6GnGyb5PftwSUG1k+Bo?= =?us-ascii?Q?71ErBK5WK3OjNkflpBR9z6qzTLhENCF68m0B/n/bLfgyLfj2o2hrV0XYjgz7?= =?us-ascii?Q?B9xlfuUE04FCNO52wU19VWC8GRB2M4K/OTvEVHpQe1m7Fjc3i8JoOBciX84P?= =?us-ascii?Q?BWSu8omqNSbOPeQBExGMs/p4RcgBHI+Fp9TZP5/0OhxcqNGShLUvtF0aQzXg?= =?us-ascii?Q?eOuPuBYrdVKCy/PYgq3v0FMaVF2d8FtuEqWFEVWMj1nPiIQ+nS8qu8L/AWS2?= =?us-ascii?Q?u5XnVpEJRcixZMsYJI3bzTvQq+aJOrVrsCNiLj8IVGRK/bFcx6uSKxVmVEsA?= =?us-ascii?Q?gWbST5AhETccasCQriF38PbL9LiOA+oy+t6FuMm5dYWRr6Dk4VRpv2K+UAEO?= =?us-ascii?Q?TVAW+sQWvw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1597.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b85a14e-257c-47b4-1389-08da1d1bb023 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 07:03:18.1820 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HAHhz6jzcmIiMDGadrVdTPxXojJJoWud2BDmFSd0CNJWUbKJmcA5NahNvz37Mw1Sb4pvtUjg8NUXGelP6Hpotg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4983 Return-Path: yi1.li@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for review and have re-sent patch series. -----Original Message----- From: Yao, Jiewen =20 Sent: Wednesday, April 13, 2022 2:42 PM To: Li, Yi1 ; devel@edk2.groups.io Cc: Wang, Jian J Subject: RE: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customize= -able way Thanks for the contribution. Great progress on adding ECC. With PcdLib removed and "no-ec" removed, the series is reviewed-by: Jiewen = Yao > -----Original Message----- > From: Li, Yi1 > Sent: Wednesday, April 13, 2022 2:24 PM > To: devel@edk2.groups.io > Cc: Li, Yi1 ; Yao, Jiewen ;=20 > Wang, Jian J > Subject: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a=20 > customize-able way >=20 > EDK2 has Enabled a feature which allow SOURCE section in INF files to=20 > use Pcd to customize source files list. If Pcd equal to FALSE, this=20 > file will not be compiled. > https://github.com/tianocore/edk2/commit/ > bf9230a9f3dde065c3c8b4175ccd32e44e8f0362 > The patches add a customizable EC feature to CryptoPkg by this feature. >=20 > If Pcd equal to FALSE(Diabled), the binary size will not be changed. >=20 > Size diff(Bytes): > | CryptDxe.efi | CryptPei.efi | CryptSmm.efi | > Before | 815,616 | 540,544 | 563,712 | > Diabled | 815,616 | 540,544 | 563,712 | > Enabled | 1,008,352 | 721,408 | 744,832 | >=20 > Cc: Jiewen Yao > Cc: Jian J Wang >=20 > Signed-off-by: yi1 li > yi1 li (3): > CryptoPkg: Add instrinsics to support building ECC on IA32 windows > CryptoPkg: Reconfigure OpensslLib to add EC algorithms > CryptoPkg: Make EC source file config-able >=20 > CryptoPkg/CryptoPkg.dec | 4 + > .../Library/Include/openssl/opensslconf.h | 10 +- > .../Library/IntrinsicLib/Ia32/MathLlmul.asm | 98 +++++++++++++++++++ > .../Library/IntrinsicLib/Ia32/MathLlshr.asm | 78 +++++++++++++++ > .../Library/IntrinsicLib/IntrinsicLib.inf | 2 + > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 50 ++++++++++ > .../Library/OpensslLib/OpensslLibCrypto.inf | 50 ++++++++++ > CryptoPkg/Library/OpensslLib/process_files.pl | 2 +- > 8 files changed, 289 insertions(+), 5 deletions(-) create mode=20 > 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathLlmul.asm > create mode 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathLlshr.asm >=20 > -- > 2.33.0.windows.2