From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.646.1593788837776675104 for ; Fri, 03 Jul 2020 08:07:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=AKCgoAqG; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) IronPort-SDR: rZEOW4uvzqQyxBCVUZgwVLjnjRzvXb89AWbsBBpp2KUB68Hy5Lr9xQImzyltlGRhQLrUiHTp+I QnIGzTYQgIpA== X-IronPort-AV: E=McAfee;i="6000,8403,9671"; a="232021898" X-IronPort-AV: E=Sophos;i="5.75,308,1589266800"; d="scan'208";a="232021898" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2020 08:07:17 -0700 IronPort-SDR: 8alnZAw7u4NZayAyeKLf4Ha6ncbMI3BhnPpX4YhZiLjFR/SEM6K+FGtxNwJCt+94452XKmiabN i4j5W4hYzAew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,308,1589266800"; d="scan'208";a="296227074" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga002.jf.intel.com with ESMTP; 03 Jul 2020 08:07:16 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Jul 2020 08:07:16 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX161.amr.corp.intel.com (10.22.240.84) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Jul 2020 08:07:16 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Jul 2020 08:07:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Axp5R2BxyUL/ctt7szJzQfVOAbb6xZCAo/1pj51RwWHn/iLJVwCni29p9su/zVrvkV609HsMeh8pbYtd6I0K/zIMj9XpgePhqwO1AJMiOIezKU+kyluVyox4i3vBZy4i3IfVaidndo9Q65D/MdBPVrxTTGg62WoFMikMoZx0kMX4GfJ6GWAVCasAr3MpmqbxeO/iX4CB2/OMKWe9Ok0eQUQJHwh7OgWhHA5fdP/WO/0OhpemDwf7aFLYtS2iG87y/TggnzJFfJtnnKvUUQOyyWYkR8KAswi00Evtl7GcrA7plvoJPsl7krQhmTFTAHBwn1/RR8XdZ8cZj01ky1Qpjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtAIlPj66/3bL+MJjsXdnT8PME0fodYtRgr1yTlxOSw=; b=mULO3ZnvFfk4xfG2nSg+Aeiv0OMQGamq4IP9NijI+3JHhaYTDN82RTGdSAUsfvVCMaaMn/kzX1zJFYo7pXNE94hV2WT8FsbQ8rbttpAIcwkXQLCRQLKfEAo9NeP9XkqIMt3oIiQq7hyMj3a66Tt4QdbSeq9ukl6vL8wp866qdv3yRJTjGijLgeOm5yaYF6qMru8QrH7+CK0ffutobbkMIaSdvmEya/MGfe+LvYdpc2z/LDsmZvf++M2Z9LMGgXSMmzjjG3NS6EVgyXXWI59M9rdFdJzLEC1cDpDErovF/lOocnORsGmW1LoqtDU28rJ5vnHs7xpupyfa7K+FNWNgIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtAIlPj66/3bL+MJjsXdnT8PME0fodYtRgr1yTlxOSw=; b=AKCgoAqGrSqz4RsoQic7d4boikq6+i/tcMCsZ5/X2e+/fXHbVywj1yBRyMqoiVUlumx9JEVuU+ebRmGGZXjhxVry8WaShdT+2yjEXhYutpm0uNBnh8JhHQZ8qgkIVNyIyi0720XxhMc68pExxOpJ1pL3me5kYkQlSQ/QiBlVwZI= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1312.namprd11.prod.outlook.com (2603:10b6:300:2b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21; Fri, 3 Jul 2020 15:07:15 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3153.028; Fri, 3 Jul 2020 15:07:15 +0000 From: "Liming Gao" To: Leif Lindholm CC: "devel@edk2.groups.io" , "ard.biesheuvel@arm.com" , Laszlo Ersek , Rebecca Cran , Andrew Fish , "Justen, Jordan L" , "Kinney, Michael D" Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve Thread-Topic: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve Thread-Index: AQHWUF815t7Xuk+RLkuJp4fcpNmfu6j0TQXwgAAIIICAAAUngIAAtcjggACbNYCAAEoA0A== Date: Fri, 3 Jul 2020 15:07:14 +0000 Message-ID: References: <92612908-44f4-30d4-ae3a-3ad595e2141f@bsdio.com> <68b55c49-1e49-e082-ca38-68c3d321611b@redhat.com> <20200702105419.GN6739@vanye> <20200702141323.GQ6739@vanye> <20200703103757.GU6739@vanye> In-Reply-To: <20200703103757.GU6739@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.219] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 642c5ac8-ad25-4ef3-6579-08d81f62c551 x-ms-traffictypediagnostic: MWHPR11MB1312: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 045315E1EE x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nVNpDr8/JIyms+A2SzY2ioIzNd0HuhKYAgpVeNQTwlptnnN0uwfGrUSx7+j1jNEdN73wCdD2hRqd4jxORgSl+aJlQV/byhTvzUiaepOeDQpBaUrUqP6WiWZ1deAn+CkQc6eLJKqdb/mQoWCR88fMCYGA9y/xOdjaOftpNYi+bDagcaFUPdHRTELF8JnTsMB0C65JnEuCd5icnXEqOVR2VnkSPpjTZKhbTo2kcqM+mnos7rWfJt1ZJkqfHPMeSWc0hLjtomlIsgJZPoB/ELW/kPHOf/kHef88obrU7GbBD59S0DBooxPaQODbmj0EZSy9Vuuj8CPExQBO2Yc1XONCe46bElcH0INWYMJvb+4wjZ4yQsZQp1fLI0dB5ivDE9DhFopR53ACiL08EdbLurR3JA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(376002)(396003)(39860400002)(346002)(366004)(186003)(2906002)(5660300002)(6916009)(52536014)(9686003)(71200400001)(54906003)(55016002)(8676002)(966005)(53546011)(66446008)(66556008)(64756008)(33656002)(66476007)(83380400001)(26005)(316002)(7696005)(4326008)(6506007)(107886003)(8936002)(66946007)(76116006)(478600001)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: BYUQ4tQBcPaCAomSoUAQizbjWiLFVVi675vqru+1EfKSqrtxGHetauuc2g3ez2IriBZriGf+PhDMnuznSKnnZTbaczqNrhZyOOdje36+xb2cmeHDGIsCZgvvOUaWUivpFOIqtxQJPW/UBdqaU1NI+5J3+rbFREtAyF4WoyWHKYUP7l8wPMBn90RxxSgrQmoBVz2bAXNB9J2Rr2hIP1djRNKcBs0b3kGoAvRU1r3cupAIuiwEv/GcWD3LOl4EzWc4NVt2JNbzJNpAfh9u+X7V8KJe6cMQ/J5u27w+IlIe+BCD1jWM3GW9RGRApkXEPmiXeIYbYibdDOCIFvoVckGqSazNmmWqK1ZBGetjKXkezEHM+EERxSzbglcIgVkzqjjjP3VCy83/96kzC+SizjT5UUkifCsI6kSxd0lA8QOkwGvOumS6BP2rr5vMOANU/G91WUZZw2efrOq71U3Lz28iwCigV+kvzjxdcU4uSOI5w5hM2rBMhIUeiU2u3pCawSZx MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 642c5ac8-ad25-4ef3-6579-08d81f62c551 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2020 15:07:14.8728 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kfkDMgBV5i3htFoTRMB/tLVwlCGuh2Hwrwz2fZwui85RjmI1R2MEz+sz3n14j5R+I4JXV1gsP1xNHpuqHDLcDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1312 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm > Sent: Friday, July 3, 2020 6:38 PM > To: Gao, Liming > Cc: devel@edk2.groups.io; ard.biesheuvel@arm.com; Laszlo Ersek ; Rebecca Cran ; > Andrew Fish ; Justen, Jordan L ; Kinney, Michael D > Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support fo= r bhyve as OvmfPkg/Bhyve >=20 > On Fri, Jul 03, 2020 at 01:40:26 +0000, Gao, Liming wrote: > > > >>> *Reads patch* > > > >>> *Figuratively spits coffee all over keyboard* > > > >>> > > > >>> No, this is not OK. > > > >>> > > > >>> We *STILL* have no agreed process for accepting non bsd+patent c= ontent > > > >>> since we dropped the contribution agreement. I have tried to rai= se > > > >>> this issue several times in the past, and there has never been a= ny > > > >>> outcome from resulting discussions. > > > >>> > > > >>> So now I'm going to send out a two-patch set consisting of: > > > >>> - Reverting a4cfb842fca9. (Doing nothing is better than implying= that > > > >>> anything !bsd+patent can currently be added to the tree.) > > > >>> - Deleting the statement in ReadmMe.rst erroneously claiming tha= t the > > > >>> includion of these other licenses are acceptable until such a= point > > > >>> an active decision has been taken, approved by the community,= that > > > >>> this is permitted. > > > >>> > > > >> > > > >> If only bsd+patent is allowed, the checker can be enhanced to che= ck this license only. > > > >> I don't understand why remove this checker. > > > > > > > > Mainly because that was the easiest thing to do :) > > > > People may miss it. So, the checker is helpful to detect the issue. >=20 > The feature is useful, but enabling it by default is not the correct > decision for all TianoCore repos, and the situation for non-bsd+patent > contributions is less than ideal. It can be added in open CI for Edk2 project now.=20 >=20 > > > > > > > > But also because: > > > > - The thread that spawned this also raised the problem of > > > > machine-generated files. > > > > This is a gap. We have no rule for the generated file. Laszlo gives one proposal to use the specific tag in file header if this f= ile is auto generated.=20 Then, the license is not required.=20 > > > > > > - I am somewhat unhappy the checker got merged in the first place > > > > without wider community feedback. BaseTools and its contents ar= e > > > > used for many repositories (even within TianoCore), and this ad= ded > > > > unconditional check breaks the use for some of those. > > > > > > The patch to add the license checker is reviewed in edk2 mail list > > for several weeks. > > I don't get other comments. Can you give the suggestion on how to > > improve the communication in edk2 community? >=20 > I think that for something as fundamental as this, we need to actively > chase feedback. I know that I will never manage to always read all > emails to the lists, so there is always a risk I will miss something > I'm not cc:d on. > For something with as big an impact as a tightening of requirements in > PatchCheck.py, if sufficient feedback (like at least 2-3 maintainers > outside of BaseTools) has not been received, then it would make sense > to ping *all* maintainers, alternatively ping the stewards and ask us > to go gather feedback. Good suggestion to include more maintainers and stewards. >=20 > > Besides, there is another new checker of ECC to check coding style > > for each patch. Can you give your comment? > > https://edk2.groups.io/g/devel/message/61966 >=20 > I have never managed to get ECC running in any of my setups. > Perhaps I should start trying to track down why, or at least raise a > bugzilla for someone else to investigate. >=20 For ECC checker, I will include more people in ECC checker mail list.=20 Thanks Liming > Regards, >=20 > Leif >=20 > > > I think the fundamental problem is that contributing code under a > > > contribution agreement that includes a patent grant is not the same = as > > > contributing it under a patent grant license, given that the latter = can > > > only be done by the author of the code, while the former could be do= ne > > > by anyone. > > > > > > This means our current licensing policy is actually more restrictive > > > that the old one, making it more difficult to incorporate 'second ha= nd' > > > code. > > > > > > I don't think we can fix this with a patch though :-( > > > > Yes. This checker is for current allowed license. It doesn't resolve t= his issue. > > > > Thanks > > Liming > > > > > >=20 > >