From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.39374.1595257089533383788 for ; Mon, 20 Jul 2020 07:58:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ZKsndW4T; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) IronPort-SDR: e2mgwRvpEMZzi21Ngc3ZAg9ptiAp/4u4PgBzeDUHTG1/dgTnIhsrTczqEvxgNUL1hfBW32aVrK OXDmNeNmm8+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="129488547" X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="129488547" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 07:58:08 -0700 IronPort-SDR: uNYmAVZOd18Pe0yZ8H2uBB9LS3YbBZhNt2gUKDao1J8k5WiH59qlPsCNAhq7Gx8zsQ32z6J+bi oYyAUYl6nV+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="362037245" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga001.jf.intel.com with ESMTP; 20 Jul 2020 07:58:08 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 20 Jul 2020 07:58:08 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 20 Jul 2020 07:58:08 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.57) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 07:58:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UwSnxj4xNYzQZ188cByV6uprNoUYXqZD+R2QBY/tJ4zSMUSEv9PaZGjDlIUjOZm3tj+rUuJoMcf7APen54ul1gOlEjzeISzHohoUcGvBYIvaLGpphhKnTFyLQvQpxsVnosZD+T3m46CsijoLl8JyU5oGaSpda7a+M1ozDf0kiC7okrrY5GBd53uKx3MaP8yxammwJy3bZZNrVHkyW38V7CiShXGjoP0TOFn/ex5/VDbmKws9sMEkId1ycO/Mopbc9RHh4dZi1bXRQml93nW525H1p9obq9lP6WtTr9aeWyoMVkcRGLDaEClhh6TQEg2rNL+LrbLrAMPz8K9eu+QxFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NFHZVMke82XtangEudrKgCC13BdgBmRthxv+eH1yt/g=; b=SZ8Jhwazi6wY634R7o6xcBBmrouEmrELXc8A2Pmba8FlmBblTHpqEHF3bR3LwbUH0N6a72grabyeMfO3QyvZUo8n243ttqxeTQ218O3A3FtuI/P7VSOxLv+pGgqV/pkQVcPV6/gHBSdHWrQAFoWLZBUNpVkD6gx4kdAwOciYsdJ+aoZ+d853z7QfnxPP7FkgUyPWjY7YHMU6co4dYE4Iis4KnFnfALZX2wgcKxamHiiCKfUBB3RxLZCChoL37B2mf6hpE8o9mBd/DwxJRFm6asblcmSK/j9ZmJ+YhCBSERe5KTYaY+KsLIjPsGUaKcmWDnCajJl5KrjUHSz6LDR1VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NFHZVMke82XtangEudrKgCC13BdgBmRthxv+eH1yt/g=; b=ZKsndW4TeJ7ja55AOYHWkEXhU8fmna23rqzB+FLsHiCCSJuPMqYLvsyjgYhJMq61FHbL/1izrT3bH6e/iCjE6HyxSz28FNNPTmzWctNb0ODF1fHeWUjr2J16Wo7waPxqr+cpBo1HoteYYdsIW22TihNumdBlt3lUD7eD2ibbg38= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1310.namprd11.prod.outlook.com (2603:10b6:300:28::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Mon, 20 Jul 2020 14:58:03 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 14:58:03 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "leif@nuviainc.com" , Jessica Clarke CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] MdePkg Base.h: Delete prototype for __builtin_return_address Thread-Topic: [edk2-devel] [PATCH] MdePkg Base.h: Delete prototype for __builtin_return_address Thread-Index: AQHWXp7MrDF3nWgtXUeDcNm/EMifTakQjqnA Date: Mon, 20 Jul 2020 14:58:03 +0000 Message-ID: References: <20200720134946.33723-1-jrtc27@jrtc27.com> <20200720140446.GP12303@vanye> In-Reply-To: <20200720140446.GP12303@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c73d1a0-ff85-40e2-3527-08d82cbd4db4 x-ms-traffictypediagnostic: MWHPR11MB1310: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:425; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ntUUE7x5ExKnexHHv8DfwPvJ0EJBbZs8luvXqHea4okYFxwwQpxDC/DxxRzQ7k695wFzbF0O4QksvjSF8bqYUt7a/Cf38NuLRzp45/syxBW6Gy4s/xXTpdRlo/Pw8VUtqDjznyEeM7x7pCgkNfYIoV/4IZYx0GYooaYK2khstHeqdSM58blNx85+YQKEjSk4eJ+z/eSyxBeDU3uJHtsdI6sIIoZx86QhoWAemb9EzsK8paZjK8biYPadEqeBltFWgSjc92cVrDFcsEWzLPXHHCR22TNHi0yxfGqd+7vG9G3yw9DuQd0XjSAL+Ety3ybp9dtadd/DfD8ZqOLjCv7PRJpzifbyZ0hqMgTmzWWGSXdRt1CKz62x+mSj0c4/xHiBqGhDh4hZ4o8De8i+yv5Ivw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(396003)(366004)(376002)(136003)(346002)(9686003)(316002)(110136005)(2906002)(55016002)(52536014)(66946007)(64756008)(66556008)(66476007)(5660300002)(478600001)(66446008)(966005)(76116006)(8676002)(86362001)(4326008)(26005)(186003)(6506007)(107886003)(53546011)(33656002)(7696005)(71200400001)(8936002)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: aiPTtRmBJ++gQBBXnBgmopdFOjpPyiHrEbsTDO0KnESFQVnZIGQn3SRobuhSgR144R85HTil/LmST+Tkpg7Ie4pje8BcTyyK+U7GBlcLlTfl0ET6r90MyVRupcx5nECXTWsxY5nSeSzpQoeDkXmgwXgrphGaoqh11ooWGqIPZZtrTZYTrX8vlzBMGYxs+Jrv0RjK8oqGof1wyHhXc0P6gtEt9mtnlxUrSoZVb1nJkmxu6KXJvPJgmsBPWXvhpgQn/ccXwXN7nXyCAWrLaR8lNgFRsQAS3bsGqAflcD8FnjNIgkLn0TnwoIj5/HXnEvhGsQp8vHMLyMoXs/NZgSvxYH1RiL38+IuI/Th73CZQMkv1N6Cco+0VMCTHZ/uDZw/1Rg3tF9SS1AAg8DEYpOQvdF1wCPVxUJttC3AHKXx43e1TCoRTZnmTSXtNDMFQHmm3Fmst0i80fINiKFpf++iJzMik4piB4yk09sPufjl/e4cYdLcVzP8POYJJaudmZ18+ MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c73d1a0-ff85-40e2-3527-08d82cbd4db4 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 14:58:03.5192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +UEuPfOK43M+WfAYpXyPxhRhjNIlh2n0v+IJhxIhQwm/Yegjexdt1JTC7qZwCOGTemcScIa7qgjjbmBc9epWnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1310 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Clarke: Do you mean CLANG compiler may have the different prototype for __builti= n_return_address()? If so, dose __builtin_return_address (L) always work?= =20 Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Leif Lind= holm > Sent: Monday, July 20, 2020 10:05 PM > To: Jessica Clarke > Cc: devel@edk2.groups.io; Kinney, Michael D = ; Gao, Liming > Subject: Re: [edk2-devel] [PATCH] MdePkg Base.h: Delete prototype for __= builtin_return_address >=20 > +Mike, Liming >=20 > On Mon, Jul 20, 2020 at 14:49:46 +0100, Jessica Clarke wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1004 > > > > Being a compiler builtin, the type of __builtin_return_address is > > already known to the compiler so no prototype is needed. Clang also > > errors out when redeclaring certain builtins like this[1], though > > currently only for ones with custom type checking. At the moment, > > __builtin_return_address does not use custom type checking and so does > > not trigger this error, however, the CHERI fork of LLVM, which will fo= rm > > the basis of the toolchain for Arm's experimental Morello platform, do= es > > use custom type checking for it, and so gives an error. Thus, simply > > delete the unnecessary line. > > > > [1] https://github.com/llvm/llvm-project/commit/41af97137572ad6d4dafc8= 72e7ecf6bbb08d4984 > > > > Cc: Leif Lindholm > > Signed-off-by: Jessica Clarke > > --- > > MdePkg/Include/Base.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > > index 85a091b9d5..8e4271f6ea 100644 > > --- a/MdePkg/Include/Base.h > > +++ b/MdePkg/Include/Base.h > > @@ -1273,7 +1273,6 @@ typedef UINTN RETURN_STATUS; > > **/ > > #define RETURN_ADDRESS(L) ((L =3D=3D 0) ? _ReturnAddress() : (V= OID *) 0) > > #elif defined (__GNUC__) || defined (__clang__) > > - void * __builtin_return_address (unsigned int level); >=20 > Agreed this looks somewhat bonkers. > And I can't see any ill effects from dropping it, so: > Reviewed-by: Leif Lindholm >=20 > > /** > > Get the return address of the calling function. > > > > -- > > 2.20.1 > > >=20 >=20