From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.10461.1594883984972037538 for ; Thu, 16 Jul 2020 00:19:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=s6K/RQir; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) IronPort-SDR: 5RXEBpz/Od+N2gGmBCcXNRfv+Azvz6WRsrYXAxkafwum7Ex1qP10MZsSwxV0hxThmNUuTk8qb/ ocZtjnhPvj5g== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="214069090" X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="214069090" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2020 00:19:44 -0700 IronPort-SDR: 6nM6TpRMLAAHci2VKzBFxKDHnj7K6dWfDWRAufxOUdc/q4IZnlrmyUCZy87XRwtMuMrpDxLgaL nuJCTVBE6ZVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="286389567" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 16 Jul 2020 00:19:44 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jul 2020 00:19:43 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jul 2020 00:19:43 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.55) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jul 2020 00:19:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDo0PauNj5XoXzFPeWWh0sNj69mFiLtBS52jqkWu3S5w/vhc6iYI8lWNM3eoQjUwM1ORKVIgfwVZtS6Uq0fGsyySlFMe+4hshCMlP4rA0Cu2XuGNqQF+FBHH4vDmPWxjEoy90R7RJOlpHCbFWhH8cPrpCRueNr/kkLC57Y/4bo0XPxFSSY1GbZq4GKjkjrO0s48/lFp9PEuSK19NzmwI3SLHgVDRHTIV5EjPQVrkJlwbhLNIyWgtSSam5x0Dd44CjoqOqo7gOP+bmqg3m5xWZcSkI9+mWvKLOJRpMgQlsbnAY9znARuvcxnRAZ4mr41ZQldI5c+YR+CXDJr4hxu6GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAL265cAnQswWt/Gj00sGguaB3Rpb+0ypyW0xD/FEs8=; b=L5sPyrWWOk1m7UXYhctLd4/0EGeFoO9oRPcTpoKe05TzjqJkZcjbRlq438F74XQU+zxORes8eHcv+W67x/Ulyrr0y/GC9k6/aoDvUCSAIH4AfUqzgwg8xDITCrEV65V6OmwcC9/nJK8c8f32m1uINZWp4OLLVtXildIT/1eLPbC+CP5H0XqUfSf9FxUesNjqu0E6jvUe2c3RnK8wlj7cJ12GczDZNABYKTnZ9QibRqZ8i2sVhrfn858SL0dCnF/hsQGCG9Dqb2CgEcOIuajDuODyfHqjBNtqD9x1DH2INWyVZ6Nyht5xY1jcVI2CrxfYIzN0mQDIjc0fO/htDZy8mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAL265cAnQswWt/Gj00sGguaB3Rpb+0ypyW0xD/FEs8=; b=s6K/RQirlvP+HWglLT+7sBLKNGJo3w7cZ84mlCGN/rIF+UVmeZA4t19kBQj6LgzpgA8fqPk8mU8o7VJ/TX2IEL9xuzcL+9XSmOW1jU0Cgvwc6741BOo2TsrCUjLsVscZQOUSzSxSB4Upp0ywD1NDv9M6+yKMGMM8skUGqLd9D+s= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1742.namprd11.prod.outlook.com (2603:10b6:300:113::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Thu, 16 Jul 2020 07:19:41 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3174.025; Thu, 16 Jul 2020 07:19:41 +0000 From: "Liming Gao" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Feng, Bob C" Subject: Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Topic: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Index: AQHWWx8nl+JVP2umBky5YMNoJ8up+6kJzKeg Date: Thu, 16 Jul 2020 07:19:41 +0000 Message-ID: References: <20200716031346.40160-1-shenglei.zhang@intel.com> In-Reply-To: <20200716031346.40160-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5c1570d0-517d-460e-1c96-08d829589bb7 x-ms-traffictypediagnostic: MWHPR11MB1742: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RrHQRei+QhGg/7p1SHeLFp2SDkdahW+VhPbJTMGDS6+/s4p/BSWy3LoJb9RCI9LCiXYaFAt9L+ypNGPJhfFZJXtSBxe9Wtvw7ji4ii8MtxAVSAoC1f/kgPZ9ghliQFPa4U270TEXBnQPqj1cq9GvkU2/AVkdVCnf/qSVAMclPoK0qIqYUx2nRI8VNePSLkMFGjXqSj7AvAMRVubXC5pR5Ri1KzKFB/n31uvdCzVxEBEtwM8YK50aGxYYpsgxJBAcPtuDE1RH+1T9QpSY4ho4lRbR0eSwY9acHXxSkkYxNqtoOIjXeMILuGY2sMfkQrjVFxHY+hFlxqSiEqkKJC4NPd8dvam+oESOIynccfOcjqHm59NPDbQDhAX7NyCUM5fZD0Hju3ClLjIiS9eCEZf00qZr9v8h5cQssm8OGmyhsB6wqBu7e/50tFehiL8bd+ay8aPdwFcrPDbpxlkVyeZyI8EManbbbj2BypkRL9Mj500= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(316002)(83380400001)(110136005)(64756008)(2906002)(66446008)(8676002)(52536014)(966005)(8936002)(76116006)(478600001)(71200400001)(4326008)(186003)(107886003)(9686003)(6506007)(53546011)(55016002)(7696005)(26005)(66946007)(86362001)(66556008)(33656002)(66476007)(5660300002)(13513002)(21314003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: X2goYlNwcGaQGgGWei7ys7rkK01iKqWzhvbuo6o07aalr7WlPj0jN8jHUOmSxE+qkyFuFb6Qr+CK2e6ZMqCbGmuKyjm7mIQaXGC/XBS78cTD+WqcLbG5uBCftORMRTodwdkMgNBhDWs3UMtL+o3P7/q2ySUC4jKDICu8vTJ5pVKW18raWzc96VHlhdGvHyzWYbOlKaQk7BDrbGSuGxAYQ2RUzAMzSo4w5YZhj7CFNoyVgVbCiejAovlvuLzuPht5D1SrTKL9KoYKjZ9cjVp1beC71MkwMneHOxwv8MvBbiBjSa2xYYhDBAGnw8jKdAUDv97Yroth54OJpGjLaanip1/KZZ87/t1jRG613MzELAB98V0cofnwLQLiZ98TFr3jhNxYpHZUW5FpDKAAPbLJ1m7tEU0Gi8IWVj873N4ZbkR8iDdaQJTRTi5ATZ/mpHT5ooQu9N2iaWzEh3u/lBzx5UhnrHTs0iicKnHmoeoQbO8f/jKopH6a2oeMxCVPekes MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c1570d0-517d-460e-1c96-08d829589bb7 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2020 07:19:41.8075 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T1zrZfr0rYsGVJLcRWuG3QrsUYhAvpgP6QBA81ls/xTtyQmKPH51Fbl1WvYrseIiDMjXsO0Sd23aRUyVau67aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1742 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao -----Original Message----- From: Zhang, Shenglei =20 Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B16=1B$BF|=1B(B 11:14 To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name i= n xxx-by REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2836 Current PatchCheck.py checks each line to ensure line's length is not large= r than 76. But there's a case that length of user's name is much longer tha= n that number. So enhance the script to handle this case. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 52244b0bc4d8..7db0775d14d1 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -268,7 +268,14 @@ class CommitMessageCheck: for i in range(2, count): if (len(lines[i]) >=3D 76 and len(lines[i].split()) > 1 and - not lines[i].startswith('git-svn-id:')): + not lines[i].startswith('git-svn-id:') and + not lines[i].startswith('Reviewed-by') and + not lines[i].startswith('Acked-by:') and + not lines[i].startswith('Tested-by:') and + not lines[i].startswith('Reported-by:') and + not lines[i].startswith('Suggested-by:') and + not lines[i].startswith('Signed-off-by:') and + not lines[i].startswith('Cc:')): # # Print a warning if body line is longer than 75 character= s # -- 2.18.0.windows.1