From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.2110.1595895988255595741 for ; Mon, 27 Jul 2020 17:26:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cF2+6YmL; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) IronPort-SDR: jihyHswMfMqQq71VPGFoXn5VKLijSt2+81PAxgae5rL9jaiBDpFou6DccMcHzcQDbrrXjfZ7yW FeWgEQWuwqXA== X-IronPort-AV: E=McAfee;i="6000,8403,9695"; a="139164992" X-IronPort-AV: E=Sophos;i="5.75,404,1589266800"; d="scan'208";a="139164992" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2020 17:26:27 -0700 IronPort-SDR: +ftF+XrAybktfsOmikp8Z5t4c/mqvBg+5n608EDR9oqVx8IrSUDR5xaJrEWemqSsfW0l3YisHD 5GJ5aDx2fo7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,404,1589266800"; d="scan'208";a="312409136" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 27 Jul 2020 17:26:27 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 27 Jul 2020 17:26:26 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 27 Jul 2020 17:26:26 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Jul 2020 17:26:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VoG/bbvjRyZOB+tetH2Wb/YmZYH4cjhJ04MC1T4q94PloRkIUoKpeUwWTZdRk2O7QUYptwoh2N+wuDt5lQfXDeDmloPjqYI1FRzQWOgjP2Qjm+S6ffHMTxLHFYxjs2dK6ZG7bbidnf29saTBYs6/PwKAjGMNrE07JZVreQ2B358tWFh7esExpH1nGHBMM9OGhfXyTwLOHvcKQtEA4D5gasi136uoHXsDxu17asszHradJWtUg5vPZSgUREYTt+A3hKmmQmj4mmB/yNKe6EckvZ+yZMXdqSYm1so+C7z86uLN3CKPLWjS8LqC7hUfX15RVtwAKf21+qlCV4fo0mtfjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cBkDfLxl2/6T1ztR43wt5bsURi5I1MVuM5XhjevIE3c=; b=KyZmvUVCPE0DhGJILQG1fPK/WUOsSQ5bgaS0Tq87fOGPzjb4l+rrZ+Frk+3JzhGeo3rXHkyCpxLIgCRJWw//lbUFoKXEDgj6t/x2+74ouRsfo9wfI1DQUxCGIP9uC7LeMbmCGsHQxzowBCbv5BBuqpW6Brn6Ohx75hZtMaztEtZx0GjEBvPz6nTZ0FnkvySiRSV8W2mbHR331LzT4uVUxTFqvfqb7Zaa/OOJV6R83wxhDrit6RGZxWOn97FDlXJKjoT+ZPAKZUTH9VKJTOKOTBAtSs4WsDplA+4Kyt4RbzAFDbQzjabXKMa1vlZapR87c/8I2tqF2V+GGGgZsUY17g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cBkDfLxl2/6T1ztR43wt5bsURi5I1MVuM5XhjevIE3c=; b=cF2+6YmLujWB5qDMyb2I5E52u4r6T9EICpq5fEAAyONNK+omedXPJVFIYQIn2e35xW8H6oAZYVkyl07OrlpeNeFfKNJHpATv1wHTd6Sem88yxRhxGTmJlVIQx0Kw6A42MCdGMIfL58ETEHXIiyIF6zWtYWX9GW9sXXQH80IiLrg= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Tue, 28 Jul 2020 00:26:25 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3216.033; Tue, 28 Jul 2020 00:26:24 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Liming" , Jessica Clarke CC: "leif@nuviainc.com" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_address Thread-Topic: [edk2-devel] [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_address Thread-Index: AQHWY7mNVNLohyUgW0qdMiGnOLpB26kasLdAgAFzMKA= Date: Tue, 28 Jul 2020 00:26:24 +0000 Message-ID: References: <20200727015850.16776-1-jrtc27@jrtc27.com> <16257A6ED97D2A8D.26462@groups.io> In-Reply-To: <16257A6ED97D2A8D.26462@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2633834a-9b16-42f3-b184-08d8328cdc7c x-ms-traffictypediagnostic: MWHPR11MB1630: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ypFCdZ1HfNQHw2fhYth2vEebKkRzkaf44t2cu+p+0mA7gzLtv5kjtZdHLxzV5D0WzAZzZqRj3lE2et1tQapEF3fqjJkocC9ipUD82nsA6ccx7vUCj429J1Trp1hZCGfUFQ/xA4OQaFkhjWN1NgGiKVTSsMbrNYLuSF+8YfoPSs6OQfnNJgsA3JAWfFHAMU2U0TsIA0NKythfz9JaitxXOFIZgCpF78PiGkZYE/9VQhil1+0PKtAdRri5CdCQ3aMLw3rKwgesV+QO89QBBqHWeuTTLWqZCO1wMWhjdG3Pk61vAv+6A0FxKiQ0jBxx1pGIH09hsaWZw3NaCcYZ7D6VItX17O4huaR+Rj3Bnk3TiYHTrxJ27QyWi9s4B2m6h+zC29iKMZQbZ8b84dGNffg67Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(39860400002)(366004)(136003)(396003)(76116006)(66946007)(4326008)(66476007)(66556008)(71200400001)(64756008)(33656002)(66446008)(2906002)(7696005)(55016002)(9686003)(5660300002)(8936002)(53546011)(6506007)(110136005)(86362001)(186003)(478600001)(83380400001)(26005)(316002)(52536014)(54906003)(966005)(107886003)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: NpBPpOWBADVH4xS1RE+64DWEx4a/yGoYywPCP5z/vFs/ZKAuLaccjJ0kDpboEf6DUA1njLbaKUzVYDpdiVMEg06N95rHSMZkYfqqF6XX9LS0eIOlyTMvD2KJFoMfVVKqi36LNWDa9sskqkn9A/+/XwY0V2Mec9md8gcbdf0EnEZpdfsITMrosjE+mwCtH0p2shPTEoFRA4b86mo6Bl3ql1TtxHS+eeqSfzEiEA2p0oY4I4OEfzsA0YHACYuKw7eVBJ3lPnw3gBLpejVGpMrO7LP+GzN79DB7mpErcQE1bPpm4b/vQh5GJEfQa30yMxL3+OWkwgDhVdgZxrvFLhvbXceQai6ErB43v+pl82Hk0rYAfa8B6MZH/RGyaijqlQ9J6DOcu37o4L9YevvkFme6jtqndDx+oDe3ePD5cUYAGD/uXeBeb8qmCxI6otgAROzY3hEHFgb0glpTak6GWcPkYOW8SK6HbhEQNTaeTaDDucK38LxA6ow48iYGOWvzH9uW MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2633834a-9b16-42f3-b184-08d8328cdc7c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2020 00:26:24.7485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KdtXZ7VnfIfMYR6mW6+WHEEd5HagFg+tBT5oDUj7XToTgb8RhLalR5acbXco14ISMjqQFVzwLw3O3Y98YvwTtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1630 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable PR https://github.com/tianocore/edk2/pull/829 has been created.=20 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B27=1B$BF|=1B(B 10:18 To: Jessica Clarke ; devel@edk2.groups.io Cc: leif@nuviainc.com; Kinney, Michael D Subject: Re: [edk2-devel] [PATCH v2] MdePkg Base.h: Delete prototype for _= _builtin_return_address Reviewed-by: Liming Gao -----Original Message----- From: Jessica Clarke =20 Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B27=1B$BF|=1B(B 9:59 To: devel@edk2.groups.io Cc: Jessica Clarke ; Gao, Liming = ; leif@nuviainc.com; Kinney, Michael D Subject: [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_a= ddress REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1004 Being a compiler builtin, the type of __builtin_return_address is already = known to the compiler so no prototype is needed. Clang also errors out when= redeclaring certain builtins like this[1], though currently only for ones = with custom type checking. At the moment, __builtin_return_address does not= use custom type checking and so does not trigger this error, however, the = CHERI fork of LLVM, which will form the basis of the toolchain for Arm's ex= perimental Morello platform, does use custom type checking for it, and so g= ives an error. Thus, simply delete the unnecessary line. [1] llvm/llvm-project@41af97137572ad6d4dafc872e7ecf6bbb08d4984 Cc: Leif Lindholm Signed-off-by: Jessica Clarke --- Changes in v2: * Shortened [1] reference to fit column limit. The bug report has the full URL already, and this will still link correctly on GitHub. MdePkg/Include/Base.h | 1 - 1 file changed, 1 deletion(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 85a091b9d= 5..8e4271f6ea 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -1273,7 +1273,6 @@ typedef UINTN RETURN_STATUS; **/ #define RETURN_ADDRESS(L) ((L =3D=3D 0) ? _ReturnAddress() : (VOID = *) 0) #elif defined (__GNUC__) || defined (__clang__) - void * __builtin_return_address (unsigned int level); /** Get the return address of the calling function. =20 -- 2.20.1