public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Javeed, Ashraf" <ashraf.javeed@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header
Date: Thu, 23 Jul 2020 09:47:55 +0000	[thread overview]
Message-ID: <MWHPR11MB16302CBD24FC671D9B05310380760@MWHPR11MB1630.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200722152139.16496-3-ashraf.javeed@intel.com>

Asharf:


-----Original Message-----
From: Javeed, Ashraf <ashraf.javeed@intel.com> 
Sent: 2020年7月22日 23:22
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2611

Introducing the Cxl.h as the main header file to support all versions of Compute Express Link Specification register definitions.

Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
--

V2: Indentation and double declaration fix, copyright date update

V3: Copyright date fix
---
 MdePkg/Include/IndustryStandard/Cxl.h | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/Cxl.h b/MdePkg/Include/IndustryStandard/Cxl.h
new file mode 100644
index 0000000000..632aa146d0
--- /dev/null
+++ b/MdePkg/Include/IndustryStandard/Cxl.h
@@ -0,0 +1,22 @@
+/** @file
+  Support for the latest CXL standard
+
+  The main header to reference all versions of CXL Base specification 
+ registers  from the MDE

Does MDE means MdePkg? I think "from the MDE" can be removed. 
With this change, Reviewed-by: Liming Gao <liming.gao@intel.com>

Thanks
Liming
+
+Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef _CXL_MAIN_H_
+#define _CXL_MAIN_H_
+
+#include <IndustryStandard/Cxl11.h>
+//
+// CXL assigned new Vendor ID
+//
+#define CXL_DVSEC_VENDOR_ID                                             0x1E98
+
+#endif
+
--
2.21.0.windows.1


  reply	other threads:[~2020-07-23  9:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 15:21 [PATCH V3 0/2] CXL Specification Registers Javeed, Ashraf
2020-07-22 15:21 ` [PATCH V3 1/2] MdePkg/Include/IndustryStandard: CXL 1.1 Registers Javeed, Ashraf
2020-07-23 10:06   ` [edk2-devel] " Liming Gao
2020-07-23 11:57     ` Javeed, Ashraf
2020-07-24 17:11       ` Michael D Kinney
2020-07-24 18:28         ` Javeed, Ashraf
2020-07-22 15:21 ` [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header Javeed, Ashraf
2020-07-23  9:47   ` Liming Gao [this message]
2020-07-23 12:03     ` Javeed, Ashraf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB16302CBD24FC671D9B05310380760@MWHPR11MB1630.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox