From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.6717.1591708212538400373 for ; Tue, 09 Jun 2020 06:10:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Z7iZcAGd; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) IronPort-SDR: VWKvQxqe8E4fdlpdCT6dSNt9FSs0HATqJQ8uNq8aq5bIExOqjG8QgT/POhxMTf/+PGiNdLis23 EKk3IUY40bKQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 06:10:12 -0700 IronPort-SDR: JYiluyC0woxVTbOpVZHHp+LdezXrmtnAmLPQ3LtO4S2C6X2tPbXm4cKqspXMFiLsgyCZ/h6+eO 5o9wsf2dNczA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,492,1583222400"; d="scan'208";a="306186274" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 09 Jun 2020 06:10:12 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 06:10:11 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 06:10:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tdljmnj5AtPQdOF8/ZhFnApM+ebfgHUJEFO2XrTE6BYoeQZtEQ9bqIG0XQxiQ8dNl6pgNLEsxmiLZYanUhhT39ElKz+Lsa6vV/mXjJf8ewtOsnR0e6a3HLMLSX6Rlsgm0EtYBmpMzmGfr5gvImKwxXTzcNZrVTnSQWGXe3uE84zN2NUHHtIUZl9XE6yD3j48ZWixIk+6T1kdH17YBbDmksu0+sZBgB/SR11OKSs+60ADBJjKNEepT1vToEGgUf4C2PZ1S22BoBFPA4kWs0c1YHm1+zJc63GeaMZcknl964vgRGoWj6cvhR7mZdtNDSOulRMtDxsJ6ItRPwqYGn6rKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLzpezK+pYoH4jVfPymuI9vIXJ4qw0WhBNqjh092duc=; b=gvK8WKrXDRa1yF0GjE8pAcIJrEOjskNyyeC0vrtSR7/t0Hy8RosSKARsfMyCUeDcReBxvtAqRYf/yo01j0cL3Ccw45u1Q4gKlMjUeKjiZl4Abj7aGUK4asWTrbEK7ApMWjXI/E/02YPyDAQJ8iR3H85+QD3W4Xjc31iATZNfADW4PrOZrZjvH7SN5EAc9z8UbBamJIGVI965YEGqcP74w5svJaywJt7omVLY6HwEaaAnk6+d7CuK0Ulp7fRuP3GBYstQv1v5e69bovaujg227wSraD3AzYP+xVf8aDqLttxLNWIhmBqa7WqRXAKcolKU4fwP/DQZEhTfAKHwPcKb1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLzpezK+pYoH4jVfPymuI9vIXJ4qw0WhBNqjh092duc=; b=Z7iZcAGd3bPlA1MgLu3woMhv05HQMOSk2Fijxr2Sps78FukQakK1ZMm6mDua05StoBrb7KRdqwJOcRp0xySkILlXJdR5maGq6k/Xj6UySZilEV3bGjHaz9dCQ4lBG9UZ7WPd0cJ86sGFTyO1IynoM0LENlivoYxhPNiO07QHb/4= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1918.namprd11.prod.outlook.com (2603:10b6:300:110::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Tue, 9 Jun 2020 13:10:09 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::50fb:d63c:5958:a67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::50fb:d63c:5958:a67e%7]) with mapi id 15.20.3066.023; Tue, 9 Jun 2020 13:10:09 +0000 From: "Liming Gao" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Feng, Bob C" , Bret Barkelew , "Kinney, Michael D" , Sean Brogan Subject: Re: [PATCH v2 0/5] Add a pipline to check Ecc issues for edk2 on open ci Thread-Topic: [PATCH v2 0/5] Add a pipline to check Ecc issues for edk2 on open ci Thread-Index: AQHWOYPD4R+hTV1cjEuX/tot9enIM6jQSxtQ Date: Tue, 9 Jun 2020 13:10:08 +0000 Message-ID: References: <20200603084807.24484-1-shenglei.zhang@intel.com> In-Reply-To: <20200603084807.24484-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1e94edb-77de-433c-eecf-08d80c766fcf x-ms-traffictypediagnostic: MWHPR11MB1918: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 042957ACD7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L/oNetaqRGS/q9cjeCrTvjmB05dYvdA+c/HVT9bM++xOIaPM17mYrH+Wq31wlhr+E18wskKIG32dmAr2yepph2TLJRDaaHsIN3lQ65zxc2fYohnABUl88wNdHmjCVfDTuE5in5lfWK208LvmCeWXEFi2Tjdjx/+GIqj4sYGwCpHGAL8+sPFNpbtF0vKnsHbZo7+PVfCDuT8FJHUIozZzDxsvUBrF1a0qwIisFC7ZvxaEHNvpb4qEL8np/viF0qPZXMsHBqyZaq6ONt3nrg4Q/M5bEPdDVvc33PPzgWo1ifjRXqBs0Z/aWsELPSss9aEKvucyxsHo3DFIvOzG7AVGk/r4KpZObrvXE1TVw16Fq+4FDVjThU8qzlShwMGMKsqQ4oxDb+5vXKOHYrEvEYtjcA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(346002)(396003)(376002)(366004)(39860400002)(6506007)(26005)(76116006)(966005)(52536014)(53546011)(86362001)(8676002)(7696005)(64756008)(54906003)(66556008)(5660300002)(186003)(66446008)(33656002)(66946007)(55016002)(9686003)(316002)(71200400001)(8936002)(110136005)(19627235002)(66476007)(83380400001)(4326008)(478600001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: RMiVtJpoJESi2wI9pCZn4XUkm9VQBRVgtpL2YZHI6CSFVoCJ058WvhNXL3mhgMXmAEmklYCWAhK2q7PFqMpc5tHw6b1i0WJLZkEZCv0RiTu3ApBV0ve189BwDtMLftJ7ZIGKnSkET0pLb8iH+hd8iX7j2312R+ZiC8WERR4qnQP9vDfiNhr1WFL1ZlC44FTBQBuiP86xrbBlCqjE1/Z+bPnK7s6LI0XWt9HtHWKhXxixjrGvn2qgaRc5ppqvpeyjqkb4DQDLwwuCfAf9O9Oxxdz0d3u1Y5YEmCRXUrNNSLkziAmnQc0UqYJFjh7upRh6rhCqW6VIdDtU88gBUfRlXdXcHxkvmXTotuy+1rUYaz480+eSznf/VS/e9m955AUYGcr5eH/9i0F1zsuXCiWVFR0qJOD/CgTYpB6gIMwE8itNaLLjsVdZ3fb0f+5tHaU7cbChhdULMTcERIy1myQspoqAj3y6vwMWEI1k5if6vQbyLC90gCOujn44MGL5uryE MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e1e94edb-77de-433c-eecf-08d80c766fcf X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2020 13:10:08.9319 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t347iiAPakbZAcHB0v76E9Pye6SC03okFsvLXFtJeuBy6XC2tmNQj8wdySt/jlg9Cngk1j5N59A5gl9JpOHIsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1918 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Shenglei: Seemly, ECC tool update is not related to this patch serial. Can you sepa= rate it?=20 Besides, please update package yaml file with new ECC checker.=20 Thanks Liming > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, June 3, 2020 4:48 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Bret Barkelew ; Kinney, Michael D > ; Gao, Liming ; Sean Br= ogan > Subject: [PATCH v2 0/5] Add a pipline to check Ecc issues for edk2 on ope= n ci >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2606 > As planed we will enable Ecc check for edk2 on open ci. And they are > ready now, but these are V2 series. So I expect that contributors in > edk2 community can try using this script when reviewing. And I appreciate > receiving feedback and comments if someone find errors or false positive > issues. >=20 > I created a pipline of EccCheck for my forked edk2. > https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=3D1= 0&_a=3Dsummary >=20 > The patch series are big, so the commits are also pushed into my forked t= ree. > https://github.com/shenglei10/edk2/commits/ECC >=20 > Patches > 1/5: This is a patch to enable python 3.8 for Ecc. It is a tool issues no= t > a pipline or script issue. But it is listed here for people willing > to try this tool. > 2/5: EccCheck.py is a tool to report Ecc issues for commits. It can be ru= n > on azure servers for open ci, or locally. Its usage is like > PatchCheck.py. > 3/5: It's a lib necessary for py3 to run Ecc on azure servers. For local > use, we need to type command > "py -3 -m pip install antlr4-python3-runtime" first. > 4/5: Windows-EccCheck.yml is a yaml file to configure the newly added > pipline. The azure uses this to create a pipline. > 5/5: We consider some cases that will report out Ecc issues but they won'= t > be fixed, like submodule and industry standard related things. So we > add two configuration fields "Exception" and "IgnoreFiles" for peopl= e > to use. The patch is a example and the contents in the fields will b= e > empty in final version. >=20 > Cc: Bob Feng > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Sean Brogan >=20 > v2: Update 2/5, fix the bug that the script can't hanlde multiple commits= . >=20 > Fan, Zhiju (1): > BaseTools:ECC needs to update the contents of CParser4 >=20 > Shenglei Zhang (4): > BaseTools/Scripts: Add EccCheck.py > pip-requirements.txt: Add Ecc required lib > .azurepiplines: Add a pipline to check ECC issues for commits > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check >=20 > .azurepipelines/Windows-EccCheck.yml | 38 ++ > BaseTools/Scripts/EccCheck.py | 433 ++++++++++++++++++ > .../Source/Python/Ecc/CParser4/CLexer.py | 6 +- > .../Source/Python/Ecc/CParser4/CListener.py | 4 +- > .../Source/Python/Ecc/CParser4/CParser.py | 38 +- > MdeModulePkg/MdeModulePkg.ci.yaml | 8 + > pip-requirements.txt | 1 + > 7 files changed, 505 insertions(+), 23 deletions(-) > create mode 100644 .azurepipelines/Windows-EccCheck.yml > create mode 100644 BaseTools/Scripts/EccCheck.py >=20 > -- > 2.18.0.windows.1