From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.11986.1594693845443940669 for ; Mon, 13 Jul 2020 19:30:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=quMz49vL; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) IronPort-SDR: Qxhj9yC3vFTZP8oDXS05j48NBJ5AcT7wAr7+vlAAH3KW3yQE4N0i7EV4WlGBvGcaK0eUUjQzh1 6+9W0ZJQOYpg== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="128876561" X-IronPort-AV: E=Sophos;i="5.75,349,1589266800"; d="scan'208";a="128876561" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 19:30:45 -0700 IronPort-SDR: qPTMDiLoM13mAA8KL2qKs06nEHk4CgVam6TCEvtuI2rZDivc1em8yCm99hJM1an/dzCkNri2Py 2yvwPPSAw1Kg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,349,1589266800"; d="scan'208";a="325703411" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga007.jf.intel.com with ESMTP; 13 Jul 2020 19:30:44 -0700 Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 19:30:44 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX153.amr.corp.intel.com (10.22.226.247) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 19:30:44 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 19:30:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ob2eNrFKWacCWozqX3C+cAcE5JbP+xYmPgsGBaiZcWYFyxOb1Ly6TAY7V6DLgAmnSTZKm47koKwfeAe2VtC2tGlL/PgM8E1eKyflMBC/t5MlMGygVoU4ji48K75PxQlCBFGWSuC0QmjIHVWDsvwwD2iv7o91uJmISAZiF9aOXOOVqYfkryk8expQYWOmIai8hA2tOPh86Au4WofNzHy37I7Yaz70InvZi/SbsSkTZViM5FKYxnZFwPKsqCp5ZAJ7NJT3Op/QKzuyeT3imUN1Wqbn2Six8EW7itJ4O9J+SvpHRZMI9FUsPZWwhziwrlpRwDPMfxA2EHvdXf7mWzVd0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4wfKzvfVtuXn4Sw+U5zEutIwpchAzZFxugalfO4qkxE=; b=KDNWDIQRfJ1aNlJScCnbRCsovfbM1H53SFSutkLlaGr8//hV1KOPNNcPFLMxBHJFfKYYSm6ZyG096GoUdmk0Y0T3DdargcIKLyvbKAo7PEzLVptSkbF8lf0wYdZkYrGoFbwZbYVAJuFl+7KnOqMQWcwPNs2JHd77GrfQlpQryYOdmAqquAOpQS49YSjg5VoN2V8jD+sZLhc+7qUEEdMVZ5/ZE8NiFtCJeaUTy2Wc/7VGX8Y6DjSyNpFqkSWCfaFGs8Zs48ErFb1M9+O0TEMrB4tE8Ht8Gp+ywQ5FiMjOmOrpzf2qVFMD/AM9Oj5ggt9MayzNx+GHTHnVBwdIH0yHXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4wfKzvfVtuXn4Sw+U5zEutIwpchAzZFxugalfO4qkxE=; b=quMz49vL0LfbaVOvzVb9tK+J+AkucNesihbRg/SGt87lf0Ass57XeiwW63g+cjQY1Yx2k3yS7NsZhdzmX4NFMZqpT+aqDqz3UYhWHe+03NKoIayLHQJC9IrLvmkOV6kxDeO+mLLNwzbszbWU+767fwpUzzwQ8FeQpGuv3DNLYvY= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Tue, 14 Jul 2020 02:30:43 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3174.025; Tue, 14 Jul 2020 02:30:43 +0000 From: "Liming Gao" To: "Zhang, Shenglei" , Leif Lindholm CC: "devel@edk2.groups.io" , "Feng, Bob C" , Bret Barkelew , "Kinney, Michael D" , Sean Brogan Subject: Re: [edk2-devel] [PATCH v7 00/16] Add a plugin to check Ecc issues for edk2 on open ci Thread-Topic: [edk2-devel] [PATCH v7 00/16] Add a plugin to check Ecc issues for edk2 on open ci Thread-Index: AQHWU3JTyKhXJpUBAU+nIVMJ7P9aZ6j6P2cAgAElHgCAAJ/tAIAA6rCAgAl3HQA= Date: Tue, 14 Jul 2020 02:30:42 +0000 Message-ID: References: <20200706084846.12748-1-shenglei.zhang@intel.com> <20200706085508.GA12303@vanye> <20200707115638.GB12303@vanye> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6498583d-3047-496c-f8c3-08d8279de829 x-ms-traffictypediagnostic: MWHPR11MB1631: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b8k5jGchtjDsolT56S40leY7Q7w0iNXyDFojl0PQAe2BLtd2lnOeB5NYWvc3jeslcXIk/UiBWcBflxMrFeE2rYTSN3brWeBqhUhZPEVOBoDTxZz+ZR699CJlHrQJn+2hvJdkZhhFJTyxXqU8OayteGjsdNYNVh5W54U1lNLbxm51OgGS0B1cF/kuzEbYDl8iQrQHqgMdDKoKQ6Sq0lcBipzxx2g927EjsrpcWknXRDEXvHRRWpU+QScZ24TTYkBRYC/HLPV4J+ctxF9iyfthrahfYDvXEI7C0LyUu0q/ZznmpAakyKMokhNxK4dPPeR6xZzAyjV2fjV2RolKlClI25fJNFITq7EH59MjRBZPH/rlEboPxXUkb0C0kVyRP4dfzEgEsitHlhCivTttl3vwsQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(396003)(39860400002)(136003)(366004)(376002)(52536014)(66476007)(64756008)(76116006)(66446008)(66556008)(71200400001)(966005)(83380400001)(54906003)(9686003)(66946007)(478600001)(26005)(8676002)(110136005)(6506007)(186003)(2906002)(53546011)(86362001)(55016002)(5660300002)(66574015)(4326008)(8936002)(316002)(7696005)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: XPcOsz5t+aLfjF/MLmqBSx8at1ZrY8lHagEA8nnFVuYfZTOHRPeeWh1LWCJ3dt/XHe8ftIAeMRq6/iBR1wSx4GNBEM4Lh82l6mMB7K2SwNW4dCswlFqRrkvRR8G8wM+lEto9qtsIHIJHTTV3PsaGULigiqlDzRYj+EcOxw33g5KL+zk2KuWAb5rG0X2x0G7wP7PkH3GZqIodek4IByGpNs7MVmvXZVL8Drk3vbkLq+aBMBPg7aBKnFCkEysl/r5n/0d+R6jHda/5pt4hQZFLF7wECxIF543Qqi0ievlKlFl7151MCSXXY8JDWIZ0kVv52we/Fe0JN/3S44XJbcAzTDP+85okfz5y+Gk2hto6Zvp74jiDDrdV86z++FoKwsHkbZQM1Stk6sGtpXXYkczsTkj7yD6pVpnYmWCMzYzSgX6T5/jiD3ZEkt83zNV8x1lOONERfrkB7vn01kQhBdz8QoLicHiUmzQPawT/Kn+KQO3ghfNij1jOAZjanRukWUah MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6498583d-3047-496c-f8c3-08d8279de829 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 02:30:42.9469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WljH6elO2Nq31t4DTnz4/4lLg4dtPh03gU5OOzkC3PpYVGi41S3D/MdTOyVv/dKZtCZfTOXRRoAgLZk+4Jkz+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1631 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Shenglei: I have no other comment. This patch set is good to me. Reviewed-by: Limi= ng Gao If no other comment, I suggest to merge this patch set before end of thi= s week.=20 Thanks Liming -----Original Message----- From: Zhang, Shenglei =20 Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B8=1B$BF|=1B(B 9:57 To: Leif Lindholm Cc: devel@edk2.groups.io; Feng, Bob C ; Bret Barkele= w ; Kinney, Michael D ; Gao, Liming ; Sean Brogan Subject: RE: [edk2-devel] [PATCH v7 00/16] Add a plugin to check Ecc issue= s for edk2 on open ci Comments below. > -----Original Message----- > From: Leif Lindholm > Sent: Tuesday, July 7, 2020 7:57 PM > To: Zhang, Shenglei > Cc: devel@edk2.groups.io; Feng, Bob C ; Bret=20 > Barkelew ; Kinney, Michael D=20 > ; Gao, Liming ; Sean= =20 > Brogan > Subject: Re: [edk2-devel] [PATCH v7 00/16] Add a plugin to check Ecc=20 > issues for edk2 on open ci >=20 > On Tue, Jul 07, 2020 at 02:24:14 +0000, Zhang, Shenglei wrote: > > Comments below. > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of=20 > > > Leif Lindholm > > > Sent: Monday, July 6, 2020 4:55 PM > > > To: devel@edk2.groups.io; Zhang, Shenglei=20 > > > > > > Cc: Feng, Bob C ; Bret Barkelew=20 > > > ; Kinney, Michael D=20 > > > ; Gao, Liming ; > Sean > > > Brogan > > > Subject: Re: [edk2-devel] [PATCH v7 00/16] Add a plugin to check=20 > > > Ecc > issues > > > for edk2 on open ci > > > > > > On Mon, Jul 06, 2020 at 16:48:30 +0800, Zhang, Shenglei wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2606 > > > > As planed we will enable Ecc check for edk2 on open ci. And they= =20 > > > > are ready now. I appreciate receiving feedback and comments if=20 > > > > someone find errors or false positive issues. > > > > > > > > I created a pipline of EccCheck for my forked edk2. Welcome=20 > > > > everyone > to > > > > create pull request to test the quality of this plugin. > > > > My forked tree: https://github.com/shenglei10/edk2 > > > > > > > > And I also created some test cases for ECC plugin. Below are test = cases. > > > > https://github.com/shenglei10/edk2/tree/ECC > > > > Results can be view in below azure server. > > > > > > > > https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=3D > 12 > > > &_a=3Dsummary > > > > > > > > Patches > > > > 1/16: It's a lib necessary for py3 to run Ecc on azure servers. > > > > > > > > 2/16: EccCheck.py is a plugin to report Ecc issues for commits.=20 > > > > It can be > run > > > > on azure servers for open ci, or a local virtual environment. > > > > > > > > 3/16~16/16: We consider some cases that will report out Ecc=20 > > > > issues but > they > > > won't > > > > be fixed, like submodule and industry standard related things= . So we > > > > add two configuration fields "Exception" and "IgnoreFiles" fo= r people > > > > to use. These patches add configuration in yaml files for Ecc= check. > > > > > > > > Cc: Bob Feng > > > > Cc: Bret Barkelew > > > > Cc: Michael D Kinney > > > > Cc: Liming Gao > > > > Cc: Sean Brogan > > > > > > > > v2: Update 1/17, fix the bug that the script can't hanlde=20 > > > > multiple > commits. > > > > > > > > v3: Update 1/17, set the only workalbe workspace is edk2 root dire= ctory. > > > > Update 2/17, designate the version of antlr4 is 4.7.1. > > > > Add 4/17~17/17. > > > > > > > > v4. Update 1/17, remove the function EdksetupRebuild(), instead ad= d > > > > function SetupEnvironment(). Update variables' format and=20 > > > > type > hints > > > > to pass flake8 and mypy. > > > > > > > > v5. Conver the former method to plugin solution, to align with > > > > other check points on open ci. > > > > > > > > v6. The 1/16 patch is missed in v5 series. Now add it in v6. > > > > > > > > v7. Fix a bug that Ecc plugin can not be run correctly under Linux= OS. > > > > > > What is the bug? Where is it fixed? > > > > V6 plugin pipeline link: > > > https://dev.azure.com/shengleizhang/shengleizhang/_build/results?build > Id > =3D282&view=3Dlogs&j=3D9b8d87a5-bd93-5358-8ffa-588e312c4376&t=3D282a77bb= - > da29-5801-6299-2bbe15d5aabb > > v7 plugin pipeline link: > > > https://dev.azure.com/shengleizhang/shengleizhang/_build/results?build > Id > =3D316&view=3Dlogs&j=3D5e3952f2-9c8a-5394-82c1-a803bcab3ca3&t=3D7ea9e85e= - > 5c3d-5fcf-865e-8449f16cc745 > > > > For the same pull request, v6 plugin can't report out the Ecc issues= =20 > > under > Linux OS. >=20 > Right. So *what* was the bug and *where* (which patch or patches) was=20 > it fixed? This is information that should (in an abbreviated form) be=20 > provided in the cover letter. >=20 > "Fix a bug" is data, not information. The same is true for "can not be= =20 > run correctly". And neither tells me which patch I should look at. > If this has been covered in a specific discussion thread, a link to=20 > the thread *and* mentioning which patch(es) it affects is sufficient. >=20 OK. Let me re-answer your question. The bug is that for the same pull request, v6 plugin can't report out the = Ecc issues under Linux OS. It's not difficult to find v6 plugin failed to r= eport out Ecc issues and v7 plugin managed to do that. V6 plugin pipeline link: https://dev.azure.com/shengleizhang/shengleizhang/_build/results?buildId= =3D282&view=3Dlogs&j=3D9b8d87a5-bd93-5358-8ffa-588e312c4376&t=3D282a77bb-d= a29-5801-6299-2bbe15d5aabb v7 plugin pipeline link: https://dev.azure.com/shengleizhang/shengleizhang/_build/results?buildId= =3D316&view=3Dlogs&j=3D5e3952f2-9c8a-5394-82c1-a803bcab3ca3&t=3D7ea9e85e-5= c3d-5fcf-865e-8449f16cc745 And the update of v7 patch series is 2/16. It fixed some case sensitive issues and separating symbol problems, like u= pdating 'ecc.log' to 'Ecc.log' and updating '\' to'/'. Above solution fixed the plugin failed to report out Ecc issues under Linu= x os. Thanks, Shenglei > Regards, >=20 > Leif >=20 > > > > Thanks, > > Shenglei > > > > > > > > / > > > Leif > > > > > > > Shenglei Zhang (16): > > > > pip-requirements.txt: Add Ecc required lib > > > > .pytool/Plugin: Add a plugin EccCheck > > > > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc > check > > > > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check > > > > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check > > > > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check > > > > FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check > > > > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc che= ck > > > > MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check > > > > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check > > > > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check > > > > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for=20 > > > > Ecc > check > > > > SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check > > > > ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check > > > > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check > > > > UnitTestFrameworkPkg: Add configuration for Ecc check in yaml=20 > > > > file > > > > > > > > .pytool/Plugin/EccCheck/EccCheck.py | 267 > ++++++++++++++++++ > > > > .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml | 11 + > > > > .pytool/Plugin/EccCheck/Readme.md | 15 + > > > > ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 + > > > > CryptoPkg/CryptoPkg.ci.yaml | 11 + > > > > EmulatorPkg/EmulatorPkg.ci.yaml | 11 + > > > > FatPkg/FatPkg.ci.yaml | 11 + > > > > FmpDevicePkg/FmpDevicePkg.ci.yaml | 11 + > > > > MdeModulePkg/MdeModulePkg.ci.yaml | 11 + > > > > MdePkg/MdePkg.ci.yaml | 11 + > > > > NetworkPkg/NetworkPkg.ci.yaml | 11 + > > > > OvmfPkg/OvmfPkg.ci.yaml | 11 + > > > > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 + > > > > SecurityPkg/SecurityPkg.ci.yaml | 11 + > > > > ShellPkg/ShellPkg.ci.yaml | 11 + > > > > UefiCpuPkg/UefiCpuPkg.ci.yaml | 11 + > > > > .../UnitTestFrameworkPkg.ci.yaml | 10 + > > > > pip-requirements.txt | 1 + > > > > 18 files changed, 447 insertions(+) create mode 100644=20 > > > > .pytool/Plugin/EccCheck/EccCheck.py > > > > create mode 100644=20 > > > > .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml > > > > create mode 100644 .pytool/Plugin/EccCheck/Readme.md > > > > > > > > -- > > > > 2.18.0.windows.1 > > > > > > > > > > > > > > > > > > > > > >=20 > >