From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.10093.1592407166067110826 for ; Wed, 17 Jun 2020 08:19:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=mwgRsTGQ; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) IronPort-SDR: SgP7ZSfIQOpUI3DIAc0vXrG2BQvu9yR7r64UEaVabl6r4nEvz3lFN5ls91o81A5WSYOfoLFoTW 5Wc3Kmpbj+Dg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 08:18:59 -0700 IronPort-SDR: ZA/t+jP+AT0C7XK2H1YPKlQhfODO3PUHHIxu1kVi0pAMmgnpKzxqVsycDp2WxUWTH3Vhh14mxg Ca88TnMOgS+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,523,1583222400"; d="scan'208";a="308824721" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 17 Jun 2020 08:18:59 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 08:18:58 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 17 Jun 2020 08:18:58 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 17 Jun 2020 08:18:58 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 08:18:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BCLWLEf78xSyQHc4xXRhcz6/K+uQ+cm3O2WJFmmUPeq60KCPkKcU3JMq4TMBYkhhwvBxlFWptO5KdyUl7bHLfVkEvVbkO2UaIsvzrODYSKkGUblttonvj+mJbifCcXSrAjvADSNptTz7Q0kGSmRWhXYhnYZEbserywG4tbhBRU8of4YoaYRZinURghG0eGzIEDHyWXfsQSDMqpiY8CpPGJ6EcgMleD64gZVVDfx7QAdq9b5vYzNNiX9v/BYNZqh0s6nlGAuKYmx5nWNlDyoSFxwElIJNkGPzlk5zpIrqsR5s+AaWSZrvGzGpFaDAWIQ7NZJB/IQihl80JQ49rGgtaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UmZx7/jIExmizk/4XsHo6I0KWlQ+AEtrL0NbPIQXtRw=; b=ff/0pD+apAMwYr1/rEPbaHNDC5vZU99eiteqblww9QZEBYPv+ce/qPlJLAANtCoC37anUCyUp6beF2ZhVFBRkw9LboVTmpkGolFkCpDerko08/+f2ftG84U7gURzPLdZN7E98SfRJyTK4U64nH1tcKzwD9Gfg6piPkMR4iUK+xo0+FsVHaVAsJ1bGRi1A0aLFnOwXm5UfouQ+1CCx4WgeK82UgVBMBHHgpkIXHP7bQDvCxyOM7S7hd3kOWz0kNi9mi85nvuzL0+OKscbSh7XdvNbTARDVQUtfIDtsuXGP4d3LVEsFUl/lod0GvK/AeCJ5G4H1uDGdK2LZeN1ajgi/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UmZx7/jIExmizk/4XsHo6I0KWlQ+AEtrL0NbPIQXtRw=; b=mwgRsTGQs3US1q4lPQ/VYnJIa5maQSJcDda8dT07Yjy8l5RNPYk0a3q9R+9sjXZBvsXt5PL5/FD6RIauVlI/b802gLug5MXjIX/ZehpZ4IPzWxjWdkEAsKQb5+6qf+rxeAmCLv278kJsReYm1i4eFUnURhJ7oOHzs6+2OhgYuM4= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1439.namprd11.prod.outlook.com (2603:10b6:301:9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Wed, 17 Jun 2020 15:18:52 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::50fb:d63c:5958:a67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::50fb:d63c:5958:a67e%7]) with mapi id 15.20.3088.029; Wed, 17 Jun 2020 15:18:51 +0000 From: "Liming Gao" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Liu, Zhiguang" Subject: Re: [PATCH V3 1/2] MdePkg/PciSegmentInfoLib: Add missing EFIAPI to GetPciSegmentInfo() Thread-Topic: [PATCH V3 1/2] MdePkg/PciSegmentInfoLib: Add missing EFIAPI to GetPciSegmentInfo() Thread-Index: AQHWRIMtocVEi5Oi7ECXHhqywJ/CjKjc7Cug Date: Wed, 17 Jun 2020 15:18:51 +0000 Message-ID: References: <20200617084058.196-1-ray.ni@intel.com> <20200617084058.196-2-ray.ni@intel.com> In-Reply-To: <20200617084058.196-2-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.214] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f6e441cf-1625-48fb-c6ed-08d812d1be19 x-ms-traffictypediagnostic: MWHPR11MB1439: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04371797A5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LYqz7d9rhCdWiDOwcE1AF3+Gz92XBn/KPp7bhince81rV2uuWSr3oXD07L7MR5jnTqK6N/hphNUG1O6hQWbH8GsnPkCDc9uk+kPtXnGTGrnw/GNlznd8LC677AM6SPE9dEzkht3FAOpBKfCE2s27rcwARa8l87awJHCEwhG/tx4bb8I5McuBaC9xvcSDTAARsrCc2KwtBt2qQ7+JCE/U6kbtSkiDMr/05TtXQStLJ4Qd6sw2bA6kMHMAPobpBqQ/dki9iulFThi4Acr9bQKtJDOsfzR30rsm7RpRpaXBnZK1TUgS3QJsPgm8/YbJD209nk3+FtLtR4DVGpPW69I8VQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(39860400002)(366004)(136003)(376002)(346002)(66476007)(66946007)(5660300002)(64756008)(66556008)(66446008)(86362001)(8676002)(7696005)(55016002)(2906002)(76116006)(9686003)(33656002)(186003)(6506007)(53546011)(71200400001)(107886003)(26005)(4326008)(83380400001)(54906003)(316002)(478600001)(8936002)(52536014)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: +0z16D7wy5uC1L44DwCLeVHAZRoyLJ5EXJ37Ga/45Sn9d/5BJxHqSgofAZYdWcvg94zg1omsHZilnxZi8Ep2Ch15Wi17Z63vpThwJQ7tpKVRuAZiVeXwCBfCZLiNTqcMhb4qqsov3MbMx+jsMcYQz6fLxl4W4Iz3CkjtaX9pcWXIY47uiRposEN3kkH5n70qEV+RymWUNn8Juh/URgB0L8LLtSbbVHNnu9M8yvmahgFzUlrjsFr2hgnKThYicQi7UaNYamkBr2NlDhENaqNCy+VwGli/DSyKEIO+GpKzAwAdoOCgfeswFNq9h4Ktnl3KMQK8aXAbjq+QSlzog2v6F+lHMyFXp2WKOua3nKeGIu9LWLjLFD2ZwPru/KVs9uoNhYYG+z5EAIdCs1jVKN60yCAkaDSMMAPxj8Dut8RM/G6LkJaBQIhw2dh/TftDlwf++JlvYEUPQ6C9ojtPlySrI3L2M4o5S8znNqoG5yf16CwMwFPO8ENi7xlyhceh3zbT MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f6e441cf-1625-48fb-c6ed-08d812d1be19 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 15:18:51.9010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vxwyP/3pYuRoKwE5qFYoW+CE9drYjgnJ8259jD66XXTVZr5a7upXIcXeoxjWEj3JXuXRSHOj9QZV5kzjGfOv7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1439 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, June 17, 2020 4:41 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang > Subject: [PATCH V3 1/2] MdePkg/PciSegmentInfoLib: Add missing EFIAPI to G= etPciSegmentInfo() >=20 > All public APIs should have EFIAPI modifier. Somehow PciSegmentInfoLib > missed the EFIAPI modifier. > The patch updates the library header file and NULL instance in MdePkg > to add the missing EFIAPI. >=20 > Signed-off-by: Ray Ni > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > --- > MdePkg/Include/Library/PciSegmentInfoLib.h | 3 ++- > MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Library/PciSegmentInfoLib.h b/MdePkg/Include/= Library/PciSegmentInfoLib.h > index 320a223628..659ff85649 100644 > --- a/MdePkg/Include/Library/PciSegmentInfoLib.h > +++ b/MdePkg/Include/Library/PciSegmentInfoLib.h > @@ -3,7 +3,7 @@ >=20 >=20 > This library is consumed by PciSegmentLib to support multiple segment = PCI configuration access. >=20 >=20 >=20 > - Copyright (c) 2017, Intel Corporation. All rights reserved.
>=20 > + Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -28,6 +28,7 @@ typedef struct { > @retval A callee owned array holding the segment information. >=20 > **/ >=20 > PCI_SEGMENT_INFO * >=20 > +EFIAPI >=20 > GetPciSegmentInfo ( >=20 > UINTN *Count >=20 > ); >=20 > diff --git a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c > b/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c > index f9019c4e64..3ec7784057 100644 > --- a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c > +++ b/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c > @@ -2,7 +2,7 @@ > Default PCI Segment Information Library that returns one segment whose >=20 > segment base address equals to PcdPciExpressBaseAddress. >=20 >=20 >=20 > - Copyright (c) 2017, Intel Corporation. All rights reserved.
>=20 > + Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -21,6 +21,7 @@ > @retval A callee owned array holding the segment information. >=20 > **/ >=20 > PCI_SEGMENT_INFO * >=20 > +EFIAPI >=20 > GetPciSegmentInfo ( >=20 > UINTN *Count >=20 > ) >=20 > -- > 2.26.2.windows.1