From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.7070.1593697796017324023 for ; Thu, 02 Jul 2020 06:49:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Y3t97WxY; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) IronPort-SDR: z+s9RKvxPmXeGJOSBkaS1UGjV0p5d/AYWm88HWmHb+DHvGgRaqDREJrJKMkrvgFshBqyLrl20i nCMnwrksaVeQ== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="135183147" X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="135183147" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 06:49:55 -0700 IronPort-SDR: aEQ2y4GXlfpLq1HAH7bgpc1Pn+bMkl3MrerADt+lkGGrQl8Q/2X+WAlWazQcMXEZ2HtOC9cmLn FaQkDR/fAtSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="455527121" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga005.jf.intel.com with ESMTP; 02 Jul 2020 06:49:54 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jul 2020 06:49:54 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 2 Jul 2020 06:49:54 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 2 Jul 2020 06:49:54 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jul 2020 06:49:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tj+bG7HK5ZPeat7zi/xMuBVWJo2Ofm5uNggepzj0K/biTXxXC+Q7l7cCVbiOcaYEZgTZvaOYgt7zA985so2CzQ7vjcokN+px4thZXgv291ICFI4dGw8cKXjXG869oxvkVTZNcNvVWhJlegr8TkBz5/twamQpwiKnakyplJ1yqgj85iDvp9rBSCK3lMFDYJMHwn/2OcNIe9K1wuwyqbG+BvtPj4CJ2aZovUSISt5tKUbpPYKWa8Bez3KNPpHOZs/hNDqvs3KNXuFRBfl1xCoPnBnzSJhoc3/0t59LjKZN/IrDXr4xPVOQXN1KWQhcvjq060BmjBnPyoc6SUsfPahRQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lsH0jqZht/GZJYQs1qKwy0jV1wxXHapT+xU+YLwM/vo=; b=ewh9MhDqedH7XUyOcF6zhnJ+ZGpStC6hkgYBM/YQblEEuLsHO1zVpPFAm3gstQo5y0XZC6CDezd4+yIw0C7DZK8RWBF80dDMYilrS8aXu14xIyD2mqu2E2dkdQ2YnhYi4FehnDmTFj/2jHaYlvXwR/g9N//tCoUjVVz/LmsnpSqYtxLDySxA28WD3brjkANT4s7x/TrFm2YkGt68OqjQ2XsVOiiYelFSuu8JQl6V3dArc73B/FIDYYP8nOVmX8Pt4O8ykOpagntTvCxwhQXa63fH5CbzvHUczzgkGk4LMKWgih3yRbG3lIwfRrY6ZE3EY/CG2jFfLYsGzz2GdKvEeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lsH0jqZht/GZJYQs1qKwy0jV1wxXHapT+xU+YLwM/vo=; b=Y3t97WxY+yNT9A4KE2KO/oXJp/MKGgN0UfwTLNPIaKfsdwtZoIZiRICra2f0KnfXp1rjzatDTA3jmwo+dhLxBqGXzyAwdnCvdhqQAD3CRWqkHZcVe/ZEsqicXHlVEWkBGE43ReiSb7+4VkhfAU6/hEw/UB0UJneDQWs9ihj6HGo= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MW3PR11MB4601.namprd11.prod.outlook.com (2603:10b6:303:59::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21; Thu, 2 Jul 2020 13:49:45 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3131.036; Thu, 2 Jul 2020 13:49:45 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "leif@nuviainc.com" , Laszlo Ersek CC: Rebecca Cran , Ard Biesheuvel , Andrew Fish , "Justen, Jordan L" , "Kinney, Michael D" Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve Thread-Topic: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve Thread-Index: AQHWUF815t7Xuk+RLkuJp4fcpNmfu6j0TQXw Date: Thu, 2 Jul 2020 13:49:45 +0000 Message-ID: References: <92612908-44f4-30d4-ae3a-3ad595e2141f@bsdio.com> <68b55c49-1e49-e082-ca38-68c3d321611b@redhat.com> <20200702105419.GN6739@vanye> In-Reply-To: <20200702105419.GN6739@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f24136fc-2b8f-4327-6aef-08d81e8ec788 x-ms-traffictypediagnostic: MW3PR11MB4601: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h6Hoqyog67Mf3EP90bXR3m7RM0hyyDZtR9BSLI0MSbcUXqEPjjLL5o/DznVD+I5Sq0o0KuLBhH6QxzBOxldzIEo+n09VDPTBzW5lSnACYo6fJ4I1mjf4ysTsW1wm1Yc1ZM0jipZUtlwd3Hgo2rwhxPVsAlmDjls/Qwtg2SIiI7ncVpluFjU4JoDM8Bv5tnR4SY/bJDYA/Kk0sJl5Cm1xdkPM/NZTVnktD8RgyQ+hApSys1dWqCkJLAKFOCxNsmJF6N6PKNpoq9l03NemTN63b+RmV+bWFK6EDEyFe2FG8pLX/17+3iKRMX4L4Chf7KT+WyEcFMe4cac/2K7H/q2quG1zX40xD2tGxQkNReCN3j90A8hc2K1gsCcbzzXso76l2Ut1Ol4PrDfmaeRCP+JEQg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(83380400001)(966005)(33656002)(55016002)(54906003)(8676002)(52536014)(316002)(110136005)(5660300002)(478600001)(9686003)(186003)(2906002)(64756008)(6506007)(66556008)(66946007)(66446008)(26005)(53546011)(66476007)(4326008)(76116006)(8936002)(107886003)(7696005)(86362001)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: WVIUJfaVpgKuGXhLRPDrQ/BnPoIE/isA4R36BXRmyvcXqqU4eiEIPGY/Sai3M88VM4CrWe0VqseMQUcehbAaCutIULas8i46GRtOTiFFhbBvtbRVqVaElUuMeenjJ+eoEttTaovD4LAJK2W01RX3u1qWpCmZIIrgdvGiVDKoMAvmSnqMcaTP5eQKon3GP6TILo8msvePV2++HBQ4sVGl+OENhOlLjEYPPfHJNr/YEItkcffS83i1slEJUGlt6ox2o3/tFo7vluxMm+qkZlqvUUcF/mIaTsd9QDy5DCgTOtCGMIFJOnP2DrMo/ViOwo7G3okYm1kKmVsIqws63TSpY36zwUN7ERXfz+dl5UmgZYXCOkQaL0bcwSQ60laRPsfYbXNdpwYzzYIkbxY/7FlZg4GGdrCtoftu0o7bATg+QUdxWyeN63CM0bQHoY3Gkoj5hB6Mmbrk5buuupz0RTJ2OKmyJ550jhAFMiahFGrNbiLtz4mkuit8F2lENsmRmpcI MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f24136fc-2b8f-4327-6aef-08d81e8ec788 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 13:49:45.2641 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MoIoVsQ6nyNOg1zCbv3rmfJfXra8XmNJSD+wgy7cxgBNl6+OP2GUhIj1RuFDxHaHEhBvDuhRyR/BJatvf2np/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4601 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Leif Lind= holm > Sent: Thursday, July 2, 2020 6:54 PM > To: Laszlo Ersek > Cc: Rebecca Cran ; edk2-devel-groups-io ; Ard Biesheuvel ; > Andrew Fish ; Justen, Jordan L ; Kinney, Michael D > Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support fo= r bhyve as OvmfPkg/Bhyve >=20 > On Thu, Jul 02, 2020 at 11:27:25 +0200, Laszlo Ersek wrote: > > This likely comes from BaseTools commit a4cfb842fca9 > > ("BaseTools/PatchCheck.py: Add LicenseCheck", 2020-06-12). > > > > One approach would be to remove "VbeShim.h" from the tracked files und= er > > OvmfPkg, replacing it with a PREBUILD command in the OVMF DSC files. > > (Then Bhyve could do the same.) > > > > However, the generator, namely "VbeShim.sh", is not written in Python, > > but in (POSIX) shell, and so it can't be called from PREBUILD (I think > > it would break OVMF builds on Windows). > > > > I don't know what to tell you, other than the blanket license > > enforcement from commit a4cfb842fca9 is likely wrong. >=20 > *Reads patch* > *Figuratively spits coffee all over keyboard* >=20 > No, this is not OK. >=20 > We *STILL* have no agreed process for accepting non bsd+patent content > since we dropped the contribution agreement. I have tried to raise > this issue several times in the past, and there has never been any > outcome from resulting discussions. >=20 > So now I'm going to send out a two-patch set consisting of: > - Reverting a4cfb842fca9. (Doing nothing is better than implying that > anything !bsd+patent can currently be added to the tree.) > - Deleting the statement in ReadmMe.rst erroneously claiming that the > includion of these other licenses are acceptable until such a point > an active decision has been taken, approved by the community, that > this is permitted. >=20 If only bsd+patent is allowed, the checker can be enhanced to check this l= icense only.=20 I don't understand why remove this checker. Thanks Liming > > The generated include file *must* be a ".h" file, otherwise the INF fi= le > > reference won't be able to trigger an incremental build, if I understa= nd > > correctly. So replacing the ".h" suffix with something else, such as > > ".genh" (for "generated header") won't work, I believe. > > > > Modifying the printf invocations in the generator script to also outpu= t > > a license header would not be right either, IMO. A license tag makes n= o > > sense (I think) without a copyright (C) statement. And what copyright > > (C) notice should we put on a generated file? > > > > Furthermore, although "ReadMe.rst" in the project root states > > > > """ > > Contributions of code put into the public domain can also be accepted. > > """ > > > > I don't see how the license check implemented in commit a4cfb842fca9 > > would accommodate a public domain contribution. (I think it would be > > fine to place the the generated header file in the public domain, *if* > > (a) we could express that somehow (is there an SPDX tag for that?), > > *and* (b) if that would eliminate the need for a (C) notice / authorsh= ip > > mark.) >=20 > Public domain is not an OSI-compatible license: > https://opensource.org/node/878 >=20 > The public domain statement is also one that needs to be re-evaluated > in light of the dropped contribution agreement. >=20 > / > Leif >=20 > > Note that this generator use case is not unique to QemuVideoDxe; see f= or > > example commit 1e9d6b0f98b5 ("OvmfPkg/OvmfXen: Creating an ELF header"= , > > 2019-08-21). > > > > I've now filed a bug for BaseTools: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2833 > > > > Once that bug is solved -- that is, once we standardize a tag for > > marking generated source files as such --, we can update "VbeShim.sh" = to > > produce the tag, in "VbeShim.h". Then OvmfPkg/Bhyve can do the same. > > > > Thanks > > Laszlo > > >=20 >=20