From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.13213.1595310195479485355 for ; Mon, 20 Jul 2020 22:43:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=PXtmO45x; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) IronPort-SDR: 8aPeXKms+BvEa04lxpUMWTcYGZ0CulvTRKKMQbRoQdjKbMOlQbdNG6awQ3uimV+1Qa3y+S2yZr yGebIlKQibWg== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="147570647" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="147570647" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 22:43:15 -0700 IronPort-SDR: zgAF1/Disznzffyo3hsXecBo0aXKozsUCsgMVyADYRdTb6UYjBp0gdC9TZl4qiKh3nSFMD314d RPVJRyWZ+LBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="326270044" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jul 2020 22:43:14 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 22:43:14 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 22:43:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rv3+Prdr8FmvgdzQu0kTpoYp34rArt7JW3QUlGTA0YLPvUl94/WZb/JBHqWsBKMX7eWebiCy2ZsZd6+Q3UjOgDzZLdgss57ire/B8Dvqrl5zh3jCwHoy3lmrr+DmL6lX+FllagXDAN6hfuKqjr2grluI1jIXBQcpinXMDGuMgZUzKIxefnTxCr1iy82nq4IWU3EX4j2TJkSqEQYIYHXWYFjVk2uSr25VJH3su+lNySHeTej3rKxGDa/NrvPreCWOeXNr62D63PVXrPFSmIX2vbfEQ1rj5Uq8C3JsButKoXXdTdAzh8mmKqZguAtIUl7kHMFkdRFNXjLHcka5q1Doiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TMIGX1I8N+OVaGhB4L+cp/O8HoA6NN9jz4grdX9SFl0=; b=EDUtPc5wlHgNeofbMoWzFQBVxwxV8sFSz37jpu8pZNqMO06hjkXRSkYlOXPjn5xMpqMS2DRcEeLA69rYuZbRPwVMwOrO7IMTSaCVUoCpvAiYasSUL1zd/C1yGvw1s6nXLNgpkhKpAAUGn7YSzGGOO3UeLy2jXf5VMCZj7L4I5G3rc0YoPeXYDCA1HtWnr+zuq8u28kgFmu2seNM0hJXtMVMqW75nZw6nQGStCLcWIXD2xB0s9jkiMJxaqlj3z+8nrGgeOnqWpjafVb4iavfi+zpVXTolEL/DtPVICH9Qe3pXuzkqQ5C4Bgas5wHnmbuTY466ti7FSPrW3PZ6YSrYYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TMIGX1I8N+OVaGhB4L+cp/O8HoA6NN9jz4grdX9SFl0=; b=PXtmO45xVRrUWR8Tl5f55lPUU333LWmkCaTOGDd1rH+vUY8wFx3ugrZXu1eTVmL8ivTLWxjBXQp9WJSeOoli/ldcKUekDcPqpzrqvh5XnPjsqPsbg9Nj/y/hzwr4QdFDdZf75uN7tLG9zqk77rx2clbggYp7I4vZtHxUeF29T9g= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1680.namprd11.prod.outlook.com (2603:10b6:301:d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 05:43:12 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020 05:43:12 +0000 From: "Liming Gao" To: "Kuo, IanX" , "devel@edk2.groups.io" CC: "Lu, James" , "Kumar, Chandana C" , "Prabhala, Varalakshmi A" , "Chaganty, Rangasai V" , "Chiu, Chasel" Subject: Re: [edk2-platforms] [PATCH v7 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib. Thread-Topic: [edk2-platforms] [PATCH v7 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib. Thread-Index: AQHWXx/0vVDGKEP/ukilL37rQuwDrKkRhOyg Date: Tue, 21 Jul 2020 05:43:12 +0000 Message-ID: References: <23a8724d8993fb3a5d82fbf24d072669ad124334.1595309109.git.ianx.kuo@intel.com> In-Reply-To: <23a8724d8993fb3a5d82fbf24d072669ad124334.1595309109.git.ianx.kuo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6851fc1e-12b6-4e49-1bb3-08d82d38f504 x-ms-traffictypediagnostic: MWHPR11MB1680: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:773; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rdBVfHkGo3zEnYqruSk5PyFPCt8Z5L/F+o3cl5wLAuV1SGMmnlA9A9QBTjHib1jL4KrPrKLoY5JBq2yCDI4B3apuU18dZKkCBI1rn0TkCqpysmgdDkFCgw/uNOmkWFnzXB9QDieMxfHO5R+mCb1wYzIlwIcSUM34pc7rPlnDMQ1sjiHbDUcjZIFTowePBjygD9rvCLgiiaOiSK9p+3Z05vGYGCg9d6gpAIyWBlSTrlcVByRMmd34E7SqeNUrwSzkgMpte13vLgJcpKGBeqEgojD9u8bQ1WlaKcpG+Blsk8Q19NEg0ZByyF8UwAeRCzMpYJaDGv4gsVoaUk932OnLjGaeLoX5fgkQoBPoyrt9O76Q0hvYCjLy5nyTciv41z3PsPzfcNILQNM+gZbe9fdr8Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(366004)(396003)(346002)(376002)(39860400002)(4326008)(316002)(5660300002)(76116006)(6506007)(64756008)(66476007)(66446008)(110136005)(53546011)(7696005)(66946007)(54906003)(66556008)(2906002)(33656002)(52536014)(966005)(186003)(55016002)(8676002)(86362001)(8936002)(478600001)(9686003)(107886003)(71200400001)(26005)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: OIoF1cyNHGQxMp+fEFrQGicgVyhkh4NZsNXVou5NU/XkKtuz8Y3u8Kf9S02a8oYmFGUvD69V6N9tk+AB8L3Vq0ISVKfO8DLNsAVj6b6naztGXkj1Oz4p4OCUB4CIXjOEXOeIGsJQMDsONB7dZjLDCr9bdbDLfKRuw0J2egiOUZuqeg2sW1fG89DUkf4LBk4jnPoMuT+uqHwHz0ckIvR9XH3jYifzXmMerapKsFihn2K/IDr6C21vt0M+J89PmkpPch3ozTS3FpdvWEg8tSsuMHarVvXNs3zfW0aGOhgdrkDlSqRJIE2zRxwl/plKrwYuUzfEegeo0n/8L8bfr7KJQ9CRcS+gUeRQ2B3zf+OXnkPV2pOrESWHrxgYQrfEKWQkP9hi4Tiha54JuZxLoY26RUM4avGzZxmzB4i0HqYXyX511DE4x7ER0WXtefVqBDYQAd6h1ivjEJi85n1JBl7w3O3oy0IlOsMHHOje1BBfYB4zjMz0AfxfDRQM7qfd5Hg3 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6851fc1e-12b6-4e49-1bb3-08d82d38f504 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 05:43:12.4171 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GYcJNmc54Y0DYdO0IVowsmmQthM/6CHoTtHpCI6R/YBwr22kkXN7fBecQLsLs0CoxeVhJAyrYu/yH+HzUdDD4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1680 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Ian: Change-id should be removed from the commit message. And, the change to != include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc is not required.= Can you help check? Thanks Liming -----Original Message----- From: Kuo, IanX =20 Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B21=1B$BF|=1B(B 13:30 To: devel@edk2.groups.io Cc: Lu, James ; Kumar, Chandana C ; Prabhala, Varalakshmi A ; Gao, L= iming ; Kuo, IanX ; Chaganty, Ran= gasai V ; Chiu, Chasel Subject: [edk2-platforms] [PATCH v7 2/6] Platform/Intel/CometlakeOpenBoardP= kg: Add ReportCpuHobLib. Create a Library instance of ReportCpuHobLib from PlatformInitPei driver. PA bits reported can be overridden by Library instance in Platform. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2674 Change-Id: I1097057046aa021dc2ff193fea335790513c10c4 Signed-off-by: IanX Kuo Cc: Sai Chaganty Cc: Chasel Chiu --- .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPk= g.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc index 136e5309..6a5c993b 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc @@ -39,7 +39,8 @@ # # Include PCD configuration for this board. # - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc + [Liming] This change is not required. Can you help check? !include OpenBoardPkgPcd.dsc !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc =20 @@ -172,6 +173,7 @@ TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Pei= TestPointCheckLib.inf !endif SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrr= LibNull.inf + ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib= /ReportCpuHobLib.inf =20 ####################################### # Board Package --=20 2.26.2.windows.1